Eric Blake wrote on 02/03/2011 02:31:13 PM:
>
> On 02/03/2011 11:41 AM, Stefan Berger wrote:
> >> Actually, you've uncovered a bigger bug, but didn't fix it right.
> >
> > ohoh, yes, there's a bug. This is how it should look like
> >
> > ---
> > src/util/macvtap.c |4 ++--
> > 1 file cha
On 02/03/2011 11:41 AM, Stefan Berger wrote:
>> Actually, you've uncovered a bigger bug, but didn't fix it right.
>
> ohoh, yes, there's a bug. This is how it should look like
>
> ---
> src/util/macvtap.c |4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: libvirt-acl/src/
Eric Blake wrote on 02/03/2011 01:28:36 PM:
>
> On 02/03/2011 11:12 AM, Davidlohr Bueso wrote:
> > It wouldn't hurt to add some parenthesis in the following two
> similar expression for better readability.
>
> I take it you were using some gcc option about precedence of operations
> being con
On 02/03/2011 11:12 AM, Davidlohr Bueso wrote:
> It wouldn't hurt to add some parenthesis in the following two similar
> expression for better readability.
I take it you were using some gcc option about precedence of operations
being confusing between ! and <; including that gcc warning message i
It wouldn't hurt to add some parenthesis in the following two similar
expression for better readability.
---
src/util/macvtap.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/util/macvtap.c b/src/util/macvtap.c
index 09d7b78..92147ab 100644
--- a/src/util/mac
