Re: [libvirt] [PATCH] network: Add support for configuring dhcp lease time

2016-09-29 Thread Martin Wilck
On Wed, 2016-09-28 at 17:10 +0100, Daniel P. Berrange wrote: > > I believe that setting "dhcp-authoritative" will be a major > > improvement > > for many setups. Without it, VMs are *never* able to reacquire > > their > > expired lease. With it, reacquiring the lease would work most of > > the > >

Re: [libvirt] [PATCH] network: Add support for configuring dhcp lease time

2016-09-28 Thread Daniel P. Berrange
On Wed, Sep 28, 2016 at 06:03:21PM +0200, Martin Wilck wrote: > On Wed, 2016-09-28 at 16:41 +0100, Daniel P. Berrange wrote: > > > Anyone who cares about VMs having the same IP address after resuming > > from suspend *must* configure persistent DHCP mappings for their > > guests. > > Relying on au

Re: [libvirt] [PATCH] network: Add support for configuring dhcp lease time

2016-09-28 Thread Martin Wilck
On Wed, 2016-09-28 at 16:41 +0100, Daniel P. Berrange wrote: > Anyone who cares about VMs having the same IP address after resuming > from suspend *must* configure persistent DHCP mappings for their > guests. > Relying on automatic assignment will always fail in the end, may be > not immediately,

Re: [libvirt] [PATCH] network: Add support for configuring dhcp lease time

2016-09-28 Thread Daniel P. Berrange
On Wed, Sep 28, 2016 at 04:23:32PM +0200, Martin Wilck wrote: > On Tue, 2016-09-27 at 09:15 +0530, Nehal J Wani wrote: > >  > > Seems like the previous experiment involved a happy accident indeed. > >  > > So, what are we going to do about libvirt+dnsmasq's handling of expired > leases now? IMHO

Re: [libvirt] [PATCH] network: Add support for configuring dhcp lease time

2016-09-28 Thread Daniel P. Berrange
On Tue, Sep 27, 2016 at 09:15:18AM +0530, Nehal J Wani wrote: > > I did another experiment. My network xml limited the range to: > > > > > > > > So, we can safely assume that, if, at any given point of time, there > are two virtual machines with different mac addresses, co

Re: [libvirt] [PATCH] network: Add support for configuring dhcp lease time

2016-09-28 Thread Martin Wilck
On Tue, 2016-09-27 at 09:15 +0530, Nehal J Wani wrote: >  > Seems like the previous experiment involved a happy accident indeed. >  So, what are we going to do about libvirt+dnsmasq's handling of expired leases now? Martin -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com

Re: [libvirt] [PATCH] network: Add support for configuring dhcp lease time

2016-09-26 Thread Nehal J Wani
On Sun, Sep 25, 2016 at 12:58 AM, Laine Stump wrote: > On 09/24/2016 10:51 AM, Nehal J Wani wrote: >> >> On Sat, Sep 24, 2016 at 3:01 AM, Laine Stump wrote: >>> >>> On 09/23/2016 02:43 PM, Martin Wilck wrote: On Fri, 2016-09-23 at 11:56 -0400, Laine Stump wrote: > Martin's patc

Re: [libvirt] [PATCH] network: Add support for configuring dhcp lease time

2016-09-24 Thread Laine Stump
On 09/24/2016 10:51 AM, Nehal J Wani wrote: On Sat, Sep 24, 2016 at 3:01 AM, Laine Stump wrote: On 09/23/2016 02:43 PM, Martin Wilck wrote: On Fri, 2016-09-23 at 11:56 -0400, Laine Stump wrote: Martin's patch tries to solve the problem with "dhcp-authoritative" which, as far as I understand,

Re: [libvirt] [PATCH] network: Add support for configuring dhcp lease time

2016-09-24 Thread Nehal J Wani
On Sat, Sep 24, 2016 at 3:01 AM, Laine Stump wrote: > On 09/23/2016 02:43 PM, Martin Wilck wrote: >> >> On Fri, 2016-09-23 at 11:56 -0400, Laine Stump wrote: >> >>> Martin's patch tries to solve the problem with "dhcp-authoritative" >>> which, as far as I understand, tells dnsmasq "you are the kee

Re: [libvirt] [PATCH] network: Add support for configuring dhcp lease time

2016-09-23 Thread Laine Stump
On 09/23/2016 02:43 PM, Martin Wilck wrote: On Fri, 2016-09-23 at 11:56 -0400, Laine Stump wrote: Martin's patch tries to solve the problem with "dhcp-authoritative" which, as far as I understand, tells dnsmasq "you are the keeper of *all* lease information on this network, so if you think the

Re: [libvirt] [PATCH] network: Add support for configuring dhcp lease time

2016-09-23 Thread Nehal J Wani
On Fri, Sep 23, 2016 at 9:26 PM, Laine Stump wrote: > On 09/23/2016 08:24 AM, Nehal J Wani wrote: >> >> On Fri, Sep 23, 2016 at 4:51 PM, Peter Krempa wrote: >>> >>> On Fri, Sep 23, 2016 at 15:33:46 +0530, Nehal J Wani wrote: On Fri, Sep 23, 2016 at 1:20 PM, Peter Krempa wrote: >>>

Re: [libvirt] [PATCH] network: Add support for configuring dhcp lease time

2016-09-23 Thread Martin Wilck
On Fri, 2016-09-23 at 11:56 -0400, Laine Stump wrote: > Martin's patch tries to solve the problem with "dhcp-authoritative"  > which, as far as I understand, tells dnsmasq "you are the keeper of  > *all* lease information on this network, so if you think the address > is  > unused, it really is un

Re: [libvirt] [PATCH] network: Add support for configuring dhcp lease time

2016-09-23 Thread Laine Stump
On 09/23/2016 08:24 AM, Nehal J Wani wrote: On Fri, Sep 23, 2016 at 4:51 PM, Peter Krempa wrote: On Fri, Sep 23, 2016 at 15:33:46 +0530, Nehal J Wani wrote: On Fri, Sep 23, 2016 at 1:20 PM, Peter Krempa wrote: On Fri, Sep 23, 2016 at 12:19:49 +0530, Nehal J Wani wrote: The default dhcp leas

Re: [libvirt] [PATCH] network: Add support for configuring dhcp lease time

2016-09-23 Thread Nehal J Wani
On Fri, Sep 23, 2016 at 4:51 PM, Peter Krempa wrote: > On Fri, Sep 23, 2016 at 15:33:46 +0530, Nehal J Wani wrote: >> On Fri, Sep 23, 2016 at 1:20 PM, Peter Krempa wrote: >> > On Fri, Sep 23, 2016 at 12:19:49 +0530, Nehal J Wani wrote: >> >> The default dhcp lease time set by dnsmasq is only one

Re: [libvirt] [PATCH] network: Add support for configuring dhcp lease time

2016-09-23 Thread Peter Krempa
On Fri, Sep 23, 2016 at 15:33:46 +0530, Nehal J Wani wrote: > On Fri, Sep 23, 2016 at 1:20 PM, Peter Krempa wrote: > > On Fri, Sep 23, 2016 at 12:19:49 +0530, Nehal J Wani wrote: > >> The default dhcp lease time set by dnsmasq is only one hour, which can be > >> pretty small for developers relying

Re: [libvirt] [PATCH] network: Add support for configuring dhcp lease time

2016-09-23 Thread Nehal J Wani
On Fri, Sep 23, 2016 at 1:20 PM, Peter Krempa wrote: > On Fri, Sep 23, 2016 at 12:19:49 +0530, Nehal J Wani wrote: >> The default dhcp lease time set by dnsmasq is only one hour, which can be >> pretty small for developers relying on ip address(es) to be consistent >> across reboots. > > This shou

Re: [libvirt] [PATCH] network: Add support for configuring dhcp lease time

2016-09-23 Thread Peter Krempa
On Fri, Sep 23, 2016 at 12:19:49 +0530, Nehal J Wani wrote: > The default dhcp lease time set by dnsmasq is only one hour, which can be > pretty small for developers relying on ip address(es) to be consistent > across reboots. This should be handled through the leases file which is supposed to rem

[libvirt] [PATCH] network: Add support for configuring dhcp lease time

2016-09-22 Thread Nehal J Wani
The default dhcp lease time set by dnsmasq is only one hour, which can be pretty small for developers relying on ip address(es) to be consistent across reboots. This patch adds support for setting a lease time in the network definition. For now, all IP ranges under one will share a common leaseti