[libvirt] [PATCH] network utilities: Allocate space for terminating NUL in virSocketFormatAddr

2009-11-04 Thread Matthew Booth
* src/util/network.c: Allocate an additional byte for virSocketFormatAddr's return buffer --- src/util/network.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/network.c b/src/util/network.c index 56426e7..f6588c7 100644 --- a/src/util/network.c +++

Re: [libvirt] [PATCH] network utilities: Allocate space for terminating NUL in virSocketFormatAddr

2009-11-04 Thread Richard W.M. Jones
On Wed, Nov 04, 2009 at 11:00:14AM +, Matthew Booth wrote: * src/util/network.c: Allocate an additional byte for virSocketFormatAddr's return buffer --- src/util/network.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/network.c

Re: [libvirt] [PATCH] network utilities: Allocate space for terminating NUL in virSocketFormatAddr

2009-11-04 Thread Matthew Booth
On 04/11/09 11:06, Richard W.M. Jones wrote: Are you sure about this? According to the man page for inet_ntop the INET*_ADDRSTRLEN macro should be long enough already: AF_INET src points to a struct in_addr (in network byte order) which is converted to