Re: [libvirt] [PATCH] show compiled in options in virsh --version

2010-10-29 Thread Justin Clift
On 10/29/2010 04:43 PM, Jim Meyering wrote: snip Of course. Thanks for the reminder, Bruno. That is indeed a slippery slope. I was too hasty in saying ok. Eric, one option is to use the GPLv3 for programs like virsh, then to have a second gnulib library that they would use. Cue making it

[libvirt] [PATCH] show compiled in options in virsh --version

2010-10-28 Thread Daniel Veillard
To ease debugging this trivial patch allows to find what was compiled in in the local version of libvirt, this doesn't work for remote access but that's probably sufficient. With the patch I get on my machine: paphio:~/libvirt/tools - ./virsh --version Virsh command line tool of libvirt 0.8.4

Re: [libvirt] [PATCH] show compiled in options in virsh --version

2010-10-28 Thread Daniel P. Berrange
On Thu, Oct 28, 2010 at 03:00:45PM +0200, Daniel Veillard wrote: To ease debugging this trivial patch allows to find what was compiled in in the local version of libvirt, this doesn't work for remote access but that's probably sufficient. With the patch I get on my machine:

Re: [libvirt] [PATCH] show compiled in options in virsh --version

2010-10-28 Thread Daniel P. Berrange
On Thu, Oct 28, 2010 at 09:02:31AM -0600, Eric Blake wrote: On 10/28/2010 07:13 AM, Daniel P. Berrange wrote: On Thu, Oct 28, 2010 at 03:00:45PM +0200, Daniel Veillard wrote: To ease debugging this trivial patch allows to find what was compiled in in the local version of libvirt, this

Re: [libvirt] [PATCH] show compiled in options in virsh --version

2010-10-28 Thread jclift
On 29/10/2010, at 12:06 AM, Daniel Veillard veill...@redhat.com wrote: Compiled with support for: Hypervisors: Xen QEmu/KVM UML OpenVZ LXC ESX PHYP Test Networking: Remote Daemon Network Bridging Netcf Nwfilter Storage: Dir Disk Filesystem SCSI Multipath iSCSI LVM Miscellaneous: SELinux

Re: [libvirt] [PATCH] show compiled in options in virsh --version

2010-10-28 Thread Eric Blake
On 10/28/2010 07:00 AM, Daniel Veillard wrote: To ease debugging this trivial patch allows to find what was compiled in in the local version of libvirt, this doesn't work for remote access but that's probably sufficient. With the patch I get on my machine: paphio:~/libvirt/tools - ./virsh

Re: [libvirt] [PATCH] show compiled in options in virsh --version

2010-10-28 Thread Daniel Veillard
On Thu, Oct 28, 2010 at 04:14:46PM +0100, Daniel P. Berrange wrote: On Thu, Oct 28, 2010 at 09:02:31AM -0600, Eric Blake wrote: We already have: $ virsh version Compiled against library: libvir 0.8.2 Using library: libvir 0.8.2 Using API: QEMU 0.8.2 Running hypervisor: QEMU 0.12.5

Re: [libvirt] [PATCH] show compiled in options in virsh --version

2010-10-28 Thread Daniel Veillard
On Thu, Oct 28, 2010 at 11:21:16AM -0600, Eric Blake wrote: On 10/28/2010 07:00 AM, Daniel Veillard wrote: [...] +vshPrint(ctl, _( Hypervisors: )); +#ifdef WITH_XEN +vshPrint(ctl, Xen ); +#endif ... +vshPrint(ctl, \n); Rather than printing a trailing space, why not:

Re: [libvirt] [PATCH] show compiled in options in virsh --version

2010-10-28 Thread Eric Blake
[adding bug-gnulib] On 10/28/2010 01:25 PM, Daniel Veillard wrote: case 'v': -/* FIXME - list a copyright blurb, as in GNU programs? */ -puts(VERSION); +vshShowVersion(ctl); exit(EXIT_SUCCESS); Pre-existing bug - we don't detect

Re: [libvirt] [PATCH] show compiled in options in virsh --version

2010-10-28 Thread Jim Meyering
Eric Blake wrote: [adding bug-gnulib] On 10/28/2010 01:25 PM, Daniel Veillard wrote: case 'v': -/* FIXME - list a copyright blurb, as in GNU programs? */ -puts(VERSION); +vshShowVersion(ctl); exit(EXIT_SUCCESS); Pre-existing bug

Re: [libvirt] [PATCH] show compiled in options in virsh --version

2010-10-28 Thread Bruno Haible
Hi Eric, case 'v': -/* FIXME - list a copyright blurb, as in GNU programs? */ -puts(VERSION); +vshShowVersion(ctl); exit(EXIT_SUCCESS); The gnulib module closeout can automatically take care of this, but it is currently

Re: [libvirt] [PATCH] show compiled in options in virsh --version

2010-10-28 Thread Jim Meyering
Bruno Haible wrote: Hi Eric, case 'v': -/* FIXME - list a copyright blurb, as in GNU programs? */ -puts(VERSION); +vshShowVersion(ctl); exit(EXIT_SUCCESS); The gnulib module closeout can automatically take care of this, but