Re: [libvirt] [PATCH] snapashot: Improve logic of virDomainMomentMoveChildren

2019-03-29 Thread Bjoern Walk
Eric Blake [2019-03-28, 09:05AM -0500]: > Even though Coverity can prove that 'last' is always set if the prior > loop executed, gcc 8.0.1 cannot: > > CC conf/libvirt_conf_la-virdomainmomentobjlist.lo > ../../src/conf/virdomainmomentobjlist.c: In function >

Re: [libvirt] [PATCH] snapashot: Improve logic of virDomainMomentMoveChildren

2019-03-28 Thread Eric Blake
On 3/28/19 10:18 AM, Ján Tomko wrote: > s/snapashot/snapshot/ > I've been making that one a lot; will fix. > On Thu, Mar 28, 2019 at 09:05:31AM -0500, Eric Blake wrote: >> Even though Coverity can prove that 'last' is always set if the prior >> loop executed, gcc 8.0.1 cannot: >> >> +++

Re: [libvirt] [PATCH] snapashot: Improve logic of virDomainMomentMoveChildren

2019-03-28 Thread Ján Tomko
s/snapashot/snapshot/ On Thu, Mar 28, 2019 at 09:05:31AM -0500, Eric Blake wrote: Even though Coverity can prove that 'last' is always set if the prior loop executed, gcc 8.0.1 cannot: CC conf/libvirt_conf_la-virdomainmomentobjlist.lo ../../src/conf/virdomainmomentobjlist.c: In function

[libvirt] [PATCH] snapashot: Improve logic of virDomainMomentMoveChildren

2019-03-28 Thread Eric Blake
Even though Coverity can prove that 'last' is always set if the prior loop executed, gcc 8.0.1 cannot: CC conf/libvirt_conf_la-virdomainmomentobjlist.lo ../../src/conf/virdomainmomentobjlist.c: In function 'virDomainMomentMoveChildren': ../../src/conf/virdomainmomentobjlist.c:178:19: