Re: [libvirt] [PATCH] virsh: fix memtune's help message for swap_hard_limit

2011-03-17 Thread Eric Blake
On 03/15/2011 11:07 PM, Nikunj A. Dadhania wrote: Hmm. Then, only messages should be fixed. Nikunj, please fix. Ok, here is the patch with doc changes and cgroup api rename == From: Nikunj A. Dadhania nik...@linux.vnet.ibm.com * Correct the documentation for cgroup: the swap_hard_limit

Re: [libvirt] [PATCH] virsh: fix memtune's help message for swap_hard_limit

2011-03-15 Thread Daniel P. Berrange
On Wed, Mar 09, 2011 at 05:13:47PM +0900, KAMEZAWA Hiroyuki wrote: diff --git a/docs/schemas/domain.rng b/docs/schemas/domain.rng index 8b215f3..2ac50a4 100644 --- a/docs/schemas/domain.rng +++ b/docs/schemas/domain.rng @@ -341,7 +341,7 @@ /optional !-- Maximum swap

Re: [libvirt] [PATCH] virsh: fix memtune's help message for swap_hard_limit

2011-03-15 Thread Daniel P. Berrange
On Mon, Mar 14, 2011 at 09:24:58PM -0600, Eric Blake wrote: On 03/09/2011 01:13 AM, KAMEZAWA Hiroyuki wrote: +++ b/docs/schemas/domain.rng @@ -341,7 +341,7 @@ /optional !-- Maximum swap area the VM can use -- optional -element

Re: [libvirt] [PATCH] virsh: fix memtune's help message for swap_hard_limit

2011-03-15 Thread KAMEZAWA Hiroyuki
On Tue, 15 Mar 2011 14:27:19 + Daniel P. Berrange berra...@redhat.com wrote: On Wed, Mar 09, 2011 at 05:13:47PM +0900, KAMEZAWA Hiroyuki wrote: diff --git a/docs/schemas/domain.rng b/docs/schemas/domain.rng index 8b215f3..2ac50a4 100644 --- a/docs/schemas/domain.rng +++

Re: [libvirt] [PATCH] virsh: fix memtune's help message for swap_hard_limit

2011-03-15 Thread KAMEZAWA Hiroyuki
On Tue, 15 Mar 2011 14:30:02 + Daniel P. Berrange berra...@redhat.com wrote: On Mon, Mar 14, 2011 at 09:24:58PM -0600, Eric Blake wrote: On 03/09/2011 01:13 AM, KAMEZAWA Hiroyuki wrote: +++ b/docs/schemas/domain.rng @@ -341,7 +341,7 @@ /optional !--

Re: [libvirt] [PATCH] virsh: fix memtune's help message for swap_hard_limit

2011-03-15 Thread Eric Blake
On 03/09/2011 01:13 AM, KAMEZAWA Hiroyuki wrote: Subject: [PATCH] rename swap_limit as memswap_limit. cgroup's /cgroup/memory/memory.memsw.limit_in_bytes is not for limitinit 'swap' but for 'memory+swap' (then, it's memsw) (So, this number cannot be smaller than memory.limit_in_bytes)

Re: [libvirt] [PATCH] virsh: fix memtune's help message for swap_hard_limit

2011-03-15 Thread Nikunj A. Dadhania
On Wed, 16 Mar 2011 09:37:32 +0900, KAMEZAWA Hiroyuki kamezawa.hir...@jp.fujitsu.com wrote: On Tue, 15 Mar 2011 14:27:19 + Daniel P. Berrange berra...@redhat.com wrote: NACK to both these changes. The XML and public API must *never* be changed once included in a release. The

Re: [libvirt] [PATCH] virsh: fix memtune's help message for swap_hard_limit

2011-03-14 Thread Eric Blake
On 03/09/2011 01:13 AM, KAMEZAWA Hiroyuki wrote: +++ b/docs/schemas/domain.rng @@ -341,7 +341,7 @@ /optional !-- Maximum swap area the VM can use -- optional -element name=swap_hard_limit +element name=memswap_hard_limit

Re: [libvirt] [PATCH] virsh: fix memtune's help message for swap_hard_limit

2011-03-09 Thread KAMEZAWA Hiroyuki
On Mon, 07 Mar 2011 15:11:12 +0530 Nikunj A. Dadhania nik...@linux.vnet.ibm.com wrote: Argh, thats me... :( Thanks for the patch Kame. Reviewed-by: Nikunj A. Dadhania nik...@linux.vnet.ibm.com Thanks, rebased onto the latest git tree. == From 421a27337458648b808f0e45cdfd83192313d7cc Mon

Re: [libvirt] [PATCH] virsh: fix memtune's help message for swap_hard_limit

2011-03-07 Thread Nikunj A. Dadhania
On Fri, 4 Mar 2011 14:46:12 +0900, KAMEZAWA Hiroyuki kamezawa.hir...@jp.fujitsu.com wrote: On Thu, 03 Mar 2011 14:47:36 +0800 Osier Yang jy...@redhat.com wrote: Yes, I think it's better. Should I prepare patches ? or you'll do ? Let's see other guys's opinions before doing it, :)

Re: [libvirt] [PATCH] virsh: fix memtune's help message for swap_hard_limit

2011-03-03 Thread KAMEZAWA Hiroyuki
On Thu, 03 Mar 2011 14:47:36 +0800 Osier Yang jy...@redhat.com wrote: Yes, I think it's better. Should I prepare patches ? or you'll do ? Let's see other guys's opinions before doing it, :) A patch (full change version) is here. maybe good input for discussion. == From

[libvirt] [PATCH] virsh: fix memtune's help message for swap_hard_limit

2011-03-02 Thread KAMEZAWA Hiroyuki
I found this when I used virsh memtune... BTW, how to fix http://libvirt.org/formatdomain.html 's memtune description ? == From 541ae04430f376e8168b413a20b35dce49779816 Mon Sep 17 00:00:00 2001 From: KAMEZAWA Hiroyuki kamezawa.hir...@jp.fujitsu.com Date: Thu, 3 Mar 2011 14:24:45 +0900 Subject:

Re: [libvirt] [PATCH] virsh: fix memtune's help message for swap_hard_limit

2011-03-02 Thread Osier Yang
于 2011年03月03日 13:25, KAMEZAWA Hiroyuki 写道: I found this when I used virsh memtune... Happened to see a bug for this yesterday. BTW, how to fix http://libvirt.org/formatdomain.html 's memtune description ? How about be consitent with what cgroup doc says? :-)

Re: [libvirt] [PATCH] virsh: fix memtune's help message for swap_hard_limit

2011-03-02 Thread KAMEZAWA Hiroyuki
On Thu, 03 Mar 2011 14:02:32 +0800 Osier Yang jy...@redhat.com wrote: 于 2011年03月03日 13:25, KAMEZAWA Hiroyuki 写道: I found this when I used virsh memtune... Happened to see a bug for this yesterday. Oh ;) BTW, how to fix http://libvirt.org/formatdomain.html 's memtune description ?

Re: [libvirt] [PATCH] virsh: fix memtune's help message for swap_hard_limit

2011-03-02 Thread Osier Yang
于 2011年03月03日 14:10, KAMEZAWA Hiroyuki 写道: On Thu, 03 Mar 2011 14:02:32 +0800 Osier Yangjy...@redhat.com wrote: 于 2011年03月03日 13:25, KAMEZAWA Hiroyuki 写道: I found this when I used virsh memtune... Happened to see a bug for this yesterday. Oh ;) BTW, how to fix