Re: [libvirt] [PATCH 0/6] syntax-check: Introduce a new rule to check misaligned stuff and fix it (batch I)

2018-09-25 Thread Michal Privoznik
On 09/25/2018 02:03 PM, Ján Tomko wrote: > On Mon, Sep 24, 2018 at 03:30:02PM +0200, Michal Privoznik wrote: >> On 09/24/2018 03:14 PM, Ján Tomko wrote: >>> Please no. >>> >>> Despite my comments on the first spacing rule [0], this series slows >>> down the spacing check by 100 % (from 1.6s to

Re: [libvirt] [PATCH 0/6] syntax-check: Introduce a new rule to check misaligned stuff and fix it (batch I)

2018-09-25 Thread Ján Tomko
On Mon, Sep 24, 2018 at 03:30:02PM +0200, Michal Privoznik wrote: On 09/24/2018 03:14 PM, Ján Tomko wrote: Please no. Despite my comments on the first spacing rule [0], this series slows down the spacing check by 100 % (from 1.6s to 3.1s in my case). I don't think that syntax-check run time

Re: [libvirt] [PATCH 0/6] syntax-check: Introduce a new rule to check misaligned stuff and fix it (batch I)

2018-09-24 Thread Michal Privoznik
On 09/24/2018 03:14 PM, Ján Tomko wrote: > On Mon, Sep 24, 2018 at 10:15:22AM +0200, Michal Privoznik wrote: >> On 09/19/2018 10:38 AM, Shi Lei wrote: >>> This series check misaligned stuff in parenthesis: >>> 1. For misaligned arguments of function >>> 2. For misaligned conditions of

Re: [libvirt] [PATCH 0/6] syntax-check: Introduce a new rule to check misaligned stuff and fix it (batch I)

2018-09-24 Thread Ján Tomko
On Mon, Sep 24, 2018 at 10:15:22AM +0200, Michal Privoznik wrote: On 09/19/2018 10:38 AM, Shi Lei wrote: This series check misaligned stuff in parenthesis: 1. For misaligned arguments of function 2. For misaligned conditions of [if|while|switch|...] It adds a temporary filter for this new rule

Re: [libvirt] [PATCH 0/6] syntax-check: Introduce a new rule to check misaligned stuff and fix it (batch I)

2018-09-24 Thread Michal Privoznik
On 09/19/2018 10:38 AM, Shi Lei wrote: > This series check misaligned stuff in parenthesis: > 1. For misaligned arguments of function > 2. For misaligned conditions of [if|while|switch|...] > > It adds a temporary filter for this new rule since there're > too much misalignment. > Now it just fix

[libvirt] [PATCH 0/6] syntax-check: Introduce a new rule to check misaligned stuff and fix it (batch I)

2018-09-19 Thread Shi Lei
This series check misaligned stuff in parenthesis: 1. For misaligned arguments of function 2. For misaligned conditions of [if|while|switch|...] It adds a temporary filter for this new rule since there're too much misalignment. Now it just fix misalignment in src/util and it's the batch I. Next