Re: [libvirt] [PATCH 05/10] nodeinfo: Add out parameter to nodeGetPresentCPUBitmap()

2015-07-20 Thread Andrea Bolognani
On Mon, 2015-07-20 at 16:18 +0200, Peter Krempa wrote: > On Mon, Jul 20, 2015 at 16:07:42 +0200, Andrea Bolognani wrote: > > On Mon, 2015-07-20 at 15:15 +0200, Peter Krempa wrote: > > > > > > > -virBitmapPtr nodeGetPresentCPUBitmap(const char > > > > *sysfs_prefix); > > > > -virBitmapPtr nodeGetC

Re: [libvirt] [PATCH 05/10] nodeinfo: Add out parameter to nodeGetPresentCPUBitmap()

2015-07-20 Thread Peter Krempa
On Mon, Jul 20, 2015 at 16:07:42 +0200, Andrea Bolognani wrote: > On Mon, 2015-07-20 at 15:15 +0200, Peter Krempa wrote: > > > > > -virBitmapPtr nodeGetPresentCPUBitmap(const char *sysfs_prefix); > > > -virBitmapPtr nodeGetCPUBitmap(const char *sysfs_prefix, int > > > *max_id); > > > +virBitmapPt

Re: [libvirt] [PATCH 05/10] nodeinfo: Add out parameter to nodeGetPresentCPUBitmap()

2015-07-20 Thread Andrea Bolognani
On Mon, 2015-07-20 at 15:15 +0200, Peter Krempa wrote: > > > -virBitmapPtr nodeGetPresentCPUBitmap(const char *sysfs_prefix); > > -virBitmapPtr nodeGetCPUBitmap(const char *sysfs_prefix, int > > *max_id); > > +virBitmapPtr nodeGetPresentCPUBitmap(const char *sysfs_prefix, > > +

Re: [libvirt] [PATCH 05/10] nodeinfo: Add out parameter to nodeGetPresentCPUBitmap()

2015-07-20 Thread Peter Krempa
On Fri, Jul 17, 2015 at 18:13:24 +0200, Andrea Bolognani wrote: > This aligns it with nodeGetCPUBitmap(), which already has a > similar out parameters, and relieves users of this API from the > need to call virBitmapSize() on the returned bitmap. > --- > src/nodeinfo.c | 8 ++-- > src/no

[libvirt] [PATCH 05/10] nodeinfo: Add out parameter to nodeGetPresentCPUBitmap()

2015-07-17 Thread Andrea Bolognani
This aligns it with nodeGetCPUBitmap(), which already has a similar out parameters, and relieves users of this API from the need to call virBitmapSize() on the returned bitmap. --- src/nodeinfo.c | 8 ++-- src/nodeinfo.h | 6 -- src/util/vircgroup.c | 4 +--- 3 files changed, 1