Re: [libvirt] [PATCH 09/14] conf: Add VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_PL011

2017-11-16 Thread Pino Toscano
On Thursday, 16 November 2017 16:44:24 CET Andrea Bolognani wrote: > On Thu, 2017-11-16 at 16:17 +0100, Pino Toscano wrote: > > On Thursday, 16 November 2017 14:56:32 CET Pavel Hrdina wrote: > > > How about we introduce another attribute/element that would specify the > > > exact model of the

Re: [libvirt] [PATCH 09/14] conf: Add VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_PL011

2017-11-16 Thread Pavel Hrdina
On Thu, Nov 16, 2017 at 04:44:24PM +0100, Andrea Bolognani wrote: > On Thu, 2017-11-16 at 16:17 +0100, Pino Toscano wrote: > > On Thursday, 16 November 2017 14:56:32 CET Pavel Hrdina wrote: > > > How about we introduce another attribute/element that would specify the > > > exact model of the

Re: [libvirt] [PATCH 09/14] conf: Add VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_PL011

2017-11-16 Thread Andrea Bolognani
On Thu, 2017-11-16 at 16:17 +0100, Pino Toscano wrote: > On Thursday, 16 November 2017 14:56:32 CET Pavel Hrdina wrote: > > How about we introduce another attribute/element that would specify the > > exact model of the serial device and it would be optional, libvirt would > > be able to choose the

Re: [libvirt] [PATCH 09/14] conf: Add VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_PL011

2017-11-16 Thread Pavel Hrdina
On Thu, Nov 16, 2017 at 03:53:42PM +0100, Andrea Bolognani wrote: > On Thu, 2017-11-16 at 14:56 +0100, Pavel Hrdina wrote: > > Here the name "pl011" is even worse than "spapr-vty". It's a device > > name and there is also "pl022" (probably not supported by QEMU). The > > bus name is APB

Re: [libvirt] [PATCH 09/14] conf: Add VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_PL011

2017-11-16 Thread Pino Toscano
On Thursday, 16 November 2017 14:56:32 CET Pavel Hrdina wrote: > How about we introduce another attribute/element that would specify the > exact model of the serial device and it would be optional, libvirt would > be able to choose the model if none is specified. Can you please provide an example

Re: [libvirt] [PATCH 09/14] conf: Add VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_PL011

2017-11-16 Thread Andrea Bolognani
On Thu, 2017-11-16 at 14:56 +0100, Pavel Hrdina wrote: > Here the name "pl011" is even worse than "spapr-vty". It's a device > name and there is also "pl022" (probably not supported by QEMU). The > bus name is APB (Advanced Peripheral Bus). [1] [2] QEMU has pl031 and pl061 devices in addition

Re: [libvirt] [PATCH 09/14] conf: Add VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_PL011

2017-11-16 Thread Pavel Hrdina
On Wed, Nov 15, 2017 at 12:50:12PM +0100, Andrea Bolognani wrote: > We can finally introduce a specific target type for the pl011 device > used by mach-virt guests, which means isa-serial will no longer show > up to confuse users. > > We make sure migration works in both directions by

[libvirt] [PATCH 09/14] conf: Add VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_PL011

2017-11-15 Thread Andrea Bolognani
We can finally introduce a specific target type for the pl011 device used by mach-virt guests, which means isa-serial will no longer show up to confuse users. We make sure migration works in both directions by interpreting the isa-serial target type, or the lack of target type, appropriately when