Re: [libvirt] [PATCH 1/14] Adding recursive locks

2010-03-22 Thread Paolo Bonzini
On 03/18/2010 06:04 PM, Eric Blake wrote: ACK. I had to double-check MSDN to make sure that threads-win32 already creates recursive mutex by default. I don't supposed you read if its possible to make it non-recursive, since the orginal impl is supposed to be non-recursive !

[libvirt] [PATCH 1/14] Adding recursive locks

2010-03-18 Thread Stefan Berger
This patch adds recursive locks necessary due to the processing of network filter XML that can reference other network filters, including references that cause looks. Loops in the XML are prevented but their detection requires recursive locks. --- src/util/threads-pthread.c | 13

Re: [libvirt] [PATCH 1/14] Adding recursive locks

2010-03-18 Thread Eric Blake
On 03/18/2010 09:15 AM, Stefan Berger wrote: This patch adds recursive locks necessary due to the processing of network filter XML that can reference other network filters, including references that cause looks. Loops in the XML are prevented but their detection requires recursive locks. ACK.

Re: [libvirt] [PATCH 1/14] Adding recursive locks

2010-03-18 Thread Daniel P. Berrange
On Thu, Mar 18, 2010 at 10:41:58AM -0600, Eric Blake wrote: On 03/18/2010 09:15 AM, Stefan Berger wrote: This patch adds recursive locks necessary due to the processing of network filter XML that can reference other network filters, including references that cause looks. Loops in the XML

Re: [libvirt] [PATCH 1/14] Adding recursive locks

2010-03-18 Thread Eric Blake
On 03/18/2010 10:51 AM, Daniel P. Berrange wrote: On Thu, Mar 18, 2010 at 10:41:58AM -0600, Eric Blake wrote: On 03/18/2010 09:15 AM, Stefan Berger wrote: This patch adds recursive locks necessary due to the processing of network filter XML that can reference other network filters, including

Re: [libvirt] [PATCH 1/14] Adding recursive locks

2010-03-18 Thread Stefan Berger
Daniel P. Berrange berra...@redhat.com wrote on 03/18/2010 12:51:55 PM: Please respond to Daniel P. Berrange On Thu, Mar 18, 2010 at 10:41:58AM -0600, Eric Blake wrote: On 03/18/2010 09:15 AM, Stefan Berger wrote: This patch adds recursive locks necessary due to the processing of

Re: [libvirt] [PATCH 1/14] Adding recursive locks

2010-03-18 Thread Daniel P. Berrange
On Thu, Mar 18, 2010 at 11:04:17AM -0600, Eric Blake wrote: On 03/18/2010 10:51 AM, Daniel P. Berrange wrote: On Thu, Mar 18, 2010 at 10:41:58AM -0600, Eric Blake wrote: On 03/18/2010 09:15 AM, Stefan Berger wrote: This patch adds recursive locks necessary due to the processing of network

Re: [libvirt] [PATCH 1/14] Adding recursive locks

2010-03-18 Thread Daniel P. Berrange
On Thu, Mar 18, 2010 at 11:16:09AM -0600, Eric Blake wrote: On 03/18/2010 11:04 AM, Eric Blake wrote: But what does a true non-recursive mutex buy you? The only difference between recursive and true non-recursive is whether you declare that an attempt to relock a mutex that you already own

Re: [libvirt] [PATCH 1/14] Adding recursive locks

2010-03-18 Thread Eric Blake
On 03/18/2010 11:04 AM, Eric Blake wrote: But what does a true non-recursive mutex buy you? The only difference between recursive and true non-recursive is whether you declare that an attempt to relock a mutex that you already own is a fatal deadlock error, rather than incrementing a counter

Re: [libvirt] [PATCH 1/14] Adding recursive locks

2010-03-18 Thread Laine Stump
On 03/18/2010 01:04 PM, Eric Blake wrote: On 03/18/2010 10:51 AM, Daniel P. Berrange wrote: On Thu, Mar 18, 2010 at 10:41:58AM -0600, Eric Blake wrote: On 03/18/2010 09:15 AM, Stefan Berger wrote: This patch adds recursive locks necessary due to the processing of network