Re: [libvirt] [PATCH 1/3] daemon: finish threads on close

2017-10-18 Thread Nikolay Shirokovskiy
On 18.10.2017 14:17, John Ferlan wrote: > [...] > >> So I can split this patch to 2 and clear servers hash table as you >> suggusted instead of tossing virThreadPoolFree and add 2 extra >> patches to make referencing at virNetDaemonAddServerPostExec straight. >> This will take almost no time thu

Re: [libvirt] [PATCH 1/3] daemon: finish threads on close

2017-10-18 Thread John Ferlan
[...] > So I can split this patch to 2 and clear servers hash table as you > suggusted instead of tossing virThreadPoolFree and add 2 extra > patches to make referencing at virNetDaemonAddServerPostExec straight. > This will take almost no time thus let's move to the other parts of the > series.

Re: [libvirt] [PATCH 1/3] daemon: finish threads on close

2017-10-17 Thread Nikolay Shirokovskiy
On 17.10.2017 15:34, John Ferlan wrote: > > > On 10/17/2017 03:40 AM, Nikolay Shirokovskiy wrote: >> >> >> On 16.10.2017 15:47, John Ferlan wrote: >>> >>> >>> On 09/27/2017 08:45 AM, Nikolay Shirokovskiy wrote: Current daemon shutdown can cause crashes. The problem is that threads ser

Re: [libvirt] [PATCH 1/3] daemon: finish threads on close

2017-10-17 Thread John Ferlan
On 10/17/2017 03:40 AM, Nikolay Shirokovskiy wrote: > > > On 16.10.2017 15:47, John Ferlan wrote: >> >> >> On 09/27/2017 08:45 AM, Nikolay Shirokovskiy wrote: >>> Current daemon shutdown can cause crashes. The problem is that threads >>> serving client request are joined on daemon dispose after

Re: [libvirt] [PATCH 1/3] daemon: finish threads on close

2017-10-17 Thread Nikolay Shirokovskiy
On 16.10.2017 15:47, John Ferlan wrote: > > > On 09/27/2017 08:45 AM, Nikolay Shirokovskiy wrote: >> Current daemon shutdown can cause crashes. The problem is that threads >> serving client request are joined on daemon dispose after drivers already >> cleaned up. But this threads typically uses

Re: [libvirt] [PATCH 1/3] daemon: finish threads on close

2017-10-16 Thread John Ferlan
On 09/27/2017 08:45 AM, Nikolay Shirokovskiy wrote: > Current daemon shutdown can cause crashes. The problem is that threads > serving client request are joined on daemon dispose after drivers already > cleaned up. But this threads typically uses drivers and thus crashes come. > We need to join t

[libvirt] [PATCH 1/3] daemon: finish threads on close

2017-09-27 Thread Nikolay Shirokovskiy
Current daemon shutdown can cause crashes. The problem is that threads serving client request are joined on daemon dispose after drivers already cleaned up. But this threads typically uses drivers and thus crashes come. We need to join threads before virStateCleanup. virNetDaemonClose is a good can