Re: [libvirt] [PATCH 3/3] virStream: Remove callbacks on Abort/Finish

2017-06-01 Thread Martin Kletzander
On Thu, Jun 01, 2017 at 02:29:04PM +0100, Daniel P. Berrange wrote: On Thu, Jun 01, 2017 at 03:20:50PM +0200, Martin Kletzander wrote: On Thu, Jun 01, 2017 at 01:29:45PM +0100, Daniel P. Berrange wrote: > On Thu, Jun 01, 2017 at 02:24:19PM +0200, Martin Kletzander wrote: > > On Thu, Jun 01, 2017

Re: [libvirt] [PATCH 3/3] virStream: Remove callbacks on Abort/Finish

2017-06-01 Thread Daniel P. Berrange
On Thu, Jun 01, 2017 at 03:20:50PM +0200, Martin Kletzander wrote: > On Thu, Jun 01, 2017 at 01:29:45PM +0100, Daniel P. Berrange wrote: > > On Thu, Jun 01, 2017 at 02:24:19PM +0200, Martin Kletzander wrote: > > > On Thu, Jun 01, 2017 at 01:19:05PM +0100, Daniel P. Berrange wrote: > > > > On Thu, J

Re: [libvirt] [PATCH 3/3] virStream: Remove callbacks on Abort/Finish

2017-06-01 Thread Martin Kletzander
On Thu, Jun 01, 2017 at 01:29:45PM +0100, Daniel P. Berrange wrote: On Thu, Jun 01, 2017 at 02:24:19PM +0200, Martin Kletzander wrote: On Thu, Jun 01, 2017 at 01:19:05PM +0100, Daniel P. Berrange wrote: > On Thu, Jun 01, 2017 at 02:08:34PM +0200, Martin Kletzander wrote: > > Users need to remove

Re: [libvirt] [PATCH 3/3] virStream: Remove callbacks on Abort/Finish

2017-06-01 Thread Daniel P. Berrange
On Thu, Jun 01, 2017 at 02:24:19PM +0200, Martin Kletzander wrote: > On Thu, Jun 01, 2017 at 01:19:05PM +0100, Daniel P. Berrange wrote: > > On Thu, Jun 01, 2017 at 02:08:34PM +0200, Martin Kletzander wrote: > > > Users need to remove their callbacks before calling virStreamAbort() > > > or virStre

Re: [libvirt] [PATCH 3/3] virStream: Remove callbacks on Abort/Finish

2017-06-01 Thread Martin Kletzander
On Thu, Jun 01, 2017 at 01:19:05PM +0100, Daniel P. Berrange wrote: On Thu, Jun 01, 2017 at 02:08:34PM +0200, Martin Kletzander wrote: Users need to remove their callbacks before calling virStreamAbort() or virStreamFinish() even though that's not documented anywhere. Since it makes no sense to

Re: [libvirt] [PATCH 3/3] virStream: Remove callbacks on Abort/Finish

2017-06-01 Thread Daniel P. Berrange
On Thu, Jun 01, 2017 at 02:08:34PM +0200, Martin Kletzander wrote: > Users need to remove their callbacks before calling virStreamAbort() > or virStreamFinish() even though that's not documented anywhere. > Since it makes no sense to keep those callbacks, we can remove them > when the stream is bei

[libvirt] [PATCH 3/3] virStream: Remove callbacks on Abort/Finish

2017-06-01 Thread Martin Kletzander
Users need to remove their callbacks before calling virStreamAbort() or virStreamFinish() even though that's not documented anywhere. Since it makes no sense to keep those callbacks, we can remove them when the stream is being aborted or finished. That way it is also more intuitive for developers