Re: [libvirt] [PATCH 4/8] conf: domaincaps: Add 'iothreads' to the features section

2019-11-14 Thread Peter Krempa
On Thu, Nov 14, 2019 at 12:59:00 +0100, Peter Krempa wrote: > On Thu, Nov 14, 2019 at 12:55:40 +0100, Ján Tomko wrote: > > On Wed, Nov 13, 2019 at 05:05:22PM +0100, Peter Krempa wrote: > > > Historically iothreads were the first feature and thus didn't have it's > > > own section. Add them to for

Re: [libvirt] [PATCH 4/8] conf: domaincaps: Add 'iothreads' to the features section

2019-11-14 Thread Peter Krempa
On Thu, Nov 14, 2019 at 12:55:40 +0100, Ján Tomko wrote: > On Wed, Nov 13, 2019 at 05:05:22PM +0100, Peter Krempa wrote: > > Historically iothreads were the first feature and thus didn't have it's > > own section. Add them to for consistency with other features. > > > > I'm not convinced

Re: [libvirt] [PATCH 4/8] conf: domaincaps: Add 'iothreads' to the features section

2019-11-14 Thread Ján Tomko
On Wed, Nov 13, 2019 at 05:05:22PM +0100, Peter Krempa wrote: Historically iothreads were the first feature and thus didn't have it's own section. Add them to for consistency with other features. I'm not convinced duplicating this is a good idea - apps looking into the element for iothread

[libvirt] [PATCH 4/8] conf: domaincaps: Add 'iothreads' to the features section

2019-11-13 Thread Peter Krempa
Historically iothreads were the first feature and thus didn't have it's own section. Add them to for consistency with other features. Unfortunately we must keep the original one in place. Signed-off-by: Peter Krempa --- docs/schemas/domaincaps.rng | 3 +++