Re: [libvirt] [PATCH v1 03/23] virSecurityDACSetOwnershipInternal: Don't chown so often

2015-10-15 Thread Peter Krempa
On Mon, Oct 12, 2015 at 12:25:48 +0200, Michal Privoznik wrote: > It's better if we stat() file that we are about to chown() at > first and check if there's something we need to change. Not that > it would make much difference, but for the upcoming patches we > need to be doing stat() anyway. > >

Re: [libvirt] [PATCH v1 03/23] virSecurityDACSetOwnershipInternal: Don't chown so often

2015-10-15 Thread John Ferlan
On 10/12/2015 06:25 AM, Michal Privoznik wrote: > It's better if we stat() file that we are about to chown() at > first and check if there's something we need to change. Not that > it would make much difference, but for the upcoming patches we > need to be doing stat() anyway. > > Signed-off-by:

[libvirt] [PATCH v1 03/23] virSecurityDACSetOwnershipInternal: Don't chown so often

2015-10-12 Thread Michal Privoznik
It's better if we stat() file that we are about to chown() at first and check if there's something we need to change. Not that it would make much difference, but for the upcoming patches we need to be doing stat() anyway. Signed-off-by: Michal Privoznik --- src/security/security_dac.c | 19 +