On Wed, Oct 25, 2023 at 07:06:53PM +0200, Andrea Bolognani wrote:
Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/1049326523
Changes from [v1]
* fix test suite on macOS and ensure it is run as part of the
pipeline (with the previous version it would just always fail);
*
There are some cases in which we automatically disable tests when
using Clang as the compiler. If the user has explicitly asked for
tests to be enabled, however, we should error out instead of
silently disabling things.
Signed-off-by: Andrea Bolognani
Reviewed-by: Michal Privoznik
---
Currently, passing -Dtests=disabled only disables a subset of
tests: those that are written in C and thus require compilation.
Other tests, such as the syntax-check ones and those that are
implemented as scripts, are always enabled.
There's a potentially dangerous consequence of this behavior:
Test cases that depend on duplicating fds are using fairly big
values as targets.
This works fine on Linux, where RLIMIT_NOFILE is 1024 by
default, but fails on macOS which uses 256 as the default.
Decrease the values so that they're valid across all platforms.
Signed-off-by: Andrea Bolognani
Given that this variable now controls not just whether C tests
are built, but also whether any test at all is executed, the new
name is more appropriate.
Update the description for the corresponding meson option
accordingly.
Signed-off-by: Andrea Bolognani
Reviewed-by: Michal Privoznik
---
It only makes sense to enable expensive tests when tests are
enabled. Disallow invalid configurations.
Signed-off-by: Andrea Bolognani
Reviewed-by: Michal Privoznik
---
meson.build | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index
As explained in the comment, the syntax-check machinery uses git
to figure out the list of files it should operate on, so we can
only enable it when building from git.
Despite only registering the various tests with meson in that
case, however, we unconditionally perform a bunch of preparation
This will make future patches nicer.
Note that we need to handle these somewhat late because of the
dependency on information about the compiler and the flags it
supports.
Signed-off-by: Andrea Bolognani
Reviewed-by: Michal Privoznik
---
meson.build | 57
Clang can be too aggressive at optimizations, which can end up
breaking our test suite. See f9f5ab57189b for details.
As a result of this, since 7944700b4037 we are automatically
disabling tests when Clang is used unless it supports the
-fsemantic-interposition compiler flag.
Since the version
Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/1049326523
Changes from [v1]
* fix test suite on macOS and ensure it is run as part of the
pipeline (with the previous version it would just always fail);
* disable a couple of tests (check-html, check-html-references)
On Wed, Oct 18, 2023 at 03:36:47PM -0400, Laine Stump wrote:
> On 10/16/23 3:34 PM, Praveen K Paladugu wrote:
> >Move guest interface management methods from qemu to hypervisor. These
> >methods will be shared by networking support in ch driver.
> >
> >Signed-off-by: Praveen K Paladugu
> >---
> >
On 10/16/23 3:34 PM, Praveen K Paladugu wrote:
Move guest interface management methods from qemu to hypervisor. These
methods will be shared by networking support in ch driver.
Signed-off-by: Praveen K Paladugu
---
po/POTFILES | 1 +
src/hypervisor/domain_interface.c
Move guest interface management methods from qemu to hypervisor. These
methods will be shared by networking support in ch driver.
Signed-off-by: Praveen K Paladugu
---
po/POTFILES | 1 +
src/hypervisor/domain_interface.c | 280 ++
On 10/5/23 4:22 AM, Andrea Bolognani wrote:
Changes from [v1]:
* disable nbdkit on anything older than Fedora 40 in the RPM.
[v1] https://listman.redhat.com/archives/libvir-list/2023-October/242498.html
Andrea Bolognani (1):
meson: Improve nbdkit configurability
libvirt.spec.in
Currently, nbdkit support will automatically be enabled as long as
the pidfd_open(2) syscall is available. Optionally, libnbd is used
to generate more user-friendly error messages.
In theory this is all good, since use of nbdkit is supposed to be
transparent to the user. In practice, however,
Changes from [v1]:
* disable nbdkit on anything older than Fedora 40 in the RPM.
[v1] https://listman.redhat.com/archives/libvir-list/2023-October/242498.html
Andrea Bolognani (1):
meson: Improve nbdkit configurability
libvirt.spec.in| 28 +---
meson.build
On Wed, Sep 27, 2023 at 06:19:32PM +0200, Andrea Bolognani wrote:
> Currently we only set this for the main sockets, which means
> that
>
> $ systemctl stop virtqemud.socket
>
> will make the socket disappear from the filesystem while
>
> $ systemctl stop virtqemud-ro.socket
>
> won't. Get
On Thu, Sep 28, 2023 at 06:52:35AM -0500, Andrea Bolognani wrote:
> On Thu, Sep 28, 2023 at 04:30:03AM -0500, Andrea Bolognani wrote:
> > On Thu, Sep 28, 2023 at 09:24:11AM +0100, Daniel P. Berrangé wrote:
> > > On Wed, Sep 27, 2023 at 06:19:07PM +0200, Andrea Bolognani wrote:
> > > > +++
On Thu, Sep 28, 2023 at 04:30:03AM -0500, Andrea Bolognani wrote:
> On Thu, Sep 28, 2023 at 09:24:11AM +0100, Daniel P. Berrangé wrote:
> > On Wed, Sep 27, 2023 at 06:19:07PM +0200, Andrea Bolognani wrote:
> > > +++ b/scripts/merge-systemd-units.py
> > > @@ -0,0 +1,91 @@
> > > +#!/usr/bin/env
On Wed, Sep 27, 2023 at 06:19:11PM +0200, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> src/nwfilter/meson.build | 4
> src/nwfilter/virtnwfilterd.service.in | 25 -
> 2 files changed, 29 deletions(-)
> delete mode 100644
On Wed, Sep 27, 2023 at 06:19:08PM +0200, Andrea Bolognani wrote:
> All services are still listing their input files explicitly, so
> no changes to the output files will occur yet.
>
> Signed-off-by: Andrea Bolognani
> ---
> src/meson.build | 10 +-
> 1 file changed, 5 insertions(+), 5
On Wed, Sep 27, 2023 at 06:19:27PM +0200, Andrea Bolognani wrote:
> Only the main socket is actually necessary for the service to be
> usable.
>
> In the past, we've had security issues that could be exploited via
> access to the read-only socket, so a security-minded administrator
> might
On Wed, Sep 27, 2023 at 06:19:31PM +0200, Andrea Bolognani wrote:
> This results in all sockets for a service being enabled when a
> single one of them is.
>
> The -tcp and -tls sockets are intentionally excluded, because
> enabling them should require explicit action on the
> administrator's
On Wed, Sep 27, 2023 at 06:19:33PM +0200, Andrea Bolognani wrote:
> Hypervisors are referred to by their user-facing name rather
> than the name of their libvirt driver, the monolithic daemon is
> explicitly referred to as legacy, and a consistent format is
> used throughout.
>
> Signed-off-by:
On Wed, Sep 27, 2023 at 06:19:15PM +0200, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> src/vbox/meson.build| 5 +
> src/vbox/virtvboxd.service.extra.in | 2 ++
> src/vbox/virtvboxd.service.in | 26 --
> 3 files changed, 3
On Thu, Sep 28, 2023 at 05:38:45AM -0500, Andrea Bolognani wrote:
> On Thu, Sep 28, 2023 at 11:16:53AM +0100, Daniel P. Berrangé wrote:
> > On Wed, Sep 27, 2023 at 06:19:09PM +0200, Andrea Bolognani wrote:
> > > Signed-off-by: Andrea Bolognani
> > > ---
> > > src/node_device/meson.build
On Wed, Sep 27, 2023 at 06:19:17PM +0200, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> src/ch/meson.build | 5 +---
> src/ch/virtchd.service.extra.in | 22 +
> src/ch/virtchd.service.in | 44 -
> 3 files
On Wed, Sep 27, 2023 at 06:19:14PM +0200, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> src/storage/meson.build | 5 +
> src/storage/virtstoraged.service.extra.in | 3 +++
> src/storage/virtstoraged.service.in | 27 ---
> 3
On Wed, Sep 27, 2023 at 06:19:10PM +0200, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> src/interface/meson.build | 4
> src/interface/virtinterfaced.service.in | 25 -
> 2 files changed, 29 deletions(-)
> delete mode 100644
On Wed, Sep 27, 2023 at 06:19:16PM +0200, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> src/vz/meson.build | 5 +
> src/vz/virtvzd.service.extra.in | 2 ++
> src/vz/virtvzd.service.in | 26 --
> 3 files changed, 3
On Wed, Sep 27, 2023 at 06:19:20PM +0200, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> src/qemu/meson.build| 5 +--
> src/qemu/virtqemud.service.extra.in | 28 +
> src/qemu/virtqemud.service.in | 48 -
> 3
On Thu, Sep 28, 2023 at 11:16:53AM +0100, Daniel P. Berrangé wrote:
> On Wed, Sep 27, 2023 at 06:19:09PM +0200, Andrea Bolognani wrote:
> > Signed-off-by: Andrea Bolognani
> > ---
> > src/node_device/meson.build | 4
> > src/node_device/virtnodedevd.service.in | 25
On Wed, Sep 27, 2023 at 06:19:22PM +0200, Andrea Bolognani wrote:
> Now that the migration to common templates has been completed,
> we no longer need these.
>
> Signed-off-by: Andrea Bolognani
> ---
> src/meson.build | 4
> 1 file changed, 4 deletions(-)
Reviewed-by: Daniel P. Berrangé
On Wed, Sep 27, 2023 at 06:19:12PM +0200, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> src/secret/meson.build| 4
> src/secret/virtsecretd.service.in | 25 -
> 2 files changed, 29 deletions(-)
> delete mode 100644
On Wed, Sep 27, 2023 at 06:19:09PM +0200, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> src/node_device/meson.build | 4
> src/node_device/virtnodedevd.service.in | 25 -
> 2 files changed, 29 deletions(-)
> delete mode 100644
On Wed, Sep 27, 2023 at 06:19:03PM +0200, Andrea Bolognani wrote:
> They're similar to the existing socket_in/socket_out variables
> and will make future changes nicer.
>
> Signed-off-by: Andrea Bolognani
> ---
> src/meson.build | 7 +--
> 1 file changed, 5 insertions(+), 2 deletions(-)
On Wed, Sep 27, 2023 at 06:19:19PM +0200, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> src/lxc/meson.build | 5 +---
> src/lxc/virtlxcd.service.extra.in | 22
> src/lxc/virtlxcd.service.in | 44 ---
> 3 files
On Wed, Sep 27, 2023 at 06:19:21PM +0200, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> src/remote/meson.build | 6 --
> src/remote/virtproxyd.service.in | 25 -
> 2 files changed, 31 deletions(-)
> delete mode 100644
On Wed, Sep 27, 2023 at 06:19:13PM +0200, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> src/network/meson.build | 5 +
> src/network/virtnetworkd.service.extra.in | 2 ++
> src/network/virtnetworkd.service.in | 26 ---
> 3
On Wed, Sep 27, 2023 at 06:19:18PM +0200, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> src/libxl/meson.build | 7 ++-
> src/libxl/virtxend.service.extra.in | 12 +++
> src/libxl/virtxend.service.in | 32 -
>
On Wed, Sep 27, 2023 at 06:19:05PM +0200, Andrea Bolognani wrote:
> These will be useful during the upcoming migration to common
> templates for systemd units and will be dropped as soon as all
> services have been converted.
>
> Signed-off-by: Andrea Bolognani
> ---
> src/meson.build | 4
On Wed, Sep 27, 2023 at 06:19:04PM +0200, Andrea Bolognani wrote:
> It is currently considered required, but we're soon going to
> provide a default that will be suitable for most services.
>
> Since all services currently provide a value explicitly, we
> can implement a default without breaking
On Thu, Sep 28, 2023 at 09:24:11AM +0100, Daniel P. Berrangé wrote:
> On Wed, Sep 27, 2023 at 06:19:07PM +0200, Andrea Bolognani wrote:
> > +++ b/scripts/merge-systemd-units.py
> > @@ -0,0 +1,91 @@
> > +#!/usr/bin/env python3
>
> Stick a license header of SPDX tag on this.
Done (patch below).
>
On Wed, Sep 27, 2023 at 06:19:06PM +0200, Andrea Bolognani wrote:
> We're about to change the defaults and start migrating to common
> templates: in order to be able to switch units over one at a
> time, make the input files that are currently used explicit
> rather than implicit.
>
>
On Wed, Sep 27, 2023 at 06:19:07PM +0200, Andrea Bolognani wrote:
> We already use templating to generate sockets, which are all
> based off libvirtd's. Push the idea further, and extend it to
> cover services as well.
>
> This is more challenging, as the various modular daemons each have
> their
On Wed, Sep 27, 2023 at 06:19:23PM +0200, Andrea Bolognani wrote:
> It's no longer used anywhere.
>
> Signed-off-by: Andrea Bolognani
> ---
> src/meson.build | 2 --
> src/remote/libvirtd-admin.socket.in | 1 -
> src/remote/libvirtd-ro.socket.in| 1 -
>
On Wed, Sep 27, 2023 at 06:19:26PM +0200, Andrea Bolognani wrote:
> This is the strongest relationship that can be declared between
> two units, and causes the service to be terminated immediately
> if its main socket disappears. This is the behavior we want.
>
> Note that we don't do the same
On Wed, Sep 27, 2023 at 06:19:24PM +0200, Andrea Bolognani wrote:
> Up until now the files have been used as template for most
> services, but now that those have been converted to common
> templates we can drop parametrization and make it clear that
> these files are for libvirtd only.
>
>
On Wed, Sep 27, 2023 at 06:19:02PM +0200, Andrea Bolognani wrote:
> The idea behind these is to prevent running both modular daemons
> and monolithic daemon at the same time. We will implement a more
> effective solution for that shortly.
>
> Signed-off-by: Andrea Bolognani
> ---
>
It's no longer used anywhere.
Signed-off-by: Andrea Bolognani
---
src/meson.build | 2 --
src/remote/libvirtd-admin.socket.in | 1 -
src/remote/libvirtd-ro.socket.in| 1 -
src/remote/libvirtd-tcp.socket.in | 1 -
src/remote/libvirtd-tls.socket.in | 1 -
Currently we only set this for the main sockets, which means
that
$ systemctl stop virtqemud.socket
will make the socket disappear from the filesystem while
$ systemctl stop virtqemud-ro.socket
won't. Get rid of this inconsistency.
Signed-off-by: Andrea Bolognani
---
We have already declared the mirror relationship, so this one
is now redundant.
Moreover, this version was incomplete: it only ever worked for
the monolithic daemon, but the modular daemons for QEMU and Xen
also want the sockets to be active.
Signed-off-by: Andrea Bolognani
Reviewed-by: Daniel
Like the Description, these are intended to be displayed to the
user, so it makes sense to have them towards the top of the file
before all the information that systemd will parse to calculate
dependencies.
Signed-off-by: Andrea Bolognani
Reviewed-by: Daniel P. Berrangé
---
It is currently considered required, but we're soon going to
provide a default that will be suitable for most services.
Since all services currently provide a value explicitly, we
can implement a default without breaking anything.
Signed-off-by: Andrea Bolognani
---
src/meson.build | 6 --
Signed-off-by: Andrea Bolognani
---
src/secret/meson.build| 4
src/secret/virtsecretd.service.in | 25 -
2 files changed, 29 deletions(-)
delete mode 100644 src/secret/virtsecretd.service.in
diff --git a/src/secret/meson.build b/src/secret/meson.build
They're similar to the existing socket_in/socket_out variables
and will make future changes nicer.
Signed-off-by: Andrea Bolognani
---
src/meson.build | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/meson.build b/src/meson.build
index 6c85cc9b9b..c6728cc8f8 100644
We're about to change the defaults and start migrating to common
templates: in order to be able to switch units over one at a
time, make the input files that are currently used explicit
rather than implicit.
Signed-off-by: Andrea Bolognani
---
src/ch/meson.build | 3 +++
Signed-off-by: Andrea Bolognani
---
src/network/meson.build | 5 +
src/network/virtnetworkd.service.extra.in | 2 ++
src/network/virtnetworkd.service.in | 26 ---
3 files changed, 3 insertions(+), 30 deletions(-)
create mode 100644
Signed-off-by: Andrea Bolognani
---
src/storage/meson.build | 5 +
src/storage/virtstoraged.service.extra.in | 3 +++
src/storage/virtstoraged.service.in | 27 ---
3 files changed, 4 insertions(+), 31 deletions(-)
create mode 100644
These will be useful during the upcoming migration to common
templates for systemd units and will be dropped as soon as all
services have been converted.
Signed-off-by: Andrea Bolognani
---
src/meson.build | 4
1 file changed, 4 insertions(+)
diff --git a/src/meson.build b/src/meson.build
We already use templating to generate sockets, which are all
based off libvirtd's. Push the idea further, and extend it to
cover services as well.
This is more challenging, as the various modular daemons each have
their own needs in terms of what system services needs to be
available before they
Signed-off-by: Andrea Bolognani
---
src/vbox/meson.build| 5 +
src/vbox/virtvboxd.service.extra.in | 2 ++
src/vbox/virtvboxd.service.in | 26 --
3 files changed, 3 insertions(+), 30 deletions(-)
create mode 100644
All services are still listing their input files explicitly, so
no changes to the output files will occur yet.
Signed-off-by: Andrea Bolognani
---
src/meson.build | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/meson.build b/src/meson.build
index
Requires/Wants only tells systemd that the corresponding unit
should be started when the current one is, but that could very
well happen in parallel. For virtlogd/virtlockd, we want the
socket to be already active when the hypervisor driver is
started.
Signed-off-by: Andrea Bolognani
systemd will automatically infer this dependency based on the
socket's Service=foo.service setting.
Signed-off-by: Andrea Bolognani
Reviewed-by: Daniel P. Berrangé
---
src/remote/libvirtd-admin.socket.in | 1 -
src/remote/libvirtd-ro.socket.in| 1 -
src/remote/libvirtd-tcp.socket.in | 1
This is the strongest relationship that can be declared between
two units, and causes the service to be terminated immediately
if its main socket disappears. This is the behavior we want.
Note that we don't do the same for the read-only/admin sockets,
because those are not as critical for the
Signed-off-by: Andrea Bolognani
---
src/lxc/meson.build | 5 +---
src/lxc/virtlxcd.service.extra.in | 22
src/lxc/virtlxcd.service.in | 44 ---
3 files changed, 23 insertions(+), 48 deletions(-)
create mode 100644
Now that the migration to common templates has been completed,
we no longer need these.
Signed-off-by: Andrea Bolognani
---
src/meson.build | 4
1 file changed, 4 deletions(-)
diff --git a/src/meson.build b/src/meson.build
index 0fbefe37d5..541ca61101 100644
--- a/src/meson.build
+++
Up until now the files have been used as template for most
services, but now that those have been converted to common
templates we can drop parametrization and make it clear that
these files are for libvirtd only.
Signed-off-by: Andrea Bolognani
---
src/remote/libvirtd-admin.socket.in | 10
Signed-off-by: Andrea Bolognani
---
src/libxl/meson.build | 7 ++-
src/libxl/virtxend.service.extra.in | 12 +++
src/libxl/virtxend.service.in | 32 -
src/libxl/virtxend.socket.extra.in | 2 ++
4 files changed, 16 insertions(+), 37
Only the main socket is actually necessary for the service to be
usable.
In the past, we've had security issues that could be exploited via
access to the read-only socket, so a security-minded administrator
might consider disabling all optional sockets. This change makes
such a setup possible.
Signed-off-by: Andrea Bolognani
---
src/nwfilter/meson.build | 4
src/nwfilter/virtnwfilterd.service.in | 25 -
2 files changed, 29 deletions(-)
delete mode 100644 src/nwfilter/virtnwfilterd.service.in
diff --git a/src/nwfilter/meson.build
Hypervisors are referred to by their user-facing name rather
than the name of their libvirt driver, the monolithic daemon is
explicitly referred to as legacy, and a consistent format is
used throughout.
Signed-off-by: Andrea Bolognani
---
src/ch/meson.build| 2 +-
Signed-off-by: Andrea Bolognani
---
src/ch/meson.build | 5 +---
src/ch/virtchd.service.extra.in | 22 +
src/ch/virtchd.service.in | 44 -
3 files changed, 23 insertions(+), 48 deletions(-)
create mode 100644
Signed-off-by: Andrea Bolognani
---
src/remote/meson.build | 6 --
src/remote/virtproxyd.service.in | 25 -
2 files changed, 31 deletions(-)
delete mode 100644 src/remote/virtproxyd.service.in
diff --git a/src/remote/meson.build b/src/remote/meson.build
Signed-off-by: Andrea Bolognani
---
src/node_device/meson.build | 4
src/node_device/virtnodedevd.service.in | 25 -
2 files changed, 29 deletions(-)
delete mode 100644 src/node_device/virtnodedevd.service.in
diff --git a/src/node_device/meson.build
We want to make sure that, at any given time, we have either the
modular daemons or the monolithic one running, never both. In
order to achieve that, make every single modular unit conflict
with the corresponding libvirtd unit.
We set both Conflicts=libvirtd.unit and After=libvirtd.unit: this
The idea behind these is to prevent running both modular daemons
and monolithic daemon at the same time. We will implement a more
effective solution for that shortly.
Signed-off-by: Andrea Bolognani
---
src/remote/meson.build | 3 ---
1 file changed, 3 deletions(-)
diff --git
A grab bag of changes, ranging from very much functional ones
to purely aesthetical ones.
Changes from [v1]
* patches 01-11 from the original series have been pushed;
* patch 40 from the original series has been dropped;
* patches 02 (cosmetic) and 31 (bug fix) have been added;
* the
Signed-off-by: Andrea Bolognani
---
src/qemu/meson.build| 5 +--
src/qemu/virtqemud.service.extra.in | 28 +
src/qemu/virtqemud.service.in | 48 -
3 files changed, 29 insertions(+), 52 deletions(-)
create mode 100644
This results in all sockets for a service being enabled when a
single one of them is.
The -tcp and -tls sockets are intentionally excluded, because
enabling them should require explicit action on the
administrator's part; moreover, disabling them should not result
in the local sockets being
Signed-off-by: Andrea Bolognani
---
src/interface/meson.build | 4
src/interface/virtinterfaced.service.in | 25 -
2 files changed, 29 deletions(-)
delete mode 100644 src/interface/virtinterfaced.service.in
diff --git a/src/interface/meson.build
Signed-off-by: Andrea Bolognani
---
src/vz/meson.build | 5 +
src/vz/virtvzd.service.extra.in | 2 ++
src/vz/virtvzd.service.in | 26 --
3 files changed, 3 insertions(+), 30 deletions(-)
create mode 100644 src/vz/virtvzd.service.extra.in
delete
On a Monday in 2023, Jonathon Jongsma wrote:
virProcessKillPainfullyDelay() currently almost always returns 1 or -1,
even though the documentation indicates that it should return 0 if the
process was terminated gracefully. But the computation of the return
code is faulty and the only case that
virProcessKillPainfullyDelay() currently almost always returns 1 or -1,
even though the documentation indicates that it should return 0 if the
process was terminated gracefully. But the computation of the return
code is faulty and the only case that it currently returns 0 is when it
is called with
On Wed, Sep 13, 2023 at 12:57:09PM +0200, Erik Skultety wrote:
> On Wed, Sep 13, 2023 at 08:56:35AM +0100, Daniel P. Berrangé wrote:
> > On Tue, Sep 12, 2023 at 04:11:01PM -0500, Jonathon Jongsma wrote:
> > > On 9/12/23 7:00 AM, Peter Krempa wrote:
> > > > On Mon, Sep 11, 2023 at 16:53:42 -0500,
On Wed, Sep 13, 2023 at 08:56:35AM +0100, Daniel P. Berrangé wrote:
> On Tue, Sep 12, 2023 at 04:11:01PM -0500, Jonathon Jongsma wrote:
> > On 9/12/23 7:00 AM, Peter Krempa wrote:
> > > On Mon, Sep 11, 2023 at 16:53:42 -0500, Jonathon Jongsma wrote:
> > > > see
On Mon, Sep 11, 2023 at 03:43:19PM +0200, Erik Skultety wrote:
> Individual shell command executions are replaced by respective
> functions in the ci/build.sh base script. This will make sure we use
> the same recipes in GitLab jobs as well as in local executions.
>
> Signed-off-by: Erik Skultety
On Tue, Sep 12, 2023 at 04:11:01PM -0500, Jonathon Jongsma wrote:
> On 9/12/23 7:00 AM, Peter Krempa wrote:
> > On Mon, Sep 11, 2023 at 16:53:42 -0500, Jonathon Jongsma wrote:
> > > see https://bugzilla.redhat.com/show_bug.cgi?id=1900770.
> > >
> > > Changes in v2:
> > > - Don't use
On Tue, Sep 12, 2023 at 16:11:01 -0500, Jonathon Jongsma wrote:
> On 9/12/23 7:00 AM, Peter Krempa wrote:
> > On Mon, Sep 11, 2023 at 16:53:42 -0500, Jonathon Jongsma wrote:
> > > see https://bugzilla.redhat.com/show_bug.cgi?id=1900770.
> > >
> > > Changes in v2:
> > > - Don't use
On 9/12/23 7:00 AM, Peter Krempa wrote:
On Mon, Sep 11, 2023 at 16:53:42 -0500, Jonathon Jongsma wrote:
see https://bugzilla.redhat.com/show_bug.cgi?id=1900770.
Changes in v2:
- Don't use virStorageSource->path for vdpa device path to avoid clashing with
existing path functionality
-
On Mon, Sep 11, 2023 at 16:53:42 -0500, Jonathon Jongsma wrote:
> see https://bugzilla.redhat.com/show_bug.cgi?id=1900770.
>
> Changes in v2:
> - Don't use virStorageSource->path for vdpa device path to avoid clashing
> with
>existing path functionality
> - Move vdpa device opening to the
Check whether the qemu binary supports the vdpa block driver. We can't
rely simply on the existence of the virtio-blk-vhost-vdpa block driver
since the first releases of qemu didn't support fd-passing for this
driver. So we have to check for the 'fdset' feature on the driver
object. This feature
qemuInterfaceVDPAConnect() was a helper function for connecting to the
vdpa device file. But in order to support other vdpa devices besides
network interfaces (e.g. vdpa block devices) make this function a bit
more generic.
Signed-off-by: Jonathon Jongsma
Reviewed-by: Peter Krempa
---
vDPA block devices will also need the same consideration for memlock
limits as other vdpa devices, so consider these devices when calculating
memlock limits.
Signed-off-by: Jonathon Jongsma
Reviewed-by: Peter Krempa
---
src/qemu/qemu_domain.c | 12 ++--
1 file changed, 10
vDPA block devices can be configured as follows:
Signed-off-by: Jonathon Jongsma
---
docs/formatdomain.rst | 19 +--
src/ch/ch_monitor.c | 1 +
src/conf/domain_conf.c| 8
src/conf/schemas/domaincommon.rng | 13
Requires recent qemu with support for the virtio-blk-vhost-vdpa device
and the ability to pass a /dev/fdset/N path for the vdpa path (8.1.0)
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1900770
Signed-off-by: Jonathon Jongsma
---
src/qemu/qemu_block.c | 20
see https://bugzilla.redhat.com/show_bug.cgi?id=1900770.
Changes in v2:
- Don't use virStorageSource->path for vdpa device path to avoid clashing with
existing path functionality
- Move vdpa device opening to the qemuProcessPrepareHostStorageSource()
function rather than the
On Mon, Sep 11, 2023 at 03:43:11PM +0200, Erik Skultety wrote:
> This helper is a shell function transcript of its original GitLab CI
> counterpart. There's one notable difference such that we pass '-j1' to
> the meson compile command otherwise we'd have to execute the 'run_build'
> function
On Mon, Sep 11, 2023 at 03:43:14PM +0200, Erik Skultety wrote:
> Firstly, this would mangle with "sourcing" this file in either
> execution environment later down the road. Secondly, we won't need this
> as future ci/helper patches will generate a throwaway script that will
> take care of a
1 - 100 of 20170 matches
Mail list logo
