On Fri, Nov 13, 2015 at 02:13:35PM -0500, Zeeshan Ali (Khattak) wrote:
> Hi,
>
> >> +guint settime_flags;
> >> +
> >> +g_return_val_if_fail(GVIR_IS_DOMAIN(dom), FALSE);
> >> +g_return_val_if_fail(err == NULL || *err == NULL, FALSE);
> >
> > I'd keep a g_return_val_if_fail(flags == 0,
Hi,
>> +guint settime_flags;
>> +
>> +g_return_val_if_fail(GVIR_IS_DOMAIN(dom), FALSE);
>> +g_return_val_if_fail(err == NULL || *err == NULL, FALSE);
>
> I'd keep a g_return_val_if_fail(flags == 0, FALSE);
But doesn't that make G_GNUC_UNUSED declaration wrong then? I think
it's more
Some minor comments below, ACK.
Christophe
On Thu, Oct 29, 2015 at 08:44:17PM +, Zeeshan Ali (Khattak) wrote:
> ---
>
> This version:
>
> * Replaces the seconds and nseconds arguments by a GDateTime.
> * Drops the use of flags argument, since caller can specify the only flag
> currently
---
This version:
* Replaces the seconds and nseconds arguments by a GDateTime.
* Drops the use of flags argument, since caller can specify the only flag
currently possible (VIR_DOMAIN_TIME_SYNC) by simply passing a NULL as the
GDateTime argument.
* Add some needed articles to doc comment.
