Re: [libvirt] [PATCH v2 0/3] Better syntax-check on BSD

2019-01-10 Thread Andrea Bolognani
On Thu, 2019-01-10 at 16:20 +0300, Roman Bolshakov wrote: > Perhaps we should install grep, gnu-sed and cppi from homebrew in > .travis.yml to get it working. I have all of them installed on my laptop > and syntax-check passes without the errors for me. > > grep provides GNU grep and all the

Re: [libvirt] [PATCH v2 0/3] Better syntax-check on BSD

2019-01-10 Thread Roman Bolshakov
On Thu, Jan 10, 2019 at 11:49:35AM +0100, Andrea Bolognani wrote: > On Thu, 2019-01-10 at 10:34 +0300, Roman Bolshakov wrote: > > I've run 'make syntax-check' on libvirt's HEAD. It succeeds on macOS. > > Perhaps we can add syntax-check to .travis.yml? > > syntax-check passes on macOS, but it

Re: [libvirt] [PATCH v2 0/3] Better syntax-check on BSD

2019-01-10 Thread Andrea Bolognani
On Thu, 2019-01-10 at 10:34 +0300, Roman Bolshakov wrote: > I've run 'make syntax-check' on libvirt's HEAD. It succeeds on macOS. > Perhaps we can add syntax-check to .travis.yml? syntax-check passes on macOS, but it doesn't quite succeed: [...] unmarked_diagnostics

Re: [libvirt] [PATCH v2 0/3] Better syntax-check on BSD

2019-01-09 Thread Roman Bolshakov
On Thu, Jan 03, 2019 at 01:41:56PM -0600, Eric Blake wrote: > Since v1: fix the gnulib bug I accidentally introduced, then > copy the gist of Roman's gnulib changes to also apply to our > cfg.mk syntax checks. > > Eric Blake (3): > maint: update gnulib for syntax-check on BSD > maint: prefer

[libvirt] [PATCH v2 0/3] Better syntax-check on BSD

2019-01-03 Thread Eric Blake
Since v1: fix the gnulib bug I accidentally introduced, then copy the gist of Roman's gnulib changes to also apply to our cfg.mk syntax checks. Eric Blake (3): maint: update gnulib for syntax-check on BSD maint: prefer $(GREP) in cfg.mk maint: split long lines for BSD syntax-check .gnulib