Re: [libvirt] [PATCH v2 2/2] bridge driver: don't masquerade local subnet broadcast/multicast packets

2013-09-24 Thread Laszlo Ersek
On 09/24/13 18:10, Brian J. Murrell wrote: > On 13-09-23 02:27 PM, Laszlo Ersek wrote: >> >> If you disagree with this approach (that is: if you think that >> "224.0.0.0/24" here is not gradual improvement but a step in the wrong >> direction), > > Of course I'm not saying that. I think that's pr

Re: [libvirt] [PATCH v2 2/2] bridge driver: don't masquerade local subnet broadcast/multicast packets

2013-09-24 Thread Brian J. Murrell
On 13-09-23 02:27 PM, Laszlo Ersek wrote: If you disagree with this approach (that is: if you think that "224.0.0.0/24" here is not gradual improvement but a step in the wrong direction), Of course I'm not saying that. I think that's pretty clear. The only point we disagree on is the size o

Re: [libvirt] [PATCH v2 2/2] bridge driver: don't masquerade local subnet broadcast/multicast packets

2013-09-24 Thread Laine Stump
On 09/23/2013 08:01 PM, Laszlo Ersek wrote: > On 09/23/13 16:46, Laine Stump wrote: > >> 2) Along with 255.255.255.255/32, I think this patch can/should also add >> a "networkDirectedLocalBroadcast" (which will obviously need to be a >> local variable and recomputed each time). This can be computed

Re: [libvirt] [PATCH v2 2/2] bridge driver: don't masquerade local subnet broadcast/multicast packets

2013-09-23 Thread Laszlo Ersek
On 09/23/13 16:46, Laine Stump wrote: > 2) Along with 255.255.255.255/32, I think this patch can/should also add > a "networkDirectedLocalBroadcast" (which will obviously need to be a > local variable and recomputed each time). This can be computed by ORing > the ip address of the network with ~ne

Re: [libvirt] [PATCH v2 2/2] bridge driver: don't masquerade local subnet broadcast/multicast packets

2013-09-23 Thread Laszlo Ersek
On 09/23/13 16:40, Brian J. Murrell wrote: > On 13-09-23 10:05 AM, Laszlo Ersek wrote: >> Packets sent by guests on virbrN, *or* by dnsmasq on the same, to >> - 255.255.255.255/32 (netmask-independent local network broadcast >>address), or to >> - 224.0.0.0/24 (local subnetwork multicast range)

Re: [libvirt] [PATCH v2 2/2] bridge driver: don't masquerade local subnet broadcast/multicast packets

2013-09-23 Thread Laine Stump
On 09/23/2013 10:05 AM, Laszlo Ersek wrote: > Packets sent by guests on virbrN, *or* by dnsmasq on the same, to > - 255.255.255.255/32 (netmask-independent local network broadcast > address), or to > - 224.0.0.0/24 (local subnetwork multicast range) > are never forwarded, hence it is not necessar

Re: [libvirt] [PATCH v2 2/2] bridge driver: don't masquerade local subnet broadcast/multicast packets

2013-09-23 Thread Brian J. Murrell
On 13-09-23 10:05 AM, Laszlo Ersek wrote: Packets sent by guests on virbrN, *or* by dnsmasq on the same, to - 255.255.255.255/32 (netmask-independent local network broadcast address), or to - 224.0.0.0/24 (local subnetwork multicast range) All multicast, not just the local subnet multicast n

[libvirt] [PATCH v2 2/2] bridge driver: don't masquerade local subnet broadcast/multicast packets

2013-09-23 Thread Laszlo Ersek
Packets sent by guests on virbrN, *or* by dnsmasq on the same, to - 255.255.255.255/32 (netmask-independent local network broadcast address), or to - 224.0.0.0/24 (local subnetwork multicast range) are never forwarded, hence it is not necessary to masquerade them. In fact we must not masquerade