Re: [libvirt] [PATCH v3 6/8] qemu: use virDomainPCIAddressIsMulti() to determine multifunction setting

2017-01-06 Thread Daniel P. Berrange
On Mon, Dec 19, 2016 at 10:23:16AM -0500, Laine Stump wrote: > If the multifunction attribute isn't set in the config for the device > at function 0 of a slot used for multifunction, it would previously > have been an error. This patch will instead automatically correct the > omission (but only if

Re: [libvirt] [PATCH v3 6/8] qemu: use virDomainPCIAddressIsMulti() to determine multifunction setting

2017-01-06 Thread Laine Stump
On 12/20/2016 10:19 AM, Andrea Bolognani wrote: On Mon, 2016-12-19 at 10:23 -0500, Laine Stump wrote: If the multifunction attribute isn't set in the config for the device at function 0 of a slot used for multifunction, it would previously have been an error. This patch will instead

Re: [libvirt] [PATCH v3 6/8] qemu: use virDomainPCIAddressIsMulti() to determine multifunction setting

2016-12-20 Thread Daniel P. Berrange
On Tue, Dec 20, 2016 at 04:19:35PM +0100, Andrea Bolognani wrote: > On Mon, 2016-12-19 at 10:23 -0500, Laine Stump wrote: > > If the multifunction attribute isn't set in the config for the device > > at function 0 of a slot used for multifunction, it would previously > > have been an error. This

Re: [libvirt] [PATCH v3 6/8] qemu: use virDomainPCIAddressIsMulti() to determine multifunction setting

2016-12-20 Thread Andrea Bolognani
On Mon, 2016-12-19 at 10:23 -0500, Laine Stump wrote: > If the multifunction attribute isn't set in the config for the device > at function 0 of a slot used for multifunction, it would previously > have been an error. This patch will instead automatically correct the > omission (but only if it

[libvirt] [PATCH v3 6/8] qemu: use virDomainPCIAddressIsMulti() to determine multifunction setting

2016-12-19 Thread Laine Stump
If the multifunction attribute isn't set in the config for the device at function 0 of a slot used for multifunction, it would previously have been an error. This patch will instead automatically correct the omission (but only if it hasn't been set at all - if someone explicitly has