Re: [libvirt] [PATCH v3 8/8] conf: aggregate multiple pcie-root-ports onto a single slot

2017-01-11 Thread Laine Stump
On 01/11/2017 04:13 AM, Andrea Bolognani wrote: On Tue, 2017-01-10 at 15:51 -0500, Laine Stump wrote: ARGH! ARGH to you too :) (Talk like a Pirate Day isn't until Sept 19.) In my final rebase before pushing, I pulled in Andrea's patches that switch aarch64/virt to using PCI by default,

Re: [libvirt] [PATCH v3 8/8] conf: aggregate multiple pcie-root-ports onto a single slot

2017-01-11 Thread Laine Stump
On 01/11/2017 03:56 AM, Andrew Jones wrote: On Tue, Jan 10, 2017 at 03:51:21PM -0500, Laine Stump wrote: On 12/19/2016 10:23 AM, Laine Stump wrote: Set the VIR_PCI_CONNECT_AGGREGATE_SLOT flag for pcie-root-ports so that they will be assigned to all the functions on a slot. Some qemu test case

Re: [libvirt] [PATCH v3 8/8] conf: aggregate multiple pcie-root-ports onto a single slot

2017-01-11 Thread Andrea Bolognani
On Tue, 2017-01-10 at 15:51 -0500, Laine Stump wrote: > ARGH! ARGH to you too :) > In my final rebase before pushing, I pulled in Andrea's patches that  > switch aarch64/virt to using PCI by default, and the test case for that  > resulted in a make check failure: >  > 564) QEMU XML-2-ARGV

Re: [libvirt] [PATCH v3 8/8] conf: aggregate multiple pcie-root-ports onto a single slot

2017-01-11 Thread Andrew Jones
On Tue, Jan 10, 2017 at 03:51:21PM -0500, Laine Stump wrote: > On 12/19/2016 10:23 AM, Laine Stump wrote: > > Set the VIR_PCI_CONNECT_AGGREGATE_SLOT flag for pcie-root-ports so > > that they will be assigned to all the functions on a slot. > > > > Some qemu test case outputs had to be adjusted

Re: [libvirt] [PATCH v3 8/8] conf: aggregate multiple pcie-root-ports onto a single slot

2017-01-10 Thread Laine Stump
On 12/19/2016 10:23 AM, Laine Stump wrote: Set the VIR_PCI_CONNECT_AGGREGATE_SLOT flag for pcie-root-ports so that they will be assigned to all the functions on a slot. Some qemu test case outputs had to be adjusted due to the pcie-root-ports now being put on multiple functions. --- ARGH! In

Re: [libvirt] [PATCH v3 8/8] conf: aggregate multiple pcie-root-ports onto a single slot

2017-01-06 Thread Andrea Bolognani
On Fri, 2017-01-06 at 09:53 -0500, Laine Stump wrote: > > I noticed most of the pcie-root-ports get a new value for the > > port attribute after the change, while the chassis attribute > > remains always the same AFAICT. >  > That's because the chassis attribute is just set to the index of the  >

Re: [libvirt] [PATCH v3 8/8] conf: aggregate multiple pcie-root-ports onto a single slot

2017-01-06 Thread Laine Stump
On 12/20/2016 12:50 PM, Andrea Bolognani wrote: On Mon, 2016-12-19 at 10:23 -0500, Laine Stump wrote: Set the VIR_PCI_CONNECT_AGGREGATE_SLOT flag for pcie-root-ports so that they will be assigned to all the functions on a slot. Some qemu test case outputs had to be adjusted due to the

Re: [libvirt] [PATCH v3 8/8] conf: aggregate multiple pcie-root-ports onto a single slot

2016-12-20 Thread Andrea Bolognani
On Mon, 2016-12-19 at 10:23 -0500, Laine Stump wrote: > Set the VIR_PCI_CONNECT_AGGREGATE_SLOT flag for pcie-root-ports so > that they will be assigned to all the functions on a slot. >  > Some qemu test case outputs had to be adjusted due to the > pcie-root-ports now being put on multiple

[libvirt] [PATCH v3 8/8] conf: aggregate multiple pcie-root-ports onto a single slot

2016-12-19 Thread Laine Stump
Set the VIR_PCI_CONNECT_AGGREGATE_SLOT flag for pcie-root-ports so that they will be assigned to all the functions on a slot. Some qemu test case outputs had to be adjusted due to the pcie-root-ports now being put on multiple functions. --- src/conf/domain_addr.c | 2