Re: [libvirt] [PATCHv3 2/3] S390: Fix virSysinfoRead memory corruption

2012-12-18 Thread Daniel P. Berrange
On Tue, Dec 18, 2012 at 01:40:45PM -0700, Eric Blake wrote: > On 12/14/2012 08:08 AM, Viktor Mihajlovski wrote: > > There was a double free issue caused by virSysinfoRead on s390, > > as the same manufacturer string instance was assigned to more > > than one processor record. > > Cleaned up other p

Re: [libvirt] [PATCHv3 2/3] S390: Fix virSysinfoRead memory corruption

2012-12-18 Thread Eric Blake
On 12/14/2012 08:08 AM, Viktor Mihajlovski wrote: > There was a double free issue caused by virSysinfoRead on s390, > as the same manufacturer string instance was assigned to more > than one processor record. > Cleaned up other potential memory issues and restructured the sysinfo > parsing code by

Re: [libvirt] [PATCHv3 2/3] S390: Fix virSysinfoRead memory corruption

2012-12-17 Thread Daniel P. Berrange
On Fri, Dec 14, 2012 at 04:08:24PM +0100, Viktor Mihajlovski wrote: > There was a double free issue caused by virSysinfoRead on s390, > as the same manufacturer string instance was assigned to more > than one processor record. > Cleaned up other potential memory issues and restructured the sysinfo

[libvirt] [PATCHv3 2/3] S390: Fix virSysinfoRead memory corruption

2012-12-14 Thread Viktor Mihajlovski
There was a double free issue caused by virSysinfoRead on s390, as the same manufacturer string instance was assigned to more than one processor record. Cleaned up other potential memory issues and restructured the sysinfo parsing code by moving repeating patterns into a helper function. The restr