Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-16 Thread Kashyap Chamarthy
On Fri, Jul 13, 2018 at 01:35:02PM +0200, Cornelia Huck wrote: > On Thu, 12 Jul 2018 17:47:00 +0200 > Thomas Huth wrote: > > On 12.07.2018 08:32, Markus Armbruster wrote: > > > Daniel P. Berrangé writes: [...] > > > Our tool to help with getting cc: wrong less often is the MAINTAINERS > > >

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-16 Thread Daniel P . Berrangé
On Thu, Jul 12, 2018 at 05:47:00PM +0200, Thomas Huth wrote: > On 12.07.2018 08:32, Markus Armbruster wrote: > > Daniel P. Berrangé writes: > [...] > >> For libvirt, I think whenever something is proposed for deprecation > >> we could just CC libvir-list, or ask one of the libvirt people to > >>

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-13 Thread Cornelia Huck
On Thu, 12 Jul 2018 17:47:00 +0200 Thomas Huth wrote: > On 12.07.2018 08:32, Markus Armbruster wrote: > > Daniel P. Berrangé writes: > [...] > >> For libvirt, I think whenever something is proposed for deprecation > >> we could just CC libvir-list, or ask one of the libvirt people to > >>

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-12 Thread Thomas Huth
On 12.07.2018 08:32, Markus Armbruster wrote: > Daniel P. Berrangé writes: [...] >> For libvirt, I think whenever something is proposed for deprecation >> we could just CC libvir-list, or ask one of the libvirt people to >> confirm its not being used. If it is, then we should file BZ against >>

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-12 Thread Markus Armbruster
Peter Krempa writes: > On Thu, Jul 12, 2018 at 08:59:44 +0200, Markus Armbruster wrote: >> Peter Krempa writes: >> > On Tue, Jul 10, 2018 at 17:01:22 +0200, Cornelia Huck wrote: >> >> On Tue, 10 Jul 2018 16:39:31 +0200 >> >> Peter Krempa wrote: > > [...] > >> > An option is to do a automatic

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-12 Thread Markus Armbruster
Peter Krempa writes: > On Thu, Jul 12, 2018 at 08:38:25 +0200, Markus Armbruster wrote: >> Kevin Wolf writes: >> > Am 10.07.2018 um 16:22 hat Cornelia Huck geschrieben: >> >> On Tue, 10 Jul 2018 07:59:15 +0200 >> >> Markus Armbruster wrote: >> >> Would that be workable? >> > >> > I think the

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-12 Thread Markus Armbruster
Cornelia Huck writes: > On Thu, 12 Jul 2018 08:51:16 +0200 > Markus Armbruster wrote: > >> Markus Armbruster writes: >> >> > Kevin Wolf writes: >> > >> >> I think the function should just take a message: >> >> >> >> /* Works like error_report(), except for the WARNING/ERROR prefix >>

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-12 Thread Kevin Wolf
Am 12.07.2018 um 09:48 hat Cornelia Huck geschrieben: > On Thu, 12 Jul 2018 08:51:16 +0200 > Markus Armbruster wrote: > > > Markus Armbruster writes: > > > > > Kevin Wolf writes: > > > > > >> Am 10.07.2018 um 16:22 hat Cornelia Huck geschrieben: > > >>> On Tue, 10 Jul 2018 07:59:15 +0200

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-12 Thread Cornelia Huck
On Thu, 12 Jul 2018 08:51:16 +0200 Markus Armbruster wrote: > Markus Armbruster writes: > > > Kevin Wolf writes: > > > >> Am 10.07.2018 um 16:22 hat Cornelia Huck geschrieben: > >>> On Tue, 10 Jul 2018 07:59:15 +0200 > >>> Markus Armbruster wrote: > >>> > >>> > In addition to actively

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-12 Thread Peter Krempa
On Thu, Jul 12, 2018 at 08:59:44 +0200, Markus Armbruster wrote: > Peter Krempa writes: > > On Tue, Jul 10, 2018 at 17:01:22 +0200, Cornelia Huck wrote: > >> On Tue, 10 Jul 2018 16:39:31 +0200 > >> Peter Krempa wrote: [...] > > An option is to do a automatic testing where one of this

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-12 Thread Peter Krempa
On Thu, Jul 12, 2018 at 08:38:25 +0200, Markus Armbruster wrote: > Kevin Wolf writes: > > Am 10.07.2018 um 16:22 hat Cornelia Huck geschrieben: > >> On Tue, 10 Jul 2018 07:59:15 +0200 > >> Markus Armbruster wrote: > >> Would that be workable? > > > > I think the function should just take a

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-12 Thread Markus Armbruster
Peter Krempa writes: > On Tue, Jul 10, 2018 at 17:01:22 +0200, Cornelia Huck wrote: >> On Tue, 10 Jul 2018 16:39:31 +0200 >> Peter Krempa wrote: >> > On Tue, Jul 10, 2018 at 16:22:08 +0200, Cornelia Huck wrote: >> > > On Tue, 10 Jul 2018 07:59:15 +0200 >> > > Markus Armbruster wrote: > > [...]

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-12 Thread Markus Armbruster
Markus Armbruster writes: > Kevin Wolf writes: > >> Am 10.07.2018 um 16:22 hat Cornelia Huck geschrieben: >>> On Tue, 10 Jul 2018 07:59:15 +0200 >>> Markus Armbruster wrote: >>> >>> > In addition to actively pulling libvirt developers into review of >>> > deprecation patches, we should pursue

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-12 Thread Markus Armbruster
Thomas Huth writes: > On 10.07.2018 17:24, Peter Krempa wrote: >> On Tue, Jul 10, 2018 at 17:01:22 +0200, Cornelia Huck wrote: >>> On Tue, 10 Jul 2018 16:39:31 +0200 >>> Peter Krempa wrote: On Tue, Jul 10, 2018 at 16:22:08 +0200, Cornelia Huck wrote: > On Tue, 10 Jul 2018 07:59:15

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-12 Thread Markus Armbruster
Kevin Wolf writes: > Am 10.07.2018 um 16:22 hat Cornelia Huck geschrieben: >> On Tue, 10 Jul 2018 07:59:15 +0200 >> Markus Armbruster wrote: >> >> > In addition to actively pulling libvirt developers into review of >> > deprecation patches, we should pursue the idea to optionally let QEMU >> >

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-12 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Mon, Jul 09, 2018 at 01:08:38PM +0200, Cornelia Huck wrote: >> On Mon, 09 Jul 2018 08:33:05 +0200 >> Markus Armbruster wrote: >> >> > Peter Maydell writes: >> > >> > > On 6 July 2018 at 15:56, Kevin Wolf wrote: >> > >> Am 06.07.2018 um 13:11 hat Cornelia

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-11 Thread Kashyap Chamarthy
On Tue, Jul 10, 2018 at 05:01:22PM +0200, Cornelia Huck wrote: [...] > Who is, in general, testing which libvirt version? I can think of: > - libvirt developers, which will probably run libvirt current git, but > more likely a released QEMU? > - QEMU (and other related tools) developers, who

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-11 Thread Cornelia Huck
On Wed, 11 Jul 2018 08:53:20 +0200 Thomas Huth wrote: > On 10.07.2018 17:24, Peter Krempa wrote: > > On Tue, Jul 10, 2018 at 17:01:22 +0200, Cornelia Huck wrote: > >> So, from that I gather that a hard failure would be the easiest for > >> libvirt to detect (and everything else would become

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-11 Thread Thomas Huth
On 10.07.2018 17:24, Peter Krempa wrote: > On Tue, Jul 10, 2018 at 17:01:22 +0200, Cornelia Huck wrote: >> On Tue, 10 Jul 2018 16:39:31 +0200 >> Peter Krempa wrote: >>> On Tue, Jul 10, 2018 at 16:22:08 +0200, Cornelia Huck wrote: On Tue, 10 Jul 2018 07:59:15 +0200 Markus Armbruster

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-10 Thread Daniel P . Berrangé
On Tue, Jul 10, 2018 at 05:01:22PM +0200, Cornelia Huck wrote: > Who is, in general, testing which libvirt version? I can think of: > - libvirt developers, which will probably run libvirt current git, but > more likely a released QEMU? In general libvirt devs tend to run a mixture of whatever

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-10 Thread Daniel P . Berrangé
On Tue, Jul 10, 2018 at 04:09:38PM +0100, Peter Maydell wrote: > On 10 July 2018 at 15:22, Cornelia Huck wrote: > > On Tue, 10 Jul 2018 07:59:15 +0200 > > Markus Armbruster wrote: > > > >> In addition to actively pulling libvirt developers into review of > >> deprecation patches, we should

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-10 Thread Peter Krempa
On Tue, Jul 10, 2018 at 17:01:22 +0200, Cornelia Huck wrote: > On Tue, 10 Jul 2018 16:39:31 +0200 > Peter Krempa wrote: > > On Tue, Jul 10, 2018 at 16:22:08 +0200, Cornelia Huck wrote: > > > On Tue, 10 Jul 2018 07:59:15 +0200 > > > Markus Armbruster wrote: [...] > > > "ERROR: 'old_option' is

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-10 Thread Peter Maydell
On 10 July 2018 at 15:22, Cornelia Huck wrote: > On Tue, 10 Jul 2018 07:59:15 +0200 > Markus Armbruster wrote: > >> In addition to actively pulling libvirt developers into review of >> deprecation patches, we should pursue the idea to optionally let QEMU >> fail on use of deprecated features,

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-10 Thread Cornelia Huck
On Tue, 10 Jul 2018 16:39:31 +0200 Peter Krempa wrote: > On Tue, Jul 10, 2018 at 16:22:08 +0200, Cornelia Huck wrote: > > On Tue, 10 Jul 2018 07:59:15 +0200 > > Markus Armbruster wrote: > > > > > In addition to actively pulling libvirt developers into review of > > > deprecation patches, we

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-10 Thread Peter Krempa
On Tue, Jul 10, 2018 at 16:22:08 +0200, Cornelia Huck wrote: > On Tue, 10 Jul 2018 07:59:15 +0200 > Markus Armbruster wrote: > > > In addition to actively pulling libvirt developers into review of > > deprecation patches, we should pursue the idea to optionally let QEMU > > fail on use of

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-10 Thread Kevin Wolf
Am 10.07.2018 um 16:22 hat Cornelia Huck geschrieben: > On Tue, 10 Jul 2018 07:59:15 +0200 > Markus Armbruster wrote: > > > In addition to actively pulling libvirt developers into review of > > deprecation patches, we should pursue the idea to optionally let QEMU > > fail on use of deprecated

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-10 Thread Cornelia Huck
On Tue, 10 Jul 2018 07:59:15 +0200 Markus Armbruster wrote: > In addition to actively pulling libvirt developers into review of > deprecation patches, we should pursue the idea to optionally let QEMU > fail on use of deprecated features, then have libvirt run its test suite > that way. What

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-09 Thread Markus Armbruster
Peter Krempa writes: > On Fri, Jul 06, 2018 at 16:56:46 +0200, Kevin Wolf wrote: >> Am 06.07.2018 um 13:11 hat Cornelia Huck geschrieben: >> > On Wed, 4 Jul 2018 17:14:02 +0100 >> > Peter Maydell wrote: >> > >> > > On 4 July 2018 at 14:34, Kevin Wolf wrote: >> > > > Essentially, what is

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-09 Thread Cornelia Huck
On Mon, 9 Jul 2018 08:58:05 +0200 Thomas Huth wrote: > On 06.07.2018 13:11, Cornelia Huck wrote: > > On Wed, 4 Jul 2018 17:14:02 +0100 > > Peter Maydell wrote: > > > >> On 4 July 2018 at 14:34, Kevin Wolf wrote: > >>> Essentially, what is important to me isn't getting these options

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-09 Thread Daniel P . Berrangé
On Mon, Jul 09, 2018 at 01:08:38PM +0200, Cornelia Huck wrote: > On Mon, 09 Jul 2018 08:33:05 +0200 > Markus Armbruster wrote: > > > Peter Maydell writes: > > > > > On 6 July 2018 at 15:56, Kevin Wolf wrote: > > >> Am 06.07.2018 um 13:11 hat Cornelia Huck geschrieben: > > >>> That way, we

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-09 Thread Cornelia Huck
On Mon, 09 Jul 2018 08:33:05 +0200 Markus Armbruster wrote: > Peter Maydell writes: > > > On 6 July 2018 at 15:56, Kevin Wolf wrote: > >> Am 06.07.2018 um 13:11 hat Cornelia Huck geschrieben: > >>> That way, we can still easily remove old cruft (case (a)), but still > >>> accommodate

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-09 Thread Peter Krempa
On Fri, Jul 06, 2018 at 16:56:46 +0200, Kevin Wolf wrote: > Am 06.07.2018 um 13:11 hat Cornelia Huck geschrieben: > > On Wed, 4 Jul 2018 17:14:02 +0100 > > Peter Maydell wrote: > > > > > On 4 July 2018 at 14:34, Kevin Wolf wrote: > > > > Essentially, what is important to me isn't getting these

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-09 Thread Thomas Huth
On 06.07.2018 13:11, Cornelia Huck wrote: > On Wed, 4 Jul 2018 17:14:02 +0100 > Peter Maydell wrote: > >> On 4 July 2018 at 14:34, Kevin Wolf wrote: >>> Essentially, what is important to me isn't getting these options dropped >>> exactly in 3.0, but not setting a bad precedence that deprecation

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-09 Thread Markus Armbruster
Peter Maydell writes: > On 6 July 2018 at 15:56, Kevin Wolf wrote: >> Am 06.07.2018 um 13:11 hat Cornelia Huck geschrieben: >>> That way, we can still easily remove old cruft (case (a)), but still >>> accommodate cases like this (case (c)). The obvious drawback is that >>> we'd need someone to

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-06 Thread Peter Maydell
On 6 July 2018 at 15:56, Kevin Wolf wrote: > Am 06.07.2018 um 13:11 hat Cornelia Huck geschrieben: >> That way, we can still easily remove old cruft (case (a)), but still >> accommodate cases like this (case (c)). The obvious drawback is that >> we'd need someone to curate the deprecation

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-06 Thread Daniel P . Berrangé
On Fri, Jul 06, 2018 at 04:56:46PM +0200, Kevin Wolf wrote: > Am 06.07.2018 um 13:11 hat Cornelia Huck geschrieben: > > On Wed, 4 Jul 2018 17:14:02 +0100 > > Peter Maydell wrote: > > > > > On 4 July 2018 at 14:34, Kevin Wolf wrote: > > > > Essentially, what is important to me isn't getting

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-06 Thread Kevin Wolf
Am 06.07.2018 um 13:11 hat Cornelia Huck geschrieben: > On Wed, 4 Jul 2018 17:14:02 +0100 > Peter Maydell wrote: > > > On 4 July 2018 at 14:34, Kevin Wolf wrote: > > > Essentially, what is important to me isn't getting these options dropped > > > exactly in 3.0, but not setting a bad precedence

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-06 Thread Cornelia Huck
On Wed, 4 Jul 2018 17:14:02 +0100 Peter Maydell wrote: > On 4 July 2018 at 14:34, Kevin Wolf wrote: > > Essentially, what is important to me isn't getting these options dropped > > exactly in 3.0, but not setting a bad precedence that deprecation isn't > > actually worth anything. We may easily

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-04 Thread Peter Maydell
On 4 July 2018 at 14:34, Kevin Wolf wrote: > Essentially, what is important to me isn't getting these options dropped > exactly in 3.0, but not setting a bad precedence that deprecation isn't > actually worth anything. We may easily end up with this deprecation > process: > > depreate a feature >

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-04 Thread Kevin Wolf
Am 04.07.2018 um 15:43 hat Daniel P. Berrangé geschrieben: > On Wed, Jul 04, 2018 at 03:34:40PM +0200, Kevin Wolf wrote: > > I understand where you're coming from, but let's be honest: It's not as > > if disk geometry or serial numbers were features that absolutely need > > to be there to give

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-04 Thread Cornelia Huck
On Wed, 4 Jul 2018 15:34:40 +0200 Kevin Wolf wrote: > Am 04.07.2018 um 15:02 hat Cornelia Huck geschrieben: > > On Tue, 3 Jul 2018 13:32:29 +0200 > > Kevin Wolf wrote: > > > > > > > > Has serial/gemoetry been fixed meanwhile and will it make it into > > > > > > the > > > > > > next release?

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-04 Thread Christian Borntraeger
On 07/04/2018 03:34 PM, Kevin Wolf wrote: > Am 04.07.2018 um 15:02 hat Cornelia Huck geschrieben: >> On Tue, 3 Jul 2018 13:32:29 +0200 >> Kevin Wolf wrote: >> >> Has serial/gemoetry been fixed meanwhile and will it make it into the >> next release? > > I cannot find an

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-04 Thread Daniel P . Berrangé
On Wed, Jul 04, 2018 at 03:34:40PM +0200, Kevin Wolf wrote: > Am 04.07.2018 um 15:02 hat Cornelia Huck geschrieben: > > On Tue, 3 Jul 2018 13:32:29 +0200 > > Kevin Wolf wrote: > > > > > > > > Has serial/gemoetry been fixed meanwhile and will it make it into > > > > > > the > > > > > > next

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-04 Thread Kevin Wolf
Am 04.07.2018 um 15:02 hat Cornelia Huck geschrieben: > On Tue, 3 Jul 2018 13:32:29 +0200 > Kevin Wolf wrote: > > > > > > Has serial/gemoetry been fixed meanwhile and will it make it into the > > > > > next release? > > > > > > > > I cannot find an archive that has it, but it is on the

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-04 Thread Cornelia Huck
On Tue, 3 Jul 2018 13:32:29 +0200 Kevin Wolf wrote: > > > > Has serial/gemoetry been fixed meanwhile and will it make it into the > > > > next release? > > > > > > I cannot find an archive that has it, but it is on the libvirt mailing > > > list as "[libvirt] [PATCH v3] qemu: format serial

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-03 Thread Christian Borntraeger
On 07/03/2018 01:35 PM, Peter Maydell wrote: > On 3 July 2018 at 12:32, Kevin Wolf wrote: >> Am 03.07.2018 um 13:22 hat Daniel P. Berrangé geschrieben: >>> Just posted latest version here: >>> >>> https://www.redhat.com/archives/libvir-list/2018-July/msg00130.html >>> >>> It will be in the

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-03 Thread Daniel P . Berrangé
On Tue, Jul 03, 2018 at 01:32:29PM +0200, Kevin Wolf wrote: > Am 03.07.2018 um 13:22 hat Daniel P. Berrangé geschrieben: > > On Tue, Jul 03, 2018 at 12:53:44PM +0200, Christian Borntraeger wrote: > > > > > > > > > On 07/02/2018 10:04 AM, Kevin Wolf wrote: > > > > Am 25.06.2018 um 13:45 hat Peter

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-03 Thread Peter Maydell
On 3 July 2018 at 12:32, Kevin Wolf wrote: > Am 03.07.2018 um 13:22 hat Daniel P. Berrangé geschrieben: >> Just posted latest version here: >> >> https://www.redhat.com/archives/libvir-list/2018-July/msg00130.html >> >> It will be in the next release on ~ Aug 1st > > It would have been a lot

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-03 Thread Kevin Wolf
Am 03.07.2018 um 13:22 hat Daniel P. Berrangé geschrieben: > On Tue, Jul 03, 2018 at 12:53:44PM +0200, Christian Borntraeger wrote: > > > > > > On 07/02/2018 10:04 AM, Kevin Wolf wrote: > > > Am 25.06.2018 um 13:45 hat Peter Krempa geschrieben: > > >> On Mon, Jun 25, 2018 at 13:41:06 +0200,

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-03 Thread Daniel P . Berrangé
On Tue, Jul 03, 2018 at 12:53:44PM +0200, Christian Borntraeger wrote: > > > On 07/02/2018 10:04 AM, Kevin Wolf wrote: > > Am 25.06.2018 um 13:45 hat Peter Krempa geschrieben: > >> On Mon, Jun 25, 2018 at 13:41:06 +0200, Kevin Wolf wrote: > >>> Am 25.06.2018 um 11:53 hat Daniel P. Berrangé

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-03 Thread Christian Borntraeger
On 07/02/2018 10:04 AM, Kevin Wolf wrote: > Am 25.06.2018 um 13:45 hat Peter Krempa geschrieben: >> On Mon, Jun 25, 2018 at 13:41:06 +0200, Kevin Wolf wrote: >>> Am 25.06.2018 um 11:53 hat Daniel P. Berrangé geschrieben: On Fri, Jun 22, 2018 at 03:31:46PM +0100, Daniel P. Berrangé wrote:

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-02 Thread Kevin Wolf
Am 25.06.2018 um 13:45 hat Peter Krempa geschrieben: > On Mon, Jun 25, 2018 at 13:41:06 +0200, Kevin Wolf wrote: > > Am 25.06.2018 um 11:53 hat Daniel P. Berrangé geschrieben: > > > On Fri, Jun 22, 2018 at 03:31:46PM +0100, Daniel P. Berrangé wrote: > > > > On Fri, Jun 22, 2018 at 04:25:13PM

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-25 Thread Peter Krempa
On Mon, Jun 25, 2018 at 13:41:06 +0200, Kevin Wolf wrote: > Am 25.06.2018 um 11:53 hat Daniel P. Berrangé geschrieben: > > On Fri, Jun 22, 2018 at 03:31:46PM +0100, Daniel P. Berrangé wrote: > > > On Fri, Jun 22, 2018 at 04:25:13PM +0200, Kevin Wolf wrote: > > > > Am 22.06.2018 um 15:36 hat

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-25 Thread Kevin Wolf
Am 25.06.2018 um 11:53 hat Daniel P. Berrangé geschrieben: > On Fri, Jun 22, 2018 at 03:31:46PM +0100, Daniel P. Berrangé wrote: > > On Fri, Jun 22, 2018 at 04:25:13PM +0200, Kevin Wolf wrote: > > > Am 22.06.2018 um 15:36 hat Christian Borntraeger geschrieben: > > > > > > > > > > > > On

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-25 Thread Daniel P . Berrangé
On Fri, Jun 22, 2018 at 07:54:00PM +0200, Kevin Wolf wrote: > Am 22.06.2018 um 17:40 hat Daniel P. Berrangé geschrieben: > > On Fri, Jun 22, 2018 at 04:25:13PM +0200, Kevin Wolf wrote: > > > This was in fact one release longer than our deprecation policy says. > > > Are we serious about the

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-25 Thread Peter Maydell
On 25 June 2018 at 11:31, Peter Krempa wrote: > On Mon, Jun 25, 2018 at 11:01:46 +0100, Peter Maydell wrote: >> On 22 June 2018 at 16:40, Daniel P. Berrangé wrote: >> > - SD card - requires -drive with if=sd, no -device support AFAICT >> >> Hmm? You can use -device if you want: >> -drive

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-25 Thread Peter Krempa
On Mon, Jun 25, 2018 at 11:01:46 +0100, Peter Maydell wrote: > On 22 June 2018 at 16:40, Daniel P. Berrangé wrote: > > - SD card - requires -drive with if=sd, no -device support AFAICT > > Hmm? You can use -device if you want: > -drive if=none,id=mydrive,... -device sd-card,...,drive=mydrive

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-25 Thread Peter Maydell
On 22 June 2018 at 16:40, Daniel P. Berrangé wrote: > - SD card - requires -drive with if=sd, no -device support AFAICT Hmm? You can use -device if you want: -drive if=none,id=mydrive,... -device sd-card,...,drive=mydrive (the sd-card device then plugs into the sd controller device via the

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-25 Thread Daniel P . Berrangé
On Fri, Jun 22, 2018 at 03:31:46PM +0100, Daniel P. Berrangé wrote: > On Fri, Jun 22, 2018 at 04:25:13PM +0200, Kevin Wolf wrote: > > Am 22.06.2018 um 15:36 hat Christian Borntraeger geschrieben: > > > > > > > > > On 06/22/2018 02:55 PM, Kevin Wolf wrote: > > > > Am 22.06.2018 um 13:38 hat

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-25 Thread Daniel P . Berrangé
On Mon, Jun 25, 2018 at 10:23:03AM +0200, Thomas Huth wrote: > On 25.06.2018 09:16, Peter Krempa wrote: > > On Fri, Jun 22, 2018 at 14:55:02 +0200, Kevin Wolf wrote: > >> Am 22.06.2018 um 13:38 hat Christian Borntraeger geschrieben: > >>> > >>> On 06/15/2018 04:21 PM, Kevin Wolf wrote: > The

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-25 Thread Thomas Huth
On 25.06.2018 09:16, Peter Krempa wrote: > On Fri, Jun 22, 2018 at 14:55:02 +0200, Kevin Wolf wrote: >> Am 22.06.2018 um 13:38 hat Christian Borntraeger geschrieben: >>> >>> On 06/15/2018 04:21 PM, Kevin Wolf wrote: The -drive option serial was deprecated in QEMU 2.10. It's time to

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-25 Thread Thomas Huth
On 22.06.2018 16:25, Kevin Wolf wrote: > Am 22.06.2018 um 15:36 hat Christian Borntraeger geschrieben: >> >> >> On 06/22/2018 02:55 PM, Kevin Wolf wrote: >>> Am 22.06.2018 um 13:38 hat Christian Borntraeger geschrieben: On 06/15/2018 04:21 PM, Kevin Wolf wrote: > The -drive option

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-25 Thread Peter Krempa
On Fri, Jun 22, 2018 at 14:55:02 +0200, Kevin Wolf wrote: > Am 22.06.2018 um 13:38 hat Christian Borntraeger geschrieben: > > > > On 06/15/2018 04:21 PM, Kevin Wolf wrote: > > > The -drive option serial was deprecated in QEMU 2.10. It's time to > > > remove it. > > > > > > Tests need to be

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-22 Thread Kevin Wolf
Am 22.06.2018 um 17:40 hat Daniel P. Berrangé geschrieben: > On Fri, Jun 22, 2018 at 04:25:13PM +0200, Kevin Wolf wrote: > > This was in fact one release longer than our deprecation policy says. > > Are we serious about the deprecation policy or aren't we? > > > > I might consider reverting a

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-22 Thread Christian Borntraeger
On 06/22/2018 05:01 PM, Kevin Wolf wrote: > Am 22.06.2018 um 16:38 hat Christian Borntraeger geschrieben: >> >> >> On 06/22/2018 04:25 PM, Kevin Wolf wrote: >>> Am 22.06.2018 um 15:36 hat Christian Borntraeger geschrieben: On 06/22/2018 02:55 PM, Kevin Wolf wrote: > Am

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-22 Thread Daniel P . Berrangé
On Fri, Jun 22, 2018 at 04:25:13PM +0200, Kevin Wolf wrote: > Am 22.06.2018 um 15:36 hat Christian Borntraeger geschrieben: > > > > > > On 06/22/2018 02:55 PM, Kevin Wolf wrote: > > > Am 22.06.2018 um 13:38 hat Christian Borntraeger geschrieben: > > >> > > >> On 06/15/2018 04:21 PM, Kevin Wolf

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-22 Thread Kevin Wolf
Am 22.06.2018 um 16:38 hat Christian Borntraeger geschrieben: > > > On 06/22/2018 04:25 PM, Kevin Wolf wrote: > > Am 22.06.2018 um 15:36 hat Christian Borntraeger geschrieben: > >> > >> > >> On 06/22/2018 02:55 PM, Kevin Wolf wrote: > >>> Am 22.06.2018 um 13:38 hat Christian Borntraeger

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-22 Thread Eric Blake
On 06/22/2018 09:30 AM, Daniel P. Berrangé wrote: Perhaps we could use a more structured notification, to make detecting use of deprecated features programmatically trivial. A QMP event might do. Libvirt currently has CI that is largely focused on unit testing. We recently did some work,

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-22 Thread Peter Maydell
On 22 June 2018 at 15:38, Christian Borntraeger wrote: > So if everyone has adopted we can certainly follow our deprecation policy. > Now if deprecation breaks some real world cases it makes no sense to > "insist" on that deprecation policy. Really: If latest greatest libvirt > does not work 2

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-22 Thread Christian Borntraeger
On 06/22/2018 04:25 PM, Kevin Wolf wrote: > Am 22.06.2018 um 15:36 hat Christian Borntraeger geschrieben: >> >> >> On 06/22/2018 02:55 PM, Kevin Wolf wrote: >>> Am 22.06.2018 um 13:38 hat Christian Borntraeger geschrieben: On 06/15/2018 04:21 PM, Kevin Wolf wrote: > The -drive

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-22 Thread Daniel P . Berrangé
On Fri, Jun 22, 2018 at 04:25:13PM +0200, Kevin Wolf wrote: > Am 22.06.2018 um 15:36 hat Christian Borntraeger geschrieben: > > > > > > On 06/22/2018 02:55 PM, Kevin Wolf wrote: > > > Am 22.06.2018 um 13:38 hat Christian Borntraeger geschrieben: > > >> > > >> On 06/15/2018 04:21 PM, Kevin Wolf

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-22 Thread Daniel P . Berrangé
On Fri, Jun 22, 2018 at 03:25:19PM +0100, Daniel P. Berrangé wrote: > On Fri, Jun 22, 2018 at 04:19:29PM +0200, Markus Armbruster wrote: > > Kevin Wolf writes: > > > > > Am 22.06.2018 um 13:38 hat Christian Borntraeger geschrieben: > > >> > > >> On 06/15/2018 04:21 PM, Kevin Wolf wrote: > > >>

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-22 Thread Daniel P . Berrangé
On Fri, Jun 22, 2018 at 04:19:29PM +0200, Markus Armbruster wrote: > Kevin Wolf writes: > > > Am 22.06.2018 um 13:38 hat Christian Borntraeger geschrieben: > >> > >> On 06/15/2018 04:21 PM, Kevin Wolf wrote: > >> > The -drive option serial was deprecated in QEMU 2.10. It's time to > >> > remove

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-22 Thread Kevin Wolf
Am 22.06.2018 um 15:36 hat Christian Borntraeger geschrieben: > > > On 06/22/2018 02:55 PM, Kevin Wolf wrote: > > Am 22.06.2018 um 13:38 hat Christian Borntraeger geschrieben: > >> > >> On 06/15/2018 04:21 PM, Kevin Wolf wrote: > >>> The -drive option serial was deprecated in QEMU 2.10. It's

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-22 Thread Markus Armbruster
Kevin Wolf writes: > Am 22.06.2018 um 13:38 hat Christian Borntraeger geschrieben: >> >> On 06/15/2018 04:21 PM, Kevin Wolf wrote: >> > The -drive option serial was deprecated in QEMU 2.10. It's time to >> > remove it. >> > >> > Tests need to be updated to set the serial number with -global

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-22 Thread Daniel P . Berrangé
On Fri, Jun 22, 2018 at 03:36:50PM +0200, Christian Borntraeger wrote: > > > On 06/22/2018 02:55 PM, Kevin Wolf wrote: > > Am 22.06.2018 um 13:38 hat Christian Borntraeger geschrieben: > >> > >> On 06/15/2018 04:21 PM, Kevin Wolf wrote: > >>> The -drive option serial was deprecated in QEMU 2.10.

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-22 Thread Christian Borntraeger
On 06/22/2018 03:36 PM, Christian Borntraeger wrote: > > > On 06/22/2018 02:55 PM, Kevin Wolf wrote: >> Am 22.06.2018 um 13:38 hat Christian Borntraeger geschrieben: >>> >>> On 06/15/2018 04:21 PM, Kevin Wolf wrote: The -drive option serial was deprecated in QEMU 2.10. It's time to

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-22 Thread Christian Borntraeger
On 06/22/2018 02:55 PM, Kevin Wolf wrote: > Am 22.06.2018 um 13:38 hat Christian Borntraeger geschrieben: >> >> On 06/15/2018 04:21 PM, Kevin Wolf wrote: >>> The -drive option serial was deprecated in QEMU 2.10. It's time to >>> remove it. >>> >>> Tests need to be updated to set the serial

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-22 Thread Kevin Wolf
Am 22.06.2018 um 13:38 hat Christian Borntraeger geschrieben: > > On 06/15/2018 04:21 PM, Kevin Wolf wrote: > > The -drive option serial was deprecated in QEMU 2.10. It's time to > > remove it. > > > > Tests need to be updated to set the serial number with -global instead > > of using the -drive

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-22 Thread Christian Borntraeger
On 06/15/2018 04:21 PM, Kevin Wolf wrote: > The -drive option serial was deprecated in QEMU 2.10. It's time to > remove it. > > Tests need to be updated to set the serial number with -global instead > of using the -drive option. libvirt 4.5 still creates those (at least on s390x)