Re: [libvirt] [RFC] Add flag for virsh undefine to remove/wipe the disk devices

2011-03-31 Thread Daniel P. Berrange
On Thu, Mar 31, 2011 at 07:14:12PM +0800, Daniel Veillard wrote: > On Thu, Mar 31, 2011 at 11:30:03AM +0100, Daniel P. Berrange wrote: > > On Wed, Mar 30, 2011 at 09:50:19PM +0800, Daniel Veillard wrote: > > > On Wed, Mar 30, 2011 at 09:39:14PM +0800, Osier Yang wrote: > > > >For these situatio

Re: [libvirt] [RFC] Add flag for virsh undefine to remove/wipe the disk devices

2011-03-31 Thread Daniel Veillard
On Thu, Mar 31, 2011 at 11:30:03AM +0100, Daniel P. Berrange wrote: > On Wed, Mar 30, 2011 at 09:50:19PM +0800, Daniel Veillard wrote: > > On Wed, Mar 30, 2011 at 09:39:14PM +0800, Osier Yang wrote: > > >For these situations, we need to do checking and throw > > >straightforward warnings to

Re: [libvirt] [RFC] Add flag for virsh undefine to remove/wipe the disk devices

2011-03-31 Thread Daniel P. Berrange
On Wed, Mar 30, 2011 at 09:50:19PM +0800, Daniel Veillard wrote: > On Wed, Mar 30, 2011 at 09:39:14PM +0800, Osier Yang wrote: > > Hi, All > > > > I'm thinking to introduce a new flag (something like --remove-disks, > > --wipe-disks) for "virsh undefine", so that the user can choose > > whether to

Re: [libvirt] [RFC] Add flag for virsh undefine to remove/wipe the disk devices

2011-03-31 Thread Jean-Baptiste Rouault
On Thursday 31 March 2011 10:04:36 Osier Yang wrote: > 于 2011年03月30日 23:56, Jean-Baptiste Rouault 写道: > > On Wednesday 30 March 2011 17:23:51 Osier Yang wrote: > >> Yes, actually I also prefer to add new flag to API, but not in > >> virsh instead, however, adding new flag argument is not workable,

Re: [libvirt] [RFC] Add flag for virsh undefine to remove/wipe the disk devices

2011-03-31 Thread Osier Yang
于 2011年03月30日 23:56, Jean-Baptiste Rouault 写道: On Wednesday 30 March 2011 17:23:51 Osier Yang wrote: Yes, actually I also prefer to add new flag to API, but not in virsh instead, however, adding new flag argument is not workable, how about introduce a new API, something like "virDomainUndefineFl

Re: [libvirt] [RFC] Add flag for virsh undefine to remove/wipe the disk devices

2011-03-31 Thread Osier Yang
于 2011年03月31日 01:11, Eric Blake 写道: > On 03/30/2011 07:39 AM, Osier Yang wrote: >> Hi, All >> >> I'm thinking to introduce a new flag (something like --remove-disks, >> --wipe-disks) for "virsh undefine", so that the user can choose >> whether to remove/wipe the disk devices or not, have seen this

Re: [libvirt] [RFC] Add flag for virsh undefine to remove/wipe the disk devices

2011-03-30 Thread Eric Blake
On 03/30/2011 07:39 AM, Osier Yang wrote: > Hi, All > > I'm thinking to introduce a new flag (something like --remove-disks, > --wipe-disks) for "virsh undefine", so that the user can choose > whether to remove/wipe the disk devices or not, have seen this > requirement in many places, @libvirt-use

Re: [libvirt] [RFC] Add flag for virsh undefine to remove/wipe the disk devices

2011-03-30 Thread Jean-Baptiste Rouault
On Wednesday 30 March 2011 17:23:51 Osier Yang wrote: > Yes, actually I also prefer to add new flag to API, but not in > virsh instead, however, adding new flag argument is not workable, > how about introduce a new API, something like "virDomainUndefineFlag"? I wanted to suggest something similar

Re: [libvirt] [RFC] Add flag for virsh undefine to remove/wipe the disk devices

2011-03-30 Thread Osier Yang
于 2011年03月30日 23:23, Osier Yang 写道: 于 2011年03月30日 21:50, Daniel Veillard 写道: On Wed, Mar 30, 2011 at 09:39:14PM +0800, Osier Yang wrote: Hi, All I'm thinking to introduce a new flag (something like --remove-disks, --wipe-disks) for "virsh undefine", so that the user can choose whether to remov

Re: [libvirt] [RFC] Add flag for virsh undefine to remove/wipe the disk devices

2011-03-30 Thread Osier Yang
于 2011年03月30日 21:58, Dave Allan 写道: On Wed, Mar 30, 2011 at 09:39:14PM +0800, Osier Yang wrote: Hi, All I'm thinking to introduce a new flag (something like --remove-disks, --wipe-disks) for "virsh undefine", so that the user can choose whether to remove/wipe the disk devices or not, have seen

Re: [libvirt] [RFC] Add flag for virsh undefine to remove/wipe the disk devices

2011-03-30 Thread Osier Yang
于 2011年03月30日 21:50, Daniel Veillard 写道: On Wed, Mar 30, 2011 at 09:39:14PM +0800, Osier Yang wrote: Hi, All I'm thinking to introduce a new flag (something like --remove-disks, --wipe-disks) for "virsh undefine", so that the user can choose whether to remove/wipe the disk devices or not, have

Re: [libvirt] [RFC] Add flag for virsh undefine to remove/wipe the disk devices

2011-03-30 Thread Dave Allan
On Wed, Mar 30, 2011 at 09:39:14PM +0800, Osier Yang wrote: > Hi, All > > I'm thinking to introduce a new flag (something like --remove-disks, > --wipe-disks) for "virsh undefine", so that the user can choose > whether to remove/wipe the disk devices or not, have seen this > requirement in many pl

Re: [libvirt] [RFC] Add flag for virsh undefine to remove/wipe the disk devices

2011-03-30 Thread Daniel Veillard
On Wed, Mar 30, 2011 at 09:39:14PM +0800, Osier Yang wrote: > Hi, All > > I'm thinking to introduce a new flag (something like --remove-disks, > --wipe-disks) for "virsh undefine", so that the user can choose > whether to remove/wipe the disk devices or not, have seen this > requirement in many pl

[libvirt] [RFC] Add flag for virsh undefine to remove/wipe the disk devices

2011-03-30 Thread Osier Yang
Hi, All I'm thinking to introduce a new flag (something like --remove-disks, --wipe-disks) for "virsh undefine", so that the user can choose whether to remove/wipe the disk devices or not, have seen this requirement in many places, @libvirt-users, public #virt, and also we have a bug of this funct