On Mon, Nov 21, 2011 at 08:27:17PM +0100, Marc-André Lureau wrote:
Hi
On Mon, Nov 21, 2011 at 6:53 PM, Zeeshan Ali (Khattak)
zeesha...@gnome.org wrote:
+ g_return_val_if_fail(error == NULL || *error == NULL, FALSE);
This is wrong, it should be error != NULL *error == NULL.
+
On Tue, Nov 22, 2011 at 11:20 AM, Daniel P. Berrange
berra...@redhat.com wrote:
On Mon, Nov 21, 2011 at 08:27:17PM +0100, Marc-André Lureau wrote:
Hi
On Mon, Nov 21, 2011 at 6:53 PM, Zeeshan Ali (Khattak)
zeesha...@gnome.org wrote:
+ g_return_val_if_fail(error == NULL || *error == NULL,
Hi
Hi
Agreed with the comments from teuf +
On Fri, Nov 18, 2011 at 8:24 PM, Zeeshan Ali (Khattak)
zeesha...@gnome.org wrote:
+void gvir_connection_redefine_domain(GVirConnection *conn,
+ GVirDomain *domain,
+
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
libvirt-gobject/libvirt-gobject-domain.c | 48 ++
libvirt-gobject/libvirt-gobject-domain.h |3 ++
libvirt-gobject/libvirt-gobject.sym |1 +
3 files changed, 52 insertions(+), 0 deletions(-)
diff --git
Hi
On Mon, Nov 21, 2011 at 6:53 PM, Zeeshan Ali (Khattak)
zeesha...@gnome.org wrote:
+ g_return_val_if_fail(error == NULL || *error == NULL, FALSE);
This is wrong, it should be error != NULL *error == NULL.
+ if (virDomainDefineXML(conn, xml) == NULL) {
+ if (error != NULL)
+
On Mon, Nov 21, 2011 at 9:27 PM, Marc-André Lureau
marcandre.lur...@gmail.com wrote:
Hi
On Mon, Nov 21, 2011 at 6:53 PM, Zeeshan Ali (Khattak)
zeesha...@gnome.org wrote:
+ g_return_val_if_fail(error == NULL || *error == NULL, FALSE);
This is wrong, it should be error != NULL *error ==
On Mon, Nov 21, 2011 at 8:45 PM, Zeeshan Ali (Khattak)
zeesha...@gnome.org wrote:
Sorry, i don't get it. Verify how?
By doing what I proposed bellow, reading libvirt code, ask on libvirt
list/maintainers, test etc..
I would really prefer we add a runtime check that verifiy the handle
is the
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
libvirt-gobject/libvirt-gobject-domain.c | 63 ++
libvirt-gobject/libvirt-gobject-domain.h |3 +
libvirt-gobject/libvirt-gobject.sym |1 +
3 files changed, 67 insertions(+), 0 deletions(-)
diff --git
On Mon, Nov 21, 2011 at 9:58 PM, Marc-André Lureau
marcandre.lur...@gmail.com wrote:
On Mon, Nov 21, 2011 at 8:45 PM, Zeeshan Ali (Khattak)
zeesha...@gnome.org wrote:
Sorry, i don't get it. Verify how?
By doing what I proposed bellow, reading libvirt code, ask on libvirt
list/maintainers,
On Mon, Nov 21, 2011 at 9:02 PM, Zeeshan Ali (Khattak)
zeesha...@gnome.org wrote:
+ g_return_val_if_fail(err == NULL || *err == NULL, FALSE);
this needs update, as I wrote before.
+ xml = gvir_config_object_to_xml(GVIR_CONFIG_OBJECT(conf));
hmm, don't we need to free xml?
+
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
libvirt-gobject/libvirt-gobject-domain.c | 65 ++
libvirt-gobject/libvirt-gobject-domain.h |3 +
libvirt-gobject/libvirt-gobject.sym |1 +
3 files changed, 69 insertions(+), 0 deletions(-)
diff --git
On Mon, Nov 21, 2011 at 10:12 PM, Marc-André Lureau
marcandre.lur...@gmail.com wrote:
On Mon, Nov 21, 2011 at 9:02 PM, Zeeshan Ali (Khattak)
zeesha...@gnome.org wrote:
+ g_return_val_if_fail(err == NULL || *err == NULL, FALSE);
As I explained on IRC, it is justified AFAICT. Either you
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
libvirt-gobject/libvirt-gobject-domain.c | 68 ++
libvirt-gobject/libvirt-gobject-domain.h |3 +
libvirt-gobject/libvirt-gobject.sym |1 +
3 files changed, 72 insertions(+), 0 deletions(-)
diff --git
On Mon, Nov 21, 2011 at 10:09 PM, Zeeshan Ali (Khattak)
zeesha...@gnome.org wrote:
As I explained on IRC, it is justified AFAICT. Either you pass a
'NULL' as the error arg or you pass an uninitialized place-holder for
error.
right, sorry for the confusion
--
Marc-André Lureau
--
ack
On Mon, Nov 21, 2011 at 10:10 PM, Zeeshan Ali (Khattak)
zeesha...@gnome.org wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
libvirt-gobject/libvirt-gobject-domain.c | 68
++
libvirt-gobject/libvirt-gobject-domain.h | 3 +
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
libvirt-gobject/libvirt-gobject-connection.c | 37 ++
libvirt-gobject/libvirt-gobject-connection.h |4 +++
libvirt-gobject/libvirt-gobject.sym |1 +
3 files changed, 42 insertions(+), 0 deletions(-)
Hey,
Reading this patch, I'm wondering if gvir_domain_set_config might achieve
what you are after (it's not implemented either)
On Fri, Nov 18, 2011 at 09:24:32PM +0200, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
On Sat, Nov 19, 2011 at 12:56 AM, Christophe Fergeau
cferg...@redhat.com wrote:
Hey,
Reading this patch, I'm wondering if gvir_domain_set_config might achieve
what you are after (it's not implemented either)
Yeah, that might actually be better.
+ GVirConnectionPrivate *priv =
On Sat, Nov 19, 2011 at 01:02:28AM +0200, Zeeshan Ali (Khattak) wrote:
On Sat, Nov 19, 2011 at 12:56 AM, Christophe Fergeau
cferg...@redhat.com wrote:
Hey,
Reading this patch, I'm wondering if gvir_domain_set_config might achieve
what you are after (it's not implemented either)
19 matches
Mail list logo
