Re: [libvirt] [libvirt-java] [PATCH 36/65] jna: Wrap the virEvent(Add, Remove)Timeout libvirt functions

2014-03-04 Thread Daniel P. Berrange
On Tue, Mar 04, 2014 at 08:31:04AM +0100, Claudio Bley wrote: > At Mon, 3 Mar 2014 15:58:25 +, > Daniel P. Berrange wrote: > > > > On Mon, Mar 03, 2014 at 04:46:51PM +0100, Claudio Bley wrote: > > > At Fri, 21 Feb 2014 11:01:47 +, > > > Daniel P. Berrange wrote: > > > > > > > > ACK, if yo

Re: [libvirt] [libvirt-java] [PATCH 36/65] jna: Wrap the virEvent(Add, Remove)Timeout libvirt functions

2014-03-03 Thread Claudio Bley
At Mon, 3 Mar 2014 15:58:25 +, Daniel P. Berrange wrote: > > On Mon, Mar 03, 2014 at 04:46:51PM +0100, Claudio Bley wrote: > > At Fri, 21 Feb 2014 11:01:47 +, > > Daniel P. Berrange wrote: > > > > > > ACK, if you also add the virEventUpdateTimeout method > > > > OK, but why should I add

Re: [libvirt] [libvirt-java] [PATCH 36/65] jna: Wrap the virEvent(Add, Remove)Timeout libvirt functions

2014-03-03 Thread Jim Fehlig
Eric Blake wrote: > On 03/03/2014 08:58 AM, Daniel P. Berrange wrote: > >> On Mon, Mar 03, 2014 at 04:46:51PM +0100, Claudio Bley wrote: >> >>> At Fri, 21 Feb 2014 11:01:47 +, >>> Daniel P. Berrange wrote: >>> ACK, if you also add the virEventUpdateTimeout method

Re: [libvirt] [libvirt-java] [PATCH 36/65] jna: Wrap the virEvent(Add, Remove)Timeout libvirt functions

2014-03-03 Thread Eric Blake
On 03/03/2014 08:58 AM, Daniel P. Berrange wrote: > On Mon, Mar 03, 2014 at 04:46:51PM +0100, Claudio Bley wrote: >> At Fri, 21 Feb 2014 11:01:47 +, >> Daniel P. Berrange wrote: >>> >>> ACK, if you also add the virEventUpdateTimeout method >> >> OK, but why should I add it? It's useless (for t

Re: [libvirt] [libvirt-java] [PATCH 36/65] jna: Wrap the virEvent(Add, Remove)Timeout libvirt functions

2014-03-03 Thread Daniel P. Berrange
On Mon, Mar 03, 2014 at 04:46:51PM +0100, Claudio Bley wrote: > At Fri, 21 Feb 2014 11:01:47 +, > Daniel P. Berrange wrote: > > > > ACK, if you also add the virEventUpdateTimeout method > > OK, but why should I add it? It's useless (for the user) and unused by > the wrapping code. I want to

Re: [libvirt] [libvirt-java] [PATCH 36/65] jna: Wrap the virEvent(Add, Remove)Timeout libvirt functions

2014-03-03 Thread Claudio Bley
At Fri, 21 Feb 2014 11:01:47 +, Daniel P. Berrange wrote: > > ACK, if you also add the virEventUpdateTimeout method OK, but why should I add it? It's useless (for the user) and unused by the wrapping code. I want to keep the JNA library definition clean -- e.g. in a later patch I remove all

Re: [libvirt] [libvirt-java] [PATCH 36/65] jna: Wrap the virEvent(Add, Remove)Timeout libvirt functions

2014-02-21 Thread Daniel P. Berrange
On Thu, Feb 13, 2014 at 04:22:44PM +0100, Claudio Bley wrote: > These functions are not (yet) exposed in the public org.libvirt > package but only used internally. > > Signed-off-by: Claudio Bley > --- > src/main/java/org/libvirt/jna/Libvirt.java | 11 +++ > 1 file changed, 11 insertio

[libvirt] [libvirt-java] [PATCH 36/65] jna: Wrap the virEvent(Add, Remove)Timeout libvirt functions

2014-02-13 Thread Claudio Bley
These functions are not (yet) exposed in the public org.libvirt package but only used internally. Signed-off-by: Claudio Bley --- src/main/java/org/libvirt/jna/Libvirt.java | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/main/java/org/libvirt/jna/Libvirt.java b/src/main/j