Re: [libvirt] [PATCH] Support transient attribute on vmware disks

2013-12-27 Thread Eric Blake
On 12/27/2013 02:40 PM, Wout Mertens wrote: > OK… So what is the next step? [please don't top-post on technical lists] > > I just noticed the node > (http://libvirt.org/formatdomain.html#elementsMetadata), could that be used > for this? E.g. > > http://libvirt.org/vmware/“>[foo] > bar/b

Re: [libvirt] [PATCH] Support transient attribute on vmware disks

2013-12-27 Thread Wout Mertens
OK… So what is the next step? I just noticed the node (http://libvirt.org/formatdomain.html#elementsMetadata), could that be used for this? E.g. http://libvirt.org/vmware/“>[foo] bar/bar.vmx Otherwise it seems to me that this would be part of the general section, perhaps simply a “path

Re: [libvirt] [PATCH] Support transient attribute on vmware disks

2013-12-27 Thread Eric Blake
On 12/26/2013 04:02 PM, Wout Mertens wrote: > Workarounds I can think of: > - Augment the domain xml description so it also defines the storage pool on > which the created domain should reside This is a good idea which I've wanted for other reasons - the qemu driver also has instances where we a

Re: [libvirt] [PATCH] Support transient attribute on vmware disks

2013-12-26 Thread Wout Mertens
Hi Eric, haven’t had time for writing the test yet, since I’m trying to get an app out the door that uses libvirt for running “instant clones” of a VM. I ran into a big issue and I’m hoping you or anyone on this list can help: When I create a new domain with a transient disk like this, the .vmx

Re: [libvirt] [PATCH] Support transient attribute on vmware disks

2013-12-17 Thread Wout Mertens
Hi Eric, thank you very much for your assistance! I'll take a look at writing that test tomorrow. Wout. On Tue, Dec 17, 2013 at 10:24 PM, Eric Blake wrote: > On 12/17/2013 01:45 PM, Eric Blake wrote: > > On 12/17/2013 01:42 PM, Eric Blake wrote: > >> On 12/17/2013 10:04 AM, Wout Mertens wrote

Re: [libvirt] [PATCH] Support transient attribute on vmware disks

2013-12-17 Thread Eric Blake
On 12/17/2013 10:04 AM, Wout Mertens wrote: > From: Wout Mertens > > vmx/vmx.c ignores the transient attribute on the disk xml format. This patch > adds a 1-1 relationship between it and [disk].mode = > "independent-nonpersistent". > > The other modes are ignored as before. It works in my testi

Re: [libvirt] [PATCH] Support transient attribute on vmware disks

2013-12-17 Thread Eric Blake
On 12/17/2013 01:45 PM, Eric Blake wrote: > On 12/17/2013 01:42 PM, Eric Blake wrote: >> On 12/17/2013 10:04 AM, Wout Mertens wrote: >>> From: Wout Mertens >>> >>> vmx/vmx.c ignores the transient attribute on the disk xml format. This patch >>> adds a 1-1 relationship between it and [disk].mode =

Re: [libvirt] [PATCH] Support transient attribute on vmware disks

2013-12-17 Thread Eric Blake
On 12/17/2013 01:42 PM, Eric Blake wrote: > On 12/17/2013 10:04 AM, Wout Mertens wrote: >> From: Wout Mertens >> >> vmx/vmx.c ignores the transient attribute on the disk xml format. This patch >> adds a 1-1 relationship between it and [disk].mode = >> "independent-nonpersistent". >> >> The other

[libvirt] [PATCH] Support transient attribute on vmware disks

2013-12-17 Thread Wout Mertens
From: Wout Mertens vmx/vmx.c ignores the transient attribute on the disk xml format. This patch adds a 1-1 relationship between it and [disk].mode = "independent-nonpersistent". The other modes are ignored as before. It works in my testing. https://bugzilla.redhat.com/show_bug.cgi?id=1044023