Re: [libvirt] [libvirt-java] [PATCH] added pom details

2015-04-15 Thread Laszlo Hornyak
re-sending, thank you Erik! On Wed, Apr 15, 2015 at 9:48 PM, Eric Blake wrote: > On 04/15/2015 01:38 PM, Laszlo Hornyak wrote: > > The added details are required in order to upload to maven central > > > > Signed-off-by: Laszlo Hornyak > > --- > > pom.xml.in | 14 ++ > > 1 file cha

Re: [libvirt] [libvirt-java] [PATCH] added pom details

2015-04-15 Thread Eric Blake
On 04/15/2015 01:38 PM, Laszlo Hornyak wrote: > The added details are required in order to upload to maven central > > Signed-off-by: Laszlo Hornyak > --- > pom.xml.in | 14 ++ > 1 file changed, 14 insertions(+) I'm not qualified to review the patch proper; but you might want to do:

Re: [libvirt] [libvirt-java] [PATCH 00/65]

2014-11-02 Thread Daniel P. Berrange
On Sat, Nov 01, 2014 at 10:40:06PM +0100, Claudio Bley wrote: > At Fri, 21 Feb 2014 11:19:23 +, > Daniel P. Berrange wrote: > > > > On Thu, Feb 13, 2014 at 04:22:08PM +0100, Claudio Bley wrote: > > > Hi. > > > > > > Here are a few patches that piled up in my local branch. Some of them > > > I

Re: [libvirt] [libvirt-java] [PATCH 00/65]

2014-11-01 Thread Claudio Bley
At Fri, 21 Feb 2014 11:19:23 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:08PM +0100, Claudio Bley wrote: > > Hi. > > > > Here are a few patches that piled up in my local branch. Some of them > > I already submitted to this list, but there has been no reponse to > > them. >

Re: [libvirt] [libvirt-java] [PATCH 35/65] Fix memleak in StorageVol.getXMLDesc

2014-03-26 Thread Claudio Bley
At Fri, 21 Feb 2014 10:59:44 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:43PM +0100, Claudio Bley wrote: > > > > Signed-off-by: Claudio Bley > > --- > > src/main/java/org/libvirt/StorageVol.java |8 +++- > > src/main/java/org/libvirt/jna/Libvirt.java |2 +- >

Re: [libvirt] [libvirt-java] [PATCH 33/65] Fix memleak in DomainSnapshot.getXMLDesc

2014-03-26 Thread Claudio Bley
At Fri, 21 Feb 2014 10:59:02 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:41PM +0100, Claudio Bley wrote: > > > > Signed-off-by: Claudio Bley > > --- > > src/main/java/org/libvirt/DomainSnapshot.java | 10 +- > > src/main/java/org/libvirt/jna/Libvirt.java|

Re: [libvirt] [libvirt-java] [PATCH 00/65]

2014-03-26 Thread Claudio Bley
At Fri, 21 Feb 2014 11:21:17 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:08PM +0100, Claudio Bley wrote: > > Hi. > > > > Here are a few patches that piled up in my local branch. Some of them > > I already submitted to this list, but there has been no reponse to > > them. >

Re: [libvirt] [libvirt-java] [PATCH 34/65] Fix memleak in StorageVol.getPath

2014-03-26 Thread Claudio Bley
At Fri, 21 Feb 2014 10:59:25 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:42PM +0100, Claudio Bley wrote: > > > > Signed-off-by: Claudio Bley > > --- > > src/main/java/org/libvirt/StorageVol.java | 10 +- > > src/main/java/org/libvirt/jna/Libvirt.java |2 +-

Re: [libvirt] [libvirt-java] [PATCH 08/65] Depend on JNA versions 3.4.1 to 4.0.0

2014-03-26 Thread Claudio Bley
At Fri, 21 Feb 2014 10:36:10 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:16PM +0100, Claudio Bley wrote: > > Specify a version range for the net.java.dev.jna / jna artifact > > in order to accept any version we tested the libvirt Java bindings > > against. > > > > Signed-of

Re: [libvirt] [libvirt-java] [PATCH 32/65] Fix memleak in StoragePool.listVolumes

2014-03-26 Thread Claudio Bley
At Fri, 21 Feb 2014 10:58:35 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:40PM +0100, Claudio Bley wrote: > > We need to free the char* entries of the result array returned > > ourselves. > > > > Signed-off-by: Claudio Bley > > --- > > src/main/java/org/libvirt/StoragePool

Re: [libvirt] [libvirt-java] [PATCH 31/65] Fix memleak in Domain.snapshotListNames

2014-03-26 Thread Claudio Bley
eAt Fri, 21 Feb 2014 10:57:44 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:39PM +0100, Claudio Bley wrote: > > We need to free the char* entries of the result array returned ourselves. > > > > Signed-off-by: Claudio Bley > > --- > > src/main/java/org/libvirt/Domain.java

Re: [libvirt] [libvirt-java] [PATCH 30/65] Fix Domain.getSchedulerParameters / getSchedulerType

2014-03-26 Thread Claudio Bley
At Fri, 21 Feb 2014 10:57:10 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:38PM +0100, Claudio Bley wrote: > > The getSchedulerType method returns a String (the name of the > > scheduler), not a String array containing a single element. > > > > It's OK to just pass null for t

Re: [libvirt] [libvirt-java] [PATCH 23/65] Remove processError method from StoragePool class

2014-03-26 Thread Claudio Bley
At Fri, 21 Feb 2014 10:49:15 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:31PM +0100, Claudio Bley wrote: > > Wrap any fallible libvirt function in a call to > > ErrorHandler.processError(..). > > > > Adjust the doc comment for storageVolLookupByName to indicate that > > it

Re: [libvirt] [libvirt-java] [PATCH 28/65] Remove ErrorHandler.processError(Libvirt) method

2014-03-26 Thread Claudio Bley
At Fri, 21 Feb 2014 10:51:17 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:36PM +0100, Claudio Bley wrote: > > It was deprecated and is no longer used. > > > > Signed-off-by: Claudio Bley > > --- > > src/main/java/org/libvirt/ErrorHandler.java | 12 > > 1 fil

Re: [libvirt] [libvirt-java] [PATCH 26/65] Remove processError method from Connect class

2014-03-26 Thread Claudio Bley
At Fri, 21 Feb 2014 10:50:22 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:34PM +0100, Claudio Bley wrote: > > Wrap any fallible libvirt function in a call to > > ErrorHandler.processError(..) and remove calls to the deprecated > > ErrorHandler.processError(Libvirt) method. >

Re: [libvirt] [libvirt-java] [PATCH 20/65] Remove processError method from Network class

2014-03-26 Thread Claudio Bley
At Fri, 21 Feb 2014 10:45:55 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:28PM +0100, Claudio Bley wrote: > > Wrap any fallible libvirt function in a call to > > ErrorHandler.processError(..). > > > > Also correct wrong javadoc comments stating that methods would return > >

Re: [libvirt] [libvirt-java] [PATCH 27/65] Call processError only when virInitialize signalled an error

2014-03-26 Thread Claudio Bley
At Fri, 21 Feb 2014 10:50:57 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:35PM +0100, Claudio Bley wrote: > > > > Signed-off-by: Claudio Bley > > --- > > src/main/java/org/libvirt/Library.java |4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > ACK Thank

Re: [libvirt] [libvirt-java] [PATCH 25/65] Remove processError method from Stream class

2014-03-26 Thread Claudio Bley
At Fri, 21 Feb 2014 10:49:52 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:33PM +0100, Claudio Bley wrote: > > Wrap any fallible libvirt function in a call to > > ErrorHandler.processError(..). > > > > Also correct wrong javadoc comments stating that methods would return > >

Re: [libvirt] [libvirt-java] [PATCH 24/65] Remove processError method from StorageVol class

2014-03-26 Thread Claudio Bley
At Fri, 21 Feb 2014 10:49:33 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:32PM +0100, Claudio Bley wrote: > > Wrap any fallible libvirt function in a call to > > ErrorHandler.processError(..). > > > > Also correct wrong javadoc comments stating that methods would return > >

Re: [libvirt] [libvirt-java] [PATCH 22/65] Remove processError method from Secret class

2014-03-26 Thread Claudio Bley
At Fri, 21 Feb 2014 10:48:44 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:30PM +0100, Claudio Bley wrote: > > Wrap any fallible libvirt function in a call to > > ErrorHandler.processError(..). > > > > Also correct wrong javadoc comments stating that methods would return > >

Re: [libvirt] [libvirt-java] [PATCH 19/65] Remove processError from Interface class

2014-03-26 Thread Claudio Bley
At Fri, 21 Feb 2014 10:45:22 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:27PM +0100, Claudio Bley wrote: > > Wrap any fallible libvirt function in a call to > > ErrorHandler.processError(..). > > > > Also correct wrong javadoc comments stating that methods would return > >

Re: [libvirt] [libvirt-java] [PATCH 21/65] Remove processError method from NetworkFilter class

2014-03-26 Thread Claudio Bley
At Fri, 21 Feb 2014 10:46:19 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:29PM +0100, Claudio Bley wrote: > > Wrap any fallible libvirt function in a call to > > ErrorHandler.processError(..). > > > > Also correct wrong javadoc comments stating that methods would return > >

Re: [libvirt] [libvirt-java] [PATCH 16/65] Remove processError from Device class

2014-03-26 Thread Claudio Bley
At Fri, 21 Feb 2014 10:43:43 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:24PM +0100, Claudio Bley wrote: > > Wrap any fallible libvirt function in a call to > > ErrorHandler.processError(..). > > > > Signed-off-by: Claudio Bley > > --- > > src/main/java/org/libvirt/Devic

Re: [libvirt] [libvirt-java] [PATCH 15/65] Start refactoring of error handling

2014-03-26 Thread Claudio Bley
At Fri, 21 Feb 2014 10:43:15 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:23PM +0100, Claudio Bley wrote: > > Almost every class contains a processError() method with an identical > > definition, just forwarding the call to ErrorHandler.processError(Libvirt). > > > > This fu

Re: [libvirt] [libvirt-java] [PATCH 18/65] Remove processError from DomainSnapshot class

2014-03-26 Thread Claudio Bley
At Fri, 21 Feb 2014 10:45:01 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:26PM +0100, Claudio Bley wrote: > > Wrap any fallible libvirt function in a call to > > ErrorHandler.processError(..). > > > > Also correct wrong javadoc comments stating that methods would return > >

Re: [libvirt] [libvirt-java] [PATCH 17/65] Remove processError from Domain class

2014-03-26 Thread Claudio Bley
At Fri, 21 Feb 2014 10:44:42 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:25PM +0100, Claudio Bley wrote: > > Wrap any fallible libvirt function in a call to > > ErrorHandler.processError(..). > > > > Also update erroneous javadoc comments stating that methods would return

Re: [libvirt] [libvirt-java] [PATCH 14/65] test: ensure the Device.listCapabilities method works

2014-03-26 Thread Claudio Bley
At Fri, 21 Feb 2014 10:42:22 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:22PM +0100, Claudio Bley wrote: > > > > Signed-off-by: Claudio Bley > > --- > > src/test/java/org/libvirt/TestJavaBindings.java | 14 ++ > > 1 file changed, 14 insertions(+) > > ACK T

Re: [libvirt] [libvirt-java] [PATCH 13/65] Make Device.listCapabilities return only valid array elements

2014-03-26 Thread Claudio Bley
At Fri, 21 Feb 2014 10:41:35 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:21PM +0100, Claudio Bley wrote: > > The libvirt function virNodeDeviceListCaps might return fewer elements > > than requested. Take this into account and properly decode the UTF-8 > > strings returned.

Re: [libvirt] [libvirt-java] [PATCH 10/65] Fix wrapping of native size_t data type

2014-03-26 Thread Claudio Bley
At Fri, 21 Feb 2014 14:42:26 +0100, Claudio Bley wrote: > > At Fri, 21 Feb 2014 10:37:36 +, > Daniel P. Berrange wrote: > > > > On Thu, Feb 13, 2014 at 04:22:18PM +0100, Claudio Bley wrote: > > > Libvirt function parameters having type (pointer to) size_t were > > > wrapped via JNA using int,

Re: [libvirt] [libvirt-java] [PATCH 12/65] tests: remove obsolete test driver

2014-03-26 Thread Claudio Bley
At Fri, 21 Feb 2014 10:40:46 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:20PM +0100, Claudio Bley wrote: > > JUnit is used for quite some time now, which supercedes the tests > > defined in the old "test" class. > > > > Signed-off-by: Claudio Bley > > --- > > src/test/jav

Re: [libvirt] [libvirt-java] [PATCH 09/65] jna: load virt-0 or virt library depending on the platform

2014-03-26 Thread Claudio Bley
At Fri, 21 Feb 2014 10:36:33 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:17PM +0100, Claudio Bley wrote: > > On Windows, the libvirt DLL is called libvirt-0.dll. Trying to load > > the "virt" library hence fails to find the file. Branch on the platform > > and load "virt-0"

Re: [libvirt] [libvirt-java] [PATCH 07/65] Ignore editor backup files

2014-03-26 Thread Claudio Bley
At Fri, 21 Feb 2014 10:35:42 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:15PM +0100, Claudio Bley wrote: > > > > Signed-off-by: Claudio Bley > > --- > > .gitignore |2 ++ > > 1 file changed, 2 insertions(+) > > ACK. Counts as a trivial patch that can be pushed withou

Re: [libvirt] [libvirt-java] [PATCH 06/65] Make comments proper javadoc comments for enum constants

2014-03-26 Thread Claudio Bley
At Fri, 21 Feb 2014 10:35:17 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:14PM +0100, Claudio Bley wrote: > > > > Signed-off-by: Claudio Bley > > --- > > src/main/java/org/libvirt/Error.java | 397 > > ++ > > 1 file changed, 262 insertions

Re: [libvirt] [libvirt-java] [PATCH 05/65] test: ensure that exceptions are thrown when expected

2014-03-26 Thread Claudio Bley
At Fri, 21 Feb 2014 10:34:52 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:13PM +0100, Claudio Bley wrote: > > > > Signed-off-by: Claudio Bley > > --- > > src/test/java/org/libvirt/TestJavaBindings.java |2 ++ > > 1 file changed, 2 insertions(+) > > ACK Thanks, pushed

Re: [libvirt] [libvirt-java] [PATCH 04/65] test: fix typo in testConnection()

2014-03-26 Thread Claudio Bley
At Fri, 21 Feb 2014 10:34:24 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:12PM +0100, Claudio Bley wrote: > > > > Signed-off-by: Claudio Bley > > --- > > src/test/java/org/libvirt/TestJavaBindings.java |2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > ACK

Re: [libvirt] [libvirt-java] [PATCH 03/65] Fix typos in Error.java

2014-03-26 Thread Claudio Bley
At Fri, 21 Feb 2014 10:34:05 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:11PM +0100, Claudio Bley wrote: > > > > Signed-off-by: Claudio Bley > > --- > > src/main/java/org/libvirt/Error.java |6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > ACK Thank

Re: [libvirt] [libvirt-java] [PATCH 01/65] Fix warnings about using raw types

2014-03-26 Thread Claudio Bley
At Fri, 21 Feb 2014 10:32:08 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:09PM +0100, Claudio Bley wrote: > > Eclipse generates this kind of warning: > > > > org/libvirt/jna/virConnectCredential.java:20: > > List is a raw type. References to generic type List should be > >

Re: [libvirt] [libvirt-java] [PATCH 02/65] Fix warnings about accessing static methods

2014-03-26 Thread Claudio Bley
At Fri, 21 Feb 2014 10:33:44 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:10PM +0100, Claudio Bley wrote: > > java/org/libvirt/Error.java:217: > > The static method wrap(int) from the type Error.ErrorDomain should be > > accessed in a static way > > > > Signed-off-by: Claudi

Re: [libvirt] [libvirt-java] [PATCH] Set Java source level in pom

2014-03-26 Thread Chris Ellis
On Wed, Mar 26, 2014 at 4:32 AM, Eric Blake wrote: > On 03/25/2014 10:19 PM, Eric Blake wrote: > > On 03/25/2014 09:29 PM, Chris Ellis wrote: > >> Hi > >> > >> Simple patch to set the Java source level within the pom, this makes it > >> easier to import the project into Eclipse. I've also added

Re: [libvirt] [libvirt-java] [PATCH] Update pom to include Java source level

2014-03-26 Thread Chris Ellis
On Wed, Mar 26, 2014 at 7:52 AM, Claudio Bley wrote: > At Wed, 26 Mar 2014 03:29:34 +, > Chris Ellis wrote: > > > > Update the pom to set the Java source level. This enables Eclipse > > to correctly configure itself. > > So, you let ant generate the pom.xml and use that with Eclipse, right?

Re: [libvirt] [libvirt-java] [PATCH 39/65] Introduce event loop support

2014-03-26 Thread Claudio Bley
At Fri, 21 Feb 2014 11:03:49 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:47PM +0100, Claudio Bley wrote: > > Add initEventLoop(), processEvent(), runEventLoop() and stopEventLoop() > > static methods to the Library class. > > > > Signed-off-by: Claudio Bley > > --- > > sr

Re: [libvirt] [libvirt-java] [PATCH] Update pom to include Java source level

2014-03-26 Thread Claudio Bley
At Wed, 26 Mar 2014 03:29:34 +, Chris Ellis wrote: > > Update the pom to set the Java source level. This enables Eclipse > to correctly configure itself. So, you let ant generate the pom.xml and use that with Eclipse, right? > Also include plugins to publish the source and javadocs vai Mave

Re: [libvirt] [libvirt-java] [PATCH] Set Java source level in pom

2014-03-25 Thread Eric Blake
On 03/25/2014 10:19 PM, Eric Blake wrote: > On 03/25/2014 09:29 PM, Chris Ellis wrote: >> Hi >> >> Simple patch to set the Java source level within the pom, this makes it >> easier to import the project into Eclipse. I've also added an ignore for >> a local pom file. >> >> I've added plugins to

[libvirt] [libvirt-java] [PATCH] Update pom to include Java source level

2014-03-25 Thread Chris Ellis
Update the pom to set the Java source level. This enables Eclipse to correctly configure itself. Also include plugins to publish the source and javadocs vai Maven. Update .gitignore to exclude a local pom. --- .gitignore | 1 + pom.xml.in | 41 + 2 files

Re: [libvirt] [libvirt-java] [PATCH] Set Java source level in pom

2014-03-25 Thread Eric Blake
On 03/25/2014 09:29 PM, Chris Ellis wrote: > Hi > > Simple patch to set the Java source level within the pom, this makes it > easier to import the project into Eclipse. I've also added an ignore for > a local pom file. > > I've added plugins to publish the sources and javadocs into Maven. Thi

[libvirt] [libvirt-java] [PATCH] Set Java source level in pom

2014-03-25 Thread Chris Ellis
Hi Simple patch to set the Java source level within the pom, this makes it easier to import the project into Eclipse. I've also added an ignore for a local pom file. I've added plugins to publish the sources and javadocs into Maven. This allows Maven (and IDE integration) to automatically us

[libvirt] [libvirt-java] [PATCH 0/2] Ensure JNA callbacks cannot be GCed

2014-03-25 Thread Chris Ellis
Hi. This is a small patch set to fix a few issues I've discovered while testing Claudio's patch set. The first patch is trivial, it adds the ConnectionCloseListener interface and corresponding enum, which were missing. The second patch ensures that the JNA callbacks cannot be garbage collecte

Re: [libvirt] [libvirt-java][PATCH] make Flags used to manipulate Domain accessible from outside of the package

2014-03-24 Thread Claudio Bley
[FTR, I've noticed the same thing when I started to use the Java bindings. Back then, this made me wonder whether the bindings are actually used by someone, because the constants are rather useless without being public and nobody objected...] At Fri, 21 Mar 2014 14:05:26 -0600, Yoshikazu Nojima

[libvirt] [libvirt-java][PATCH] make Flags used to manipulate Domain accessible from outside of the package

2014-03-21 Thread Yoshikazu Nojima
Hi, I'd like to submit a small patch to libvirt-java. This patch make Flags used to manipulate Domain accessible from outside of the package I'm new to libvirt-java development process, please let me know if I miss something. Thanks! Yoshikazu Nojima From 9eebc8caef1f8b4f87d63e5e74079b1ced3c0e7

Re: [libvirt] [libvirt-java] [PATCH] Implement equals and hashCode methods for Connect and Domain

2014-03-12 Thread Claudio Bley
At Tue, 11 Mar 2014 11:18:57 +0100, Claudio Bley wrote: > > > Signed-off-by: Claudio Bley > --- > src/main/java/org/libvirt/Connect.java | 39 + > src/main/java/org/libvirt/Domain.java | 52 > ++- > src/test/java/org/libvirt/TestJavaBi

[libvirt] [libvirt-java] [PATCH] Implement equals and hashCode methods for Connect and Domain

2014-03-11 Thread Claudio Bley
Signed-off-by: Claudio Bley --- src/main/java/org/libvirt/Connect.java | 39 + src/main/java/org/libvirt/Domain.java | 52 ++- src/test/java/org/libvirt/TestJavaBindings.java |4 ++ 3 files changed, 94 insertions(+), 1 deletion(-) d

Re: [libvirt] [libvirt-java] [PATCH 40/65] Add constants for enum virDomainEventID

2014-03-04 Thread Claudio Bley
At Mon, 03 Mar 2014 13:06:50 -0700, Eric Blake wrote: > > [1 ] > On 02/13/2014 08:22 AM, Claudio Bley wrote: > > Note: these are only used internally. > > > > Signed-off-by: Claudio Bley > > --- > > > +static final int CONTROL_ERROR = 7; > > +static final int BLOCK_JOB = 8; > >

Re: [libvirt] [libvirt-java] [PATCH 36/65] jna: Wrap the virEvent(Add, Remove)Timeout libvirt functions

2014-03-04 Thread Daniel P. Berrange
On Tue, Mar 04, 2014 at 08:31:04AM +0100, Claudio Bley wrote: > At Mon, 3 Mar 2014 15:58:25 +, > Daniel P. Berrange wrote: > > > > On Mon, Mar 03, 2014 at 04:46:51PM +0100, Claudio Bley wrote: > > > At Fri, 21 Feb 2014 11:01:47 +, > > > Daniel P. Berrange wrote: > > > > > > > > ACK, if yo

Re: [libvirt] [libvirt-java] [PATCH 36/65] jna: Wrap the virEvent(Add, Remove)Timeout libvirt functions

2014-03-03 Thread Claudio Bley
At Mon, 3 Mar 2014 15:58:25 +, Daniel P. Berrange wrote: > > On Mon, Mar 03, 2014 at 04:46:51PM +0100, Claudio Bley wrote: > > At Fri, 21 Feb 2014 11:01:47 +, > > Daniel P. Berrange wrote: > > > > > > ACK, if you also add the virEventUpdateTimeout method > > > > OK, but why should I add

Re: [libvirt] [libvirt-java] [PATCH 36/65] jna: Wrap the virEvent(Add, Remove)Timeout libvirt functions

2014-03-03 Thread Jim Fehlig
Eric Blake wrote: > On 03/03/2014 08:58 AM, Daniel P. Berrange wrote: > >> On Mon, Mar 03, 2014 at 04:46:51PM +0100, Claudio Bley wrote: >> >>> At Fri, 21 Feb 2014 11:01:47 +, >>> Daniel P. Berrange wrote: >>> ACK, if you also add the virEventUpdateTimeout method

Re: [libvirt] [libvirt-java] [PATCH 40/65] Add constants for enum virDomainEventID

2014-03-03 Thread Eric Blake
On 02/13/2014 08:22 AM, Claudio Bley wrote: > Note: these are only used internally. > > Signed-off-by: Claudio Bley > --- > +static final int CONTROL_ERROR = 7; > +static final int BLOCK_JOB = 8; > +static final int DISK_CHANGE = 9; > +static final int TRAY_CHANGE

Re: [libvirt] [libvirt-java] [PATCH 36/65] jna: Wrap the virEvent(Add, Remove)Timeout libvirt functions

2014-03-03 Thread Eric Blake
On 03/03/2014 08:58 AM, Daniel P. Berrange wrote: > On Mon, Mar 03, 2014 at 04:46:51PM +0100, Claudio Bley wrote: >> At Fri, 21 Feb 2014 11:01:47 +, >> Daniel P. Berrange wrote: >>> >>> ACK, if you also add the virEventUpdateTimeout method >> >> OK, but why should I add it? It's useless (for t

Re: [libvirt] [libvirt-java] [PATCH 36/65] jna: Wrap the virEvent(Add, Remove)Timeout libvirt functions

2014-03-03 Thread Daniel P. Berrange
On Mon, Mar 03, 2014 at 04:46:51PM +0100, Claudio Bley wrote: > At Fri, 21 Feb 2014 11:01:47 +, > Daniel P. Berrange wrote: > > > > ACK, if you also add the virEventUpdateTimeout method > > OK, but why should I add it? It's useless (for the user) and unused by > the wrapping code. I want to

Re: [libvirt] [libvirt-java] [PATCH 36/65] jna: Wrap the virEvent(Add, Remove)Timeout libvirt functions

2014-03-03 Thread Claudio Bley
At Fri, 21 Feb 2014 11:01:47 +, Daniel P. Berrange wrote: > > ACK, if you also add the virEventUpdateTimeout method OK, but why should I add it? It's useless (for the user) and unused by the wrapping code. I want to keep the JNA library definition clean -- e.g. in a later patch I remove all

Re: [libvirt] [libvirt-java] [PATCH 45/65] events: handle registration of domain lifecycle events

2014-02-21 Thread Claudio Bley
At Fri, 21 Feb 2014 11:10:22 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:53PM +0100, Claudio Bley wrote: > > Add LifecycleListener interface which needs to be implemented > > when the user wishes to receive lifecycle change events on domains. > > > > The DomainEvent class r

Re: [libvirt] [libvirt-java] [PATCH 10/65] Fix wrapping of native size_t data type

2014-02-21 Thread Claudio Bley
At Fri, 21 Feb 2014 10:37:36 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:18PM +0100, Claudio Bley wrote: > > Libvirt function parameters having type (pointer to) size_t were > > wrapped via JNA using int, long or even NativeLong. Alas, none of > > these is actually correct a

Re: [libvirt] [libvirt-java] [PATCH 07/65] Ignore editor backup files

2014-02-21 Thread Claudio Bley
At Fri, 14 Feb 2014 11:06:12 +0100, Guido Günther wrote: > > On Thu, Feb 13, 2014 at 04:22:15PM +0100, Claudio Bley wrote: > > > > Signed-off-by: Claudio Bley > > --- > > .gitignore |2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/.gitignore b/.gitignore > > index b02fd55..2

Re: [libvirt] [libvirt-java] [PATCH 00/65]

2014-02-21 Thread Claudio Bley
At Fri, 21 Feb 2014 11:19:23 +, Daniel P. Berrange wrote: > > On Thu, Feb 13, 2014 at 04:22:08PM +0100, Claudio Bley wrote: > > Hi. > > > > Here are a few patches that piled up in my local branch. Some of them > > I already submitted to this list, but there has been no reponse to > > them. >

Re: [libvirt] [libvirt-java] [PATCH 21/65] Remove processError method from NetworkFilter class

2014-02-21 Thread Daniel P. Berrange
On Thu, Feb 13, 2014 at 04:22:29PM +0100, Claudio Bley wrote: > Wrap any fallible libvirt function in a call to > ErrorHandler.processError(..). > > Also correct wrong javadoc comments stating that methods would return > a value in case an error occurs. > > Signed-off-by: Claudio Bley > --- > s

Re: [libvirt] [libvirt-java] [PATCH 22/65] Remove processError method from Secret class

2014-02-21 Thread Daniel P. Berrange
On Thu, Feb 13, 2014 at 04:22:30PM +0100, Claudio Bley wrote: > Wrap any fallible libvirt function in a call to > ErrorHandler.processError(..). > > Also correct wrong javadoc comments stating that methods would return > a value in case an error occurs. > > Signed-off-by: Claudio Bley > --- > s

Re: [libvirt] [libvirt-java] [PATCH 00/65]

2014-02-21 Thread Daniel P. Berrange
On Thu, Feb 13, 2014 at 04:22:08PM +0100, Claudio Bley wrote: > Hi. > > Here are a few patches that piled up in my local branch. Some of them > I already submitted to this list, but there has been no reponse to > them. > > Included are a few trivial fixes as well as memory leak fixes and > additi

Re: [libvirt] [libvirt-java] [PATCH 65/65] Deprecate Connect.getHypervisorVersion

2014-02-21 Thread Daniel P. Berrange
On Thu, Feb 13, 2014 at 04:23:13PM +0100, Claudio Bley wrote: > In libvirt 0.9.3 this has been changed to simply return the libvirt > version number. > > Signed-off-by: Claudio Bley > --- > src/main/java/org/libvirt/Connect.java | 11 --- > 1 file changed, 8 insertions(+), 3 deletions(

Re: [libvirt] [libvirt-java] [PATCH 56/65] Implement Domain.PMwakeup

2014-02-21 Thread Daniel P. Berrange
On Thu, Feb 13, 2014 at 04:23:04PM +0100, Claudio Bley wrote: > This wraps the virDomainPMWakeup libvirt function available since > version 0.9.11. > > Signed-off-by: Claudio Bley > --- > src/main/java/org/libvirt/Domain.java| 27 > ++ > src/main/java/org/libvi

Re: [libvirt] [libvirt-java] [PATCH 51/65] Implement Domain.blockPeek

2014-02-21 Thread Daniel P. Berrange
On Thu, Feb 13, 2014 at 04:22:59PM +0100, Claudio Bley wrote: > This wraps the virDomainBlockPeek libvirt function, available since > version 0.4.5. > > Signed-off-by: Claudio Bley > --- > src/main/java/org/libvirt/Domain.java | 53 > > src/main/java/org/libv

Re: [libvirt] [libvirt-java] [PATCH 00/65]

2014-02-21 Thread Daniel P. Berrange
On Thu, Feb 13, 2014 at 04:22:08PM +0100, Claudio Bley wrote: > Hi. > > Here are a few patches that piled up in my local branch. Some of them > I already submitted to this list, but there has been no reponse to > them. > > Included are a few trivial fixes as well as memory leak fixes and > additi

Re: [libvirt] [libvirt-java] [PATCH 57/65] Implement Domain.sendKey

2014-02-21 Thread Daniel P. Berrange
On Thu, Feb 13, 2014 at 04:23:05PM +0100, Claudio Bley wrote: > This wraps the virDomainSendKey libvirt function available since version > 0.9.3. > > Signed-off-by: Claudio Bley > --- > src/main/java/org/libvirt/Domain.java | 12 > src/main/java/org/libvirt/KeycodeSet.java | 4

Re: [libvirt] [libvirt-java] [PATCH 61/65] Add helper for handling bit-flags

2014-02-21 Thread Daniel P. Berrange
On Thu, Feb 13, 2014 at 04:23:09PM +0100, Claudio Bley wrote: > > Signed-off-by: Claudio Bley > --- > src/main/java/org/libvirt/BitFlags.java | 18 ++ > 1 file changed, 18 insertions(+) > create mode 100644 src/main/java/org/libvirt/BitFlags.java ACK Regards, Daniel -- |: ht

Re: [libvirt] [libvirt-java] [PATCH 64/65] Replace static connectionVersion method with getLibVersion

2014-02-21 Thread Daniel P. Berrange
On Thu, Feb 13, 2014 at 04:23:12PM +0100, Claudio Bley wrote: > Since the libvirt version information is a property of an *instance* of a > connnection, the method to retrieve this information should not be static. > > Deprecate its use and recommend using aConnect.getLibVersion instead. > > Sign

Re: [libvirt] [libvirt-java] [PATCH 37/65] Implement Connect.isAlive

2014-02-21 Thread Daniel P. Berrange
On Thu, Feb 13, 2014 at 04:22:45PM +0100, Claudio Bley wrote: > This wraps the virConnectIsAlive libvirt function available since > version 0.9.8. > > Signed-off-by: Claudio Bley > --- > src/main/java/org/libvirt/Connect.java | 12 > src/main/java/org/libvirt/jna/Libvirt.

Re: [libvirt] [libvirt-java] [PATCH 63/65] Replace Connect.getLibVirVersion method with Library.getVersion

2014-02-21 Thread Daniel P. Berrange
On Thu, Feb 13, 2014 at 04:23:11PM +0100, Claudio Bley wrote: > It should not be necessary to create a Connect object in order to > determine the version of the libvirt library. > > Introduce Library.getVersion which returns this information. > > Deprecate Connect.getLibVirVersion but keep it for

Re: [libvirt] [libvirt-java] [PATCH 62/65] Connect: add constructors using java.net.URI params

2014-02-21 Thread Daniel P. Berrange
On Thu, Feb 13, 2014 at 04:23:10PM +0100, Claudio Bley wrote: > Additionally, add an OpenFlags enum to the Connect classes which > implements the BitFlags interface. > > This should be used when creating a read-only connection or > to prevent using URI aliases. > > Signed-off-by: Claudio Bley >

Re: [libvirt] [libvirt-java] [PATCH 54/65] Implement Domain.isUpdated

2014-02-21 Thread Daniel P. Berrange
On Thu, Feb 13, 2014 at 04:23:02PM +0100, Claudio Bley wrote: > This wraps the virDomainIsUpdated libvirt function available since version > 0.8.6. > > Signed-off-by: Claudio Bley > --- > src/main/java/org/libvirt/Domain.java |8 > src/main/java/org/libvirt/jna/Libvirt.java |

Re: [libvirt] [libvirt-java] [PATCH 47/65] events: handle registration for PMWakeup events

2014-02-21 Thread Daniel P. Berrange
On Thu, Feb 13, 2014 at 04:22:55PM +0100, Claudio Bley wrote: > > Signed-off-by: Claudio Bley > --- > src/main/java/org/libvirt/Connect.java | 57 > > src/main/java/org/libvirt/Domain.java | 20 +++ > .../java/org/libvirt/event/PMWakeupListe

Re: [libvirt] [libvirt-java] [PATCH 58/65] Implement interface ByteChannel for Stream class

2014-02-21 Thread Daniel P. Berrange
On Thu, Feb 13, 2014 at 04:23:06PM +0100, Claudio Bley wrote: > This makes the Stream class a native citizen of the Java API. > > It can be used with the NIO Channel API, as well as (In,Out)putStream's > using the java.nio.channels.Channels convenience wrappers. > > Signed-off-by: Claudio Bley >

Re: [libvirt] [libvirt-java] [PATCH 42/65] Add constructIncRef factory method to Domain class

2014-02-21 Thread Daniel P. Berrange
On Thu, Feb 13, 2014 at 04:22:50PM +0100, Claudio Bley wrote: > This method constructs a new Domain class instance while > increasing the reference count on the virDomainPtr in > order to make sure the Domain object "owns" the given > virDomainPtr. > > Signed-off-by: Claudio Bley > --- > src/mai

Re: [libvirt] [libvirt-java] [PATCH 60/65] test: add testDomainScreenshot JUnit test

2014-02-21 Thread Daniel P. Berrange
On Thu, Feb 13, 2014 at 04:23:08PM +0100, Claudio Bley wrote: > > Signed-off-by: Claudio Bley > --- > src/test/java/org/libvirt/TestJavaBindings.java | 44 > +++ > 1 file changed, 44 insertions(+) ACK Regards, Daniel -- |: http://berrange.com -o-http://www.flic

Re: [libvirt] [libvirt-java] [PATCH 59/65] Implement Domain.screenshot

2014-02-21 Thread Daniel P. Berrange
On Thu, Feb 13, 2014 at 04:23:07PM +0100, Claudio Bley wrote: > This wraps the native virDomainScreenshot libvirt function available > since version 0.9.2. > > Signed-off-by: Claudio Bley > --- > src/main/java/org/libvirt/Domain.java | 10 ++ > src/main/java/org/libvirt/Stream.jav

Re: [libvirt] [libvirt-java] [PATCH 55/65] Implement Domain.reset

2014-02-21 Thread Daniel P. Berrange
On Thu, Feb 13, 2014 at 04:23:03PM +0100, Claudio Bley wrote: > This wraps the virDomainReset libvirt function available since > version 0.9.7. > > Signed-off-by: Claudio Bley > --- > src/main/java/org/libvirt/Domain.java |7 +++ > src/main/java/org/libvirt/jna/Libvirt.java |1 +

Re: [libvirt] [libvirt-java] [PATCH 52/65] Implement Domain.memoryPeek

2014-02-21 Thread Daniel P. Berrange
On Thu, Feb 13, 2014 at 04:23:00PM +0100, Claudio Bley wrote: > This wraps the virDomainMemoryPeek libvirt function, available since > version 0.4.5. > > Signed-off-by: Claudio Bley > --- > src/main/java/org/libvirt/Domain.java| 40 > ++ > src/main/java/org/lib

Re: [libvirt] [libvirt-java] [PATCH 50/65] Implement Connect.getSysinfo

2014-02-21 Thread Daniel P. Berrange
On Thu, Feb 13, 2014 at 04:22:58PM +0100, Claudio Bley wrote: > This wraps the virConnectGetSysinfo function available since libvirt > version 0.8.8. > > Signed-off-by: Claudio Bley > --- > src/main/java/org/libvirt/Connect.java | 21 + > src/main/java/org/libvirt/jna/L

Re: [libvirt] [libvirt-java] [PATCH 53/65] Implement Secret.getUsageType

2014-02-21 Thread Daniel P. Berrange
On Thu, Feb 13, 2014 at 04:23:01PM +0100, Claudio Bley wrote: > This wraps the virSecretGetUsageType libvirt function available since > version 0.7.1. > > Signed-off-by: Claudio Bley > --- > src/main/java/org/libvirt/Secret.java |5 + > src/main/java/org/libvirt/SecretUsageType.

Re: [libvirt] [libvirt-java] [PATCH 48/65] events: add support for PMSuspend events

2014-02-21 Thread Daniel P. Berrange
On Thu, Feb 13, 2014 at 04:22:56PM +0100, Claudio Bley wrote: > > Signed-off-by: Claudio Bley > --- > src/main/java/org/libvirt/Connect.java | 59 > > src/main/java/org/libvirt/Domain.java | 20 +++ > .../java/org/libvirt/event/PMSuspendList

Re: [libvirt] [libvirt-java] [PATCH 39/65] Introduce event loop support

2014-02-21 Thread Daniel P. Berrange
On Thu, Feb 13, 2014 at 04:22:47PM +0100, Claudio Bley wrote: > Add initEventLoop(), processEvent(), runEventLoop() and stopEventLoop() > static methods to the Library class. > > Signed-off-by: Claudio Bley > --- > src/main/java/org/libvirt/Library.java | 91 >

Re: [libvirt] [libvirt-java] [PATCH 45/65] events: handle registration of domain lifecycle events

2014-02-21 Thread Daniel P. Berrange
On Thu, Feb 13, 2014 at 04:22:53PM +0100, Claudio Bley wrote: > Add LifecycleListener interface which needs to be implemented > when the user wishes to receive lifecycle change events on domains. > > The DomainEvent class represents the kind of event that > occurred including details on that event

Re: [libvirt] [libvirt-java] [PATCH 46/65] test: add unit test for domain lifecycle events

2014-02-21 Thread Daniel P. Berrange
On Thu, Feb 13, 2014 at 04:22:54PM +0100, Claudio Bley wrote: > Signed-off-by: Claudio Bley > --- > src/test/java/org/libvirt/TestJavaBindings.java | 69 > +++ > 1 file changed, 69 insertions(+) ACK Regards, Daniel -- |: http://berrange.com -o-http://www.flickr.c

Re: [libvirt] [libvirt-java] [PATCH 49/65] Implement connection close callback support

2014-02-21 Thread Daniel P. Berrange
On Thu, Feb 13, 2014 at 04:22:57PM +0100, Claudio Bley wrote: > There can only be a single connection close listener registered > per connection object. > > Signed-off-by: Claudio Bley > --- > src/main/java/org/libvirt/Connect.java | 57 > > src/main/java/org/

Re: [libvirt] [libvirt-java] [PATCH 34/65] Fix memleak in StorageVol.getPath

2014-02-21 Thread Daniel P. Berrange
On Thu, Feb 13, 2014 at 04:22:42PM +0100, Claudio Bley wrote: > > Signed-off-by: Claudio Bley > --- > src/main/java/org/libvirt/StorageVol.java | 10 +- > src/main/java/org/libvirt/jna/Libvirt.java |2 +- > 2 files changed, 10 insertions(+), 2 deletions(-) ACK Regards, Daniel --

Re: [libvirt] [libvirt-java] [PATCH 44/65] events: handle registration for Reboot events

2014-02-21 Thread Daniel P. Berrange
On Thu, Feb 13, 2014 at 04:22:52PM +0100, Claudio Bley wrote: > Add RebootListener interface in package org.libvirt.event and > implement addRebootListener methods in classes Domain and Connect. > > Add removeRebootListener to Connect class. > > Signed-off-by: Claudio Bley > --- > src/main/java

Re: [libvirt] [libvirt-java] [PATCH 43/65] events: handle registration for IOError events

2014-02-21 Thread Daniel P. Berrange
On Thu, Feb 13, 2014 at 04:22:51PM +0100, Claudio Bley wrote: > Add IOErrorActionListener and IOErrorAction enum which is handed to the > onIOError callback method when an IO error event occurs. > > Signed-off-by: Claudio Bley > --- > src/main/java/org/libvirt/Connect.java | 59 >

Re: [libvirt] [libvirt-java] [PATCH 41/65] Prepare to define proper domain event callback support

2014-02-21 Thread Daniel P. Berrange
On Thu, Feb 13, 2014 at 04:22:49PM +0100, Claudio Bley wrote: > Remove the public domainEventRegisterAny and domainEventDeregisterAny > methods. These methods basically were of no use since the only thing you > could register was a "generic" callback. > > At runtime, you would have to provide a re

Re: [libvirt] [libvirt-java] [PATCH 36/65] jna: Wrap the virEvent(Add, Remove)Timeout libvirt functions

2014-02-21 Thread Daniel P. Berrange
On Thu, Feb 13, 2014 at 04:22:44PM +0100, Claudio Bley wrote: > These functions are not (yet) exposed in the public org.libvirt > package but only used internally. > > Signed-off-by: Claudio Bley > --- > src/main/java/org/libvirt/jna/Libvirt.java | 11 +++ > 1 file changed, 11 insertio

Re: [libvirt] [libvirt-java] [PATCH 33/65] Fix memleak in DomainSnapshot.getXMLDesc

2014-02-21 Thread Daniel P. Berrange
On Thu, Feb 13, 2014 at 04:22:41PM +0100, Claudio Bley wrote: > > Signed-off-by: Claudio Bley > --- > src/main/java/org/libvirt/DomainSnapshot.java | 10 +- > src/main/java/org/libvirt/jna/Libvirt.java|2 +- > 2 files changed, 10 insertions(+), 2 deletions(-) ACK Regards, Dan

Re: [libvirt] [libvirt-java] [PATCH 40/65] Add constants for enum virDomainEventID

2014-02-21 Thread Daniel P. Berrange
On Thu, Feb 13, 2014 at 04:22:48PM +0100, Claudio Bley wrote: > Note: these are only used internally. > > Signed-off-by: Claudio Bley > --- > src/main/java/org/libvirt/Connect.java | 20 > 1 file changed, 20 insertions(+) ACK Regards, Daniel -- |: http://berrange.com

Re: [libvirt] [libvirt-java] [PATCH 38/65] Implement Connect.setKeepAlive

2014-02-21 Thread Daniel P. Berrange
On Thu, Feb 13, 2014 at 04:22:46PM +0100, Claudio Bley wrote: > This wraps the virConnectSetKeepAlive libvirt function available since > version 0.9.8. > > Signed-off-by: Claudio Bley > --- > src/main/java/org/libvirt/Connect.java | 34 > > src/main/java/org/l

Re: [libvirt] [libvirt-java] [PATCH 31/65] Fix memleak in Domain.snapshotListNames

2014-02-21 Thread Daniel P. Berrange
On Thu, Feb 13, 2014 at 04:22:39PM +0100, Claudio Bley wrote: > We need to free the char* entries of the result array returned ourselves. > > Signed-off-by: Claudio Bley > --- > src/main/java/org/libvirt/Domain.java | 14 +++--- > src/main/java/org/libvirt/jna/Libvirt.java |2

  1   2   3   >