Re: [libvirt PATCH 1/4] PCI VPD: handle additional edge cases

2021-10-27 Thread Dmitrii Shcherbakov
Daniel, > The issue I have is that 'lspci -vvv' will happily report the VPD > data on my machine: > > ... > > while libvirt refuses to report it. Even if the BIOS is not perfectly > following the spec, it is clearly still possible to extract the data > and display it to the user. So I don't think

Re: [libvirt PATCH 1/4] PCI VPD: handle additional edge cases

2021-10-27 Thread Daniel P . Berrangé
On Tue, Oct 26, 2021 at 08:28:20PM +0300, Dmitrii Shcherbakov wrote: > Hi Daniel, > > > Something is still not right with the logic here as this error report > is triggering on my machines. If I comment out this check, then I can > get data reported by libvirt > > The VPD example you shared

Re: [libvirt PATCH 1/4] PCI VPD: handle additional edge cases

2021-10-26 Thread Dmitrii Shcherbakov
Hi Daniel, > Something is still not right with the logic here as this error report is triggering on my machines. If I comment out this check, then I can get data reported by libvirt The VPD example you shared previously has multiple violations of the VPD format: * Invalid field values ("N/A" in

Re: [libvirt PATCH 1/4] PCI VPD: handle additional edge cases

2021-10-26 Thread Daniel P . Berrangé
On Fri, Oct 22, 2021 at 03:45:42PM +0300, Dmitrii Shcherbakov wrote: > * RV and RW fields must be at the last position in their respective > section (per the conditions in the spec). Therefore, the parser now > stops iterating over fields as soon as it encounters one of those > fields and

[libvirt PATCH 1/4] PCI VPD: handle additional edge cases

2021-10-22 Thread Dmitrii Shcherbakov
* RV and RW fields must be at the last position in their respective section (per the conditions in the spec). Therefore, the parser now stops iterating over fields as soon as it encounters one of those fields and checks whether the end of the resource has been reached; * Individual fields