On Mon, Oct 31, 2011 at 05:51:55PM +0800, Daniel Veillard wrote:
We are now entering the freeze for libvirt-0.9.7 .
We may make an exception for patch set which got a few round of reviews
though, like Stefan's ones (v4 IIRC), and anything which we know may
need fixing in the API before the
On Wed, Nov 02, 2011 at 02:19:07PM -0600, Eric Blake wrote:
On 11/02/2011 12:57 PM, Guido Günther wrote:
Built fine on most Debian architectures:
https://buildd.debian.org/status/package.php?p=libvirtsuite=experimental
The built failure on amd64 is due to virnetsockettest failing
---
src/rpc/virnetsocket.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/src/rpc/virnetsocket.c b/src/rpc/virnetsocket.c
index ab88e19..d832c53 100644
--- a/src/rpc/virnetsocket.c
+++ b/src/rpc/virnetsocket.c
@@ -327,7 +327,8 @@ int virNetSocketNewListenUNIX(const
to avoid exceeding UNIX_PATH_MAX
---
tests/virnetsockettest.c | 60 ++---
1 files changed, 40 insertions(+), 20 deletions(-)
diff --git a/tests/virnetsockettest.c b/tests/virnetsockettest.c
index 6320ce0..aeb4f3f 100644
--- a/tests/virnetsockettest.c
+++
On Wed, Nov 02, 2011 at 03:35:05PM -0600, Eric Blake wrote:
On 11/02/2011 03:30 PM, Guido Günther wrote:
---
src/rpc/virnetsocket.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/src/rpc/virnetsocket.c b/src/rpc/virnetsocket.c
index ab88e19..d832c53 100644
On Wed, Nov 02, 2011 at 03:39:54PM -0600, Eric Blake wrote:
On 11/02/2011 03:31 PM, Guido Günther wrote:
to avoid exceeding UNIX_PATH_MAX
---
tests/virnetsockettest.c | 60
++---
1 files changed, 40 insertions(+), 20 deletions(-)
I like
On Wed, Nov 02, 2011 at 04:28:54PM -0600, Eric Blake wrote:
On 11/02/2011 04:00 PM, Guido Günther wrote:
+template = strdup(/tmp/libvirt_XX);
No need to malloc() the template. Just do:
char template[] = /tmp/libvirt_XX;
This was actually the first version I had
On Thu, Nov 03, 2011 at 06:19:25PM +0800, Daniel Veillard wrote:
Thanks to everybody who provided feedback and patches on rc1,
I have made an rc2 available at
ftp://libvirt.org/libvirt/libvirt-0.9.7-rc2.tar.gz
there is also the rpms rebuilds for Fedora 14.
Builds fine now on Debian:
Hi,
if I'm reading this test correctly it's supposed to fail without a
security model at work.
The file images are always readable/writeable to the libvirt user and
group without one.
Cheers,
-- Guido
---
scripts/qemu/205-qcow2-double-backing-file.t |9 +++--
1 files changed, 7
On Mon, Nov 07, 2011 at 10:00:25AM +, Daniel P. Berrange wrote:
On Sun, Nov 06, 2011 at 04:30:02PM +0100, Guido Günther wrote:
Hi,
if I'm reading this test correctly it's supposed to fail without a
security model at work.
The file images are always readable/writeable to the libvirt
Hi Daniel,
On Mon, Nov 07, 2011 at 09:56:39AM +, Daniel P. Berrange wrote:
On Sat, Nov 05, 2011 at 02:41:41PM +0100, Guido Günther wrote:
Hi,
when running libvirt-tck I'm seeing this test failure:
# Failed test 'deleted pool'
# at /usr/share/libvirt-tck/tests/storage/110-disk
Hi Daniel,
On Thu, Jul 07, 2011 at 03:17:24PM +0100, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
This patch adds support for a systemd init service for libvirtd
and libvirt-guests. The libvirtd.service is *not* written to use
socket activation, since we want
which would blow away all volumes. Honor VIR_STORAGE_POOL_BUILD_OVERWRITE
to force a rebuild.
This was caught by libvirt-tck's storage/110-disk-pool.t.
Cheers,
-- Guido
---
src/storage/storage_backend_disk.c | 72 ++--
1 files changed, 68 insertions(+), 4
On Mon, Nov 14, 2011 at 12:58:08PM +0800, Osier Yang wrote:
于 2011年11月13日 00:19, Guido Günther 写道:
which would blow away all volumes. Honor VIR_STORAGE_POOL_BUILD_OVERWRITE
to force a rebuild.
This was caught by libvirt-tck's storage/110-disk-pool.t.
Cheers,
-- Guido
---
src
Hi,
attached patch makes the example work again with recent pygobject-3.0
which doesn't allow to import gtk anymore.
Cheers,
-- Guido
On Thu, Nov 17, 2011 at 10:36:23PM +0100, Guido Günther wrote:
---
examples/event-test.py |7 +++
1 files changed, 3 insertions(+), 4 deletions
On Fri, Nov 18, 2011 at 10:00:52AM +, Daniel P. Berrange wrote:
On Thu, Nov 17, 2011 at 10:38:01PM +0100, Guido Günther wrote:
Hi,
attached patch makes the example work again with recent pygobject-3.0
which doesn't allow to import gtk anymore.
Cheers,
ACK
Pushed. Thanks,
-- Guido
Fix crash on daemon strdup in that case.
udev_device_get_devpath returs NULL for
'/sys/devices/virtual/block/dm-*' devices. In that case the later strdup
segfaults. O.k. to apply?
19:12:46.319: info : udevGetDeviceProperty:111 : udev reports device 'dm-0'
does not have property 'DRIVER'
On Mon, Dec 07, 2009 at 03:16:32PM -0500, Cole Robinson wrote:
On 12/07/2009 01:15 PM, Guido Günther wrote:
Fix crash on daemon strdup in that case.
udev_device_get_devpath returs NULL for
'/sys/devices/virtual/block/dm-*' devices. In that case the later strdup
segfaults. O.k. to apply
Hi,
attached patch looks for the DMI information in /sys/class since older
kernels (e.g. 2.6.26) have it there.
Cheers,
-- Guido
From: =?UTF-8?q?Guido=20G=C3=BCnther?= a...@sigxcpu.org
Date: Thu, 7 Jan 2010 10:13:51 +0100
Subject: [PATCH] Also look for dmi information in /sys/class
older kernels
On Fri, Jan 08, 2010 at 11:50:17AM +0100, Daniel Veillard wrote:
Looks safe to me, assuming the kernel information are exported in the
same way,
Yes, it seems to be the same. Pushed now.
Cheers,
-- Guido
--
Libvir-list mailing list
Libvir-list@redhat.com
On Mon, Jan 11, 2010 at 04:15:45PM -0500, Dave Allan wrote:
On 01/11/2010 06:53 AM, Guido Günther wrote:
On Fri, Jan 08, 2010 at 11:50:17AM +0100, Daniel Veillard wrote:
Looks safe to me, assuming the kernel information are exported in the
same way,
Yes, it seems to be the same. Pushed
On Sat, Jan 16, 2010 at 06:24:28PM +0100, Marc Haber wrote:
Hi,
On Fri, Jan 15, 2010 at 03:13:25PM +0100, Marc Haber wrote:
$ dpkg --list *kvm*
Desired=Unknown/Install/Remove/Purge/Hold
|
Status=Not/Inst/Cfg-files/Unpacked/Failed-cfg/Half-inst/trig-aWait/Trig-pend
|/
On Sun, Jan 17, 2010 at 01:27:21PM +0100, Matthias Bolte wrote:
2010/1/17 Guido Günther a...@sigxcpu.org:
On Sat, Jan 16, 2010 at 06:24:28PM +0100, Marc Haber wrote:
Hi,
On Fri, Jan 15, 2010 at 03:13:25PM +0100, Marc Haber wrote:
$ dpkg --list *kvm*
Desired=Unknown/Install/Remove
Hi,
Debian's (and therefore likely the derivatives') kernel headers are
lacking the typdef for sa_family_t in linux/socket.h so the
compilation of the macvtap check fails. Additionally including
sockaddr.h fixes this and doesn't hurt the other cases where there's
also a typedef in socket.h since
Hi Matthias,
On Mon, Mar 08, 2010 at 08:28:07PM +0100, Matthias Bolte wrote:
2010/3/8 Dimitris Kalogeras d.kaloge...@noc.ntua.gr:
Hi *,
Apologies for cross posting.
I have installed the the libvirt and virt-toolss in an ubuntu karmic
9.10. I am trying to access-manage an ESX 3.5i via
Hi,
virsh dominfo domain crashes with:
#0 strlen () at ../sysdeps/i386/i486/strlen.S:69
#1 0x080891c9 in qemudNodeGetSecurityModel (conn=0x8133940,
secmodel=0xb5676ede) at qemu/qemu_driver.c:4911
#2 0xb7eb5623 in virNodeGetSecurityModel (conn=0x8133940, secmodel=0x0) at
libvirt.c:5118
#3
Hi,
kvm 72 uses info migration instead of info migrate:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=574272
It's not only that, the output format of these commands differs too so
that virsh save breaks. Stefan suggested the attached improved error
message.
Cheers,
-- Guido
From
On Fri, Mar 19, 2010 at 06:19:02PM +0100, Guido Günther wrote:
Hi,
kvm 72 uses info migration instead of info migrate:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=574272
It's not only that, the output format of these commands differs too so
that virsh save breaks. Stefan suggested
On Fri, Mar 19, 2010 at 04:21:43PM -0400, Ric Foster wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=526913
Will this bug get fixed? I had hoped the using CLVM would keep the
guest disk image from getting corrupted if a running guest was
inadvertently started on another cluster
On Thu, Mar 18, 2010 at 02:48:46PM +0100, Daniel Veillard wrote:
On Wed, Mar 17, 2010 at 09:11:07PM +0100, Guido Günther wrote:
Hi,
virsh dominfo domain crashes with:
#0 strlen () at ../sysdeps/i386/i486/strlen.S:69
#1 0x080891c9 in qemudNodeGetSecurityModel (conn=0x8133940
Hi,
I just ran across these oddities when using a bit more libvirt+xen:
1.) virsh setmaxmem:
On a running domain:
# virsh setmaxmem domain 256000
completes but virsh dumpxml as well as the config.sxp still shows the
old amount of memory. Looks as the set_maxmem hypercall simply gets
Hi,
libvirt_sym.version is looked for at the wrong location. O.k. to apply?
Cheers,
-- Guido
From df2b33ae4a865b0039899297c4fbda066c6be638 Mon Sep 17 00:00:00 2001
From: =?utf-8?q?Guido=20G=C3=BCnther?= [EMAIL PROTECTED]
Date: Mon, 24 Nov 2008 14:49:47 +0100
Subject: [PATCH] look for
On Mon, Nov 24, 2008 at 01:56:29PM +, Daniel P. Berrange wrote:
On Mon, Nov 24, 2008 at 02:52:50PM +0100, Guido G?nther wrote:
Hi,
libvirt_sym.version is looked for at the wrong location. O.k. to apply?
Ah yes, forgot to change this. Go ahead.
Applied.
-- Guido
--
Libvir-list mailing
Finally got around to have another look at qemu/kvm surviving libvirt
restarts:
On Tue, Oct 07, 2008 at 05:37:52PM +0100, Daniel P. Berrange wrote:
diff --git a/src/domain_conf.h b/src/domain_conf.h
index 632e5ad..1ac1561 100644
--- a/src/domain_conf.h
+++ b/src/domain_conf.h
@@ -448,6
On Tue, Nov 25, 2008 at 04:32:00PM -0800, Bryan McLellan wrote:
Is there a way to configure libvirt to cache the serial console on the
host so the buffer on the guest does not fill up when you aren't
connected to the console, or should I disable the serial console?
As Daniel pointed out this is
On Tue, Nov 25, 2008 at 11:39:57AM +, Daniel P. Berrange wrote:
On Fri, Nov 21, 2008 at 11:13:04PM +0100, Guido G?nther wrote:
Hi,
I just ran across these oddities when using a bit more libvirt+xen:
1.) virsh setmaxmem:
On a running domain:
# virsh setmaxmem domain
On Wed, Nov 26, 2008 at 05:08:49PM +0100, Chris Lalancette wrote:
+AC_PATH_PROG([UDEVSETTLE], [udevsettle], [udevsettle],
+ [/sbin:/usr/sbin:/usr/local/sbin:$PATH])
As far as I understand things as of udev 117 udevsettle is deprecated in
favour of udevadm settle. So it's probably better to
On Tue, Nov 25, 2008 at 11:39:57AM +, Daniel P. Berrange wrote:
Yeha, this is almost certainly just another example of XenD not properly
cleaning up / destroying domains. If you still have a machine which
shows this behaviour, then I'd recommend trying this change to our Xen
impl
In
On Thu, Nov 27, 2008 at 04:07:48PM +, Daniel P. Berrange wrote:
On Thu, Nov 27, 2008 at 05:04:05PM +0100, Guido G?nther wrote:
On Tue, Nov 25, 2008 at 11:39:57AM +, Daniel P. Berrange wrote:
Yeha, this is almost certainly just another example of XenD not properly
cleaning up /
On Wed, Nov 26, 2008 at 08:54:40PM +, Daniel P. Berrange wrote:
[..snip..]
Hmm, interesting idea - we already have a variant for parsing based
off an arbitrary XML node, rather than assuming the root,
virDomainDefPtr virDomainDefParseNode(virConnectPtr conn,
On Mon, Dec 01, 2008 at 03:31:55PM +0100, Mickaël Canévet wrote:
In other (debian) words, will an apt-get update kvm -t
experimental (which provides kvm-79) be enough on my lenny (I would
like to limit unstable or experimental packages) ?
experimental also has kvm-source, you can build new
On Sun, Nov 30, 2008 at 12:43:48PM +0100, Guido Günther wrote:
From 87db4a698ed9b49294c0f94137fc6beef13bd4e8 Mon Sep 17 00:00:00 2001
From: =?utf-8?q?Guido=20G=C3=BCnther?= [EMAIL PROTECTED]
Date: Tue, 25 Nov 2008 13:02:43 +0100
Subject: [PATCH] differentiate between active and inactive
On Wed, Dec 03, 2008 at 04:38:10PM +0100, Daniel Veillard wrote:
On Tue, Dec 02, 2008 at 10:22:28PM +0100, Guido Günther wrote:
We do so in qemudCapsInitGuest() but not in qemudProbe(). O.k. to apply?
-- Guido
Looks fine to me !
Applied now.
-- Guido
--
Libvir-list mailing list
On Thu, Dec 04, 2008 at 10:56:25AM +, Daniel P. Berrange wrote:
On Wed, Dec 03, 2008 at 06:20:12PM +0100, Guido G?nther wrote:
On Sun, Nov 30, 2008 at 12:43:48PM +0100, Guido Günther wrote:
From 87db4a698ed9b49294c0f94137fc6beef13bd4e8 Mon Sep 17 00:00:00 2001
From: =?utf-8?q?Guido
Hi,
attached patch is from Debian Bug #507553:
The logfile is opened with O_APPEND (to make logrotate work with
copytruncate) and without O_TRUNC (to not lose log information e.g. with
stop and start of a VM).
Using collectd or munin to monitor VMs creates quiet a bit of qemu
monitor output so
On Thu, Dec 04, 2008 at 01:26:40PM +, Daniel P. Berrange wrote:
On Thu, Dec 04, 2008 at 02:11:07PM +0100, Guido G?nther wrote:
Hi,
attached patch is from Debian Bug #507553:
The logfile is opened with O_APPEND (to make logrotate work with
copytruncate) and without O_TRUNC (to not
On Fri, Dec 05, 2008 at 02:20:08PM +0100, Daniel Veillard wrote:
On Thu, Dec 04, 2008 at 05:44:30PM +0100, Guido Günther wrote:
On Thu, Dec 04, 2008 at 01:26:40PM +, Daniel P. Berrange wrote:
On Thu, Dec 04, 2008 at 02:11:07PM +0100, Guido G?nther wrote:
Hi,
attached patch
Hi,
as to my understanding we should pass 'server' instead of 'listen' to
forward virtual serial ports via unix domain sockets or tcp. See:
http://bellard.org/qemu/qemu-doc.html
I also added nowait to tcp,unix and telnet since otherwise qemu/kvm
would wait for a connection before proceeding
Hi,
look for devhelp.xsl in $(srcdir).
Patch attached,
-- Guido
From d32b09c1d3f758e54d7a9f9ed843839ca51319a5 Mon Sep 17 00:00:00 2001
From: =?utf-8?q?Guido=20G=C3=BCnther?= [EMAIL PROTECTED]
Date: Thu, 11 Dec 2008 14:25:26 +0100
Subject: [PATCH] fix devhelp build in separate build dir
---
Hi,
attached is a new version of the let kvm/qemu survive libvirt restart
patches. Since we have the VIR_DOMAIN_XML_INACTIVE changes already
applied we now only need to persist the monitor path, pid and current
domain state (running, paused, ...).
Cheers,
-- Guido
Pathes:
write pid file into
This patch does the actual saving and removal of the vm status. It does
so only at vm creation time at the moment. We need to update the config
every time the life config changes later.
---
src/qemu_driver.c | 46 ++
1 files changed, 46
The earlier patches didn't change libvirtd behaviour (except for
kvm/qemu not being teared down on an unexpected daemon crash), all vms
were still being shutoff at daemon shutdown. This patch now adds the
code to read back the vm status after on daemon startup and reconnects
all running vms found
On Fri, Dec 12, 2008 at 08:42:10PM +0100, Jim Meyering wrote:
Guido Günther a...@sigxcpu.org wrote:
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-hostdev-usb-address.args
b/tests/qemuxml2argvdata/qemuxml2argv-hostdev-usb-address.args
index 3d6c16d..e1c5638 100644
--- a/tests
On Fri, Dec 12, 2008 at 08:30:26PM +, Daniel P. Berrange wrote:
This is crying out for us to write a virASprintf() that explicitly
always sets path = NULL upon failure. And then blacklist 'asprintf'
in make syntax-check.
Possible virAsprintf attached. I've already moved the posted patch
On Mon, Dec 15, 2008 at 11:23:15AM +, Daniel P. Berrange wrote:
On Fri, Dec 12, 2008 at 11:21:09PM +0100, Guido G?nther wrote:
On Fri, Dec 12, 2008 at 08:30:26PM +, Daniel P. Berrange wrote:
This is crying out for us to write a virASprintf() that explicitly
always sets path = NULL
On Mon, Dec 15, 2008 at 05:48:25PM +0100, Gerd v. Egidy wrote:
Hi Guido,
This patch does the actual saving and removal of the vm status. It does
so only at vm creation time at the moment. We need to update the config
every time the life config changes later.
sorry for asking such dumb
On Mon, Dec 15, 2008 at 11:58:06AM -0800, john.le...@sun.com wrote:
diff --git a/src/domain_conf.h b/src/domain_conf.h
--- a/src/domain_conf.h
+++ b/src/domain_conf.h
@@ -307,12 +307,13 @@ struct _virDomainHostdevDef {
unsigned slot;
unsigned
On Sat, Dec 13, 2008 at 04:52:10PM +, Daniel P. Berrange wrote:
On Sat, Dec 13, 2008 at 12:23:30AM +0100, Guido G?nther wrote:
Hi,
Makefile.maint assumes this in some places. This doesn't make the world
perfect but maybe a bit better?
Seems reasonable to me.
Applied now.
-- Guido
On Wed, Dec 17, 2008 at 03:18:16PM +0100, Jim Meyering wrote:
Daniel P. Berrange berra...@redhat.com wrote:
On Sat, Dec 13, 2008 at 12:23:30AM +0100, Guido G?nther wrote:
Hi,
Makefile.maint assumes this in some places. This doesn't make the world
perfect but maybe a bit better?
On Wed, Dec 17, 2008 at 03:31:45PM +0100, Jim Meyering wrote:
Guido Günther a...@sigxcpu.org wrote:
Makefile.maint assumes this in some places. This doesn't make the world
perfect but maybe a bit better?
Um, not really, since a pathological $(abs_srcdir) may contain ; rm -rf /;
Best
Hi,
due to some restructuring we free the device structure so devices are
plugged correctly but dumpxml fails since the dev structure is already
freed.
Cheers,
-- Guido
From ba61f99ed3449cf2fbe44a994bd245425ec6087d Mon Sep 17 00:00:00 2001
From: =?utf-8?q?Guido=20G=C3=BCnther?= a...@sigxcpu.org
On Mon, Dec 15, 2008 at 07:09:10PM +, Daniel P. Berrange wrote:
[..snip..]
I skipped this since -pidfile got introduced 2004 already with:
Opps, my mistake - it was -daemon that was added in 0.9.0, not -pidfile
svn://svn.savannah.nongnu.org/qemu/tr...@1166
Do we really support
On Mon, Dec 15, 2008 at 10:25:27AM +0100, Daniel Veillard wrote:
On Fri, Dec 12, 2008 at 07:26:51PM +0100, Guido Günther wrote:
Functions to read and write vm status in $(statedir)/qemu/domain.xml.
Keeps the necessary to reconnect to a running domain state within
domstate.../domstate. I
On Mon, Dec 15, 2008 at 11:22:52AM +, Daniel P. Berrange wrote:
On Fri, Dec 12, 2008 at 07:27:08PM +0100, Guido G?nther wrote:
This patch does the actual saving and removal of the vm status. It does
so only at vm creation time at the moment. We need to update the config
every time the
On Thu, Dec 18, 2008 at 10:51:04AM +, Daniel P. Berrange wrote:
On Thu, Dec 18, 2008 at 10:26:07AM +0100, Guido G?nther wrote:
Hi,
due to some restructuring we free the device structure so devices are
plugged correctly but dumpxml fails since the dev structure is already
This is a
Hi,
some checks compare to the english error messages:
--- out 2008-12-18 15:36:44.0 +0100
+++ exp 2008-12-18 15:36:44.0 +0100
@@ -1,3 +1,3 @@
-libvir: Domain Config Fehler : failed Xen syscall Topologie-Syntaxfehler beim
Cpuset
-Fehler: Fehler beim Definieren einer Domain von
On Thu, Dec 18, 2008 at 10:23:39AM +, Daniel P. Berrange wrote:
No, not guarenteed to be safe because the 'config_xml' string could
contain '%' sequences that'll be interpreted by sprintf. In any case
why not just use
virBufferAdd(buf, config_xml)
Updated version using virBufferAdd
On Thu, Dec 18, 2008 at 10:24:57AM +, Daniel P. Berrange wrote:
On Thu, Dec 18, 2008 at 10:31:35AM +0100, Guido G?nther wrote:
On Mon, Dec 15, 2008 at 07:09:10PM +, Daniel P. Berrange wrote:
[..snip..]
I skipped this since -pidfile got introduced 2004 already with:
Opps,
On Thu, Dec 18, 2008 at 05:35:28PM +0100, Daniel Veillard wrote:
On Thu, Dec 18, 2008 at 03:45:04PM +0100, Guido Günther wrote:
On Thu, Dec 18, 2008 at 10:51:04AM +, Daniel P. Berrange wrote:
On Thu, Dec 18, 2008 at 10:26:07AM +0100, Guido G?nther wrote:
Hi,
due to some
On Thu, Dec 18, 2008 at 03:53:17PM +0100, Guido Günther wrote:
On Thu, Dec 18, 2008 at 10:23:39AM +, Daniel P. Berrange wrote:
No, not guarenteed to be safe because the 'config_xml' string could
contain '%' sequences that'll be interpreted by sprintf. In any case
why not just use
On Thu, Dec 18, 2008 at 10:26:15AM +, Daniel P. Berrange wrote:
On Thu, Dec 18, 2008 at 10:37:55AM +0100, Guido G?nther wrote:
On Mon, Dec 15, 2008 at 11:22:52AM +, Daniel P. Berrange wrote:
On Fri, Dec 12, 2008 at 07:27:08PM +0100, Guido G?nther wrote:
This patch does the actual
Hi,
please find a possible asprintf vs. virAsprintf cleanup attached. There
were several occations where the result of a failed asprintf was used.
Cheers,
-- Guido
diff --git a/.x-sc_prohibit_asprintf b/.x-sc_prohibit_asprintf
new file mode 100644
index 000..614c238
--- /dev/null
+++
On Sat, Dec 20, 2008 at 04:30:30PM +0100, Jim Meyering wrote:
Guido Günther a...@sigxcpu.org wrote:
some checks compare to the english error messages:
...
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 87e4235..5290606 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
Hi,
new version attached. It adds your suggestions and also uses virAsprintf
in the new src/logging.c.
-- Guido
diff --git a/.x-sc_prohibit_asprintf b/.x-sc_prohibit_asprintf
new file mode 100644
index 000..614c238
--- /dev/null
+++ b/.x-sc_prohibit_asprintf
@@ -0,0 +1,3 @@
+^gnulib/
+^po/
Hi,
possible patch attached.
-- Guido
From e991a8740a5777d779fb8df0b4b2514a9878b464 Mon Sep 17 00:00:00 2001
From: =?utf-8?q?Guido=20G=C3=BCnther?= a...@sigxcpu.org
Date: Mon, 22 Dec 2008 23:23:57 +0100
Subject: [PATCH] document vnc's keymap parameter
---
docs/drvqemu.html.in |2 +-
On Tue, Dec 23, 2008 at 10:45:57AM +0100, Jim Meyering wrote:
Guido Günther a...@sigxcpu.org wrote:
new version attached. It adds your suggestions and also uses virAsprintf
in the new src/logging.c.
Thanks!
That looks fine, applies, and passes tests.
You're welcome to apply it.
Applied
On Thu, Dec 04, 2008 at 02:16:06PM +0100, Daniel Veillard wrote:
On Thu, Dec 04, 2008 at 01:15:23PM +0100, Guido Günther wrote:
On Thu, Dec 04, 2008 at 10:56:25AM +, Daniel P. Berrange wrote:
On Wed, Dec 03, 2008 at 06:20:12PM +0100, Guido G?nther wrote:
On Sun, Nov 30, 2008 at 12:43
rights:
Dave Leskovecdle...@linux.vnet.ibm.com
Cole Robinsoncrobi...@redhat.com
Dan Smithda...@us.ibm.com
- Guido Guenther a...@sigxcpu.org
+ Guido Günthera...@sigxcpu.org
Patches have also been contributed by:
--
1.6.0.3
From
On Tue, Dec 23, 2008 at 02:17:43PM +0100, Daniel Veillard wrote:
On Tue, Dec 23, 2008 at 01:59:58PM +0100, Guido Günther wrote:
Hi,
possible patch attached.
Looks fine to me, +1,
O.k., applied now.
-- Guido
--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redhat.com
On Mon, Dec 15, 2008 at 02:22:42PM +0100, Daniel Veillard wrote:
On Mon, Dec 15, 2008 at 11:21:20AM +, Daniel P. Berrange wrote:
On Fri, Dec 12, 2008 at 07:26:32PM +0100, Guido G?nther wrote:
+if (kill(vm-pid, SIGTERM) 0)
+qemudLog(QEMUD_ERROR, _(Failed to send SIGTERM to
Hi,
current domstatus code saves the domain as number, attached patch safes
it as string which looks a bit nicer.
Cheers,
-- Guido
From b266ff63d9a96a5901e2171b94acef287685109a Mon Sep 17 00:00:00 2001
From: =?utf-8?q?Guido=20G=C3=BCnther?= a...@sigxcpu.org
Date: Mon, 29 Dec 2008 12:21:31 +0100
Hi,
attached patch splits out the qemu logfile opening into a separate
function which makes the code a bit more readable and I'll need this for
the libvirtd restart code.
Cheers,
-- Guido
From b65295d7693274fb84a21597cafc9628799dacf7 Mon Sep 17 00:00:00 2001
From: =?utf-8?q?Guido=20G=C3=BCnther?=
On Mon, Dec 15, 2008 at 10:19:28AM +0100, Daniel Veillard wrote:
On Fri, Dec 12, 2008 at 07:26:32PM +0100, Guido Günther wrote:
Make sure vms don't get killed when the libvirtd quits unexpectedly.
Needs the previous patch since it looks at the pid file.
[...]
+/* wait for qemu process
On Tue, Jan 06, 2009 at 03:27:52PM +0100, Daniel Veillard wrote:
On Mon, Dec 29, 2008 at 03:44:54PM +0100, Guido Günther wrote:
Hi,
current domstatus code saves the domain as number, attached patch safes
it as string which looks a bit nicer.
[...]
@@ -1414,7 +1416,9
On Tue, Jan 06, 2009 at 03:28:59PM +0100, Daniel Veillard wrote:
On Mon, Jan 05, 2009 at 07:52:26AM +0100, Jim Meyering wrote:
Guido Günther a...@sigxcpu.org wrote:
attached patch splits out the qemu logfile opening into a separate
function which makes the code a bit more readable
On Mon, Jan 05, 2009 at 08:00:56AM +0100, Jim Meyering wrote:
Guido Günther a...@sigxcpu.org wrote:
these accumulated over time. O.k. to apply?
Those all look fine.
From 35569e95febc37818998cd1834099090a3cf852d Mon Sep 17 00:00:00 2001
From: =?utf-8?q?Guido=20G=C3=BCnther
On Mon, Jan 05, 2009 at 09:58:06AM +, Daniel P. Berrange wrote:
On Mon, Dec 29, 2008 at 03:36:15PM +0100, Guido G?nther wrote:
On Mon, Dec 15, 2008 at 02:22:42PM +0100, Daniel Veillard wrote:
On Mon, Dec 15, 2008 at 11:21:20AM +, Daniel P. Berrange wrote:
On Fri, Dec 12, 2008 at
On Tue, Jan 06, 2009 at 05:51:27PM +, Daniel P. Berrange wrote:
[..snip..]
The file we write is /var/run/libvirt/qemu/*.xml where we keep the
internal state of a running vm. We can change this at at any time.
Yes no, but mostly no.
These persistent state files will need to be
On Mon, Jan 05, 2009 at 03:21:35PM +0100, Daniel Veillard wrote:
On Mon, Jan 05, 2009 at 10:27:03AM +, Daniel P. Berrange wrote:
On Fri, Dec 26, 2008 at 02:19:06PM +0100, Guido G?nther wrote:
by honoring the VIR_DOMAIN_XML_INACTIVE flag.
O.k. to commit this part as a start so
On Thu, Jan 08, 2009 at 05:02:14PM +0100, Jim Meyering wrote:
[..snip..]
Hi Guido,
libvirt doesn't build right now, because of this:
xm_internal.c:2288: error: too few arguments to function
'virDomainDefParseString'
xm_internal.c:2530: error: too few arguments to function
On Thu, Jan 08, 2009 at 06:29:13PM +0100, Guido Günther wrote:
On Thu, Jan 08, 2009 at 05:02:14PM +0100, Jim Meyering wrote:
[..snip..]
Hi Guido,
libvirt doesn't build right now, because of this:
xm_internal.c:2288: error: too few arguments to function
'virDomainDefParseString
On Tue, Jan 06, 2009 at 04:42:15PM +0100, Jim Meyering wrote:
[..snip..]
Thanks!
IMHO, committing your patch as-is, and then making the
suggested change in a separate change set would be fine.
Maybe even a little better, since it's easier to see
what's happening when one doesn't mix
On Fri, Jan 09, 2009 at 10:05:06AM +0100, Guido Günther wrote:
On Tue, Jan 06, 2009 at 04:42:15PM +0100, Jim Meyering wrote:
[..snip..]
Thanks!
IMHO, committing your patch as-is, and then making the
suggested change in a separate change set would be fine.
Maybe even a little better
On Tue, Jan 06, 2009 at 04:42:15PM +0100, Jim Meyering wrote:
Guido Günther a...@sigxcpu.org wrote:
On Tue, Jan 06, 2009 at 03:28:59PM +0100, Daniel Veillard wrote:
On Mon, Jan 05, 2009 at 07:52:26AM +0100, Jim Meyering wrote:
Guido Günther a...@sigxcpu.org wrote:
attached patch splits
On Sun, Jan 11, 2009 at 08:50:59AM +0100, Jim Meyering wrote:
Guido Günther a...@sigxcpu.org wrote:
Does the attached patch look ok? I'll apply this together with
0001-split-out-opening-of-the-domain-logfile.patch then.
-- Guido
Rereading your mail you also suggest using sizeof() instead
On Mon, Dec 15, 2008 at 11:27:27AM +, Daniel P. Berrange wrote:
[..snip..]
+vm-stdin_fd = qemudGetProcFD(vm-pid, 0);
+vm-stdout_fd = qemudGetProcFD(vm-pid, 1);
+vm-stderr_fd = qemudGetProcFD(vm-pid, 2);
NACK, to these 3 lines - since we go to trouble of
On Thu, Jan 15, 2009 at 09:19:39AM -0800, john.le...@sun.com wrote:
[..snip..]
+/* Change the group ownership of /var/run/libvirt to unix_sock_gid */
+if (geteuid () == 0) {
+const char *rundir = LOCAL_STATE_DIR /run/libvirt;
+
+if (mkdir (rundir, 0755)) {
This one is as posted before. Not really necessary, but makes things look
nicer.
-- Guido
---
src/domain_conf.c|9 +
src/domain_conf.h|2 ++
src/libvirt_private.syms |2 ++
src/qemu_conf.c | 12
4 files changed, 21 insertions(+), 4
Hi,
attached is the current patch series for the above issue. The biggest
change is in the 3rd patch that switches the qemu driver to use the
monitor fd to detect daemon shutdown, therefore we can dup the vms
stdout/err on the logfile right at startup.
Cheers,
-- Guido
--
Libvir-list mailing
connect back to running vms.
changes:
* don't use proc
* don't bother about stdin
* don't use global qemu_driver directly
Cheer,
-- Guido
---
src/qemu_driver.c | 112 +
1 files changed, 96 insertions(+), 16 deletions(-)
diff --git
501 - 600 of 1099 matches
Mail list logo
