[libvirt] [PATCH] lxc: Init activeUsbHostdevs

otherwise we crash with #0 virUSBDeviceListFind (list=0x0, dev=dev@entry=0x8193d70) at util/virusb.c:526 #1 0xb1a4995b in virLXCPrepareHostdevUSBDevices (driver=driver@entry=0x815d9a0, name=0x815dbf8 "debian-700267", list=list@entry=0x81d8f08) at lxc/lxc_hostdev.c:88 #2 0xb1a49fce in virL

[libvirt] [PATCH] nodeGetCellMemory is unused without numactl

make[3]: Entering directory `/var/scratch/debian/libvirt/upstream/libvirt/src' CC libvirt_driver_la-nodeinfo.lo nodeinfo.c:105:27: error: 'nodeGetCellMemory' declared 'static' but never defined [-Werror=unused-function] cc1: all warnings being treated as errors --- src/nodeinfo.c |9 ++-

Re: [libvirt] [PATCH] Convert HAVE_SELINUX to WITH_SELINUX

On Mon, Mar 11, 2013 at 09:54:42AM +0800, Osier Yang wrote: > On 2013年03月09日 23:08, Guido Günther wrote: > >these were missed by 63f18f378693cac6b6e33f4a8c15c20cb191c7c8 > >--- > > src/lxc/lxc_container.c |4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [libvirt] [PATCH] lxc: Init activeUsbHostdevs

On Mon, Mar 11, 2013 at 09:56:19AM +0800, Osier Yang wrote: > On 2013年03月09日 23:08, Guido Günther wrote: > >otherwise we crash with > > > > #0 virUSBDeviceListFind (list=0x0, dev=dev@entry=0x8193d70) at > > util/virusb.c:526 > > #1 0xb1a4995b in virLXCPrep

[libvirt] [PATCH] Don't fail if SELinux is diabled

but libvirt is built with --with-selinux. In this case getpeercon returns ENOPROTOOPT so dont' return an error in that case but simply don't set seccon. --- src/rpc/virnetsocket.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rpc/virnetsocket.c b/src/rpc/virnetsocket.c

[libvirt] libvirt-tck test failure with identity patches

Hi, the qemu session libvirt-tck test currently fails with: [19:58:21] scripts/domain/050-transient-lifecycle.t ok59684 ms [19:59:20] scripts/domain/051-transient-autostart.t ok 2001 ms [19:59:22] scripts/domain/060-persistent-lifecycle.t ... ok 2943 m

Re: [libvirt] [PATCH] Don't fail if SELinux is diabled

On Wed, Mar 20, 2013 at 01:10:13PM -0600, Eric Blake wrote: > On 03/20/2013 01:04 PM, Guido Günther wrote: > > s/diabled/disabled/ in the subject > > > but libvirt is built with --with-selinux. In this case getpeercon > > returns ENOPROTOOPT so dont' return an

Re: [libvirt] [PATCH] Don't fail if SELinux is diabled

On Wed, Mar 20, 2013 at 02:20:52PM -0600, Eric Blake wrote: > On 03/20/2013 02:06 PM, Guido Günther wrote: > > On Wed, Mar 20, 2013 at 01:10:13PM -0600, Eric Blake wrote: > >> On 03/20/2013 01:04 PM, Guido Günther wrote: > >> > >> s/diabled/disabled/

Re: [libvirt] libvirt-tck test failure with identity patches

Hi, On Wed, Mar 20, 2013 at 08:15:31PM +0100, Guido Günther wrote: > Hi, > the qemu session libvirt-tck test currently fails with: > > [19:58:21] scripts/domain/050-transient-lifecycle.t ok59684 > ms > [19:59:20] scripts/domain/051-transient-autostart.t ..

[libvirt] [PATCH] qemu: Don't set type too earla during virtio disk hotplug

f946462e14ac036357b7c11ce5c23f94a3ee4e49 changed behaviour by settings VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI upfront. If we do so before invoking qemuDomainPCIAddressEnsureAddr we merely try to set the PCI slot via qemuDomainPCIAddressReserveSlot instead reserving a new address via qemuDomainPCIAddres

Re: [libvirt] Build failed in Jenkins: libvirt-syntax-check #759

On Fri, Mar 22, 2013 at 06:18:48AM -0600, Eric Blake wrote: > On 03/21/2013 09:54 PM, Jenkins CI wrote: > > See > > > > -- > > Started by upstream project "libvirt-build" build number 856 > > [work

Re: [libvirt] Build failed in Jenkins: libvirt-syntax-check #759

On Fri, Mar 22, 2013 at 02:10:59PM +0100, Guido Günther wrote: > On Fri, Mar 22, 2013 at 06:18:48AM -0600, Eric Blake wrote: > > On 03/21/2013 09:54 PM, Jenkins CI wrote: > > > See <http://honk.sigxcpu.org:8001/job/lib

Re: [libvirt] Build failed in Jenkins: libvirt-syntax-check #759

On Fri, Mar 22, 2013 at 02:10:59PM +0100, Guido Günther wrote: [..snip..] > > > prohibit_argmatch_without_use > > > grep: write error > > > grep: write error > > > sed: couldn't write 1 item to stdout: Broken pipe > > > sed: couldn&

[libvirt] [PATCH v2] qemu: Don't set address type too early during virtio disk hotplug

f946462e14ac036357b7c11ce5c23f94a3ee4e49 changed behavior by settings VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI upfront. If we do so before invoking qemuDomainPCIAddressEnsureAddr we merely try to set the PCI slot via qemuDomainPCIAddressReserveSlot instead reserving a new address via qemuDomainPCIAddress

Re: [libvirt] [PATCH v2] qemu: Don't set address type too early during virtio disk hotplug

On Fri, Mar 22, 2013 at 06:52:46PM +0100, Guido Günther wrote: > f946462e14ac036357b7c11ce5c23f94a3ee4e49 changed behavior by settings > VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI upfront. If we do so before invoking > qemuDomainPCIAddressEnsureAddr we merely try to set the PCI

Re: [libvirt] [PATCH v2] qemu: Don't set address type too early during virtio disk hotplug

On Tue, Mar 26, 2013 at 05:13:17PM +0100, Ján Tomko wrote: > On 03/22/2013 06:52 PM, Guido Günther wrote: > > f946462e14ac036357b7c11ce5c23f94a3ee4e49 changed behavior by settings > > VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI upfront. If we do so before invoking > > qemuDomainPC

Re: [libvirt] [Libvirt-announce] Candidate release 2 of libvirt-1.0.4 available

Hi, On Mon, Apr 01, 2013 at 11:04:09AM +0800, Daniel Veillard wrote: > On Mon, Apr 01, 2013 at 03:30:47AM +0100, Justin Clift wrote: > > On 28/03/2013, at 3:08 AM, Daniel Veillard wrote: > > > I tagged it in git and pushed the tarball to the usual area: > > > > > > ftp://libvirt.org/libvirt/ > >

[libvirt] [PATCH] security_manager: fix comparison

otherwise we crash later on if we don't find a match like: #0 0xb72c2b4f in virSecurityManagerGenLabel (mgr=0xb8e42d20, vm=0xb8ef40c0) at security/security_manager.c:424 #1 0xb18811f3 in qemuProcessStart (conn=conn@entry=0xb8eed880, driver=driver@entry=0xb8e3b1e0, vm=vm@entry=0xb8ef58f0,

Re: [libvirt] [PATCH] security_manager: fix comparison

On Wed, Apr 03, 2013 at 02:53:05PM -0600, Eric Blake wrote: > On 04/03/2013 02:40 PM, Luiz Capitulino wrote: > > On Wed, 3 Apr 2013 22:23:28 +0200 > > Guido Günther wrote: > > > >> otherwise we crash later on if we don't find a match like: > >> > &

Re: [libvirt] Is DBus a hard dependency

On Mon, Nov 26, 2012 at 10:33:15AM +, Daniel P. Berrange wrote: > On Sat, Nov 24, 2012 at 06:34:35PM +0100, Guido Günther wrote: > > Hi, > > currently running libvirtd without DBus fails due to: > > > > error : nwfilterDriverStartup:208 : DBus matches could not b

[libvirt] libvirt-tck breackage

Hi, it seems a recent commit broke allmost all off the libvirt-tck tests: http://honk.sigxcpu.org:8001/job/libvirt-tck-debian-wheezy-qemu-session/196/console I won't have a chance to have a closer look but but wanted to at least send a heads up. I'll have a closer look later this week. C

[libvirt] [PATCH] Don't fail hard when we can't connect to the monitor

As of 1a50ba2cb07d8bb2aa724062889deb9efd7ad9e9 we fail to connect to the monitor instead of getting an exit status != 0 from qemu itself. This breaks capabilities probing for the non QMP case. --- src/qemu/qemu_capabilities.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [libvirt] [PATCH] Don't fail hard when we can't connect to the monitor

On Thu, Nov 29, 2012 at 12:39:24PM +, Daniel P. Berrange wrote: > On Thu, Nov 29, 2012 at 01:29:38PM +0100, Guido Günther wrote: > > As of 1a50ba2cb07d8bb2aa724062889deb9efd7ad9e9 we fail to connect to the > > monitor instead of getting an exit status != 0 from qemu itself.

[libvirt] [PATCH] Fix uninitialized variables

detecet by http://honk.sigxcpu.org:8001/job/libvirt-build/348/console --- Probably o.k. to push under the build breaker rule but I'd better check. Cheers, -- Guido src/qemu/qemu_monitor.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_monitor.c

Re: [libvirt] [PATCH] Fix uninitialized variables

On Fri, Nov 30, 2012 at 06:38:31PM +, Daniel P. Berrange wrote: > On Fri, Nov 30, 2012 at 07:13:01PM +0100, Guido Günther wrote: > > detecet by > > > > http://honk.sigxcpu.org:8001/job/libvirt-build/348/console > > --- > > Probably o.k. to push under the

[libvirt] [jenk...@libvirt.sigxcpu.org: Build failed in Jenkins: libvirt-tck-debian-wheezy-qemu-session #227]

Hi, this commit ae2163f852448fafce3bfcb2814e823d18e394ea Only let VM drivers block libvirtd timed shutdown broke the libvirt-tck integration build with qemu:///session: http://honk.sigxcpu.org:8001/job/libvirt-tck-debian-wheezy-qemu-session/227/console I won't have a chance to look into this

[libvirt] [PATCH] Inhibit daemon shutdown during capabilities probing

As of 1a50ba2cb07d8bb2aa724062889deb9efd7ad9e9 qemu capabilities probing takes longer since we timeout waiting for the monitor socket. When probing qemu for different architectures this can add up so the daemon auto shutdown timeout is reached and the client doesn't have a chance to connect. To avo

[libvirt] [PATCH] Inhibit daemon shutdown during driver initialization

As of 1a50ba2cb07d8bb2aa724062889deb9efd7ad9e9 qemu capabilities probing takes longer since we timeout waiting for the monitor socket. When probing qemu for different architectures this can add up so the daemon auto shutdown timeout is reached and the client doesn't have a chance to connect. To avo

Re: [libvirt] [PATCH] network: prevent a few invalid configuration combinations

On Wed, Dec 05, 2012 at 02:15:17PM -0500, Laine Stump wrote: > This resolves: https://bugzilla.redhat.com/show_bug.cgi?id=767057 > > It was possible to define a network with that > had both a bridge device and a forward device defined. These two are > mutually exclusive by definition (if you are

Re: [libvirt] [PATCH] Inhibit daemon shutdown during driver initialization

On Thu, Dec 06, 2012 at 03:51:43PM +, Daniel P. Berrange wrote: > On Thu, Dec 06, 2012 at 04:47:18PM +0100, Guido Günther wrote: > > As of 1a50ba2cb07d8bb2aa724062889deb9efd7ad9e9 qemu capabilities probing > > takes longer since we timeout waiting for the monitor socket. When &

[libvirt] [PATCH] Define SANLK_INQ_WAIT if missing in headers

so we can build with older sanlock (like 2.2) --- I've applied this to the current Debian builds since we're lagging a bit regarding sanlock but it might make sense to also support this upstream. Cheers, -- Guido src/locking/lock_driver_sanlock.c |3 +++ 1 file changed, 3 insertions(+) diff

[libvirt] [PATCH] Require SANLK_INQ_WAIT for inq_lockspace support

since compilation breaks otherwise with older libsanlock. --- Hi Daniel, does this make more sense then? Cheers, -- Guido configure.ac | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index bf32f95..1936982 100644 --- a/configure.ac +

Re: [libvirt] [PATCH] Require SANLK_INQ_WAIT for inq_lockspace support

On Thu, Dec 13, 2012 at 03:55:21PM -0700, Eric Blake wrote: > On 12/13/2012 03:48 PM, Guido Günther wrote: > > since compilation breaks otherwise with older libsanlock. > > --- > > Hi Daniel, > > does this make more sense then? > > Cheers, > > -- Guido >

[libvirt] [jenk...@libvirt.sigxcpu.org: Build failed in Jenkins: libvirt-check #419]

Hi, it seems one of these commits 5411e7e176dcbb65591cb97ec128b5fd0f365805 473011334ccd93e8efbb67f2561f1d4e54d212ae 392c192240566d9e167d2b5a1022092d8f7e045c broke "make check" as seen on http://honk.sigxcpu.org:8001/job/libvirt-check/417/console output attached. I can't look into this i

Re: [libvirt] [jenk...@libvirt.sigxcpu.org: Build failed in Jenkins: libvirt-check #419]

On Wed, Dec 19, 2012 at 11:04:38AM +, Daniel P. Berrange wrote: > On Wed, Dec 19, 2012 at 09:59:45AM +, Daniel P. Berrange wrote: > > On Wed, Dec 19, 2012 at 10:50:42AM +0100, Guido Günther wrote: > > > Hi, > > > it

Re: [libvirt] [jenk...@libvirt.sigxcpu.org: Build failed in Jenkins: libvirt-check #419]

On Wed, Dec 19, 2012 at 02:22:23PM -0700, Eric Blake wrote: > On 12/19/2012 01:43 PM, Guido Günther wrote: > >> With the fixes I just pushed, I hope this should be working now. > >> I tested with everything configure option except AppArmor enabled > >> now. > >

Re: [libvirt] Build failed in Jenkins: libvirt-build #472

Hi, On Wed, Jan 02, 2013 at 11:20:08AM -0700, Eric Blake wrote: > On 01/02/2013 10:29 AM, Jenkins CI wrote: > > See > > > > Changes: > > > > [eblake] maint: update to latest gnulib > > > CCLD libvirt_security_manager.la > > CCLD

Re: [libvirt] where is config.log when debugging a failure reported by Jenkins

Hi Eric, On Wed, Jan 02, 2013 at 02:45:24PM -0700, Eric Blake wrote: > Hello Jenkins folks, > > On the libvirt list, we came across a case where a broken commit was > detected, but where the information available in the failure report was > insufficient (for at least me) to reproduce the failure e

Re: [libvirt] where is config.log when debugging a failure reported by Jenkins

On Wed, Jan 02, 2013 at 11:12:31PM +0100, Guido Günther wrote: > Hi Eric, > On Wed, Jan 02, 2013 at 02:45:24PM -0700, Eric Blake wrote: > > Hello Jenkins folks, > > > > On the libvirt list, we came across a case where a broken commit was > > detected, but where th

Re: [libvirt] [PATCH] build: fix build with optimization enabled

On Thu, Jan 03, 2013 at 10:15:06AM -0700, Eric Blake wrote: > Build failure detected by Jenkins autobuilder: > http://honk.sigxcpu.org:8001/job/libvirt-build/472/changes > > * .gnulib: Update to latest, for stdio.h rpl_fwrite fix. That fixed it. Thanks a lot! As of the latest update I'm seeing sp

[libvirt] [PATCH] Install virtlockd.{socket, service} non executable

since they're not scripts but systemd service files. --- src/Makefile.am |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index f7a9b91..0cfc1ed 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -1687,9 +1687,9 @@ DISTCLEANFILES += vi

Re: [libvirt] [PATCH] Install virtlockd.{socket, service} non executable

On Thu, Jan 03, 2013 at 04:37:51PM -0700, Eric Blake wrote: > On 01/03/2013 03:05 PM, Guido Günther wrote: > > since they're not scripts but systemd service files. > > --- > > src/Makefile.am |4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) >

[libvirt] [PATCH] No need to use a .in file for virtlockd.socket

since there are no substitutions in it. --- src/Makefile.am | 10 +- src/locking/virtlockd.socket|8 src/locking/virtlockd.socket.in |8 3 files changed, 13 insertions(+), 13 deletions(-) create mode 100644 src/locking/virtlockd.socket dele

Re: [libvirt] [PATCH 2/4] build: properly substitute virtlockd.socket

On Fri, Jan 04, 2013 at 03:36:46PM -0700, Eric Blake wrote: > virtlockd.service could be installed to a configurable root, > but virtlockd.socket was hardcoded to installation into a > distro. > > * src/Makefile.am (virtlockd.service, virtlockd.socket): Drop > unused substitutions. > * src/locking

Re: [libvirt] [PATCH 3/4] build: .service files don't need to be executable

On Fri, Jan 04, 2013 at 03:36:47PM -0700, Eric Blake wrote: > See also commit 66ff2dd, where we avoided installing these files > as executables. > > * daemon/Makefile.am (libvirtd.service): Drop chmod. > * tools/Makefile.am (libvirt-guests.service): Likewise. > * src/Makefile.am (virtlockd.service

Re: [libvirt] [PATCH 1/4] build: use common .in replacement mechanism

On Fri, Jan 04, 2013 at 03:36:45PM -0700, Eric Blake wrote: > We had several different styles of .in conversion in our Makefiles: > ALLCAPS, @ALLCAPS@, @lower@, ::lower:: > Canonicalize on one form, to make it easier to copy and paste > between .in files. > > Also, we were using some non-portable

[libvirt] [PATCH] Add missing flags to migrate documentation

--- src/libvirt.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/src/libvirt.c b/src/libvirt.c index 6d1da12..83aeb23 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -5121,10 +5121,15 @@ virDomainMigrateDirect(virDomainPtr domain, * VIR_MIGRATE_UNDEFINE_SOURCE

Re: [libvirt] [PATCH] Add missing flags to migrate documentation

On Mon, Jan 07, 2013 at 04:57:14PM -0700, Eric Blake wrote: > On 01/07/2013 08:04 AM, Guido Günther wrote: > > --- > > src/libvirt.c | 22 ++ > > 1 file changed, 22 insertions(+) > > ACK. Pushed. Thanks, -- Guido -- libvir-list mailing list l

Re: [libvirt] [PATCH] virsh: add --start option to the define command

On Tue, Jan 08, 2013 at 04:41:58PM -0700, Eric Blake wrote: > On 01/08/2013 02:36 PM, Doug Goldstein wrote: > > I often find myself doing virsh "define blah.xml; start blah". I figured > > adding this would be a easier^Hlazier way to do it. > > --- > > tools/virsh-domain.c | 20 +

[libvirt] [PATCH] Don't try to include xattr.h if not available

--- tests/securityselinuxhelper.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/securityselinuxhelper.c b/tests/securityselinuxhelper.c index abe4d7c..bd5ea87 100644 --- a/tests/securityselinuxhelper.c +++ b/tests/securityselinuxhelper.c @@ -24,7 +24,9 @@ #includ

[libvirt] [PATCH] Fix typo in variable name

Hi, I pushed that under the build breaker rule: that broke the build like: CC libvirt_conf_la-domain_conf.lo conf/domain_conf.c: In function 'virDomainVcpuPinAdd': conf/domain_conf.c:11920:29: error: 'vpcupin' undeclared (first use in this function) conf/domain_conf.c:11920:29: note:

[libvirt] [PATCH] Make sure we only abort without libcurl if $with_esx = yes

--- configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 712918f..4bd3c3e 100644 --- a/configure.ac +++ b/configure.ac @@ -1810,7 +1810,7 @@ dnl check for (ESX) dnl if test "$with_curl" != "yes" ; then - if test "$with_esx" = "c

Re: [libvirt] [PATCH] Make sure we only abort without libcurl if $with_esx = yes

On Fri, Jan 25, 2013 at 02:22:01PM -0700, Eric Blake wrote: > On 01/25/2013 02:14 PM, Guido Günther wrote: > > --- > > configure.ac |2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/configure.ac b/configure.ac > >

Re: [libvirt] [PATCH] Make python objects inherit from 'object' base class

Hi, On Thu, Jan 24, 2013 at 01:17:32PM +, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > As of python >= 2.2, it is recommended that all objects inherit > from the 'object' base class. We already require python >= 2.3 > for libvirt for thread macro support, so we should follow thi

Re: [libvirt] [PATCH] rpc: Fix crash on error paths of message dispatching

Hi, On Mon, Jan 28, 2013 at 07:35:38PM +0100, Peter Krempa wrote: > When reading and dispatching of a message failed the message was freed > but wasn't removed from the message queue. > > After that when the connection was about to be closed the pointer for > the message was still present in the q

Re: [libvirt] [PATCH] rpc: Fix crash on error paths of message dispatching

Hi Eric, On Tue, Jan 29, 2013 at 02:21:30PM -0700, Eric Blake wrote: > On 01/29/2013 01:22 PM, Guido Günther wrote: > > Hi, > > On Mon, Jan 28, 2013 at 07:35:38PM +0100, Peter Krempa wrote: > >> When reading and dispatching of a message failed the message was freed > >

Re: [libvirt] Entering freeze for libvirt-1.0.5

On Fri, Apr 26, 2013 at 04:09:59PM +0800, Daniel Veillard wrote: > So as discussed earlier this week, I have tagged the release candidate 1 > of libvirt-1.0.5 in git and pushed the tarball and associated rpms to > the FTP at: >ftp://libvirt.org/libvirt/ > > We may still push some of the patc

[libvirt] [PATCH] virInitctlRequest: Don't hardcode 384 bytes size

When MAXHOSTNAMELEN is set we have to take it's value into account. Otherwise the build fails on kFreeBSD (FreeBSD kernel and GNU userland) --- src/util/virinitctl.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/util/virinitctl.c b/src/util/virinitctl.c index 1618

Re: [libvirt] [PATCH] virInitctlRequest: Don't hardcode 384 bytes size

On Wed, May 01, 2013 at 02:48:35PM -0600, Eric Blake wrote: > On 05/01/2013 02:39 PM, Guido Günther wrote: > > When MAXHOSTNAMELEN is set we have to take it's value into account. > > Otherwise the build fails on kFreeBSD (FreeBSD kernel and GNU userland) > > --- > &g

Re: [libvirt] [PATCH] virInitctlRequest: Don't hardcode 384 bytes size

On Thu, May 02, 2013 at 08:19:11AM +0200, Guido Günther wrote: > On Wed, May 01, 2013 at 02:48:35PM -0600, Eric Blake wrote: > > On 05/01/2013 02:39 PM, Guido Günther wrote: > > > When MAXHOSTNAMELEN is set we have to take it's value into account. > > > Other

[libvirt] [PATCH] virthreadpthread: don't try to cast pthread_t to void*

This fixes the build on kFreeBSD that otherwise fails with: util/virthreadpthread.c: In function 'virThreadSelfID': util/virthreadpthread.c:222:27: error: cast from function call of type 'pthread_t' to non-matching type 'void *' [-Werror=bad-function-cast] --- I'm unsure why we'd need the cast to

Re: [libvirt] Release of libvirt-1.0.5

On Thu, May 02, 2013 at 06:39:07PM +0800, Daniel Veillard wrote: > I forgot to make the rc2 release on tuesday, but looking at the > git state it was looking like the problem reported on rc1 had been > fixed, so I decided to go ahead and roll the release as scheduled > today. It is tagged in git

Re: [libvirt] Release of libvirt-1.0.5

On Thu, May 02, 2013 at 10:08:11PM +0800, Daniel Veillard wrote: > On Thu, May 02, 2013 at 03:35:50PM +0200, Guido Günther wrote: > > On Thu, May 02, 2013 at 06:39:07PM +0800, Daniel Veillard wrote: > > > I forgot to make the rc2 release on tuesday, but looking at the >

Re: [libvirt] [PATCH] build: avoid non-portable cast of pthread_t

than futz around with figuring which 32 bits of a potentially > 64-bit pointer are most likely to be unique, convert the rest of > the code base to use 64-bit values when using a debug id. > > Based on a report by Guido Günther against kFreeBSD, but with a > fix that doesn't regr

[libvirt] [PATCH 1/2] Fixup rpcgen code on kFreeBSD too

since it uses glibc's rpcgen. --- src/rpc/genprotocol.pl |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rpc/genprotocol.pl b/src/rpc/genprotocol.pl index c8c1570..f02ce13 100755 --- a/src/rpc/genprotocol.pl +++ b/src/rpc/genprotocol.pl @@ -31,7 +31,7 @@ open RPCGEN, "-|

[libvirt] [PATCH 2/2] Make detect_scsi_host_caps a function on all architectures

In the non linux case some callers like gather_scsi_host_caps needed the return code of -1 while others like update_caps needed an emtpy statement (to avoid a "statement without effect" warning). This is much simpler solved by using a function instead of a define. --- src/node_device/node_device_d

Re: [libvirt] [PATCH 2/2] Make detect_scsi_host_caps a function on all architectures

On Fri, May 03, 2013 at 06:04:11AM -0600, Eric Blake wrote: > On 05/03/2013 12:22 AM, Guido Günther wrote: > > In the non linux case some callers like gather_scsi_host_caps needed the > > return code of -1 while others like update_caps needed an emtpy > > s/emtpy/empty/

Re: [libvirt] [PATCH 2/2] Make detect_scsi_host_caps a function on all architectures

On Fri, May 03, 2013 at 06:04:11AM -0600, Eric Blake wrote: > On 05/03/2013 12:22 AM, Guido Günther wrote: > > In the non linux case some callers like gather_scsi_host_caps needed the > > return code of -1 while others like update_caps needed an emtpy > > s/emtpy/empty/ >

[libvirt] Build failed in Jenkins: libvirt-check #1003

Hi, I don't have time to look into these test failurs in detail atm: but it seems that one of these commits broke qemuxml2argvtest: qemu: New cap flags for scsi-generic utils: util functions for scsi hostdev qemu: Build qemu command line for scsi host device rng: Interleave hostde

Re: [libvirt] Build failed in Jenkins: libvirt-check #1003

On Mon, May 13, 2013 at 03:59:20PM +0100, Daniel P. Berrange wrote: > On Mon, May 13, 2013 at 04:16:53PM +0200, Guido Günther wrote: > > Hi, > > I don't have time to look into these test failurs in detail atm: > > > > but it seems that one of thes

Re: [libvirt] Build failed in Jenkins: libvirt-check #1003

Hi Osier, On Mon, May 13, 2013 at 11:45:15PM +0800, Osier Yang wrote: > On 13/05/13 23:25, Guido Günther wrote: > >On Mon, May 13, 2013 at 03:59:20PM +0100, Daniel P. Berrange wrote: > >>On Mon, May 13, 2013 at 04:16:53PM +0200, Guido Günther wrote: > >>>Hi, >

Re: [libvirt] [PATCH 3/3] tests: Move fchostdata into sysfsroot

On Wed, May 15, 2013 at 06:52:46PM +0800, Osier Yang wrote: > "fchostdata" is also about sysfs files, it can go home now. > --- > tests/Makefile.am | 2 +- > tests/fchostdata/fc_host/host4/fabric_name| 1 - > tests/fchostdata/fc_host/host4/max_npiv_v

Re: [libvirt] [PATCH 2/3] tests: Feed the fake sysfs root to qemuBuildCommandLine

On Wed, May 15, 2013 at 06:52:45PM +0800, Osier Yang wrote: > This creates a new directory "sysfsroot" under "tests", any sysfs > test input files should be put into it in future. Currently only > the scsi-generic tests need to use it, so only one file path is > created (bus/scsi/devices/0:0:0:0/sc

Re: [libvirt] [PATCH 1/3] qemu: Allow to specify the sysfs root for qemuBuildCommandLine

On Wed, May 15, 2013 at 06:52:44PM +0800, Osier Yang wrote: > Since 0d70656afded, it starts to access the sysfs files to build > the qemu command line (by virSCSIDeviceGetSgName, which is find I'm not a native speaker but s/which is/to/ sounds better to me. > out the scsi generic device name b

Re: [libvirt] [PATCH 2/2] tests: Move fchostdata into sysfsroot

Hi Osier, On Thu, May 16, 2013 at 12:37:23AM +0800, Osier Yang wrote: [..snip..] > >Not sure I really agree with this change. The 'fchostdata' files are > >used by the 'fchosttest.c' test program. So that existing naming is > >following our conventions of naming the data dir to match the test > >p

[libvirt] [libvirt-tck PATCH] 121-block-info.t: omit network

qemu:///session doesn't have a default network so we fail with: ./scripts/domain/121-block-info.t .. 1/29 # Defining transient storage pool # Generic guest with pervious created vol ./scripts/domain/121-block-info.t .. 12/29 # Failed test 'Create domain' # at /var/lib/jenkins/jobs/libvirt

[libvirt] [libvirt-tck PATCH] 121-block-info.t: allow for greater capacity/allocation

Don't be too picky about the actual size and allocation. The size needs to be correct but it's o.k. for allocation and size to be bigger. Debian Wheezy's qemu adds 4096 bytes. --- scripts/domain/121-block-info.t |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/scripts

Re: [libvirt] [libvirt-tck PATCH] 121-block-info.t: omit network

On Tue, May 28, 2013 at 06:56:21AM -0600, Eric Blake wrote: > On 05/27/2013 01:17 PM, Guido Günther wrote: > > qemu:///session doesn't have a default network so we fail with: > > > > ./scripts/domain/121-block-info.t .. 1/29 # Defining transient storage pool > >

Re: [libvirt] Candidate release 2 for libvirt-1.0.6

On Thu, May 30, 2013 at 11:57:50AM +0200, Daniel Veillard wrote: > I have just tagged and pushed to FTP the second candidate release for > libvirt-1.0.6, available at: > ftp://libvirt.org/libvirt/ > > So far feedback on rc1 has been positive, and my own small testing of > rc2 is okay too.

[libvirt] [PATCH] vbox: define DYNLIB_NAME for kFreeBSD

Similar to what Eric did for Cygwin it helps at least to compile without --without-vbox --- src/vbox/vbox_XPCOMCGlue.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vbox/vbox_XPCOMCGlue.c b/src/vbox/vbox_XPCOMCGlue.c index 9719014..7809719 100644 --- a/src/vbox/vbox_XP

Re: [libvirt] [PATCH] vbox: define DYNLIB_NAME for kFreeBSD

On Thu, May 30, 2013 at 02:59:56PM -0600, Eric Blake wrote: > On 05/30/2013 02:48 PM, Guido Günther wrote: > > Similar to what Eric did for Cygwin it helps at least to compile > > without --without-vbox > > Well, my patch for Cygwin was nak'd, so you probably ought to

[libvirt] kFreeBSD pdwtags make check failure

Hi, make check on kFreeBSD currently fails with: make[3]: Entering directory `/data/home/jenkins/jobs/libvirt-build-debian-jessie-kfreebsd64/workspace/libvirt/src' GENremote_protocol-struct --- remote_protocol-structs 2013-05-03 17:48:29.0 +0200 +++ remote_protocol-struct-t3 2

Re: [libvirt] kFreeBSD pdwtags make check failure

Hi Eric, On Fri, May 31, 2013 at 12:31:48PM -0600, Eric Blake wrote: > On 05/31/2013 12:16 PM, Guido Günther wrote: > > Hi, > > make check on kFreeBSD currently fails with: > > > > > -uint64_t cpu_time; > > +long unsig

Re: [libvirt] [PATCH 1/2] qemu: Change return type of qemuMonitorGetGuestCPU()

On Tue, Nov 12, 2013 at 10:04:09AM +0100, Peter Krempa wrote: > To allow returning more granullar errors, change the error type to an > integer. > --- > src/qemu/qemu_monitor.c | 19 --- > src/qemu/qemu_monitor.h | 5 +++-- > src/qemu/qemu_monitor_json.c | 26 +++

Re: [libvirt] [PATCH 2/2] qemu: Check for presence of device and properities when getting CPUID

On Tue, Nov 12, 2013 at 10:04:33AM +0100, Peter Krempa wrote: > The QOM path in qemu that contains the CPUID registers of a running VM > may not be present (introduced in QEMU 1.5). > > Since commit d94b7817719 we have a regression with QEMU that don't > support reporting of the CPUID register sta

Re: [libvirt] [PATCH libvirt-python 00/14] Split the python binding out

On Tue, Nov 12, 2013 at 06:21:43PM +, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > This patch series is a followup to > > https://www.redhat.com/archives/libvir-list/2013-September/msg00413.html I do like this much more than the version from September since it reuses much more

Re: [libvirt] [PATCH] Don't depend on syslog.service

On Mon, Nov 11, 2013 at 10:02:18AM +0100, Guido Günther wrote: > Syslog is socket activated since at least systemd v35 so we can drop > this dependency. Debian's linitian otherwise complains about it. > > References: > > http://www.freedesktop.org/wiki/Software/system

Re: [libvirt] [PATCH] Don't depend on syslog.service

On Tue, Nov 19, 2013 at 03:14:44PM -0500, Cole Robinson wrote: > On 11/11/2013 04:02 AM, Guido Günther wrote: > > Syslog is socket activated since at least systemd v35 so we can drop > > this dependency. Debian's linitian otherwise complains about it. > > > &g

[libvirt] [PATCH] Allow to install apparmor profiles

Make it easy to install the shipped examples. The aim is to have reasonably working templates so that distros only need to minimally patch these and can feed things upstream more easily. This was prompted by http://bugs.debian.org/725144 --- configure.ac | 12 +++- exampl

[libvirt] [ruby-libvirt] Don't free more entries than we retrieved

The vir*List* functions return the number of fetched entries. We mustn't free more, otherwise we'll crash like #0 0xb779d424 in __kernel_vsyscall () #1 0xb733981f in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56 #2 0xb733ccd3 in __GI_abort () at abort.c:90 #3

Re: [libvirt] [ruby-libvirt] Don't free more entries than we retrieved

On Tue, Jan 07, 2014 at 03:38:48PM -0500, Chris Lalancette wrote: > On Tue, Jan 7, 2014 at 3:24 PM, Guido Günther wrote: > > The vir*List* functions return the number of fetched entries. We mustn't > > free more, otherwise we'll crash like > > > > #0 0xb77

[libvirt] [ruby-libvirt] Allow to set URI via environment variable

This allows us to run tests with the destdriver like: RUBY_LIBVIRT_TEST_URI=test:///default \ RUBYLIB=lib/:ext/libvirt/ \ ruby tests/test_open.rb --- I've only converted three modules so far since they were simple but these already help to run tests during package build. tests/test_nodedev

[libvirt] [PATCH ruby-libvirt v2] Don't free more entries than we retrieved

The vir*List* functions return the number of fetched entries. We mustn't free more, otherwise we'll crash like #0 0xb779d424 in __kernel_vsyscall () #1 0xb733981f in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56 #2 0xb733ccd3 in __GI_abort () at abort.c:90 #3

Re: [libvirt] [PATCH] Allow to install apparmor profiles

On Tue, Jan 07, 2014 at 09:50:10AM -0700, Eric Blake wrote: > On 01/07/2014 09:19 AM, Guido Günther wrote: > > Make it easy to install the shipped examples. The aim is to have > > reasonably working templates so that distros only need to minimally > > patch these and can feed

Re: [libvirt] Add GVirConfigDomainDiskDriver

On Mon, Jan 06, 2014 at 10:59:31AM +0100, Christophe Fergeau wrote: > Hey, > > On Mon, Jan 06, 2014 at 10:40:49AM +0100, Michal Privoznik wrote: > > It's been a while since the last time I've written something for > > libivrt-glib. So just my two cents: I'd say go with new class esp. if > > there'

[libvirt] [PATCH] Make sure AC_ARG_WITH is always executed

--- I'm not sure whether it's good autoconf style to have AC_ARG_WITH in a conditional so this patch moves it out. Cheers, -- Guido configure.ac | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 97752f4..d02b9d2 100644 --- a/configure.ac +++

Re: [libvirt] Add GVirConfigDomainDiskDriver

On Tue, Jan 07, 2014 at 11:54:57PM +0100, Christophe Fergeau wrote: > On Tue, Jan 07, 2014 at 11:21:22PM +0100, Guido Günther wrote: > > On Mon, Jan 06, 2014 at 10:59:31AM +0100, Christophe Fergeau wrote: > > > Hey, > > > > > > On Mon, Jan 06, 2014 at 10:4

Re: [libvirt] [PATCH ruby-libvirt v2] Don't free more entries than we retrieved

On Tue, Jan 07, 2014 at 08:55:04PM -0500, Chris Lalancette wrote: > On Tue, Jan 7, 2014 at 4:54 PM, Guido Günther wrote: > > The vir*List* functions return the number of fetched entries. We mustn't > > free more, otherwise we'll crash like > > > > #0 0xb77

Re: [libvirt] [PATCH] Make sure AC_ARG_WITH is always executed

On Tue, Jan 07, 2014 at 04:19:14PM -0700, Eric Blake wrote: > On 01/07/2014 04:10 PM, Guido Günther wrote: > > --- > > I'm not sure whether it's good autoconf style to have AC_ARG_WITH in a > > conditional so this patch moves it out. > > Much of the

Re: [libvirt] [PATCHv2 6/7] lxc: add virProcessRunInMountNamespace

On Mon, Dec 23, 2013 at 10:55:50PM -0700, Eric Blake wrote: [..snip..] > +if (virAsprintf(&path, "/proc/%llu/ns/mnt", (unsigned long long)pid) < 0) > +goto cleanup; > + > +if ((fd = open(path, O_RDONLY)) < 0) { > +virReportSystemError(errno, "%s", > +

<    1   2   3   4   5   6   7   8   9   10   >