Re: [Lift] Re: Strip header from a subset of pages

2009-11-25 Thread Timothy Perrett
I dont disagree - I was just wanting to comment on the consistency of the API :-) Cheers, Tim On 25 Nov 2009, at 23:26, David Pollak wrote: > I'm not opposed to adding a skipXmlThingy style as well, but giving the > developer a generic function for inserting this XML top-matter is the higher

Re: [Lift] Re: Strip header from a subset of pages

2009-11-25 Thread David Pollak
I'm not opposed to adding a skipXmlThingy style as well, but giving the developer a generic function for inserting this XML top-matter is the higher priority. On Wed, Nov 25, 2009 at 3:24 PM, Timothy Perrett wrote: > David, > > I read harry's other email with interest - and thinking about it, it

Re: [Lift] Re: Strip header from a subset of pages

2009-11-25 Thread Timothy Perrett
David, I read harry's other email with interest - and thinking about it, it seems this style of implementation differs quite significantly from S.skipDocType. It strikes me that a LiftRules configuration is our usual idiom; is there a reason that S.skipDocType falls out of this? One way or an

Re: [Lift] Re: Strip header from a subset of pages

2009-11-25 Thread David Pollak
object excludeXmlHeaderStuff extends RequestVar(false) in boot: val current = LiftRules.calculateXmlHeader LiftRules.calculateXmlHeader = (resp, node, contentType) => if (excludeXmlHeaderStuff) "" else current(resp, node, contentType) On Wed, Nov 25, 2009 at 2:09 PM, harryh wrote: > It is no

[Lift] Re: Strip header from a subset of pages

2009-11-25 Thread harryh
It is not 100% obvious to me how I would, after this change is submitted, avoid sending an header when serving pages under a certain path. Should we be adding something similar to S.skipDocType (S.skipXmlHeader)? -harryh -- You received this message because you are subscribed to the Google Gro

[Lift] Re: Strip header from a subset of pages

2009-11-24 Thread David Pollak
http://reviewboard.liftweb.net/r/124/ On Nov 24, 3:40 pm, David Pollak wrote: > I've created issue 207:http://github.com/dpp/liftweb/issues/#issue/207 > > > > On Mon, Nov 23, 2009 at 12:34 PM, harryh wrote: > > > It will eliminate both the doctype and the thing. > > > This does not appear to be

Re: [Lift] Re: Strip header from a subset of pages

2009-11-24 Thread David Pollak
I've created issue 207: http://github.com/dpp/liftweb/issues/#issue/207 On Mon, Nov 23, 2009 at 12:34 PM, harryh wrote: > > It will eliminate both the doctype and the thing. > > This does not appear to be the case. I just tried it (on M7). Also > looking at the code for NodeResponse this does

[Lift] Re: Strip header from a subset of pages

2009-11-23 Thread harryh
> It will eliminate both the doctype and the thing. This does not appear to be the case. I just tried it (on M7). Also looking at the code for NodeResponse this does not appear to be what the code is doing. -harryh -- You received this message because you are subscribed to the Google Groups

Re: [Lift] Re: Strip header from a subset of pages

2009-11-23 Thread David Pollak
On Mon, Nov 23, 2009 at 12:22 PM, harryh wrote: > That will skip the DOCTYPE though right? > I'm looking to avoid sending the XML header ( encoding="UTF-8"?>) > It will eliminate both the doctype and the thing. If you just need to the XML header removed, please open a ticket and we'll add a Li

[Lift] Re: Strip header from a subset of pages

2009-11-23 Thread harryh
That will skip the DOCTYPE though right? I'm looking to avoid sending the XML header () -harryh On Nov 23, 3:03 pm, David Pollak wrote: > If you set S.skipDocType = false during the processing of the request for > these devices, the stuff will be omitted. > > > > On Mon, Nov 23, 2009 at 11:49 A