Mixing up 2.7 and 2.8 codes inline (was Re: [Lift] Why not SHtml?)

2010-02-10 Thread Indrajit Raychaudhuri
Hey Naftoli, Man, it would be great *not to* mix up 2.7 and 2.8 codes inline. Keeping it in sync with master would get very confusing and error prone (personally I don't find that aesthetically pleasing either). In fact, with some adjustment, it's possible to have parts of code friendly

Re: [Lift] Why not SHtml?

2010-02-09 Thread Naftoli Gugenheim
Could you give me exact instructions what to do to test my code on 2.8? Thanks. 2010/2/7 David Pollak feeder.of.the.be...@gmail.com On Sun, Feb 7, 2010 at 1:01 PM, Naftoli Gugenheim naftoli...@gmail.comwrote: So if I get around to it would it indeed be preferable to point it to SHtml?

Re: [Lift] Why not SHtml?

2010-02-09 Thread David Pollak
On Tue, Feb 9, 2010 at 2:28 PM, Naftoli Gugenheim naftoli...@gmail.comwrote: Could you give me exact instructions what to do to test my code on 2.8? git checkout -b 280_port_refresh origin/280_port_refresh cd framework/lift-persistence/lift-mapper emacs $(grep -l FIXME: 280 $(find . -name

Re: [Lift] Why not SHtml?

2010-02-09 Thread Naftoli Gugenheim
Sorry - what's the Windows (eclipse) equivalent--i.e., what does that line do? Also I wasn't sure what you meant by 'comments around my code.' Thanks! - David Pollakfeeder.of.the.be...@gmail.com wrote: On Tue, Feb 9, 2010 at 2:28 PM, Naftoli Gugenheim

Re: [Lift] Why not SHtml?

2010-02-09 Thread David Pollak
On Tue, Feb 9, 2010 at 2:49 PM, Naftoli Gugenheim naftoli...@gmail.comwrote: Sorry - what's the Windows (eclipse) equivalent--i.e., what does that line do? Find all the files that contain FIXME: 280 in the mapper package. Also I wasn't sure what you meant by 'comments around my code.' It

Re: [Lift] Why not SHtml?

2010-02-09 Thread Naftoli Gugenheim
Never mind, I go your intent. Thanks. - David Pollakfeeder.of.the.be...@gmail.com wrote: On Tue, Feb 9, 2010 at 2:28 PM, Naftoli Gugenheim naftoli...@gmail.comwrote: Could you give me exact instructions what to do to test my code on 2.8? git checkout -b

Re: [Lift] Why not SHtml?

2010-02-09 Thread Naftoli Gugenheim
Thanks - David Pollakfeeder.of.the.be...@gmail.com wrote: On Tue, Feb 9, 2010 at 2:49 PM, Naftoli Gugenheim naftoli...@gmail.comwrote: Sorry - what's the Windows (eclipse) equivalent--i.e., what does that line do? Find all the files that contain FIXME:

Re: [Lift] Why not SHtml?

2010-02-09 Thread Naftoli Gugenheim
Never mind, apparently I wasn't up to date. On Tue, Feb 9, 2010 at 11:20 PM, Naftoli Gugenheim naftoli...@gmail.comwrote: I got OneToMany to compile (not in a way that would work on 2.7 though). Then I tried to push it: naft...@naftoli-pc /c/dev/gitrepo/liftweb (280_port_refresh) $ git

[Lift] Why not SHtml?

2010-02-07 Thread Naftoli Gugenheim
Hello. Why do Mapper's toForm implementations use S.fmapFunc directly rather than using SHtml? Is it not duplicate code? Thanks. -- You received this message because you are subscribed to the Google Groups Lift group. To post to this group, send email to lift...@googlegroups.com. To

Re: [Lift] Why not SHtml?

2010-02-07 Thread Naftoli Gugenheim
So if I get around to it would it indeed be preferable to point it to SHtml? - David Pollakfeeder.of.the.be...@gmail.com wrote: On Sun, Feb 7, 2010 at 12:47 PM, Naftoli Gugenheim naftoli...@gmail.comwrote: Hello. Why do Mapper's toForm implementations use

Re: [Lift] Why not SHtml?

2010-02-07 Thread David Pollak
On Sun, Feb 7, 2010 at 1:01 PM, Naftoli Gugenheim naftoli...@gmail.comwrote: So if I get around to it would it indeed be preferable to point it to SHtml? Changing the code is one of the lowest priorities I could imagine. I would say that closing the stuff you've had on review board for 1

Re: [Lift] Why not SHtml?

2010-02-07 Thread Naftoli Gugenheim
Sure. It came up as part of those. The RB about TableEditor has been waiting for a Ship it for a while, and the one about ConversionRules is pretty much done locally -- some questions on Mapper's usage of it are on the list waiting for a good answer. - David