Re: [Lightning-dev] Liquidity Ads: Updated Spec Posted, please review

2023-11-22 Thread Bastien TEINTURIER
Hey Lisa, > One drawback is that it adds another reason an RBF attempt > might be rejected. That's true, but not including it is also a reason for an RBF attempt to be rejected! If the seller changed their mind (because the tx took too much time to confirm and they want to allocate their

Re: [Lightning-dev] Liquidity Ads: Updated Spec Posted, please review

2023-11-21 Thread niftynei
> Each RBF attempt renegotiates a potential liquidity purchase, independently of what the previous attempts contained. You're right, I'm missing the RBF spec! Thanks for the reminder. I think having the lease renegotiated makes sense, it gives maximum flexibility and allows the API for an

Re: [Lightning-dev] Liquidity Ads: Updated Spec Posted, please review

2023-11-21 Thread Bastien TEINTURIER
Hey Lisa, Thanks for the update! I believe that moving to CLTV instead of CSV is definitely the right move here. Regarding the newly added 2nd-stage lease locked transactions, I don't think that works. The issue is that you don't have an opportunity to receive signatures for those transactions

[Lightning-dev] Liquidity Ads: Updated Spec Posted, please review

2023-11-20 Thread niftynei
Hi all. The original Liquidity Ads spec draft[1] was posted a few years ago and implemented and shipped in core-lightning's v0.10.1 (Aug 2021). We received some great comments and feedback on the initial design, and I've since updated the spec to incorporate some of these changes. Big thanks