- **labels**: --> Fixed_2_21_0
- Description has changed:
Diff:
- **status**: Started --> Fixed
- **Needs**: -->
- **Patch**: new -->
- **Type**: Enhancement --> Critical
- **Comment**:
Pushed to staging as
commit 92e15f3cbc30036c823961812f06134ab9e2893b
Author: David
> but what bothers me a bit is that these positioning differences actually do
> not show up in the standard regtests. I didn't expect that at all.
Well, me neither. Hence the fume. I needed hitting in the face with it to
even start looking for an explanation. It's likely a potential problem
No problem with "fuming off", but what bothers me a bit is that these
positioning differences actually do not show up in the standard regtests. I
didn't expect that at all.
But when using the png comparison regtests (make-regtest-png.sh), the
differences will become visible - even the slight
`out/bin/lilypond -ddebug-skylines input/regression/skyline-grob-rotation.ly`
looks fixed with this patch. I'll give it an expedited push if there is some
corroboration.
---
** [issues:#5348] Fix bad rotation center from issue 5346**
**Status:** Started
**Created:** Sat Jun 16, 2018 08:39
> It should have shown up in the standard regtest procedures, I'll check this.
Sorry for fuming off here: I searched for the file name of your regtest image
and you named it different from the test so I thought it wasn't there and I had
no time looking for it. I think the problem is that our
---
** [issues:#5348] Fix bad rotation center from issue 5346**
**Status:** Started
**Created:** Sat Jun 16, 2018 08:39 PM UTC by David Kastrup
**Last Updated:** Sat Jun 16, 2018 08:39 PM UTC
**Owner:** nobody
Fix bad rotation center from issue 5346
http://codereview.appspot.com/341380043
- **labels**: --> Fixed_2_21_0
- **status**: Started --> Fixed
- **Patch**: push -->
- **Comment**:
commit bb34e5bbfdcf8d10877b5b85a339416f0a03c39b (HEAD ->
pushed/issue-5340-used-columns-in-range, origin/staging)
Author: Dan Eble
Date: Mon Jun 11 06:47:48 2018 -0400
Issue 5340:
This wasn't private at all since I actually had added this very example to the
regtests:
input/regression/skyline-grob-rotation.ly
It should have shown up in the standard regtest procedures, I'll check this.
By the way: grob rotation (the printed stencil) uses rotate_degrees, i.e. the
offset
Could you please keep tests like that not private but add them to the regtests?
Particularly when you are working on that area? This could have been caught
by either me or James then. I doubt I'll be able to fix this before tomorrow
as I have to leave for a family celebration soonish.
---
Sorry for reporting so late, but there's a problem with the rotation centre,
see attached image:
Attachments:
-
[issue-5346-skyline-rot.png](https://sourceforge.net/p/testlilyissues/issues/_discuss/thread/6083b388/f57c/attachment/issue-5346-skyline-rot.png)
(65.1 kB; image/png)
---
**
- Description has changed:
Diff:
- **Needs**: -->
- **Patch**: new --> review
- **Comment**:
Passes make, make check and a full make doc.
---
** [issues:#5347] Add and use a Transform data type**
**Status:** Started
**Created:** Sat Jun 16, 2018 09:03 AM UTC by David
- **labels**: --> Fixed_2_21_0
- **status**: Started --> Fixed
- **Patch**: push -->
- **Comment**:
~~~
author Don Armstrong
Sat, 2 Jun 2018 18:56:52 +0100 (18:56 +0100)
committer James Lowe
Sat, 16 Jun 2018 11:05:02 +0100 (11:05 +0100)
commit
- **labels**: --> Fixed_2_21_0
- **status**: Started --> Fixed
- **Patch**: push -->
- **Comment**:
~~~
author Alexander Myltsev
Wed, 27 Apr 2016 16:04:43 +0100 (18:04 +0300)
committer James Lowe
Sat, 16 Jun 2018 10:58:59 +0100 (10:58 +0100)
commit
---
** [issues:#5347] Add and use a Transform data type**
**Status:** Started
**Created:** Sat Jun 16, 2018 09:03 AM UTC by David Kastrup
**Last Updated:** Sat Jun 16, 2018 09:03 AM UTC
**Owner:** nobody
Add and use a Transform data type
As of now, this is just used in stencil-integral.
- **Patch**: review --> countdown
- **Comment**:
Patch on countdown for June 19th.
---
** [issues:#5346] Fix GC issue in skyline rotations**
**Status:** Started
**Created:** Fri Jun 15, 2018 03:32 PM UTC by David Kastrup
**Last Updated:** Fri Jun 15, 2018 04:32 PM UTC
**Owner:** David
- **Patch**: review --> countdown
- **Comment**:
Patch on countdown for June 19th.
---
** [issues:#5343] Remove Moment::as_scheme**
**Status:** Started
**Created:** Wed Jun 13, 2018 02:12 PM UTC by David Kastrup
**Last Updated:** Wed Jun 13, 2018 04:54 PM UTC
**Owner:** David Kastrup
- **Patch**: review --> countdown
- **Comment**:
Patch on countdown for June 19th.
---
** [issues:#5341] Urgent corrections to stencil-integral.cc (skylines)**
**Status:** Started
**Created:** Mon Jun 11, 2018 04:19 PM UTC by Torsten Hämmerle
**Last Updated:** Wed Jun 13, 2018 08:52 AM UTC
- **Patch**: countdown --> push
- **Comment**:
Patch counted down - I'll push.
---
** [issues:#5334] Use system* instead of system when invoking browser**
**Status:** Started
**Created:** Sat Jun 02, 2018 06:03 PM UTC by pkx166h
**Last Updated:** Wed Jun 13, 2018 02:41 PM UTC
**Owner:**
- **status**: Started --> Invalid
- **assigned_to**: Knut Petersen --> pkx166h
- **Comment**:
It b was a mistake (by me) to have created this - see
https://sourceforge.net/p/testlilyissues/issues/5334/
Setting invalid.
---
** [issues:#5342] lilypond-invoke-editor only should only handle
- **Patch**: countdown --> push
---
** [issues:#5338] Fix out-of-sync LilyScriptEncoding / ps script defs**
**Status:** Started
**Created:** Fri Jun 08, 2018 09:49 AM UTC by Knut Petersen
**Last Updated:** Sat Jun 16, 2018 08:49 AM UTC
**Owner:** Knut Petersen
Fix out-of-sync
- **Patch**: countdown --> push
- **Comment**:
Patch counted down - please push.
---
** [issues:#5340] Simplify Spacing_spanner::get_columns**
**Status:** Started
**Created:** Mon Jun 11, 2018 11:02 AM UTC by Dan Eble
**Last Updated:** Wed Jun 13, 2018 02:42 PM UTC
**Owner:** Dan Eble
21 matches
Mail list logo
