[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5346 Fix GC issue in skyline rotations

2018-06-16 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto
> but what bothers me a bit is that these positioning differences actually do > not show up in the standard regtests. I didn't expect that at all. Well, me neither. Hence the fume. I needed hitting in the face with it to even start looking for an explanation. It's likely a potential problem

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5346 Fix GC issue in skyline rotations

2018-06-16 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto
No problem with "fuming off", but what bothers me a bit is that these positioning differences actually do not show up in the standard regtests. I didn't expect that at all. But when using the png comparison regtests (make-regtest-png.sh), the differences will become visible - even the slight

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5346 Fix GC issue in skyline rotations

2018-06-16 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto
> It should have shown up in the standard regtest procedures, I'll check this. Sorry for fuming off here: I searched for the file name of your regtest image and you named it different from the test so I thought it wasn't there and I had no time looking for it. I think the problem is that our

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5346 Fix GC issue in skyline rotations

2018-06-16 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto
This wasn't private at all since I actually had added this very example to the regtests: input/regression/skyline-grob-rotation.ly It should have shown up in the standard regtest procedures, I'll check this. By the way: grob rotation (the printed stencil) uses rotate_degrees, i.e. the offset

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5346 Fix GC issue in skyline rotations

2018-06-16 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto
Could you please keep tests like that not private but add them to the regtests? Particularly when you are working on that area? This could have been caught by either me or James then. I doubt I'll be able to fix this before tomorrow as I have to leave for a family celebration soonish. ---