Re: attachment points for vertical spacing dimensions

2010-10-07 Thread Alexander Kobel
On 2010-10-07 04:11, Joe Neeman wrote: On Wed, Oct 6, 2010 at 1:26 AM, Mark Polesky mailto:markpole...@yahoo.com>> wrote: Joe Neeman wrote: > I would argue that the baseline is more natural then the > bottom. Moreover, using the baseline as a reference point > will result in m

Re: names of vertical spacing dimensions

2010-10-07 Thread Alexander Kobel
On 2010-10-06 17:46, Mark Polesky wrote: I also think the name 'space is misleading; I propose 'default-distance. Opinions? I can't see why 'space should be misleading, but that might just be that I'm accustomed to it by now. It's shorter, but anything other is okay as well. (Of course, thi

Re: names of vertical spacing dimensions

2010-10-07 Thread Mark Polesky
IIUC, making all of these changes should be done in 5 steps: 1) rename the variables in the code files 2) change 'space to 'default-distance* in the code files 3) write rules for convert-ly 4) update affected regtests (?) 5) update the docs *or Alexander's "optimal-distance" (still open to debate

Re: names of vertical spacing dimensions

2010-10-07 Thread David Kastrup
Mark Polesky writes: > IIUC, making all of these changes should be done in 5 steps: > > 1) rename the variables in the code files > 2) change 'space to 'default-distance* in the code files > 3) write rules for convert-ly > 4) update affected regtests (?) > 5) update the docs > > *or Alexander's "

Re: names of vertical spacing dimensions

2010-10-07 Thread Carl Sorensen
On 10/7/10 1:44 AM, "Alexander Kobel" wrote: > On 2010-10-06 17:46, Mark Polesky wrote: >> I also think the name 'space is misleading; I propose >> 'default-distance. Opinions? > > I can't see why 'space should be misleading, but that might just be that > I'm accustomed to it by now. It's s

Re: Inconsistent placing of TrillSpanners when not using \stopTrillSpan

2010-10-07 Thread Valentin Villenave
On Wed, Jul 7, 2010 at 2:56 PM, James Lowe wrote: > While updating the NR with the reg tests that have not yet been documented I > came across an anomaly with trill spanners. Greetings James and everybody, please forgive me for raising this issue again, but I do think this issue should be added

Re: names of vertical spacing dimensions

2010-10-07 Thread Alexander Kobel
On 2010-10-07 15:53, Carl Sorensen wrote: I like base-; it's shorter to type, and it still carries the right connotation. +1. Cheers, Alexander ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-de

Re: names of vertical spacing dimensions

2010-10-07 Thread Carl Sorensen
On 10/7/10 7:51 AM, "Valentin Villenave" wrote: > On Thu, Oct 7, 2010 at 3:41 PM, Carl Sorensen wrote: >> I think I'd prefer desired-distance to optimal-distance.  optimal distance >> is what the algorithms actually end up with, as a tradeoff between desired >> distance and the amount of stuf

Re: names of vertical spacing dimensions

2010-10-07 Thread Valentin Villenave
On Thu, Oct 7, 2010 at 3:41 PM, Carl Sorensen wrote: > I think I'd prefer desired-distance to optimal-distance.  optimal distance > is what the algorithms actually end up with, as a tradeoff between desired > distance and the amount of stuff on a page. How about requested- rather than desired-?

Question about 'odd' messages when running git pull -r

2010-10-07 Thread James
Hello, Occasionally when i run 'git pull -r' in a terminal I get the following jl...@jlowenetbuntu:~/lilypond-git$ git pull -r usage: git merge-base [-a|--all] ... -a, --all outputs all common ancestors usage: git merge-base [-a|--all] ... -a, --all outputs

Re: names of vertical spacing dimensions

2010-10-07 Thread David Kastrup
Carl Sorensen writes: > On 10/7/10 7:51 AM, "Valentin Villenave" wrote: > >> On Thu, Oct 7, 2010 at 3:41 PM, Carl Sorensen wrote: >>> I think I'd prefer desired-distance to optimal-distance.  optimal distance >>> is what the algorithms actually end up with, as a tradeoff between desired >>> dis

Re: names of vertical spacing dimensions

2010-10-07 Thread Mark Polesky
Enough votes are in for 'base-distance (and you can add my vote as well), so I think that settles it.  But I still need people to comment on 1) the patch: http://codereview.appspot.com/2303044 and 2) the approach: http://lists.gnu.org/archive/html/lilypond-devel/2010-10/msg00095.html Two more q

Missing image in web & docs

2010-10-07 Thread Francisco Vila
Hello all; A question: every @sourceimage PNG linked from the docs has to exist previously, or are there some of them that are expected to be rendered from EPS? We have a 404 in all languages, although the matching EPS does exist. offline docs out-www/offline-root/Documentation/pictures/context-

Re: names of vertical spacing dimensions

2010-10-07 Thread Graham Percival
On Thu, Oct 07, 2010 at 07:59:25AM -0700, Mark Polesky wrote: > 1) Pardon my ignorance, but do we ever run convert-ly on the > regtests? I'd consider that as part of 1288. Cheers, - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org http://l

Re: Missing image in web & docs

2010-10-07 Thread Graham Percival
On Thu, Oct 07, 2010 at 05:03:43PM +0200, Francisco Vila wrote: > A fix could be to render it manually into a PNG, then add it to the > repo. If this is the right solution, I could do it. No, that's not the right solution. My guess is that the generated image isn't getting produced in the right d

Unhealthy commit e3340714c8 Style: clarify "do nothing" macro with {};

2010-10-07 Thread David Kastrup
Here we have -#define ASSERT_LIVE_IS_ALLOWED() +#define ASSERT_LIVE_IS_ALLOWED() {}; The problem is that the replaced statement defines ASSERT_LIVE_IS_ALLOWED() as being 1, while the second defines it as {};. Now ASSERT_LIVE_IS_ALLOWED(); was one statement previously, while it now is three(!)

Re: Unhealthy commit e3340714c8 Style: clarify "do nothing" macro with {};

2010-10-07 Thread Graham Percival
On Thu, Oct 7, 2010 at 8:36 PM, David Kastrup wrote: > > -#define ASSERT_LIVE_IS_ALLOWED() > +#define ASSERT_LIVE_IS_ALLOWED() {}; > > The problem is that the replaced statement defines > ASSERT_LIVE_IS_ALLOWED() as being 1, while the second defines it as {};. > That is a particular bad idea for

Re: names of vertical spacing dimensions

2010-10-07 Thread Carl Sorensen
On 10/7/10 8:59 AM, "Mark Polesky" wrote: > Enough votes are in for 'base-distance (and you can add my > vote as well), so I think that settles it.  But I still need > people to comment on > > 1) the patch: > http://codereview.appspot.com/2303044 The patch looks fine to me. > > and > > 2)

Re: Question about 'odd' messages when running git pull -r

2010-10-07 Thread Colin Campbell
On Thu, 2010-10-07 at 15:29 +0100, James wrote: > Hello, > > Occasionally when i run 'git pull -r' in a terminal I get the following > > > jl...@jlowenetbuntu:~/lilypond-git$ git pull -r > > usage: git merge-base [-a|--all] ... > > > > -a, --all outputs all common ancestors > > >

Re: T1265 - Remove deprecation warnings when running with Guile V2 (issue2204044)

2010-10-07 Thread pnorcks
Hi Ian, Just a few more comments for you. I am okay with using scm_to_uint(); that looks like a safe route for us to take. Thanks, Patrick http://codereview.appspot.com/2204044/diff/14001/flower/include/guile-compatibility.hh File flower/include/guile-compatibility.hh (right): http://coderev

T1249 - Remove (define define-ly-syntax define-public). (issue2313044)

2010-10-07 Thread pnorcks
http://codereview.appspot.com/2313044/diff/1/scm/ly-syntax-constructors.scm File scm/ly-syntax-constructors.scm (left): http://codereview.appspot.com/2313044/diff/1/scm/ly-syntax-constructors.scm#oldcode20 scm/ly-syntax-constructors.scm:20: (define define-ly-syntax define-public) Instead of remo

Re: Fix #888: Add ly:stencil-scale. (issue2275042)

2010-10-07 Thread pnorcks
Hi Neil, Looks great! I just have a couple of comments for you (below). Thanks, Patrick http://codereview.appspot.com/2275042/diff/2001/input/regression/stencil-scale.ly File input/regression/stencil-scale.ly (right): http://codereview.appspot.com/2275042/diff/2001/input/regression/stencil-s

Re: Unhealthy commit e3340714c8 Style: clarify "do nothing" macro with {};

2010-10-07 Thread David Kastrup
Graham Percival writes: > On Thu, Oct 7, 2010 at 8:36 PM, David Kastrup wrote: >> >> -#define ASSERT_LIVE_IS_ALLOWED() >> +#define ASSERT_LIVE_IS_ALLOWED() {}; >> >> The problem is that the replaced statement defines >> ASSERT_LIVE_IS_ALLOWED() as being 1, while the second defines it as {};. > >

Re: Question about 'odd' messages when running git pull -r

2010-10-07 Thread Patrick McCarty
On Thu, Oct 7, 2010 at 7:29 AM, James wrote: > Hello, > > Occasionally when i run 'git pull -r' in a terminal I get the following > >> jl...@jlowenetbuntu:~/lilypond-git$ git pull -r >> usage: git merge-base [-a|--all] ... >> >>    -a, --all             outputs all common ancestors >> >> usage: g