LGTM. I was a bit shocked when I saw the collisions in the example, but
I think I understand Keith's point.
http://codereview.appspot.com/3782042/diff/1/Documentation/notation/keyboards.itely
File Documentation/notation/keyboards.itely (right):
http://codereview.appspot.com/3782042/diff/1/Docum
On Dec 23, 2010, at 5:21 AM, Graham Percival wrote:
>
> PS virtually nobody runs "make install", and I certainly wouldn't
> expect a new contributor to do this. The only people running
> "make install" should be linux package creators, and extremely
> advanced users who are both very familiar wi
Hi,
I'm trying to get an easier method of creating custom string tunings (see
http://article.gmane.org/gmane.comp.gnu.lilypond.general/60871)
I'd like to do one of the following:
\makeStringTuning #'violin-tuning
or
violin-tuning = \makeStringTuning
I can get the chord music argument into
On 2010/12/23 04:41:43, Keith wrote:
> I don't see a patch to convertrules.py.
> [...] Am I missing something?
Reinhold created the rule months ago, along with the implementation of
the new
\cresc. (I should have said "is *already* convert-ly-ed".)
> Deprecated doesn't mean removed, it m
I don't see a patch to convertrules.py.
[...] Am I missing something?
Reinhold created the rule months ago, along with the implementation of
the new \cresc. (I should have said "is *already* convert-ly-ed".)
Deprecated doesn't mean removed, it means "still in
place, but we recommend that it n
On Wed, Dec 22, 2010 at 08:52:44PM -0700, Colin Campbell wrote:
> I had occasion to try and run convert-ly (from Frescobaldi, but
> LIlyPondTool was the same) over a piece I'd opened in Denemo then saved
> as a .ly file. Convert-ly promptly threw an error about not finding
> lilylib. After a bit o
On 2010/12/23 04:11:34, Keith wrote:
Thanks for the comments. Second patch set is up.
The new patch corresponds to the state *before* makelsr.py, so that it
is not
cluttered with version bumps to all the snippets.
Regarding deprecation,
the old *prefix* implementation of \cresc, never doc
Thanks for the comments. Second patch set is up.
The new patch corresponds to the state *before* makelsr.py, so that it
is not cluttered with version bumps to all the snippets.
Regarding deprecation,
the old *prefix* implementation of \cresc, never documented, is
convert-ly-ed to \deprecatedcres
Over the course of time, I've kept myself amused with building lilypond
from git by doing the usual make and sudo make install stuff.
Apparently, each successive install created a new folder
in /usr/local/share for each new version installed. The import scripts
(midi2ly and friends) were left in /
This has been up for nearly three days now. Any comments?
http://codereview.appspot.com/3782042/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
http://codereview.appspot.com/3743045/diff/1/Documentation/notation/expressive.itely
File Documentation/notation/expressive.itely (right):
http://codereview.appspot.com/3743045/diff/1/Documentation/notation/expressive.itely#newcode366
Documentation/notation/expressive.itely:366: Textual crescend
http://codereview.appspot.com/3743045/diff/1/Documentation/notation/expressive.itely
File Documentation/notation/expressive.itely (right):
http://codereview.appspot.com/3743045/diff/1/Documentation/notation/expressive.itely#newcode366
Documentation/notation/expressive.itely:366: Textual crescend
On Tue, Dec 21, 2010 at 03:03:24PM +0100, Valentin Villenave wrote:
> On Tue, Dec 21, 2010 at 12:33 AM, Graham Percival
> wrote:
> > % or even:
> > c2 d e d | e f g f | g f e d
> > \break
> > c2 d e d | e f g f | g c, e d | c1
>
> Why not use quarter-notes?
I think there was some spacing reas
On 2010/12/22 12:37:41, pkx166h wrote:
I think that the two 'warning' boxes will look a bit awkward
Maybe, but the placement makes the warning much more relevant. Let's
leave for a couple of days, and if there are no further comments send me
a patch.
http://codereview.appspot.com/3705042/
_
http://codereview.appspot.com/3743045/diff/1/Documentation/notation/expressive.itely
File Documentation/notation/expressive.itely (right):
http://codereview.appspot.com/3743045/diff/1/Documentation/notation/expressive.itely#newcode366
Documentation/notation/expressive.itely:366: Textual crescend
My comments on the two discussion points below.
http://codereview.appspot.com/3743045/diff/1/Documentation/notation/expressive.itely
File Documentation/notation/expressive.itely (right):
http://codereview.appspot.com/3743045/diff/1/Documentation/notation/expressive.itely#newcode366
Documentatio
Federico Bruni wrote Wednesday, December 22, 2010 4:10 PM
2010/12/22 Mike Solomon
1) svgdance.svg (best viewed in something that's not Internet
Explorer -
click on the notes and/or accidentals and see what happens!)
Actually, only clicks on notes work here (FF4 and Opera), nothing
happe
Your thoughts generally look good to me, but I'll need to see a patch
before I can approve.
Thanks,
Carl
http://codereview.appspot.com/3743045/diff/1/Documentation/notation/expressive.itely
File Documentation/notation/expressive.itely (right):
http://codereview.appspot.com/3743045/diff/1/Doc
On 2010/12/22 21:43:37, Keith wrote:
> The snippets in input/regression/ are *not* part of the
documentation
Now I see. I updated the file in /snippets/new so it uses the
predefined \cresc
(just like updated the reg-test does).
Perfect!
I have this and the tweaks noted below ready for a
Reviewers: carl.d.sorensen_gmail.com, Trevor Daniels, Graham Percival,
Message:
The snippets in input/regression/ are *not* part of the documentation
Now I see. I updated the file in /snippets/new so it uses the predefined
\cresc (just like updated the reg-test does).
I have this and the twea
2010/12/22 Mike Solomon
> 1) svgdance.svg (best viewed in something that's not Internet Explorer -
> click on the notes and/or accidentals and see what happens!)
>
Cool! Thanks for sharing :)
cheers,
Janek
PS i opened it in Google Chrome and only the d flat was animated - when i
clicked on f s
On 12/22/10 4:16 AM, "Marc Hohl" wrote:
> Am 22.12.2010 09:48, schrieb Carl Sorensen:
>> On 12/22/10 1:30 AM, "Marc Hohl" wrote:
>>
>>> Hello all,
>>>
>>> attached is a small patch to handle Issue 1035.
>>>
>>> Instead of giving an error, it raises a warning when negative frets
>>> are cal
2010/12/22 Mike Solomon
> Hey all,
>
> I am embarking on a new project to make lily dance.
>
> Attached are 3 files:
>
> 1) svgdance.svg (best viewed in something that's not Internet Explorer -
> click on the notes and/or accidentals and see what happens!)
>
>
Cool!
Actually, only clicks on note
Reviewers: Trevor Daniels,
Message:
Trevor, I've add the full point.
I'll send to you directly to push if that's ok?
James
http://codereview.appspot.com/3792041/diff/1/Documentation/notation/ancient.itely
File Documentation/notation/ancient.itely (right):
http://codereview.appspot.com/379204
Done.
However I think that the two 'warning' boxes will look a bit awkward,
but I understand why Graham doesn't want them all in the same @warning
{}.
http://codereview.appspot.com/3705042/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http:/
Am 22.12.2010 09:48, schrieb Carl Sorensen:
On 12/22/10 1:30 AM, "Marc Hohl" wrote:
Hello all,
attached is a small patch to handle Issue 1035.
Instead of giving an error, it raises a warning when negative frets
are calculated in tablature staves or in fret diagrams.
Marc,
If instead of bei
Hi James
I think a further change is needed to position the warning in repeats
correctly.
Trevor
http://codereview.appspot.com/3705042/diff/12001/Documentation/notation/repeats.itely
File Documentation/notation/repeats.itely (right):
http://codereview.appspot.com/3705042/diff/12001/Documentat
- Ursprüngliche Mitteilung -
>
> Carl Sorensen wrote Tuesday, December 21, 2010 10:22 PM
> > On 12/21/10 1:14 PM, "Valentin Villenave"
> > wrote:
> >
> > > Oh, and by the way: we have \textSpannerDown for text spanners,
> > > but
> > > not \textDown for simple TextScript objects (that
Carl Sorensen wrote Tuesday, December 21, 2010 10:22 PM
On 12/21/10 1:14 PM, "Valentin Villenave"
wrote:
Oh, and by the way: we have \textSpannerDown for text spanners,
but
not \textDown for simple TextScript objects (that are quite
likely to
be needed by new users). Anyone against addin
Valentin Villenave wrote Tuesday, December 21, 2010 8:14 PM
I've been looking at the LM 4.4.2 Placement of objects >
Within-staff
objects, and I'm not sure we want to use "Down/Left" and
"Up/Right" in
the table. Yes, we all know that -1 and 1 may respectively mean
either
"down" or "left" and
On 12/22/10 1:48 AM, "Carl Sorensen" wrote:
> I think that's a more robust way to handle it than setting the negative fret
> number.
Oops, I meant "that's a more robust way to handle it than ignoring the note
with the negative fret number."
Thanks,
Carl
_
On 12/22/10 1:30 AM, "Marc Hohl" wrote:
> Hello all,
>
> attached is a small patch to handle Issue 1035.
>
> Instead of giving an error, it raises a warning when negative frets
> are calculated in tablature staves or in fret diagrams.
Marc,
If instead of being inside set-fret, this check took
Hello all,
attached is a small patch to handle Issue 1035.
Instead of giving an error, it raises a warning when negative frets
are calculated in tablature staves or in fret diagrams.
Regards,
Marc
From 4a1a80c4be5426e5b4c34beee19656f85aa52ba9 Mon Sep 17 00:00:00 2001
From: Marc Hohl
Date: Wed
33 matches
Mail list logo
