Re: Fixes issue 39 by raising stems (issue3934041)

2011-01-13 Thread Mike Solomon
Thanks Keith, I think that the case you're talking about (<< e'32. \\ e'2>>) is a problem with my code, which triggers stem raising for flags that fall on the right even though these flags do note cause intersection problems. Is there a good way to weed this out? On Jan 13, 2011, at 1:03 AM,

Coding style

2011-01-13 Thread David Kastrup
Hi, in note-collision.cc I read the following: Direction d = UP; do { vector &clashes (clash_groups[d]); vector_sort (clashes, Note_column::shift_less); } while ((flip (&d)) != UP); Uh, is there any reason not to just write vector_sort (clash_groups[UP], Note_column

Re: Fixes issue 39 by raising stems (issue3934041)

2011-01-13 Thread Keith OHara
On Thu, 13 Jan 2011 03:23:16 -0800, Mike Solomon wrote: I think that the case you're talking about (<< e'32. \\ e'2>>) is a problem with my code, which triggers stem raising for flags that fall on the right even though these flags do note cause intersection problems. Is there a good way to

Re: 2.13.46 regtests

2011-01-13 Thread Graham Percival
On Wed, Jan 12, 2011 at 4:01 PM, Phil Holmes wrote: > Have we ever done a regression test versus 2.12.3? Depends what you mean. 2.13.0 (or maybe .1) had a regtest comparison to 2.12.0. 2.13.1 had a regtest comparison to 2.13.0. etc. We haven't done a recent-2.13 comparison to 2.12.3 because w

Re: Coding style

2011-01-13 Thread Joe Neeman
On Thu, Jan 13, 2011 at 7:19 PM, David Kastrup wrote: > > Hi, > > in note-collision.cc I read the following: > > Direction d = UP; > do >{ > vector &clashes (clash_groups[d]); > vector_sort (clashes, Note_column::shift_less); >} > while ((flip (&d)) != UP); > > Uh, is there a

Re: Optical spacing fails at tight situations

2011-01-13 Thread Janek Warchoł
Hi, looks like this mail was somehow overlooked. May i ask you to answer the question posed by James - is the behaviour described below intended? 2011/1/4 James Bailey > > On Dec 30, 2010, at 12:48 PM, Janek Warchoł wrote: > > > Hi, > > > > didn't find it in the tracker so i report: > > optical

Re: Optical spacing fails at tight situations

2011-01-13 Thread Carl Sorensen
On 1/13/11 7:24 AM, "Janek Warchoł" wrote: > Hi, > > looks like this mail was somehow overlooked. May i ask you to answer > the question posed by James - is the behaviour described below > intended? I assume that the reason it hasn't been answered is because nobody knows. But as notes are sque

Re: Optical spacing fails at tight situations

2011-01-13 Thread Janek Warchoł
W dniu 13 stycznia 2011 16:02 użytkownik Carl Sorensen napisał: > On 1/13/11 7:24 AM, "Janek Warchoł" > wrote: > >> Hi, >> >> looks like this mail was somehow overlooked. May i ask you to answer >> the question posed by James - is the behaviour described below >> intended? > > I assume that the r

Re: Coding style

2011-01-13 Thread Han-Wen Nienhuys
On Thu, Jan 13, 2011 at 10:19 AM, David Kastrup wrote: > > Hi, > > in note-collision.cc I read the following: > >  Direction d = UP; >  do >    { >      vector &clashes (clash_groups[d]); >      vector_sort (clashes, Note_column::shift_less); >    } >  while ((flip (&d)) != UP); > > Uh, is there a

Re: Optical spacing fails at tight situations

2011-01-13 Thread Carl Sorensen
On 1/13/11 8:14 AM, "Janek Warchoł" wrote: > W dniu 13 stycznia 2011 16:02 użytkownik Carl Sorensen > napisał: >> On 1/13/11 7:24 AM, "Janek Warchoł" >> wrote: >> >>> Hi, >>> >>> looks like this mail was somehow overlooked. May i ask you to answer >>> the question posed by James - is the beha

Re: Coding style

2011-01-13 Thread David Kastrup
Han-Wen Nienhuys writes: > On Thu, Jan 13, 2011 at 10:19 AM, David Kastrup wrote: >> >> Hi, >> >> in note-collision.cc I read the following: >> >>  Direction d = UP; >>  do >>    { >>      vector &clashes (clash_groups[d]); >>      vector_sort (clashes, Note_column::shift_less); >>    } >>  whil

Re: Potential fix for issue 37

2011-01-13 Thread Mike Solomon
Hey Jan, Please check out http://codereview.appspot.com/3928041/ for the most recent version, which has a regtest. Cheers, MS On Jan 13, 2011, at 12:49 PM, Jan Nieuwenhuizen wrote: > [cc: lilypond-devel] > > This looks great, I don't see a regression test file; are you > adding that please? >

Re: Potential fix for issue 37

2011-01-13 Thread Jan Nieuwenhuizen
[cc: lilypond-devel] This looks great, I don't see a regression test file; are you adding that please? Jan Mike Solomon schreef op vr 07-01-2011 om 20:54 [-0500]: > Kinda meh, but it gets the job done! I've included three patches, > including the original. > The second preserves the flat beams

Re: Coding style

2011-01-13 Thread Hans Aberg
On 13 Jan 2011, at 16:50, David Kastrup wrote: Doesn't C++ have some more useful idiom for iterators or so? Then you'd have to write a function to apply. Below is an example; I let you decide if it is more useful. :-) Something like for (d=UP;;d=DOWN) { ... if (d == DOWN)

volunteers for commit-finding for a regression

2011-01-13 Thread Graham Percival
We've found a regression; I'll announce that the release candidate is no good. Here's the issue: http://code.google.com/p/lilypond/issues/detail?id=1472 Do we have any volunteers to find the exact commit in which this broke? Recently-rewritten instructions here: http://lilypond.org/doc/v2.13/Doc

Re: volunteers for commit-finding for a regression

2011-01-13 Thread Phil Holmes
Can't do it tonight, but assuming my Ubuntu VM can do this, I could do it before tomorrow evening. -- Phil Holmes - Original Message - From: "Graham Percival" To: Sent: Thursday, January 13, 2011 6:15 PM Subject: volunteers for commit-finding for a regression We've found a regre

Re: volunteers for commit-finding for a regression

2011-01-13 Thread Carl Sorensen
On 1/13/11 11:15 AM, "Graham Percival" wrote: > We've found a regression; I'll announce that the release candidate > is no good. Here's the issue: > http://code.google.com/p/lilypond/issues/detail?id=1472 I think we've already identified the commit. It's the removal of extra-spacing-height

Re: volunteers for commit-finding for a regression

2011-01-13 Thread Graham Percival
On Thu, Jan 13, 2011 at 11:24:06AM -0700, Carl Sorensen wrote: > > On 1/13/11 11:15 AM, "Graham Percival" wrote: > > > We've found a regression; I'll announce that the release candidate > > is no good. Here's the issue: > > http://code.google.com/p/lilypond/issues/detail?id=1472 > > I think we

Re: volunteers for commit-finding for a regression

2011-01-13 Thread Carl Sorensen
On 1/13/11 11:56 AM, "Graham Percival" wrote: > On Thu, Jan 13, 2011 at 11:24:06AM -0700, Carl Sorensen wrote: >> >> On 1/13/11 11:15 AM, "Graham Percival" wrote: >> >>> We've found a regression; I'll announce that the release candidate >>> is no good. Here's the issue: >>> http://code.google

Re: Coding style

2011-01-13 Thread David Kastrup
Hans Aberg writes: > On 13 Jan 2011, at 16:50, David Kastrup wrote: >> Doesn't C++ have some more useful >> idiom for iterators or so? > > Then you'd have to write a function to apply. Below is an example; I > let you decide if it is more useful. :-) > >> Something like >> >>for (d=UP;;d=DOWN

Re: Optical spacing fails at tight situations

2011-01-13 Thread Janek Warchoł
2011/1/13 Carl Sorensen : > On 1/13/11 8:14 AM, "Janek Warchoł" > wrote: >> I'd say that instead of adding some space between notes that should be >> put farther apart, some space can be substracted from between notes >> that should be closer, and the result is the same. >> There is plenty of spac

Re: volunteers for commit-finding for a regression

2011-01-13 Thread Keith OHara
Graham Percival percival-music.ca> writes: > Oh, ok. It would have been nice if somebody had added this to the > issue tracker. I've added the patch there. > When the bug reports get immediate replies or questions, there is a tendency to wait for the discussion to die down before opening a n

Re: Optical spacing fails at tight situations

2011-01-13 Thread Carl Sorensen
On 1/13/11 2:16 PM, "Janek Warchoł" wrote: > > The distances are not equal. Optical corrections are made there. > OK, you got me interested so I spent some time I didn't have on this. I must be a LilyPond addict. It appears that the optical spacing *is* being added during note-spacing.cc. I as