RE: regression tests for white mensural ligature enhancements (issue3989049)

2011-02-02 Thread James Lowe
Hello, -Original Message- From: lilypond-devel-bounces+james.lowe=datacore@gnu.org [mailto:lilypond-devel-bounces+james.lowe=datacore@gnu.org] On Behalf Of Graham Percival Sent: 01 February 2011 19:21 To: benko@gmail.com; percival.music...@gmail.com; pkx1...@gmail.com;

Re: Messed up adding issue 1499

2011-02-02 Thread Trevor Daniels
Graham Percival wrote Tuesday, February 01, 2011 9:28 PM On Tue, Feb 01, 2011 at 09:09:50PM -, Trevor Daniels wrote: Any idea why my entry as contributor fails? It looks right. If you mean why couldn't I edit that field, then I'd double-check that you're logged in. If you mean why

Re: Cleanup beam scoring code. (issue4001046)

2011-02-02 Thread Reinhold Kainhofer
Am Mittwoch, 2. Februar 2011, um 06:49:14 schrieb Werner LEMBERG: There is one diff remaining: see the attached file. I introduced some streamlining of an inner loop, which affects the way we handle beams that start/end with invisible stems. The compare image is the new one. I have no

Re: Cleanup beam scoring code. (issue4001046)

2011-02-02 Thread Han-Wen Nienhuys
On Wed, Feb 2, 2011 at 3:49 AM, Werner LEMBERG w...@gnu.org wrote: There is one diff remaining: see the attached file.  I introduced some streamlining of an inner loop, which affects the way we handle beams that start/end with invisible stems. The compare image is the new one.  I have no

Re: Cleanup beam scoring code. (issue4001046)

2011-02-02 Thread Reinhold Kainhofer
Am Mittwoch, 2. Februar 2011, um 15:54:36 schrieb Han-Wen Nienhuys: On Wed, Feb 2, 2011 at 3:49 AM, Werner LEMBERG w...@gnu.org wrote: There is one diff remaining: see the attached file. I introduced some streamlining of an inner loop, which affects the way we handle beams that start/end

PATCHES: 48-hour notice for note spacing and negative frets

2011-02-02 Thread Graham Percival
Unless I hear complaints (or requests for more time), I will be pushing these patches on: Friday, 6pm GMT. Fix melisma spacing (the infamous re-fix for 1120) http://codereview.appspot.com/4095041/ Fix Issue 1035 -- Add context property for negative frets

Re: regression tests for white mensural ligature enhancements (issue3989049)

2011-02-02 Thread Benkő Pál
http://codereview.appspot.com/3989049/diff/3002/Documentation/notation/ancient.itely#newcode966 Documentation/notation/ancient.itely:966: \[ d\longa Can we put note durations for the first note of every new line (again as per the CG)? I'm afraid I don't get this.  all first notes have

Re: regression tests for white mensural ligature enhancements (issue3989049)

2011-02-02 Thread pkx166h
Thanks, that all looks good. http://codereview.appspot.com/3989049/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Add Modal transformations (issue4126042)

2011-02-02 Thread tdanielsmusic
Might it be worth having some predefined scales, i.e. \diatonicScale and \pentatonicScale and the like? I don't think so; they are not unique. Even a chromatic scale can be written using many combinations of naming the enharmonically equivalent notes. You might argue that a C major scale

Re: regression tests for white mensural ligature enhancements (issue3989049)

2011-02-02 Thread Benkő Pál
hi James, The CG asks that for every new line of music you put the note length of the first note of every measure that starts a new line, even though it is not technically needed. That's all. So for example \override NoteHead #'style = #'blackpetrucci  a'8*4/3 a'  \override NoteHead

Re: PATCHES: 48-hour notice for note spacing and negative frets

2011-02-02 Thread Han-Wen Nienhuys
On Wed, Feb 2, 2011 at 1:58 PM, Graham Percival gra...@percival-music.ca wrote: Not quite on this list, but I would like to draw people's attention to: some kind of beaming work http://codereview.appspot.com/4022045 I don't know how this interacts (if at all) with Han-Wen's recent work on

Re: regression tests for white mensural ligature enhancements (issue3989049)

2011-02-02 Thread Graham Percival
On Wed, Feb 02, 2011 at 12:19:58PM +, James Lowe wrote: On Mon, Jan 31, 2011 at 11:17:46AM +, pkx1...@gmail.com wrote: Just some minor syntax changes to make it read better. I hope no one is offended. Not offended, but unfortunately I already pushed it. Could you make these

RE: regression tests for white mensural ligature enhancements (issue3989049)

2011-02-02 Thread James Lowe
Benko, -Original Message- From: Benkő Pál [mailto:benko@gmail.com] Sent: 02 February 2011 17:09 To: James Lowe Cc: Graham Percival; lilypond-devel@gnu.org Subject: Re: regression tests for white mensural ligature enhancements (issue3989049) \longa is a duration; a'8\longa should

Re: Add Modal transformations (issue4126042)

2011-02-02 Thread Bernard Hurley
On Wed, Feb 02, 2011 at 11:20:22AM +, tdanielsmu...@googlemail.com wrote: Might it be worth having some predefined scales, i.e. \diatonicScale and \pentatonicScale and the like? I don't think so; they are not unique. I'm not sure what you mean by this. For instance: \majorScale c is

RE: regression tests for white mensural ligature enhancements (issue3989049)

2011-02-02 Thread James Lowe
Benko, -Original Message- From: lilypond-devel-bounces+james.lowe=datacore@gnu.org [mailto:lilypond-devel-bounces+james.lowe=datacore@gnu.org] On Behalf Of Benko Pál Sent: 02 February 2011 16:22 To: Graham Percival Cc: pkx1...@gmail.com; re...@codereview.appspotmail.com;

Re: Add Modal transformations (issue4126042)

2011-02-02 Thread Graham Percival
On Wed, Feb 02, 2011 at 05:55:04PM +, Bernard Hurley wrote: On Wed, Feb 02, 2011 at 11:20:22AM +, tdanielsmu...@googlemail.com wrote: Might it be worth having some predefined scales, i.e. \diatonicScale and \pentatonicScale and the like? I don't think so; they are not unique.

Re: Messed up adding issue 1499

2011-02-02 Thread Graham Percival
On Wed, Feb 02, 2011 at 11:37:43AM -, Trevor Daniels wrote: Graham Percival wrote Tuesday, February 01, 2011 9:28 PM If you mean why can't I be set to be the owner of this issue, then... I couldn't set it to you with the @googlemail part in there, but when I took it out I could set it

Re: regression tests for white mensural ligature enhancements (issue3989049)

2011-02-02 Thread Benkő Pál
Pal, could you do that git pull, then send me git format-patch origin ?  Now that we have James' approval, let's push your latest patch. attached; thanks! p 0001-document-new-mensural-ligature-features.patch Description: Binary data ___

Re: Cleanup beam scoring code. (issue4001046)

2011-02-02 Thread Werner LEMBERG
BTW, the pages from Read and Stone that I quoted are up at: http://www.fam.tuwien.ac.at/~reinhold/LilyPond/WholeNoteTremolo/ Thanks, I stay corrected. Werner ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Fix 1120 in a way to avoid issues 1472, 1474 (issue4095041)

2011-02-02 Thread n . puttock
LGTM. http://codereview.appspot.com/4095041/diff/52002/lily/separation-item.cc File lily/separation-item.cc (right): http://codereview.appspot.com/4095041/diff/52002/lily/separation-item.cc#newcode83 lily/separation-item.cc:83: double horizon_padding = robust_scm2double (me-get_property

Re: Fix Issue 1035 -- Add context property for negative frets (issue4056041)

2011-02-02 Thread n . puttock
LGTM. Just needs rebasing (I assume you don't want to delete tablature-dot-placement.ly) http://codereview.appspot.com/4056041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: PATCHES: 48-hour notice for note spacing and negative frets

2011-02-02 Thread m...@apollinemike.com
On Feb 2, 2011, at 12:43 PM, Han-Wen Nienhuys wrote: On Wed, Feb 2, 2011 at 1:58 PM, Graham Percival gra...@percival-music.ca wrote: Not quite on this list, but I would like to draw people's attention to: some kind of beaming work http://codereview.appspot.com/4022045 I don't know how

Re: PATCHES: 48-hour notice for note spacing and negative frets

2011-02-02 Thread Han-Wen Nienhuys
On Thu, Feb 3, 2011 at 12:26 AM, m...@apollinemike.com m...@apollinemike.com wrote: The most recent patch set only has a single pass through beam quanting.  I don't believe it adds significant overhead to a score's compile time, although I'd need someone to do some benchmarking to verify that.

Optimize beam scoring. (issue4129047)

2011-02-02 Thread hanwenn
Reviewers: , Message: Please review. Description: Optimize beam scoring. Use a priority queue of scores. This allows us to drop the arbitrary reasonable_score threshold. On morgenlied.ly, this reduces the number of scoring passes from 13.5k to 10.7k. Please review this at

Re: Optimize beam scoring. (issue4129047)

2011-02-02 Thread Han-Wen Nienhuys
regtest is clean. On Thu, Feb 3, 2011 at 12:40 AM, hanw...@gmail.com wrote: Reviewers: , Message: Please review. Description: Optimize beam scoring. Use a priority queue of scores.  This allows us to drop the arbitrary reasonable_score threshold. On morgenlied.ly, this reduces the

Re: Add Modal transformations (issue4126042)

2011-02-02 Thread k-ohara5a5a
This works very nicely for me. One tiny oops, and suggestions you can take or leave as you wish. I think I understand the point that some scales *can* un-ambiguously named, but a facility to generate scales from these names is not necessary for this patch. I can type myPentatonic = \relative

Re: Fix 1120 in a way to avoid issues 1472, 1474 (issue4095041)

2011-02-02 Thread k-ohara5a5a
On 2011/02/02 23:14:39, Neil Puttock wrote: LGTM. http://codereview.appspot.com/4095041/diff/52002/lily/separation-item.cc File lily/separation-item.cc (right): http://codereview.appspot.com/4095041/diff/52002/lily/separation-item.cc#newcode83 lily/separation-item.cc:83: double