Phil Holmes m...@philholmes.net wrote in message news:...
The regtests on the website look fine, although some of the text items
have
been moved.
On my pixel comparator, I think every single regtest is different. It
looks
like a number of elements, including noteheads and time sigs, have
Phil Holmes m...@philholmes.net wrote in message
news:in1e3s$to9$1...@dough.gmane.org...
Phil Holmes m...@philholmes.net wrote in message news:...
The regtests on the website look fine, although some of the text items
have
been moved.
On my pixel comparator, I think every single regtest is
http://codereview.appspot.com/4323045/diff/1/ly/engraver-init.ly#oldcode424
ly/engraver-init.ly:424: instrumentName = #'()
I'm missing something from the commit message -- why are you
removing
these?
They were in the context definition twice, so I deleted
one of the duplicates. Sorry, I
Reviewers: ,
Message:
Cheers,
Mike
Description:
Adds stem acknowledgement to beam collision engraver to fix issue 795.
Please review this at http://codereview.appspot.com/4337045/
Affected files:
M lily/beam-collision-engraver.cc
Index: lily/beam-collision-engraver.cc
diff --git
Patch set 3 follows up on Neil's suggestion to use
the kill-zero-spanned-time callback. This patch
removes the changes in Patch set 1 (which was pushed)
and implements this alternative fix. This is both
simpler and permits the behaviour to be changed with
an override.
Regtests run clean.
New patch coming soon after license update.
http://codereview.appspot.com/4277067/diff/1/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):
http://codereview.appspot.com/4277067/diff/1/Documentation/notation/input.itely#newcode1690
tiM Sportny wrote:
I'm using windows 7 64 bit, lilypond 2.12.3
I hope you can tell me what i'm doing wrong
i hope i can: i doubt inter-box-padding was available under 2.12.3!
cheers
Eluze
--
View this message in context:
Are you able to build a regtest comparison with this patch? I can't,
but I also haven't been able to identify the problematic file(s) within
10 minutes of poking around.
http://codereview.appspot.com/4337045/
___
lilypond-devel mailing list
On Mar 31, 2011, at 5:39 PM, percival.music...@gmail.com wrote:
Are you able to build a regtest comparison with this patch? I can't,
but I also haven't been able to identify the problematic file(s) within
10 minutes of poking around.
http://codereview.appspot.com/4337045/
\relative c'{
Lots of changes to stem lengths, but it compiles and nothing makes me go
definitely ick.
http://codereview.appspot.com/4337045/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
On Mar 31, 2011, at 6:39 PM, percival.music...@gmail.com wrote:
Lots of changes to stem lengths, but it compiles and nothing makes me go
definitely ick.
http://codereview.appspot.com/4337045/
I'm a fan of most of the changes in the regtests.
I'm amazed you got it to compile, though. Mine
11 matches
Mail list logo
