LGTM
http://codereview.appspot.com/4278058/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Carl Sorensen wrote Saturday, April 30, 2011 1:59 PM
So it appears that the biggest source of Critical bugs, and the
thing that
is holding up release of 2.14, is the beam-collision-engraver.
Should we try to remove the beam-collision-engraver from 2.14.0?
Or should
we wait for it to settle
http://codereview.appspot.com/4426072/diff/4002/lily/beam.cc
File lily/beam.cc (right):
http://codereview.appspot.com/4426072/diff/4002/lily/beam.cc#newcode1329
lily/beam.cc:1329: while (dirty);
this looks fishy; what guarantees that the loop will terminate?
forbidden is
[ (-inf, 2),
On May 1, 2011, at 5:24 AM, hanw...@gmail.com wrote:
http://codereview.appspot.com/4426072/diff/4002/lily/beam.cc
File lily/beam.cc (right):
http://codereview.appspot.com/4426072/diff/4002/lily/beam.cc#newcode1329
lily/beam.cc:1329: while (dirty);
this looks fishy; what guarantees that
I've created a patch that gets rid of the warning messages in make website,
and want to upload it for comments. I use the LilyPond Ubuntu build in a
VM, and use lily-git.tcl. I've created the patch, and am trying to follow
the instructions at
I don't like spamming about bugs, but here goes anyway.
http://code.google.com/p/lilypond/issues/detail?id=1615
Do these instructions work reliably for anybody?
mkdir new-lilypond-dir
cd new-lilypond-dir
git init
git config core.bare false
git remote add -t master origin
2011/5/1 Graham Percival gra...@percival-music.ca:
I don't like spamming about bugs, but here goes anyway.
http://code.google.com/p/lilypond/issues/detail?id=1615
Do these instructions work reliably for anybody?
mkdir new-lilypond-dir
cd new-lilypond-dir
git init
git config core.bare
- Original Message -
From: Graham Percival gra...@percival-music.ca
To: Phil Holmes m...@philholmes.net
Cc: lilypond-devel@gnu.org
Sent: Sunday, May 01, 2011 5:59 PM
Subject: Re: Uploading a patch to Rietveld
On Sun, May 01, 2011 at 05:36:45PM +0100, Phil Holmes wrote:
When I type
Ran the regtests - had to make one change, but they are now squeaky
clean. Confirmations would be appreciated!
Cheers,
Mike
http://codereview.appspot.com/4426072/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
On Sun, May 01, 2011 at 07:24:13PM +0200, Francisco Vila wrote:
2011/5/1 Graham Percival gra...@percival-music.ca:
git remote add -t master origin git://git.sv.gnu.org/lilypond.git
git fetch --depth 1
This command block has worked for me at the first attempt. It leaves
an empty directory
On Sun, May 01, 2011 at 06:44:41PM +0100, Phil Holmes wrote:
- Original Message - From: Graham Percival
Are you certain that you have the latest version? IIRC we added
git-cl in lilydev-1.1. It was certainly one of the last things
that was added. We certainly don't expect new
On Sun, May 1, 2011 at 7:03 PM, Graham Percival
gra...@percival-music.ca wrote:
mkdir new-lilypond-dir
cd new-lilypond-dir
git init
git config core.bare false
git remote add -t master origin git://git.sv.gnu.org/lilypond.git
git fetch --depth 1
I may be wrong, but doesn't
$ git clone
On Sun, May 01, 2011 at 08:55:55PM +0200, Valentin Villenave wrote:
On Sun, May 1, 2011 at 7:03 PM, Graham Percival
gra...@percival-music.ca wrote:
git fetch --depth 1
I may be wrong, but doesn't
$ git clone git://git.sv.gnu.org/lilypond.git
do exactly that in one single line?
No,
- programmers: any new regression tests or features should have
\version 2.15.0.
- Carl: if you backport any .ly file (regtest or snippet or doc),
change the version to 2.13.x.
- bug squad: absolutely nothing changes for you.
- after 2.14.0 is out: who knows.
Cheers,
- Graham
- Original Message -
From: Graham Percival gra...@percival-music.ca
To: Phil Holmes m...@philholmes.net
Cc: lilypond-devel@gnu.org
Sent: Sunday, May 01, 2011 7:16 PM
Subject: Re: Uploading a patch to Rietveld
On Sun, May 01, 2011 at 06:44:41PM +0100, Phil Holmes wrote:
- Original
On Sun, May 01, 2011 at 08:35:15PM +0100, Phil Holmes wrote:
- Original Message - From: Graham Percival
On Sun, May 01, 2011 at 06:44:41PM +0100, Phil Holmes wrote:
the iso from lilynet is named ubuntu-lilydev-remix-1.1.iso
so if yours is called something else, I'd be suspicious.
LGTM.
It wasn't necessary to remove \chordGlissando from the text of the
non-english docs, and it may even have been best not to do so.
We need to keep compiling working, so if these docs had a snippet
containing \chordGlissando, we would have needed to change that. But
since the snippet was
On May 1, 2011, at 1:15 PM, carl.d.soren...@gmail.com wrote:
LGTM.
It wasn't necessary to remove \chordGlissando from the text of the
non-english docs, and it may even have been best not to do so.
We need to keep compiling working, so if these docs had a snippet
containing
- Original Message -
From: Graham Percival gra...@percival-music.ca
To: Phil Holmes m...@philholmes.net
Cc: lilypond-devel@gnu.org
Sent: Sunday, May 01, 2011 9:02 PM
Subject: Re: Uploading a patch to Rietveld
On Sun, May 01, 2011 at 08:35:15PM +0100, Phil Holmes wrote:
- Original
Graham Percival gra...@percival-music.ca writes:
Both methods will work, but one of them feels a bit off.
and then try:
git-cl
you should get a git cl help message at this point.
Yup :-). Is the CG in error - it says git cl, not git-cl?
It should be fine either way.
Why? AFAICS, git
Am Sonntag, 1. Mai 2011, um 23:36:16 schrieb David Kastrup:
Graham Percival gra...@percival-music.ca writes:
Both methods will work, but one of them feels a bit off.
and then try:
git-cl
you should get a git cl help message at this point.
Yup :-). Is the CG in error - it says
On Sun, May 01, 2011 at 11:54:43PM +0200, Reinhold Kainhofer wrote:
Am Sonntag, 1. Mai 2011, um 23:36:16 schrieb David Kastrup:
If you did not place the git-cl binary there,
you can't use git cl instead. If you did place it there, you can't use
git-cl as it won't be in the path.
Clearly
22 matches
Mail list logo
