Better approach to fixing the TabVoice glissando problem. (issue4438092)

Reviewers: , Message: A better approach to the TabVoice glissando problem, although I'm still not quite sure why it works, but it seems to work! Cheers, MS Description: Better approach to fixing the TabVoice glissando problem. Please review this at http://codereview.appspot.com/4438092/ Affec

Kludgy way to get the glissando engraver working with tabs. (issue4428081)

Reviewers: , Message: I have no clue why this works, but I think it works and solves Federico's problem. Hopefully someone can have a look at it and suggest a better way to tackle this. Cheers, MS Description: Kludgy way to get the glissando engraver working with tabs. Please review this at ht

Changed custom paper size in scm file (issue4432088)

LGTM, please push. http://codereview.appspot.com/4432088/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix error messages in website build (issue4428077)

On 2011/05/02 17:43:12, email_philholmes.net wrote: - Original Message - From: "Graham Percival" > python has .readlines() for a file, and generally it's > "pythonesque" to use lists. You'll be trying to convert me to Lisp next :-) Have I mentioned y

Re: Doc: Adjusted CG Policy on @lilypond[] variables (issue4445070)

LGTM http://codereview.appspot.com/4445070/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix error messages in website build (issue4428077)

- Original Message - From: "Graham Percival" To: "Phil Holmes" Cc: ; ; ; Sent: Monday, May 02, 2011 6:28 PM Subject: Re: Fix error messages in website build (issue4428077) On Mon, May 02, 2011 at 05:29:27PM +0100, Phil Holmes wrote: >http://codereview.appspot.com/4428077/diff/1/s

Re: Uploading a patch to Rietveld

On Mon, May 02, 2011 at 05:36:59PM +0100, Phil Holmes wrote: > - Original Message - From: "James Lowe" > )BTW - it might be worth mentioning in the CG that "git cl upload > )origin/master" at one point fires you into vi. For windows users, that's a > )bit of an issue - took me a couple of

Re: Doc: Adjusted CG Policy on @lilypond[] variables (issue4445070)

wrote Monday, May 02, 2011 5:22 PM http://codereview.appspot.com/4445070/diff/4001/Documentation/contributor/doc-work.itexi#newcode314 Documentation/contributor/doc-work.itexi:314: inlcude the @code{papersize=X} variable, where @code{X} is a defined Done the typo..where's the superfluous spac

Re: Fix error messages in website build (issue4428077)

On Mon, May 02, 2011 at 05:29:27PM +0100, Phil Holmes wrote: > >http://codereview.appspot.com/4428077/diff/1/scripts/build/extract_texi_filenames.py#newcode65 > >scripts/build/extract_texi_filenames.py:65: known_missing_files = '' > >could this be a list instead of a string? > > I thought about wh

Re: Uploading a patch to Rietveld

- Original Message - From: "James Lowe" To: "Phil Holmes" ; "Graham Percival" Cc: Sent: Monday, May 02, 2011 5:28 PM Subject: RE: Uploading a patch to Rietveld Hello, )-Original Message- )From: lilypond-devel-bounces+james.lowe=datacore@gnu.org )[mailto:lilypond-devel-b

Re: Fix error messages in website build (issue4428077)

- Original Message - From: To: Cc: ; Sent: Monday, May 02, 2011 4:20 PM Subject: Re: Fix error messages in website build (issue4428077) good start! I'm not certain about the location of the text file (having it inside scripts/ seems a bit weird), but the framework is definitely the

RE: Uploading a patch to Rietveld

Hello, )-Original Message- )From: lilypond-devel-bounces+james.lowe=datacore@gnu.org )[mailto:lilypond-devel-bounces+james.lowe=datacore@gnu.org] On )Behalf Of Phil Holmes )Sent: 02 May 2011 17:16 )To: Graham Percival )Cc: lilypond-devel@gnu.org )Subject: Re: Uploading a patch to R

Re: Doc: Adjusted CG Policy on @lilypond[] variables (issue4445070)

Third draft includes new change from c9landscape to a8landscape - this requires an approval of http://codereview.appspot.com/4432088 first as the new paper size is changed in the file in that patch (didn't think it good form to combine the two). http://codereview.appspot.com/4445070/diff/4001/D

Re: Uploading a patch to Rietveld

- Original Message - From: "Phil Holmes" To: "Graham Percival" In the end, I nuked the git directory (having copied my changes elsewhere) and started from scratch. It's at http://codereview.appspot.com/4428077/ but hopefully this should be announced properly. -- Phil Holmes BT

PATCH: added new paper size in scm/paper.scm - updates original commit 71e0343fdf2a1936b07db0a5892155351c72d553

Updates original commit 71e0343fdf2a1936b07db0a5892155351c72d553 http://codereview.appspot.com/4432088 Regards James ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix error messages in website build (issue4428077)

good start! I'm not certain about the location of the text file (having it inside scripts/ seems a bit weird), but the framework is definitely there. http://codereview.appspot.com/4428077/diff/1/scripts/build/extract_texi_filenames.py File scripts/build/extract_texi_filenames.py (right): http:

Re: Uploading a patch to Rietveld

- Original Message - From: "Graham Percival" To: "Phil Holmes" Cc: Sent: Monday, May 02, 2011 2:08 PM Subject: Re: Uploading a patch to Rietveld On Mon, May 02, 2011 at 01:41:50PM +0100, Phil Holmes wrote: - Original Message - From: "Graham Percival" >- have you rebooted?

Re: 2.13.61 Windows version wrong

Phil Holmes-2 wrote: > > > If you right-click, properties, details, the version number of the > executable is wrong. > i didn't check that - you're right! -- View this message in context: http://old.nabble.com/2.13.61-Windows-version-wrong-tp31523709p31524008.html Sent from the Gnu - Lilypo

Re: 2.13.61 Windows version wrong

- Original Message - From: "-Eluze" To: Sent: Monday, May 02, 2011 3:05 PM Subject: Re: 2.13.61 Windows version wrong Phil Holmes-2 wrote: The 2.13.61 release for Windows reports an internal version number of 2.13.60. under windows vista it's ok (tagline, file-info [snippet 19

Re: 2.13.61 Windows version wrong

On Mon, May 02, 2011 at 02:44:20PM +0100, Phil Holmes wrote: > The 2.13.61 release for Windows reports an internal version number > of 2.13.60. I noticed that the VERSION hadn't been updated after building packages, so I cancelled the build, changed the number, then started it again. That general

Re: 2.13.61 Windows version wrong

Phil Holmes-2 wrote: > > The 2.13.61 release for Windows reports an internal version number of > 2.13.60. > under windows vista it's ok (tagline, file-info [snippet 197] and the log). -- View this message in context: http://old.nabble.com/2.13.61-Windows-version-wrong-tp31523709p31523875.ht

2.13.61 regtests

Apart from the previous report concerning Windows version number, regtests look good, both on my pixel comparator and the official site. Beam bug appears fixed from regtest check. -- Phil Holmes Bug Squad ___ lilypond-devel mailing list lilypond-

2.13.61 Windows version wrong

The 2.13.61 release for Windows reports an internal version number of 2.13.60. -- Phil Holmes Bug Squad ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: savannah git fetch --depth 1

On Mon, May 02, 2011 at 11:02:47AM +0200, Valentin Villenave wrote: > On Sun, May 1, 2011 at 9:08 PM, Graham Percival > wrote: > > No, clone gets the entire history.  fetch --depth 1  only gets the > > previous 1 commit, so it's less to download. > > Note that clone also accepts a --depth argumen

Re: Uploading a patch to Rietveld

Graham Percival writes: > On Mon, May 02, 2011 at 01:41:50PM +0100, Phil Holmes wrote: >> - Original Message - From: "Graham Percival" >> >- have you rebooted? IIRC the ubuntu startup scripts >> >> No. I have now, and git cl now works :-) Except I get a failure like this: >> >> phil@

Re: Uploading a patch to Rietveld

On Mon, May 02, 2011 at 01:41:50PM +0100, Phil Holmes wrote: > - Original Message - From: "Graham Percival" > >- have you rebooted? IIRC the ubuntu startup scripts > > No. I have now, and git cl now works :-) Except I get a failure like this: > > phil@phil-lilydev:~/lilypond-git$ git c

Re: Uploading a patch to Rietveld

- Original Message - From: "Graham Percival" To: "Phil Holmes" Cc: Sent: Monday, May 02, 2011 12:41 PM Subject: Re: Uploading a patch to Rietveld On Mon, May 02, 2011 at 10:22:26AM +0100, Phil Holmes wrote: I'm guessing a) my bin directory is not in my PATH yet? Sounds like it.

Re: Uploading a patch to Rietveld

On Mon, May 02, 2011 at 10:22:26AM +0100, Phil Holmes wrote: > I'm guessing a) my bin directory is not in my PATH yet? Sounds like it. - have you rebooted? IIRC the ubuntu startup scripts automatically add ~/bin/ to your PATH if it exists. - if no, then add this to your ~/.profile # set PATH s

Re: Uploading a patch to Rietveld

"Phil Holmes" writes: > phil@phil-lilydev:~/lilypond-git$ git-cl upload origin/master > bash: /bin/git-cl: No such file or directory That sounds like a symbolic link from /bin/git-cl pointing nowhere. There is little reason for bash to single out /bin/git-cl otherwise. -- David Kastrup _

RE: Uploading a patch to Rietveld

Phil, )-Original Message- )From: Phil Holmes [mailto:m...@philholmes.net] )Sent: 02 May 2011 11:39 )To: James Lowe; Graham Percival )Cc: lilypond-devel@gnu.org )Subject: Re: Uploading a patch to Rietveld ) ) )- Original Message - )From: "James Lowe" )To: "Phil Holmes" ; "Graham Pe

Re: Uploading a patch to Rietveld

- Original Message - From: "James Lowe" To: "Phil Holmes" ; "Graham Percival" Cc: Sent: Monday, May 02, 2011 10:52 AM Subject: RE: Uploading a patch to Rietveld Phil, )-Original Message- )From: lilypond-devel-bounces+james.lowe=datacore@gnu.org )[mailto:lilypond-devel

RE: Uploading a patch to Rietveld

Phil, )-Original Message- )From: lilypond-devel-bounces+james.lowe=datacore@gnu.org )[mailto:lilypond-devel-bounces+james.lowe=datacore@gnu.org] On )Behalf Of Phil Holmes )Sent: 02 May 2011 10:22 )To: Phil Holmes; Graham Percival )Cc: lilypond-devel@gnu.org )Subject: Re: Uploading

Re: Uploading a patch to Rietveld

Latest sit-rep of my attempts. I now have a bin directory under my home phil directory. It contains a singe file - looks like it's a link to git-cl at /home/phil/git-cl/git-cl. If I do "git cl upload origin/master" I get: git: 'cl' is not a git command I'm guessing a) my bin directory is not

Re: savannah git fetch --depth 1

On Sun, May 1, 2011 at 9:08 PM, Graham Percival wrote: > No, clone gets the entire history.  fetch --depth 1  only gets the > previous 1 commit, so it's less to download. Note that clone also accepts a --depth argument (aka "shallow clones"). So my point is still valid. > This series of commands