Re: GOP-PROP 3: C++ formatting

2011-06-21 Thread m...@apollinemike.com
On Jun 22, 2011, at 2:54 AM, Keith OHara wrote: > Graham Percival percival-music.ca> writes: > >> This one will be contentious. > > Maybe the various opinions will share a small overlapping area of consensus; > applying even a small improvement might be enough to make life easier. > >> ** Eli

Re: GOP-PROP 3: C++ formatting

2011-06-21 Thread Jan Warchoł
2011/6/22 Graham Percival : > I see three main contenders: > >    * emacs x.y.z with extra post-processing: our current >      “official” style with scripts/auxiliar/fixcc.py >    * astyle 2.0.2, possibly with extra post-processing >    * uncrustify 0.58 I'm confused. Are we talking about choosin

Re: GOP-PROP 2: mentors and Frogs - probably decision

2011-06-21 Thread Jan Warchoł
2011/6/18 Graham Percival : > Of people who have git access, what (if anything) > would make you consider being a mentor?  Not everybody > is cut out to be a teacher; if you don't feel comfortable in that > position, then it's best not to offer. I think the answer came to my mind: "i'd spend some

Re: GOP-PROP 3: C++ formatting

2011-06-21 Thread Keith OHara
Graham Percival percival-music.ca> writes: > This one will be contentious. Maybe the various opinions will share a small overlapping area of consensus; applying even a small improvement might be enough to make life easier. > ** Eliminate tabs > That helps (even though editors should handle ta

GOP-PROP 3: C++ formatting

2011-06-21 Thread Graham Percival
This one will be contentious. ** Proposal summary Speaking academically, C++ code style is a "solved problem". Let’s pick one of the existing solutions, and let a computer deal with this. Humans should not waste their time, energy, and creativity manually adding tabs or spaces to source code. I

GOP-PROP 2: mentors and Frogs - probably decision

2011-06-21 Thread Graham Percival
Not much change from the initial one. http://lilypond.org/~graham/gop/gop_2.html ** Proposal summary Many new contributors expect more help than they’re getting. We should either: 1. give them more help, or 2. tell them up-front that they won’t be getting help. Think of a roller-coaster e

Re: Question: 'External references' in compiled scheme files when moving to Guile V2 from V1.8.7

2011-06-21 Thread Ludovic Courtès
Hi Ian, Ian Hulin skribis: > (for-each ly:load init-scheme-files) > > Most of these files assume definitions are going into the default (lily) > module, but some .scm files lower down the list reference definitions > declared in a .scm file above it in the list. > > My question is this: >

Re: PATCHES: 48-hour notice for removing extra naturals and beam bound endpoints

2011-06-21 Thread m...@apollinemike.com
On Jun 21, 2011, at 11:16 PM, Han-Wen Nienhuys wrote: > On Tue, Jun 21, 2011 at 6:19 AM, Graham Percival > wrote: > >> Attaches bound info to beam for better normalized-endpoint >> calculations >> http://codereview.appspot.com/4605047 > > * How does setting left/right-bound-info achieve anythin

Re: PATCHES: 48-hour notice for removing extra naturals and beam bound endpoints

2011-06-21 Thread Han-Wen Nienhuys
On Tue, Jun 21, 2011 at 6:19 AM, Graham Percival wrote: > Attaches bound info to beam for better normalized-endpoint > calculations > http://codereview.appspot.com/4605047 * How does setting left/right-bound-info achieve anything? AFAICS, it is only read in line-spanner.cc * last_normal_stem

Re: GOP-PROP 2: mentors and Frogs

2011-06-21 Thread Graham Percival
On Tue, Jun 21, 2011 at 03:01:37PM +0200, Jan Warchoł wrote: > 2011/6/18 Graham Percival > > Here's the responsibilities for mentors.  Do any of these seem too > > heavy?  We can relax/remove any that are a sticking point for many > > people. > > I see that these are the same that we have in CG p

Re: Question: 'External references' in compiled scheme files when moving to Guile V2 from V1.8.7

2011-06-21 Thread Ian Hulin
Hi all, The original post was sent to the guile-users list and cc'ed here. Cheers, Ian ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: GOP-PROP 2: mentors and Frogs

2011-06-21 Thread Graham Percival
On Wed, Jun 15, 2011 at 03:20:51PM +0200, Jan Warchoł wrote: > 2011/6/15 Graham Percival : > > I think the story of this patch > > http://code.google.com/p/lilypond/issues/detail?id=1630 > > http://codereview.appspot.com/4490045/ > > is a horrible black eye for us.  Initial patch sent on 2011-04-29

Question: 'External references' in compiled scheme files when moving to Guile V2 from V1.8.7

2011-06-21 Thread Ian Hulin
Hi, I'm currently working on getting Lilypond to use Guile V2 and compiled Scheme files. Currently, using V1.8.7, the Lilypond image fires up a lily.scm file which includes as list of other .scm files. The initialization code in the program declares a (lily) module and adjusts %load-path enable

Re: enharmonic problem with \transpose - should we modify it?

2011-06-21 Thread Felipe Gonçalves Assis
Hi, About enharmonicity: 2011/6/20 Benkő Pál : > > with an algebraic pitch representation the test and adjustment would > look like as follows: > two pitches are enharmonic iff their interval is in the subspace spanned > by the enharmonic interval (default: diminished second) and the scale > peri

Re: ambitus: special handling of small ambits' lines (issue4609041)

2011-06-21 Thread m...@apollinemike.com
On Jun 21, 2011, at 3:31 PM, Janek Warchoł wrote: > 2011/6/21 m...@apollinemike.com : >> What I meant is that every time you use a magic number (i.e. 0.35), >> consider making it user-tweakable unless you are absolutely sure >> that there is no utility in changing that number. > > Ah, you meant t

Re: ambitus: special handling of small ambits' lines (issue4609041)

2011-06-21 Thread Janek Warchoł
2011/6/21 m...@apollinemike.com : > What I meant is that every time you use a magic number (i.e. 0.35), > consider making it user-tweakable unless you are absolutely sure > that there is no utility in changing that number. Ah, you meant this! :) well, i think that 0.35 in (ly:grob-property grob 'g

Re: ambitus: special handling of small ambits' lines (issue4609041)

2011-06-21 Thread Phil Holmes
- Original Message - From: "Janek Warchoł" Have you zoomed the output to check it? I suppose its a rasterization problem; a lot of things seem to be wrong when output is watched unzoomed on a computer screen (for example one stem in the attachment looks two times thicker than the other,

Re: ambitus: special handling of small ambits' lines (issue4609041)

2011-06-21 Thread m...@apollinemike.com
On Jun 21, 2011, at 3:04 PM, lemniskata.bernoull...@gmail.com wrote: > > http://codereview.appspot.com/4609041/diff/12001/scm/define-grobs.scm > File scm/define-grobs.scm (right): > > http://codereview.appspot.com/4609041/diff/12001/scm/define-grobs.scm#newcode141 > scm/define-grobs.scm:141: (wo

Re: ambitus: special handling of small ambits' lines (issue4609041)

2011-06-21 Thread Janek Warchoł
Hi Karin, i'm back from my short vacation. 2011/6/17 : > the description explains clearly how to use the parameters gap and woot. > So, it is a good starting point to understanding the scheme code that > follows. Good! >> Yes, the quanting stays the same. > > I couldn't find the verb "to quant

Re: GOP-PROP 2: mentors and Frogs

2011-06-21 Thread Jan Warchoł
2011/6/18 James Lowe : > > Well I'm happy to help and of course I can 'mentor' someone around editing > doc and formatting and uploading patches, however I seem to be of the 'rare' > breed here that while understanding 'coding' principles and terminology, has > no ability to write code (I can ju

Re: ambitus: special handling of small ambits' lines (issue4609041)

2011-06-21 Thread Janek Warchoł
2011/6/17 James Lowe : > Hello > > What about 'glyph-space-distance-within-staff-affinity-thing'? cheek> > Isn't that more in keeping with the new spacing terminology. Huh? I don't understand. The <> tags don't match! :P ___ lilypond-devel mailing l

Re: ambitus: special handling of small ambits' lines (issue4609041)

2011-06-21 Thread lemniskata . bernoullego
http://codereview.appspot.com/4609041/diff/12001/scm/define-grobs.scm File scm/define-grobs.scm (right): http://codereview.appspot.com/4609041/diff/12001/scm/define-grobs.scm#newcode141 scm/define-grobs.scm:141: (woot . 1) On 2011/06/17 07:18:49, MikeSol wrote: This seems like 1337 $p34k - I ha

Re: GOP-PROP 2: mentors and Frogs

2011-06-21 Thread Jan Warchoł
2011/6/18 Graham Percival > Well, I'm not encouraged by the general disinterest in this topic. I'm afraid it's because this problem isn't about finding some new solutions or establishing a policy (like with C++ code formatting), but about doing more work. *Maybe* someone will discover a great ide

Re: PartCombine: Keep track of the state in the Part_combine_engraver (issue3334043)

2011-06-21 Thread reinhold . kainhofer
On 2011/06/21 09:27:28, Graham Percival wrote: It would be nice if Neil's concerns could be addressed and we could move forward with this patch. Actually, that patch by itself it not that useful as it might first look. Its main purpose is to make it possible to print the a2/Solo I/Solo II tex

Re: CueClefs: Use middleCClefPosition in the key engraver (issue4551101)

2011-06-21 Thread percival . music . ca
LGTM, please push after making the small changes requested by Neil. http://codereview.appspot.com/4551101/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: PartCombine: Keep track of the state in the Part_combine_engraver (issue3334043)

2011-06-21 Thread percival . music . ca
It would be nice if Neil's concerns could be addressed and we could move forward with this patch. http://codereview.appspot.com/3334043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

PATCHES: 48-hour notice for removing extra naturals and beam bound endpoints

2011-06-21 Thread Graham Percival
Thurs 11:00. default accidental style prints too many 'extra' natural http://code.google.com/p/lilypond/issues/detail?id=1701 Attaches bound info to beam for better normalized-endpoint calculations http://codereview.appspot.com/4605047 Cheers, - Graham

Re: Current state of automatic footnotes. (issue4580041)

2011-06-21 Thread percival . music . ca
I can confirm the "cannot compile with this patch applied". http://codereview.appspot.com/4580041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel