On Jul 26, 2011, at 5:01 AM, hanw...@gmail.com wrote:
regtest missing.
http://codereview.appspot.com/4813048/diff/3001/lily/slur-scoring.cc
File lily/slur-scoring.cc (right):
http://codereview.appspot.com/4813048/diff/3001/lily/slur-scoring.cc#newcode286
lily/slur-scoring.cc:286:
On Jul 26, 2011, at 5:23 AM, Han-Wen Nienhuys wrote:
On Fri, Jul 22, 2011 at 5:33 PM, m...@apollinemike.com
m...@apollinemike.com wrote:
Hey Han-Wen,
I've been bumping into this problem recently :
http://code.google.com/p/lilypond/issues/detail?id=1645
and I think the solution is in the
For whatever reason, the review processes are not working. The code in
commit 104f80daf1dab11ef5b598006e3d4be8dfbe1926
repeatedly uses floating point arithmetic like int(pow(2.0,...)) where
the outcome is not guaranteed to be correct, it does its calculations
based on non-existing glyphs
David Kastrup writes:
The overall code makes obvious that this has been created by a
comparative novice to the programming languages and data structures of
Lilypond. He has been doing his best.
Good catch. The patch also
@@ -208,63 +221,46 @@ Multi_measure_rest::church_rest (Grob *me,
Jan Nieuwenhuizen writes:
The patch also
removes a reference
Not so, it is moved
+++ b/scm/define-grobs.scm
@@ -1309,6 +1309,8 @@
(staff-position . 0)
(stencil . ,ly:multi-measure-rest::print)
(thick-thickness . 6.6)
+ ;; See Wanske pp. 125
+
On Jul 26, 2011, at 11:22 AM, Jan Nieuwenhuizen wrote:
David Kastrup writes:
The overall code makes obvious that this has been created by a
comparative novice to the programming languages and data structures of
Lilypond. He has been doing his best.
Good catch. The patch also
@@
m...@apollinemike.com m...@apollinemike.com writes:
On Jul 26, 2011, at 11:22 AM, Jan Nieuwenhuizen wrote:
David Kastrup writes:
The overall code makes obvious that this has been created by a
comparative novice to the programming languages and data structures of
Lilypond. He has been
On Jul 26, 2011, at 12:05 PM, David Kastrup wrote:
m...@apollinemike.com m...@apollinemike.com writes:
On Jul 26, 2011, at 11:22 AM, Jan Nieuwenhuizen wrote:
David Kastrup writes:
The overall code makes obvious that this has been created by a
comparative novice to the programming
Yes, this probably needs to be discussed during the GLISS.
But maybe we can do something before, because adding the tilde notation
doesn't mean that the current syntax must be removed.
Bertrand
___
lilypond-devel mailing list
lilypond-devel@gnu.org
Am Dienstag, 26. Juli 2011, 12:33:03 schrieb Bertrand Bordage:
Yes, this probably needs to be discussed during the GLISS.
But maybe we can do something before, because adding the tilde notation
doesn't mean that the current syntax must be removed.
But implementing both systems is a lot more
Please review:
http://codereview.appspot.com/1659041/
This patch adds support for including MusicXML files into
documents processed by lilypond-book. In particular:
-) HTML: musicxmlfile optionsfilename.xml/musicxmlfile
-) TeX: \musicxmlfile[options]{filename.xml}
-) Texinfo:
Okay, I will fix these before the end of the day.
Thanks for taking time to do the review !
Bertrand
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
I currently can't build doc. Fresh pull, nuked and recreated build
directory. I get:
extract_texi_filenames.py: Processing out-www/usage.texi
writing: /home/phil/lilypond-git/build/./out-www/xref-maps/usage.de.xref-map
cp -p web.texi out-www/web.texi
cp: cannot stat `web.texi': No such file
LGTM (without testing).
http://codereview.appspot.com/1659041/diff/5001/Documentation/usage/lilypond-book.itely
File Documentation/usage/lilypond-book.itely (right):
http://codereview.appspot.com/1659041/diff/5001/Documentation/usage/lilypond-book.itely#newcode207
Phil Holmes m...@philholmes.net wrote in message
news:j0mln8$tvu$1...@dough.gmane.org...
I currently can't build doc. Fresh pull, nuked and recreated build
directory. I get:
extract_texi_filenames.py: Processing out-www/usage.texi
writing:
On 2011/07/26 06:14:47, mike_apollinemike.com wrote:
On Jul 26, 2011, at 5:01 AM, mailto:hanw...@gmail.com wrote:
regtest missing.
http://codereview.appspot.com/4813048/diff/3001/lily/slur-scoring.cc
File lily/slur-scoring.cc (right):
http://codereview.appspot.com/4536068/diff/30001/lily/multi-measure-rest.cc
File lily/multi-measure-rest.cc (right):
http://codereview.appspot.com/4536068/diff/30001/lily/multi-measure-rest.cc#newcode254
lily/multi-measure-rest.cc:254: Stencil r (musfont-find_by_name
(rests. + to_string (k)));
On Tue, Jul 26, 2011 at 12:05:31PM +0200, David Kastrup wrote:
m...@apollinemike.com m...@apollinemike.com writes:
Perhaps this would be a good case study.
The more interesting question is just how common the circumstances are
under which this happens.
...
Did
Graham Percival gra...@percival-music.ca writes:
On Tue, Jul 26, 2011 at 12:05:31PM +0200, David Kastrup wrote:
Perhaps a minimal measure of sanity would be if a patch countdown
without code review was only started when the author of the patch
says I feel reasonably confident that this not
Am Dienstag, 26. Juli 2011, 18:54:28 schrieb David Kastrup:
Graham Percival gra...@percival-music.ca writes:
On Tue, Jul 26, 2011 at 12:05:31PM +0200, David Kastrup wrote:
Perhaps a minimal measure of sanity would be if a patch countdown
without code review was only started when the author
Graham Percival gra...@percival-music.ca writes:
On Tue, Jul 26, 2011 at 12:05:31PM +0200, David Kastrup wrote:
m...@apollinemike.com m...@apollinemike.com writes:
...
Did 104f80daf1dab11ef5b598006e3d4be8dfbe1926 go through full review?
Was it verified with a full build?
Very likely.
Reinhold Kainhofer reinh...@kainhofer.com writes:
So, it seems the only one who is aware of those rounding problems is
David. The question then is, why didn't David do a review of the patch
and now complains that the process is not working?
Come on. I got pointed to this patch because
On Tue, Jul 26, 2011 at 07:36:43PM +0200, David Kastrup wrote:
So it needs to tell its story in comments. It doesn't. There is a lot
of code in Lilypond that nonchalantly expects people to get along
without commenting what it does. This is often a nuisance, but if the
code is written by a
On Tue, Jul 26, 2011 at 04:15:45PM +0100, Phil Holmes wrote:
I currently can't build doc. Fresh pull, nuked and recreated build
directory. I get:
Cannot reproduce with git master
f9af9dd76a0481c993caf90ebefb1b8a71c5898d
You're not on the lilypond/translation branch by mistake, are you?
*
Le 26/07/2011 21:41, Graham Percival disait :
On Tue, Jul 26, 2011 at 04:15:45PM +0100, Phil Holmes wrote:
I currently can't build doc. Fresh pull, nuked and recreated build
directory. I get:
Cannot reproduce with git master
f9af9dd76a0481c993caf90ebefb1b8a71c5898d
You're not on the
- Original Message -
From: Graham Percival gra...@percival-music.ca
To: Phil Holmes m...@philholmes.net
Cc: lilypond-devel@gnu.org
Sent: Tuesday, July 26, 2011 8:41 PM
Subject: Re: Doc build error
On Tue, Jul 26, 2011 at 04:15:45PM +0100, Phil Holmes wrote:
I currently can't build
On 26 July 2011 18:43, David Kastrup d...@gnu.org wrote:
Come on. I got pointed to this patch because _warnings_ occured. Don't
tell me David is the only one who can see warnings. The patch is in
an area I have no clue about. _Anybody_ with reasonable C and Scheme
experience would have
On 26 July 2011 11:17, m...@apollinemike.com m...@apollinemike.com wrote:
This is my fault. I don't know why I missed it these warnings in the
side-by-side comparison, but I won't let this slip again.
It isn't your fault. There were no warnings.
It appears David's getting warnings from the
Hello,
From: lilypond-devel-bounces+james.lowe=datacore@gnu.org
[lilypond-devel-bounces+james.lowe=datacore@gnu.org] on behalf of Phil
Holmes [m...@philholmes.net]
Sent: 26 July 2011 21:58
To: Graham Percival
Cc: lilypond-devel@gnu.org
Subject:
A few minor syntax and doc policy issues
http://codereview.appspot.com/1659041/diff/5001/Documentation/usage/lilypond-book.itely
File Documentation/usage/lilypond-book.itely (right):
http://codereview.appspot.com/1659041/diff/5001/Documentation/usage/lilypond-book.itely#newcode206
Hi,
I am currently stuck in rethinking what music functions should be able
to do.
Actually, the point is more that I am _tracing_ that, and the current
state is just scary in its inconsistency, which is only alleviated by
being pretty much undocumented.
So I am not sure which of the
On 26 July 2011 22:41, David Kastrup d...@gnu.org wrote:
So the question basically is: which of those mechanisms is actually
being in use? Are there examples for existing music functions
interpreting a postevent or a chord constituent?
\tweak would be the most common usage for both of these
http://codereview.appspot.com/4536068/diff/30001/lily/multi-measure-rest.cc#newcode130
lily/multi-measure-rest.cc:130: double duration_log = -log2
(ml.Rational::to_double ());
log2 is a floating point operation not guaranteed to be exact. One
usually uses
a loop for figuring out a proper
On Tue, Jul 26, 2011 at 09:58:14PM +0100, Phil Holmes wrote:
I'm _still_ running the older version of lilydev, but with all the
patches.
hmm.
It's really quite an odd problem: the recipe should be in
texinfo-rules.make:
$(outdir)/%.texi: $(src-dir)/%.texi
cp -p $ $@
But when I put a
Most people seem to like the status quo.
http://lilypond.org/~graham/gop/gop_6.html
** Proposal summary
Potentially sensitive or private matters will be referred to
Graham. He will then decide who should discuss the matter on an
ad-hoc basis, and forward or CC them on future emails.
For
On 2011/07/26 22:47:53, Bertrand Bordage wrote:
For example, what to do about 3/2? We either get 2/1 rests, or 1/1
rests, and
it is not clear to me that this rounding choice is necessarily the
same as
that
for 3/4.
I think it might be saner to [...]
This sounds complex...
How it
http://codereview.appspot.com/4536068/diff/30001/lily/multi-measure-rest.cc
File lily/multi-measure-rest.cc (right):
http://codereview.appspot.com/4536068/diff/30001/lily/multi-measure-rest.cc#newcode131
lily/multi-measure-rest.cc:131: int measure_duration_log = int (ceil
(duration_log));
To
http://codereview.appspot.com/4748044/diff/1/mf/feta-noteheads.mf
File mf/feta-noteheads.mf (right):
http://codereview.appspot.com/4748044/diff/1/mf/feta-noteheads.mf#newcode181
mf/feta-noteheads.mf:181: % when there is an interval of fourth.
Wouldn't it be simpler to explicitly specify the
38 matches
Mail list logo
