Re: GOP-PROP 8: issue priorities (probable decision)

2011-08-11 Thread Trevor Daniels
Graham Percival wrote Thursday, August 11, 2011 6:06 AM On Thu, Aug 11, 2011 at 04:59:02AM +, Keith OHara wrote: Graham Percival graham at percival-music.ca writes: * Type-ignorance: (fixme name?) it is not clear what the correct output should look like. In a classification

Commas in section headings

2011-08-11 Thread Trevor Daniels
Graham I vaguely remember commas should not be used in section headings, but can't remember why. There is nothing about this in the CG that I can find. Can you please remind me. Trevor - No virus found in this message. Checked by AVG - www.avg.com Version: 10.0.1392 / Virus

Re: Commas in section headings

2011-08-11 Thread Jean-Charles Malahieude
Le 11/08/2011 10:10, Trevor Daniels disait : Graham I vaguely remember commas should not be used in section headings, but can't remember why. There is nothing about this in the CG that I can find. Can you please remind me. Trevor You may not have a comma in a @node, but you can use it in its

Re: Get rid of some compiler warnings (issue4854049)

2011-08-11 Thread Benkő Pál
generally signed-unsigned problems are better solved by casting to size_t, not to unsigned - size_t works equally well in 32 bit and 64 bit mode. (even better, some variables can be size_t instead of int.) p ___ lilypond-devel mailing list

Re: Commas in section headings

2011-08-11 Thread Trevor Daniels
Jean-Charles, you wrote Thursday, August 11, 2011 10:00 AM Le 11/08/2011 10:10, Trevor Daniels disait : I vaguely remember commas should not be used in section headings, but can't remember why. There is nothing about this in the CG that I can find. Can you please remind me. You may not

Uses Y-offset for stem tremolos instead of translated stencil. (issue4867043)

2011-08-11 Thread mtsolo
Reviewers: , Message: My summer of lily continues with this patch. Currently, the pure height function in stem tremolo leads to incorrect results, as without an offset, it places every stem tremolo at the center of the staff for all pure calculations. This patch provides a conservative

Re: Adds a glyph for tied lyrics. (issue4808074)

2011-08-11 Thread Francisco Vila
2011/8/11 Werner LEMBERG w...@gnu.org: An example is the second aria of Susanna in Mozart's `Le Nozze di Figaro', bar 16:   f2     f8  e8       g8        c8  fin -- chè l'a -- ria è an -- cor Almost all singers I've met during my work as a coach have problems if they sing it the first

Re: Fixes note column skylines by adding stem tremolo to axis group. (issue4754054)

2011-08-11 Thread m...@apollinemike.com
On Jul 19, 2011, at 6:11 PM, Neil Puttock wrote: On 19 July 2011 09:10, m...@apollinemike.com m...@apollinemike.com wrote: After making several round-trips around the source this morning, I can't put off composition any longer, but I fear that all I will compose today are songs about the

Re: Adds a glyph for tied lyrics. (issue4808074)

2011-08-11 Thread Jean-Charles Malahieude
Le 11/08/2011 13:16, Francisco Vila disait : 2011/8/11 Werner LEMBERGw...@gnu.org: An example is the second aria of Susanna in Mozart's `Le Nozze di Figaro', bar 16: f2 f8 e8 g8c8 fin -- chè l'a -- ria è an -- cor Almost all singers I've met during my work as a coach

Re: Adds a glyph for tied lyrics. (issue4808074)

2011-08-11 Thread bordage . bertrand
I forgot these cases (o~è~in; a~è~in; o~è~an...). They are often elided (quest'in instead of questa~è~in) by editors and composers. So your view is that lyric ties are not used in the real world? I still feel them as a pedagogy resource for young musicians or something. Or maybe old scores

Fixes footnote automatic numbering. (issue4877041)

2011-08-11 Thread mtsolo
Reviewers: , Message: This gets the numbering of automatic footnotes correct for systems with more than one staff. Cheers, MS Description: Fixes footnote automatic numbering. Please review this at http://codereview.appspot.com/4877041/ Affected files: M lily/system.cc Index:

Re: T1349 - Fix load order for running with Guile V2 (issue4849054)

2011-08-11 Thread ianhulin44
http://codereview.appspot.com/4849054/diff/1/scm/lily.scm File scm/lily.scm (right): http://codereview.appspot.com/4849054/diff/1/scm/lily.scm#newcode116 scm/lily.scm:116: midi) On 2011/08/11 13:32:43, Ian Hulin (gmail) wrote: Sort out (increase) indentation for lines 115-116 Done.

Re: T1349 - Fix load order for running with Guile V2 (issue4849054)

2011-08-11 Thread ianhulin44
New patch-set available for review. Ian http://codereview.appspot.com/4849054/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fixes footnote automatic numbering. (issue4877041)

2011-08-11 Thread reinhold . kainhofer
Regtest missing. Much better now, but with my example there are still some inconsistencies. In particular, the ordering of the six footnotes in each of the systems is: 1st system: 2 3 5 1 4 6 2nd system (start at 7, shown here as 1): 1 4 5 2 3 6 3rd system (2nd page): 1 3 5 2 4 6

Re: Fixes footnote automatic numbering. (issue4877041)

2011-08-11 Thread m...@apollinemike.com
On Aug 11, 2011, at 4:48 PM, reinhold.kainho...@gmail.com wrote: Regtest missing. Much better now, but with my example there are still some inconsistencies. In particular, the ordering of the six footnotes in each of the systems is: 1st system: 2 3 5 1 4 6 2nd system (start at

New Spanish PO file for 'lilypond' (version 2.15.9)

2011-08-11 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'lilypond' has been submitted by the Spanish team of translators. The file is available at: http://translationproject.org/latest/lilypond/es.po (We can arrange things so

Re: custom engraver in scheme: accessing nested Music object

2011-08-11 Thread Ricardo Wurmus
On Aug 10, Reinhold Kainhofer wrote: Am Mittwoch, 10. August 2011, 17:11:44 schrieb Ricardo Wurmus: On Aug 10, Neil Puttock wrote: BTW, if you're prepared to wrap the notes in a chord (so you have access to 'articulations), you won't even need a scheme engraver (all the processing can

Re: Doc: NR Warning added to para for cueduring (issue4850051)

2011-08-11 Thread tdanielsmusic
LGTM http://codereview.appspot.com/4850051/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fixes note column skylines by adding stem tremolo to axis group. (issue4754054)

2011-08-11 Thread Neil Puttock
On 11 August 2011 12:34, m...@apollinemike.com m...@apollinemike.com wrote: I figured out why it works - I figured I'd post this to the list in case anyone else ever wants to mess around with pure properties. The StemTremolo is added to the paper column's element grob array via the

Re: T1349 - Fix load order for running with Guile V2 (issue4849054)

2011-08-11 Thread n . puttock
On 2011/08/11 14:36:24, Ian Hulin (gmail) wrote: New patch-set available for review. Please rebase against master. Cheers, Neil http://codereview.appspot.com/4849054/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: GOP-PROP 8: issue priorities (probable decision)

2011-08-11 Thread Keith OHara
On Wed, 10 Aug 2011 22:06:16 -0700, Graham Percival gra...@percival-music.ca wrote: On Thu, Aug 11, 2011 at 04:59:02AM +, Keith OHara wrote: Graham Percival graham at percival-music.ca writes: Type-critical: You might want to split this into two: regressions to the output of Lilypond,

Re: T1349 - Fix load order for running with Guile V2 (issue4849054)

2011-08-11 Thread ianhulin44
On 2011/08/11 17:35:22, Neil Puttock wrote: On 2011/08/11 14:36:24, Ian Hulin (gmail) wrote: New patch-set available for review. Please rebase against master. Cheers, Neil Thanks for the catch. Rebased, scm/lily.scm merged and new patch-set uploaded. Cheers, Ian

Re: GOP-PROP 8: issue priorities (probable decision)

2011-08-11 Thread Graham Percival
On Thu, Aug 11, 2011 at 12:32:09PM -0700, Keith OHara wrote: On Wed, 10 Aug 2011 22:06:16 -0700, Graham Percival gra...@percival-music.ca wrote: On Thu, 11 Aug 2011 00:02:51 -0700, Trevor Daniels t.dani...@treda.co.uk wrote: Graham Percival graham at percival-music.ca writes: *

Re: Commas in section headings

2011-08-11 Thread Graham Percival
On Thu, Aug 11, 2011 at 11:45:39AM +0100, Trevor Daniels wrote: Jean-Charles, you wrote Thursday, August 11, 2011 10:00 AM You may not have a comma in a @node, but you can use it in its labeling *section: Yes. I disallow commas in @section headings because IMO we should always have the

Re: lily/auto-beam-engraver: keep a Context_handle to starting Staff (issue4830064)

2011-08-11 Thread n . puttock
LGTM. Just needs a regtest. http://codereview.appspot.com/4830064/diff/5001/lily/auto-beam-engraver.cc File lily/auto-beam-engraver.cc (right): http://codereview.appspot.com/4830064/diff/5001/lily/auto-beam-engraver.cc#newcode85 lily/auto-beam-engraver.cc:85: Handle on the starting staff

Re: modifying default behaviour of tremolo slashes (issue4636081)

2011-08-11 Thread n . puttock
Needs a regression test exercising the different settings. http://codereview.appspot.com/4636081/diff/38001/lily/stem-tremolo.cc File lily/stem-tremolo.cc (right): http://codereview.appspot.com/4636081/diff/38001/lily/stem-tremolo.cc#newcode118 lily/stem-tremolo.cc:118: shape = ly_symbol2scm

Re: Fixes bad slur heights by limiting fit_factor to the interior of slurs. (issue4810072)

2011-08-11 Thread n . puttock
Needs a rebase. http://codereview.appspot.com/4810072/diff/1003/input/regression/slur-height-capping.ly File input/regression/slur-height-capping.ly (right): http://codereview.appspot.com/4810072/diff/1003/input/regression/slur-height-capping.ly#newcode4

Re: Commas in section headings

2011-08-11 Thread Trevor Daniels
Graham Percival wrote Thursday, August 11, 2011 8:42 PM On Thu, Aug 11, 2011 at 11:45:39AM +0100, Trevor Daniels wrote: Jean-Charles, you wrote Thursday, August 11, 2011 10:00 AM You may not have a comma in a @node, but you can use it in its labeling *section: Yes. I disallow commas in

Re: T1349 - Fix load order for running with Guile V2 (issue4849054)

2011-08-11 Thread n . puttock
http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm File scm/lily.scm (right): http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode324 scm/lily.scm:324: ( file-name-length 2) tab-space conversion has broken indentation here (and lines below)

Re: Prevents nested tuplets from colliding. (issue4808082)

2011-08-11 Thread n . puttock
Hi Mike, Have you tested this with broken tuplets? I've tried adding breaks at random in tuplet-nest.ly and get collisions in some cases. Cheers, Neil http://codereview.appspot.com/4808082/diff/2001/input/regression/tuplet-nest.ly File input/regression/tuplet-nest.ly (right):

Re: Fixes note column skylines by adding stem tremolo to axis group. (issue4754054)

2011-08-11 Thread m...@apollinemike.com
On Aug 11, 2011, at 7:03 PM, Neil Puttock wrote: On 11 August 2011 12:34, m...@apollinemike.com m...@apollinemike.com wrote: I figured out why it works - I figured I'd post this to the list in case anyone else ever wants to mess around with pure properties. The StemTremolo is added to

Re: Treats multi measure rest staff position like rest staff position. (issue4822046)

2011-08-11 Thread mtsolo
Pushed as e75f38b1a9adaf7752ced683fff0e6ec01bd8a13. Cheers, MS http://codereview.appspot.com/4822046/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fixes bad slur heights by limiting fit_factor to the interior of slurs. (issue4810072)

2011-08-11 Thread mtsolo
Pushed as 94ea10f3f341fff503599a9eb947c81f1803290f. Cheers, MS http://codereview.appspot.com/4810072/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: T1349 - Fix load order for running with Guile V2 (issue4849054)

2011-08-11 Thread ianhulin44
http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm File scm/lily.scm (right): http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode324 scm/lily.scm:324: ( file-name-length 2) On 2011/08/11 20:40:46, Neil Puttock wrote: tab-space conversion has broken indentation here

Re: T1349 - Fix load order for running with Guile V2 (issue4849054)

2011-08-11 Thread ianhulin44
Two more indentation problems in scm/lily.scm new patchset follows. Ian http://codereview.appspot.com/4849054/diff/8004/scm/lily.scm File scm/lily.scm (right): http://codereview.appspot.com/4849054/diff/8004/scm/lily.scm#newcode394 scm/lily.scm:394: (ly:version)) Needs indenting to line up

Re: T1349 - Fix load order for running with Guile V2 (issue4849054)

2011-08-11 Thread ianhulin44
On 2011/08/11 23:16:59, Ian Hulin (gmail) wrote: Two more indentation problems in scm/lily.scm new patchset follows. Ian http://codereview.appspot.com/4849054/diff/8004/scm/lily.scm File scm/lily.scm (right): http://codereview.appspot.com/4849054/diff/8004/scm/lily.scm#newcode394

Re: test macosx 10.7 binaries

2011-08-11 Thread Dan Eble
On 2011-08-07, at 20:52 , Graham Percival wrote: On Wed, Aug 03, 2011 at 12:30:15PM -0700, Graham Percival wrote: Get them here: http://lilypond.org/~graham/ Hmm. Nobody cares about MacOS X 10.7 ? ok, no skin off my nose... I never use the GUI, but for your special bulid of 2.15.9 x86,

script for auto-indenting .scm files.

2011-08-11 Thread Carl Sorensen
Having spent more time than I thought it would be necessary, I finally found something that could work as a stand-alone script for indenting scheme files. It appears to follow standard Scheme indenting rules, which means that it changes the indentation we have in lily.scm where the

Re: script for auto-indenting .scm files.

2011-08-11 Thread Carl Sorensen
On 8/11/11 6:07 PM, Carl Sorensen c_soren...@byu.edu wrote: Having spent more time than I thought it would be necessary, I finally found something that could work as a stand-alone script for indenting scheme files. It appears to follow standard Scheme indenting rules, which means that it

Re: script for auto-indenting .scm files.

2011-08-11 Thread Carl Sorensen
On 8/11/11 6:17 PM, Carl Sorensen c_soren...@byu.edu wrote: On 8/11/11 6:07 PM, Carl Sorensen c_soren...@byu.edu wrote: Oops -- I have now found a problem with it. The else part of an if doesn't line up with the then part. More work to do, I guess. New version fixes that problem.

Re: script for auto-indenting .scm files.

2011-08-11 Thread Graham Percival
On Thu, Aug 11, 2011 at 06:07:07PM -0600, Carl Sorensen wrote: The call to guile is hardcoded at the top of the file, and will need to be changed to use the appropriate lilypond environment variable that defines the location of guile. Change it to: #!/usr/bin/env guile and all should be well.

Re: test macosx 10.7 binaries

2011-08-11 Thread Graham Percival
On Thu, Aug 11, 2011 at 07:35:30PM -0400, Dan Eble wrote: I never use the GUI, but for your special bulid of 2.15.9 x86, clicking the application icon opens the GUI, and the Compile Typeset file menu first prompts me to save Untitled.ly, and then on the second attempt it creates

Re: script for auto-indenting .scm files.

2011-08-11 Thread Graham Percival
On Thu, Aug 11, 2011 at 06:28:09PM -0600, Carl Sorensen wrote: On 8/11/11 6:17 PM, Carl Sorensen c_soren...@byu.edu wrote: BTW, usage is ./scmindent.scm input-file output-file Could we get that in a comment at the top of the file ? Cheers, - Graham

Re: script for auto-indenting .scm files.

2011-08-11 Thread Carl Sorensen
On 8/11/11 6:32 PM, Graham Percival gra...@percival-music.ca wrote: On Thu, Aug 11, 2011 at 06:28:09PM -0600, Carl Sorensen wrote: On 8/11/11 6:17 PM, Carl Sorensen c_soren...@byu.edu wrote: BTW, usage is ./scmindent.scm input-file output-file Could we get that in a comment at the top

PATCH: 48-Hour countdown

2011-08-11 Thread Colin Campbell
22:00 MDT Saturday, Aug 13 Issue T 1790 http://code.google.com/p/lilypond/issues/detail?id=1790: Proper loglevels: cmd-line option --loglevel=NONE/ERROR/WARN/PROGRESS/INFO/DEBUG - R Issue 4822055 http://codereview.appspot.com/4822055/ Issue T 40

Re: test macosx 10.7 binaries

2011-08-11 Thread Dan Eble
On 2011-08-11, at 20:31 , Graham Percival wrote: Incidentally, I have been running lilypond 2.14.1 from a Makefile with no noticeable problems, but I'm not using 2.14.2 because it produced a bus error when I tried it. http://lilypond.org/bug-reports.html please. If you can produce a

Re: Adds a glyph for tied lyrics. (issue4808074)

2011-08-11 Thread Werner LEMBERG
No lyric ties either... So your view is that lyric ties are not used in the real world? No. I simply can't discuss how lyric ties should look like since I haven't seen real-world examples in the scores I've used up to now. It seems that German engraving for classical music can live without