Re: Adds epsilon to Bezier range calculations. (issue 4820048)

2011-09-30 Thread k-ohara5a5a
Mike, this could make sense *if* it is normal to ask where the Bezier curve touches the left or right side of its bounding box. I considered doing exactly this for the rounding problem in Bezier::minmax() but I chose instead to put the corner-case handling in the caller. Your proposed reg-test c

PATCH: countdown to 20111002

2011-09-30 Thread Colin Campbell
Actually, there aren't any patches to be counted down, so here's a weekend holiday for us all. Starting Sunday, I'll be putting out patch batches on Sunday, Tuesday and Thursday, as Mrs Bean Counter and I have dance class on Monday, she works late and I have cello lessons Wednesday, and we both

Issue 1266: Dots in chords can not be moved

2011-09-30 Thread Seafire
This issue bothers me, so I took a look at it. It appears that extremal_head_ of the Dot_position struct found in dot-configuration.hh/.cc and dot-column.cc exists solely to limit the Dots #'direction setting to the main note head. I removed this limitation and it fixed Issue 1266. I've run a few

Re: New partcombineUp and partcombineDown functions (issue 4514042)

2011-09-30 Thread bordage . bertrand
Pushed as bb7cac7b276bd7d1335523f3be8df815cf894ece. http://codereview.appspot.com/4514042/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Build dependencies for .texi files (issue 1852). (issue 5169041)

2011-09-30 Thread julien . rioux
Publish comments. http://codereview.appspot.com/5169041/diff/1/Documentation/topdocs/AUTHORS.texi File Documentation/topdocs/AUTHORS.texi (right): http://codereview.appspot.com/5169041/diff/1/Documentation/topdocs/AUTHORS.texi#newcode13 Documentation/topdocs/AUTHORS.texi:13: @include ../macros.

Re: a weekly pause

2011-09-30 Thread Peekay Ex
Janek, 2011/9/30 Janek Warchoł : > Hi all, > > i'm moving to a new flat - i cannot do any Lily work now.  I should be > back no later than on 10.10. > Graham: please find someone to look after issues owned by me - i've > checked that every patch i know i'm "mentoring" is there. > Colin: if i would

Re: Sketch for fix of issue 307 (issue 4813048)

2011-09-30 Thread Peekay Ex
Hello, On Fri, Sep 30, 2011 at 12:01 AM, Reinhold Kainhofer wrote: > Am Thursday, 29. September 2011, 23:30:20 schrieb pkx1...@gmail.com: >> Passes make but fails make check >> >> --snip-- >> >> job 4 terminated with signal: 6 >> >> >> job 3 terminated with signal: 6 >> fatal error: Children (4 3

Re: Build dependencies for .texi files (issue 1852). (issue 5169041)

2011-09-30 Thread reinhold . kainhofer
I don't really like the naive approach of using the exact include file as the make dependency, because that blatantly ignores all include path settings for texinfo... http://codereview.appspot.com/5169041/diff/1/Documentation/topdocs/AUTHORS.texi File Documentation/topdocs/AUTHORS.texi (right):

git-cl upload mimetypes fixed (issue 1491)

2011-09-30 Thread Graham Percival
Following Nicholas' suggestion from last February, I've fixed the git-cl upload: https://github.com/gperciva/git-cl/commit/86d891d0817b0d4946fd22bd03554ea2685337b9 I suggest that everybody using git-cl upgrade to this. Also note that I've added a -s --no_code_issue option to skip uploading to c

Re: Build dependencies for .texi files (issue 1852). (issue 5169041)

2011-09-30 Thread percival . music . ca
the GNUmakefile and texinfo-rules.make look good http://codereview.appspot.com/5169041/diff/1/Documentation/topdocs/AUTHORS.texi File Documentation/topdocs/AUTHORS.texi (right): http://codereview.appspot.com/5169041/diff/1/Documentation/topdocs/AUTHORS.texi#newcode13 Documentation/topdocs/AUTHO

a weekly pause

2011-09-30 Thread Janek Warchoł
Hi all, i'm moving to a new flat - i cannot do any Lily work now. I should be back no later than on 10.10. Graham: please find someone to look after issues owned by me - i've checked that every patch i know i'm "mentoring" is there. Colin: if i would be necessary for some Frog work, you can try r

Build dependencies for .texi files (issue 1852). (issue 5169041)

2011-09-30 Thread janek . lilypond
Reviewers: Julien Rioux, Graham Percival, Message: By Julien Rioux. I apologize for delay, i wasn't smart enough to get around 1491. I also apologize for previous erroneus e-mail, i was struggling with git-cl and published wrong issue by accident. Description: Build dependencies for .texi files

Build dependencies for .texi files (issue 1852). (issue 5162044)

2011-09-30 Thread janek . lilypond
Reviewers: Julien Rioux, Graham Percival, Message: By Julien Rioux. I apologize for delay, i wasn't smart enough to get around 1491. Description: Build dependencies for .texi files (issue 1852). Write .dep files containing make dependency rules for .texi files. These .dep files are generated b

Re: Glyphs for Kievan Notation (issue 4951062)

2011-09-30 Thread bordage . bertrand
Very good! The MetaFont code could still be improved, but don't think about it. The only things you have to improve in MetaFont are the character boxes, which are broken. Example: \markup \box { \musicglyph #"noteheads.u3kievan" \musicglyph #"scripts.barline.kievan" \musicglyph #"accidentals.ki