Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062)

2011-11-01 Thread m...@apollinemike.com
On Oct 31, 2011, at 6:18 PM, m...@apollinemike.com wrote: > On Oct 31, 2011, at 3:19 PM, Phil Holmes wrote: > >> >> Mike - do you have a Windows machine? And a Windows .exe for your changes? >> If so, you could run my pixel comparator. >> >> -- >> Phil Holmes >> >> > > Unfortunately, I do

Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062)

2011-11-01 Thread dak
On 2011/11/01 08:25:48, mike_apollinemike.com wrote: Given that the 0.6 skyline horizontal padding is, according to the comment above it, only intended to block ledger lines from overlapping a bar line, I think that this blocking effect it has on horizontal spacing is an unintended side effec

Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062)

2011-11-01 Thread m...@apollinemike.com
On Nov 1, 2011, at 12:52 AM, Keith OHara wrote: >> This fixes the SpanBar regression ID'd by Phil. > > Well, not exactly. The failing regression test said: > texidoc = "SpanBars participate in the horizontal collision system; > the accidentals should not collide with the bar lines." > > This p

RFC: \hideNote

2011-11-01 Thread Adam Spiers
I noticed that we already have \hideNotes and \unHideNotes, but that is rather clumsy when you only want to hide a single note. So I wrote a patch to add \hideNote, and as a newbie to Lilypond development I wanted to check that this was a sensible idea. The patch is here, although I haven't teste

Re: [translations] Re: CG 5.8.3: updating committish of lsr snippets

2011-11-01 Thread Federico Bruni
Il 31/10/2011 21:05, Francisco Vila ha scritto: you haven't applied it yet, right? Now it is; please pull, test it and tell me. Ok, thanks. Well, I had tested it before and I knew what it would have happened. 'make check-translation' is a mess now. If you run this command you'll see what I m

Re: Fixes slope errors from incorrect X extents in Beam::print. (issue 5293060)

2011-11-01 Thread m...@apollinemike.com
Thanks Keith! I've incorporated most of your comments into the code and otherwise have a couple questions below. No change in the regtests & a new patch set up. Cheers, MS On Nov 1, 2011, at 5:19 AM, k-ohara5...@oco.net wrote: > This looks more reasonable. > I read through a few times until I

Re: Who is really alive in the bug squad today?

2011-11-01 Thread Peekay Ex
Graham, On Tue, Nov 1, 2011 at 6:39 AM, Graham Percival wrote: > On Mon, Oct 31, 2011 at 06:20:31PM +, Peekay Ex wrote: >> However the Contributor Guide has > > I think you're looking at the 2.14 CG ?  or maybe from 2.13 ? > > That section in git looks different.  You should remove Dmytro, >

Re: RFC: \hideNote

2011-11-01 Thread Peekay Ex
Adam, On Tue, Nov 1, 2011 at 10:21 AM, Adam Spiers wrote: > I noticed that we already have \hideNotes and \unHideNotes, but that > is rather clumsy when you only want to hide a single note.  So I wrote > a patch to add \hideNote, and as a newbie to Lilypond development I > wanted to check that th

Re: Polyphony, ledger lines, and dotted notes

2011-11-01 Thread Peekay Ex
Hello, On Tue, Nov 1, 2011 at 9:35 AM, Nick Payne wrote: > See below - the dots are differently placed depending on whether the notes > are in one voice or two: > > \version "2.15.16" > > \relative c' { > 4. > << { d } \\ { } >> > } > > > ___ > lilypon

Re: patches to apply

2011-11-01 Thread Peekay Ex
Julien, On Tue, Nov 1, 2011 at 12:22 AM, Julien Rioux wrote: > Hi, > > Can somebody please push these to patches? They were accepted in a countdown > over a week ago (I think it was 20111023) but they initially caused some > conflicts when the time came to push them. I can push these. @graham e

Re: RFC: \hideNote

2011-11-01 Thread Kieren MacMillan
Hi all, > I am sure other more experienced programmers will chime in but having > two 'similar' functions > > \hideNote > \hideNotes > > Is a good idea. I thought we had settled on \functionOn and \functionOff (e.g., \sustainOn and \sustainOff). So we should have \hideNotesOn and \hideNotesOff

Re: patches to apply

2011-11-01 Thread Graham Percival
On Tue, Nov 01, 2011 at 01:32:13PM +, Peekay Ex wrote: > On Tue, Nov 1, 2011 at 12:22 AM, Julien Rioux > wrote: > > Can somebody please push these to patches? They were accepted in a countdown > > over a week ago (I think it was 20111023) but they initially caused some > > conflicts when the t

Re: patches to apply

2011-11-01 Thread David Kastrup
Graham Percival writes: > On Tue, Nov 01, 2011 at 01:32:13PM +, Peekay Ex wrote: >> On Tue, Nov 1, 2011 at 12:22 AM, Julien Rioux >> wrote: >> > Can somebody please push these to patches? They were accepted in a >> > countdown >> > over a week ago (I think it was 20111023) but they initiall

Re: patches to apply

2011-11-01 Thread Peekay Ex
Hello, On Tue, Nov 1, 2011 at 1:45 PM, David Kastrup wrote: > Graham Percival writes: > >> On Tue, Nov 01, 2011 at 01:32:13PM +, Peekay Ex wrote: >>> On Tue, Nov 1, 2011 at 12:22 AM, Julien Rioux >>> wrote: >>> > Can somebody please push these to patches? They were accepted in a >>> > coun

Re: patches to apply

2011-11-01 Thread David Kastrup
Peekay Ex writes: > Yes and I suppose that is why I cannot push these patches to dev\staging > > --snip-- > > jlowe@jlowe-lilybuntu2:~/lilypond-git$ git push origin > HEAD:refs/heads/dev/staging > To ssh://pkx1...@git.sv.gnu.org/srv/git/lilypond.git > ! [rejected]HEAD -> dev/staging (non

Re: changing-defaults.itely: correct misstatement about variables for context mods (issue 5306076)

2011-11-01 Thread dak
Reviewers: J_lowe, Message: Review addressed. Changes are trivial enough that countdown can continue. Description: changing-defaults.itely: correct misstatement about variables for context mods Please review this at http://codereview.appspot.com/5306076/ Affected files: M Documentation/nota

Re: RFC: \hideNote

2011-11-01 Thread Adam Spiers
On Tue, Nov 1, 2011 at 12:23 PM, Peekay Ex wrote: > On Tue, Nov 1, 2011 at 10:21 AM, Adam Spiers > wrote: >> I noticed that we already have \hideNotes and \unHideNotes, but that >> is rather clumsy when you only want to hide a single note.  So I wrote >> a patch to add \hideNote, and as a newbie

Re: RFC: \hideNote

2011-11-01 Thread Adam Spiers
On Tue, Nov 1, 2011 at 1:35 PM, Kieren MacMillan wrote: >> I am sure other more experienced programmers will chime in but having >> two 'similar' functions >> >> \hideNote >> \hideNotes >> >> Is a good idea. > > I thought we had settled on \functionOn and \functionOff (e.g., \sustainOn > and \sus

Re: [translations] Re: CG 5.8.3: updating committish of lsr snippets

2011-11-01 Thread Adam Spiers
On Tue, Nov 1, 2011 at 10:38 AM, Federico Bruni wrote: > Il 31/10/2011 21:05, Francisco Vila ha scritto: >>> >>> you haven't applied it yet, right? >> >> Now it is; please pull, test it and tell me. > > Ok, thanks. > Well, I had tested it before and I knew what it would have happened. > > 'make ch

Re: RFC: \hideNote

2011-11-01 Thread Peekay Ex
Adam, On Tue, Nov 1, 2011 at 2:28 PM, Adam Spiers wrote: > On Tue, Nov 1, 2011 at 12:23 PM, Peekay Ex wrote: >> On Tue, Nov 1, 2011 at 10:21 AM, Adam Spiers >> wrote: >>> I noticed that we already have \hideNotes and \unHideNotes, but that >>> is rather clumsy when you only want to hide a singl

Re: RFC: \hideNote

2011-11-01 Thread Peekay Ex
Adam, On Tue, Nov 1, 2011 at 2:29 PM, Adam Spiers wrote: > On Tue, Nov 1, 2011 at 1:35 PM, Kieren MacMillan > wrote: >>> I am sure other more experienced programmers will chime in but having >>> two 'similar' functions >>> >>> \hideNote >>> \hideNotes >>> >>> Is a good idea. >> >> I thought we h

Re: RFC: \hideNote

2011-11-01 Thread Peekay Ex
Adam, On Tue, Nov 1, 2011 at 2:28 PM, Adam Spiers wrote: ... > Please feel free to create a new issue to track this. http://code.google.com/p/lilypond/issues/detail?id=2002 -- -- James ___ lilypond-devel mailing list lilypond-devel@gnu.org https://

Re: RFC: \hideNote

2011-11-01 Thread Adam Spiers
On Tue, Nov 1, 2011 at 3:15 PM, Peekay Ex wrote: > On Tue, Nov 1, 2011 at 2:28 PM, Adam Spiers > wrote: >> Thanks James.  I'm a little confused regarding snippets: I was aware >> that files in Documentation/snippets are autogenerated from files in >> Documentation/snippets/new, however I assumed

Re: RFC: \hideNote

2011-11-01 Thread Adam Spiers
On Tue, Nov 1, 2011 at 3:17 PM, Peekay Ex wrote: > On Tue, Nov 1, 2011 at 2:29 PM, Adam Spiers > wrote: >> On Tue, Nov 1, 2011 at 1:35 PM, Kieren MacMillan >> wrote: >> Ah, that makes sense.  I could do the rename, but is there some process >> for handling non-backwards-compatible changes in syn

Re: patches to apply

2011-11-01 Thread Peekay Ex
On Tue, Nov 1, 2011 at 2:10 PM, David Kastrup wrote: > Peekay Ex writes: > >> Yes and I suppose that is why I cannot push these patches to dev\staging >> >> --snip-- >> >> jlowe@jlowe-lilybuntu2:~/lilypond-git$ git push origin >> HEAD:refs/heads/dev/staging >> To ssh://pkx1...@git.sv.gnu.org/srv/

Re: patches to apply

2011-11-01 Thread David Kastrup
Peekay Ex writes: > On Tue, Nov 1, 2011 at 2:10 PM, David Kastrup wrote: >> Peekay Ex writes: >> >>> Yes and I suppose that is why I cannot push these patches to dev\staging >>> >>> --snip-- >>> >>> jlowe@jlowe-lilybuntu2:~/lilypond-git$ git push origin >>> HEAD:refs/heads/dev/staging >>> To ss

Re: RFC: \hideNote

2011-11-01 Thread m...@apollinemike.com
On Nov 1, 2011, at 4:39 PM, Adam Spiers wrote: > On Tue, Nov 1, 2011 at 3:17 PM, Peekay Ex wrote: >> On Tue, Nov 1, 2011 at 2:29 PM, Adam Spiers >> wrote: >>> On Tue, Nov 1, 2011 at 1:35 PM, Kieren MacMillan >>> wrote: >>> Ah, that makes sense. I could do the rename, but is there some process

Re: RFC: \hideNote

2011-11-01 Thread David Kastrup
Kieren MacMillan writes: > Hi all, > >> I am sure other more experienced programmers will chime in but having >> two 'similar' functions >> >> \hideNote >> \hideNotes >> >> Is a good idea. > > I thought we had settled on \functionOn and \functionOff (e.g., > \sustainOn and \sustainOff). > So we

Re: changes in chord names formatting (1503, 1572) (issue 4981052)

2011-11-01 Thread adam . spiers
I have finally figured out how to reproduce these regressions, and am working on a fix. http://codereview.appspot.com/4981052/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: RFC: \hideNote

2011-11-01 Thread Kieren MacMillan
Hi David, > Or we just define \once as a music function doing that and remove it > from the parser altogether. Should be slightly less efficient and quite > more convenient. I've been wanting that to be true since the very first time I ever used \once… Cheers, Kieren. __

*.profile file changes in regression tests?

2011-11-01 Thread Adam Spiers
I'm starting to get the hang of regression tests, but my build/out/test-results/index.html shows a very large number of entries referring to *.profile files. I assume this is something to do with performance, but for once the Contributor's Guide isn't much help; http://lilypond.org/doc/v2.15/Docu

Re: RFC: \hideNote

2011-11-01 Thread Graham Percival
On Tue, Nov 01, 2011 at 03:39:23PM +, Adam Spiers wrote: > Perfect thanks. I'm pretty sure I've *never* seen a better documented > F/OSS project. The level of attention to detail is incredible, > although as a newbie developer it's a double-edged sword - on the one > hand it's comforting to k

Re: *.profile file changes in regression tests?

2011-11-01 Thread Adam Spiers
On Tue, Nov 1, 2011 at 5:11 PM, Adam Spiers wrote: > I'm starting to get the hang of regression tests, but my > build/out/test-results/index.html shows a very large number of entries > referring to *.profile files.  I assume this is something to do with > performance, but for once the Contributor'

Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062)

2011-11-01 Thread Keith OHara
mike apollinemike.com apollinemike.com> writes: > > -) TabStaffs tend to make horizontal spacing tighter, as the average spring between paper columns has an > ideal length that is shorter than that of staves comprised of normal notes. Very true. The lack of time-signature and key-signature ma

Re: RFC: \hideNote

2011-11-01 Thread David Kastrup
Kieren MacMillan writes: > Hi David, > >> Or we just define \once as a music function doing that and remove it >> from the parser altogether. Should be slightly less efficient and quite >> more convenient. > > I've been wanting that to be true since the very first time I ever > used \once… Prep

Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062)

2011-11-01 Thread Keith OHara
mike apollinemike.com apollinemike.com> writes: > > > > So if we take this patch, we should probably change the regression test, > > as well, because the SpanBars will not actually be participating in the > > horizontal collision system. > > (e.g., if somebody does \remove "Bar_engraver", the

Re: Fixes slope errors from incorrect X extents in Beam::print. (issue 5293060)

2011-11-01 Thread Keith OHara
On Tue, 01 Nov 2011 04:41:22 -0700, m...@apollinemike.com wrote: Where is this advertising? Is it the word prolongation? Yes. When a beam grob is passed to a function called prolongation people will at first think the function lengthens the beam. To make things more consistent, I could c

Re: [translations] Re: CG 5.8.3: updating committish of lsr snippets

2011-11-01 Thread Francisco Vila
2011/11/1 Federico Bruni : > 'make check-translation' is a mess now. > > If you run this command you'll see what I mean: > > cd Documentation > make ISOLANG=it NO_COLOR=1 check-translation | less I usually leave colors on and use less -R instead. > Is it normal? I do not see this output especial

Can anybody think of how to make use of this?

2011-11-01 Thread David Kastrup
I used the following for helping me understand conflicts in the parser. When one uses bison -v -g lily/parser.yy and has some problematic state for which one does not know a good example of how it might get reached, one can load the generated parser.dot into Emacs, and after using M-x load-file on

Re: patches to apply

2011-11-01 Thread Peekay Ex
David, On Tue, Nov 1, 2011 at 3:55 PM, David Kastrup wrote: > Peekay Ex writes: > >> On Tue, Nov 1, 2011 at 2:10 PM, David Kastrup wrote: >>> Peekay Ex writes: >>> Yes and I suppose that is why I cannot push these patches to dev\staging --snip-- jlowe@jlowe-lilybuntu2:

Re: patches to apply

2011-11-01 Thread Carl Sorensen
On 11/1/11 4:30 PM, "Peekay Ex" wrote: >David, > >On Tue, Nov 1, 2011 at 3:55 PM, David Kastrup wrote: >> Peekay Ex writes: >> >>> On Tue, Nov 1, 2011 at 2:10 PM, David Kastrup wrote: Peekay Ex writes: > Yes and I suppose that is why I cannot push these patches to >dev\sta

Re: Latest (ja) Translation branch merge breaks make doc - possible new syntax change ist he cause

2011-11-01 Thread Francisco Vila
2011/10/31 David Kastrup : > The syntax changed in incompatible ways.  Appropriate changes to > convertrules.py were made, and update-with-convert-ly was run on the > tree including the translations, keeping the translations compilable but > untranslated.  No manual changes were made to the transla

multiple issues with building docs (patch included)

2011-11-01 Thread Adam Spiers
I'm trying to make sure my patches include the right tweaks to the documentation, but as a newbie to lilypond development (but with a lot of development experience elsewhere), I'm sorry to say I'm really struggling :-( `make doc' works, but takes too long to be of practical use except as a final s

Re: Who is really alive in the bug squad today?

2011-11-01 Thread Brett McCoy
On Tue, Nov 1, 2011 at 8:05 AM, Peekay Ex wrote: > Yes sorry I was looking at an old PDF. > > I'll update the list myself and put myself in Dmytro's place for now > and leave Brett in until I hear different. Yep, I'm still here! -- Brett W. McCoy -- http://www.electricminstrel.com ---

Re: multiple issues with building docs (patch included)

2011-11-01 Thread Carl Sorensen
On 11/1/11 5:44 PM, "Adam Spiers" wrote: >I'm trying to make sure my patches include the right tweaks to the >documentation, but as a newbie to lilypond development (but with a lot >of development experience elsewhere), I'm sorry to say I'm really >struggling :-( > >`make doc' works, but takes

PATCH: Countdown to 20111103

2011-11-01 Thread Colin Campbell
Got nothing tonight, see you Thursday! Colin -- I've learned that you shouldn't go through life with a catcher's mitt on both hands. You need to be able to throw something back. -Maya Angelou, poet (1928- ) ___ lilypond-devel mailing list lilypond-d

Re: multiple issues with building docs (patch included)

2011-11-01 Thread Graham Percival
On Wed, Nov 02, 2011 at 02:14:13AM +, Carl Sorensen wrote: > > On 11/1/11 5:44 PM, "Adam Spiers" wrote: > > >`make doc' works, but takes too long to be of practical use except as > >a final sanity check before submitting a patch upstream. You can use multiple threads. > >http://lilypond.or

Re: patches to apply

2011-11-01 Thread Peekay Ex
Carl, On Tue, Nov 1, 2011 at 10:42 PM, Carl Sorensen wrote: > > > On 11/1/11 4:30 PM, "Peekay Ex" wrote: > >>David, >> >>On Tue, Nov 1, 2011 at 3:55 PM, David Kastrup wrote: .. > > For single patches, this is reasonably simple.  First do > > git rebase origin/dev/staging >>

Re: patches to apply

2011-11-01 Thread David Kastrup
Peekay Ex writes: Well, use whatever your tracking branch is called.  What does git branch -r say? >>> >>>jlowe@jlowe-lilybuntu2:~/lilypond-git$ git branch -r >>>  origin/HEAD -> origin/master >>>  origin/master >> >> >> I would do: >> >> git checkout dev/staging >> git push origin

Re: Doc: NR Added new node for Custom Footnotes (issue 5315053)

2011-11-01 Thread pkx166h
4th Draft. Thanks Graham. @Mike Solomon: I'd still like an example on how to autofootnote top-level markup if you can, so I can remove that technically inaccurate statement. Just in case you missed it, I'd like to use the same example as I use for \footnote in this patch but for \autofootnote a

Re: 2.15.16 regtests - pixel comparator

2011-11-01 Thread Keith OHara
Phil Holmes philholmes.net> writes: > > A few differences of note - in particular span-bar-spacing where we now get > a collision between the bar line and natural symbol which did not exist in > 2.15.13. The other attached images are for comment - but I think there's a > critical regression

Re: 2.15.16 regtests - pixel comparator

2011-11-01 Thread David Kastrup
Keith OHara writes: > fret-diagrams-fret-label > David's commit 8a459d03 changed the regression test itself. > (Whatever \revert TextScript #'(fret-diagram-details label-dir) > is supposed to do, it does not revert the direction fret number. Well, this was a mechanical change without understand