Issue 2426: override hardwired fonts in test-baseline (issue 5900048)

LGTM, please push immediately. http://codereview.appspot.com/5900048/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Add an example implementation of cross-staff stems (issue 5882053)

The basic question is this: is this test helpful for programmers? At first glance I'd say that it is, provided that you update the syntax as David suggested. IMO it takes a pretty silly example for something to *not* be a helpful test case. Sure, having complicated scheme here might mean that f

Re: Change all occurences of "echo -n" to "printf" for portability (issue 5903046)

LGTM, I think this could be pushed immediately? http://codereview.appspot.com/5903046/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: AU - document -dhelp CLI options (issue 5843060)

LGTM http://codereview.appspot.com/5843060/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: PATCH: Countdown to 20120327

Colin Campbell writes: > For 20:00 MDT Tuesday March 27 > > Enhancement: >     Issue 2434: Patch: Reduce amount of consing (mostly replace > reverse with reverse! where appropriate) - R 5909048 >   Note that David would like extra review of this one. Not really. I just mentioned that if

PATCH: Countdown to 20120327

For 20:00 MDT Tuesday March 27 Defect: Issue 744 : Cross-staff beams do not work well when including rests - R5908043 Documentation: Issue 2216

Re: Directs displaying-grob-ancestry.ly to stderr (issue 5905052)

On 25/03/12 14:59, philehol...@googlemail.com wrote: > Reviewers: dak, Graham Percival, Julien Rioux, > > Message: Please review > > Description: This is effectively a proof-of-concept patch to send > the output from the above snippet to stderr rather than stdout as > at present. As ever, it's t

Re: Directs displaying-grob-ancestry.ly to stderr (issue 5905052)

On 2012/03/25 18:36:26, Keith wrote: LGTM Just for clarity for patch-tracking, the 'silly' comment refers to the existing code, not the change from patch. On 2012/03/25 14:01:37, dak wrote: > That's silly. While the existing code calls format a whole lot, it does not call it within form

Re: Directs displaying-grob-ancestry.ly to stderr (issue 5905052)

LGTM Just for clarity for patch-tracking, the 'silly' comment refers to the existing code, not the change from patch. On 2012/03/25 14:01:37, dak wrote: That's silly. http://codereview.appspot.com/5905052/ ___ lilypond-devel mailing list lilypond-d

Re: strange conditionals in bar-line.cc

Marc Hohl hohlart.de> writes: > if (str == "|." || ( h == 0 && str == ":|")) > > IIUC, h == 0 could never be true, isn't it? > The current users of the function never ask it to print a zero-height bar line. It is still a good thing that the function handles the case with zero-height correctly

Re: Directs displaying-grob-ancestry.ly to stderr (issue 5905052)

- Original Message - From: To: ; ; Cc: ; Sent: Sunday, March 25, 2012 3:01 PM Subject: Re: Directs displaying-grob-ancestry.ly to stderr (issue 5905052) http://codereview.appspot.com/5905052/diff/1/Documentation/snippets/displaying-grob-ancestry.ly File Documentation/snippets/disp

Re: Directs displaying-grob-ancestry.ly to stderr (issue 5905052)

http://codereview.appspot.com/5905052/diff/1/Documentation/snippets/displaying-grob-ancestry.ly File Documentation/snippets/displaying-grob-ancestry.ly (right): http://codereview.appspot.com/5905052/diff/1/Documentation/snippets/displaying-grob-ancestry.ly#newcode198 Documentation/snippets/displ

Directs displaying-grob-ancestry.ly to stderr (issue 5905052)

Reviewers: dak, Graham Percival, Julien Rioux, Message: Please review Description: This is effectively a proof-of-concept patch to send the output from the above snippet to stderr rather than stdout as at present. As ever, it's to reduce make doc clutter. This patch should apply and work. A r

German translation request

In Notation/wind.itely, please could the following be changed: Die Liste aller möglichen Löcher und Einstellungen eines bestimmten Instruments kann auf der Kommandozeile oder in einer Log-Datei angezeigt werden, auch wenn man sie nicht in der Notenausgabe anzeigen lassen kann: @lilypond[verbatim

2.15.24 regtests

Clean. -- Phil Holmes ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

strange conditionals in bar-line.cc

Hello list, while analyzing and rewriting Bar_line::compound_barline in scheme I stumbled across an inconsistency: In Bar_line::print, the function compound_barline is called only if the length of bar-extent is > 0. In Bar_line::compound_barline, there is h = extent.length (); and later if (