Re: Documentation of Kievan notation (issue 6303095)

2012-06-22 Thread janek . lilypond
pushed as a10311ff02578de9f979dc6ad83ba9535f8e4e4c. Aleksandr, please close this Rietveld issue. thanks! http://codereview.appspot.com/6303095/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-deve

Re: Documentation of Kievan notation (issue 6303095)

2012-06-22 Thread aleksandr . andreev
Per comments by Graham and Trevor, I have removed 'fragment' throughout ancient.itely where 'relative' is also used. http://codereview.appspot.com/6303095/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/li

Re: add general_alignment (issue 2613) (issue 6308093)

2012-06-22 Thread Keith OHara
On Fri, 22 Jun 2012 08:21:02 -0700, Janek Warchoł wrote: The new property X-alignment will be awkward to use, because it is a complex structure of unnamed conceptually-distinct objects. Unnamed? What do you mean? If you change things as you have the patch now, when someone asks, over the

Re: Survey response completed [GOP2-0] Why are we losing developers?

2012-06-22 Thread Graham Percival
On Fri, Jun 22, 2012 at 11:09:14AM +0100, Colin Hall wrote: > > I have posted all the responses to the survey. Thanks so much for your help, Colin! I suggest that we spend a few days to think about the responses and how we view the project, then start discussing them on Monday. - Graham __

Re: Treat accidentals parentheses as cautionary (issue 6310065)

2012-06-22 Thread Rodolfo Zitellini
On Fri, Jun 22, 2012 at 5:29 PM, wrote: > So until now cautionary accidentals *were* supported - the problem was > just that the software that exported mxls didn't mark them > appropriately?  I.e. they had parentheses around them, but didn't have > appropriate property set? > That's an interestin

Re: add general_alignment (issue 2613) (issue 6308093)

2012-06-22 Thread Keith OHara
On Fri, 22 Jun 2012 08:21:02 -0700, Janek Warchoł wrote: On Fri, Jun 22, 2012 at 7:41 AM, wrote: This fails an assertion in scm_or_str2symbol, so I had to recompile with NDEBUG I'm sorry, but i don't recognize what failing an assertion in scm_or_str2symbol could mean here. Neither did I

Re: Treat accidentals parentheses as cautionary (issue 6310065)

2012-06-22 Thread janek . lilypond
So until now cautionary accidentals *were* supported - the problem was just that the software that exported mxls didn't mark them appropriately? I.e. they had parentheses around them, but didn't have appropriate property set? That's an interesting example of how WYSIWYG sucks. LGTM http://coder

Re: DevA response to [GOP2-0] Why are we losing developers?

2012-06-22 Thread Janek Warchoł
On Fri, Jun 22, 2012 at 11:52 AM, Colin Hall wrote: > FWIW, I think that efforts like Janek's benchmarks are useful for > overcoming this last point: a clear, well thought out specification of > what lilypond does wrong makes it easy for me to pick out a little > project to work on in my spare tim

Re: add general_alignment (issue 2613) (issue 6308093)

2012-06-22 Thread Janek Warchoł
On Fri, Jun 22, 2012 at 7:41 AM, wrote: > This fails an assertion in scm_or_str2symbol, so I had to recompile with > NDEBUG I'm sorry, but i don't recognize what failing an assertion in scm_or_str2symbol could mean here. Was this related to bad docstrings? (they are fixed now) >> Nevertheless

Survey response completed [GOP2-0] Why are we losing developers?

2012-06-22 Thread Colin Hall
I have posted all the responses to the survey. Cheers, Colin. -- Colin Hall ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

DevK response to [GOP2-0] Why are we losing developers?

2012-06-22 Thread Colin Hall
Hey - just a quick note. I don't work on Lilypond anymore since I think I did my fair share of it, and since I know it inside out it's not that challenging for me anymore. I just want to make another point, which is that (name deleted) managed to fit within the community pretty OK. Considering hi

DevJ response to [GOP2-0] Why are we losing developers?

2012-06-22 Thread Colin Hall
Just a quick response to say that I'm not as active as I used to be but I still feel like I'm in the project - my professional obligations are such that it is more difficult for me to spend time on development. This summer things will pick up a bit (I already have 3 patches on the countdown). Che

DevH response to [GOP2-0] Why are we losing developers?

2012-06-22 Thread Colin Hall
Here's my pseudo-anonymous answer :) My motivation goes down when i feel insignificant: - when i don't get reviews - when a simple patch takes forever because every word is discussed over and over again - when i spend more time on maintenance (creating issues, searching for messages on two trac

DevG response to [GOP2-0] Why are we losing developers?

2012-06-22 Thread Colin Hall
I'm replying directly as I have nothing to say in secret. There have been moments of disagreement with other developers that left me feeling annoyed and occasionally put down rather disrespectfully, sometimes to the extent that I decided to disconnect from LilyPond altogether, but that feeling ne

DevF response to [GOP2-0] Why are we losing developers?

2012-06-22 Thread Colin Hall
Hi, Let me first stress that my main reason not to have contributed to the Lilypond development for the last years has been the lack of time, both due to family reasons and an increased work load. So, for me the amount of contributions from my side (i.e. zero for serveral years) would have been th

DevE response to [GOP2-0] Why are we losing developers?

2012-06-22 Thread Colin Hall
Hi Graham, everyone. I hope it's okay if I just respond publicly. I would really like to be more active but I have never been the same since getting carpal tunnel syndrome and having surgery. The best I can do right now is maintain the ubuntu lilydev remix. I do still subscribe to the developers m

DevD response to [GOP2-0] Why are we losing developers?

2012-06-22 Thread Colin Hall
Hi, I am a once-developer for Lilypond mainly involved in the effort to add Braille Music support. I guess that makes it pretty obvious to those who know who I am, but I do not mind. I do have git push permission, but I don't think that I ever used it in anger. For me, like may others, time was

DevC response to [GOP2-0] Why are we losing developers?

2012-06-22 Thread Colin Hall
To explain my "problematic reasons" for contributing less, I'm first going to look at how I felt lilypond development was a few years ago. There was a feeling of teamwork, where every aspect of development had somebody taking care of it. Person 32 wrote GUB and handled problems in it. Person 14

DevB response to [GOP2-0] Why are we losing developers?

2012-06-22 Thread Colin Hall
I've stopped contributing to LilyPond in part because of mailing list arguments, leading to hurted feelings and lack of sleep. -devel used to be a nice place, but at times it is less so. I've not come back because of patch-handling bureaucratie (and mailing list arguments). I should be able to m

DevA response to [GOP2-0] Why are we losing developers?

2012-06-22 Thread Colin Hall
I don't quite consider myself an ex-developer, although it's true that I've become much less active. This is basically due to the "positive" reasons that Graham outlined; however, another reason for my inactivity is that I just don't use lilypond that much anymore. FWIW, I think that effor

Re: Error in resolving number of staff lines

2012-06-22 Thread David Kastrup
Marc Hohl writes: > Ok, but in lily/bar-line.cc, Bar_line::compound_barline, the number > of lines is computed by > > int lines = Staff_symbol_referencer::line_count (me) > > which is defined as > > int > Staff_symbol_referencer::line_count (Grob *me) > { > Grob *st = get_staff_symbol (me); >

Re: [Lilypond-auto] Issue 2607 in lilypond: Patch: Allow immediate Scheme expressions to take multiple values

2012-06-22 Thread Werner LEMBERG
>> (map! + '(1 2 3) '(4 5 6)) => (5 7 9) > > You must not! not! not! use map! on constant lists. Interesting. This is something non-obvious, at least after reading the Guile documentation. Now, knowing what you've just written, a second read makes much more sense, and I can see that th

Re: Error in resolving number of staff lines

2012-06-22 Thread Marc Hohl
Am 22.06.2012 10:49, schrieb David Kastrup: Marc Hohl writes: You are only overriding line-positions. While the bar line printer will see that this now contains a value and heeds it, this does not magically affect the (now ignored) line-count property. Ah, I see, thanks for the explanation.

Re: Add missing shebang line in MacOSX instructions. (issue 6300118)

2012-06-22 Thread julien . rioux
Reviewers: Graham Percival, Message: On 2012/06/22 08:19:29, Graham Percival wrote: I thought that bash doesn't need the shebang in some cases? at least, I could have sworn that I never added the shebang in this case? As I understand it, problems ensue when you try to call that script from

Re: Treat accidentals parentheses as cautionary (issue 6310065)

2012-06-22 Thread julien . rioux
Reviewers: MikeSol, Graham Percival, Message: On 2012/06/22 08:20:56, Graham Percival wrote: LGTM, although I'd personally have prepended "musicxml2ly:" to the beginning of the patch subject line. That makes it much more obvious when skimming the git history (or just available patches to re

Re: Error in resolving number of staff lines

2012-06-22 Thread David Kastrup
Marc Hohl writes: >> You are only overriding line-positions. While the bar line printer will >> see that this now contains a value and heeds it, this does not magically >> affect the (now ignored) line-count property. > Ah, I see, thanks for the explanation. > But why are the dots placed as if t

Re: Error in resolving number of staff lines

2012-06-22 Thread Marc Hohl
Am 22.06.2012 10:29, schrieb David Kastrup: Marc Hohl writes: Hello list, the following snippet prints a value of 5 in both cases, whereas the second system has only four staff lines. What's wrong here? Regards, Marc \version "2.15.41" #(define (test-bar-print grob) (let* ((staff-symb

Re: Add missing shebang line in MacOSX instructions. (issue 6300118)

2012-06-22 Thread David Kastrup
gra...@percival-music.ca writes: > I thought that bash doesn't need the shebang in some cases? at least, I > could have sworn that I never added the shebang in this case? > > Anyway, LGTM and you can push it directly to staging if you want. > > http://codereview.appspot.com/6300118/ For shell sc

Re: Error in resolving number of staff lines

2012-06-22 Thread Phil Holmes
- Original Message - From: "Marc Hohl" To: "Lily-Devel List" Sent: Friday, June 22, 2012 9:13 AM Subject: Error in resolving number of staff lines Hello list, the following snippet prints a value of 5 in both cases, whereas the second system has only four staff lines. What's wrong h

Re: Error in resolving number of staff lines

2012-06-22 Thread David Kastrup
Marc Hohl writes: > Hello list, > > the following snippet prints a value of 5 in both cases, > whereas the second system has > only four staff lines. What's wrong here? > > Regards, > > Marc > > \version "2.15.41" > > #(define (test-bar-print grob) >(let* ((staff-symbol (ly:grob-object grob '

Re: [Lilypond-auto] Issue 2607 in lilypond: Patch: Allow immediate Scheme expressions to take multiple values

2012-06-22 Thread David Kastrup
Werner LEMBERG writes: >> If I break down the example I listed before, here are a few >> useful ways of applying it: > > This is much easier to understand, thanks. However: > >> ; this $@ produces elements for a sequential music list via map!. Each >> ; element is constructed from p, a list of

Re: Treat accidentals parentheses as cautionary (issue 6310065)

2012-06-22 Thread graham
LGTM, although I'd personally have prepended "musicxml2ly:" to the beginning of the patch subject line. That makes it much more obvious when skimming the git history (or just available patches to review). http://codereview.appspot.com/6310065/ ___ lil

Add missing shebang line in MacOSX instructions. (issue 6300118)

2012-06-22 Thread graham
I thought that bash doesn't need the shebang in some cases? at least, I could have sworn that I never added the shebang in this case? Anyway, LGTM and you can push it directly to staging if you want. http://codereview.appspot.com/6300118/ ___ lilypon

Error in resolving number of staff lines

2012-06-22 Thread Marc Hohl
Hello list, the following snippet prints a value of 5 in both cases, whereas the second system has only four staff lines. What's wrong here? Regards, Marc \version "2.15.41" #(define (test-bar-print grob) (let* ((staff-symbol (ly:grob-object grob 'staff-symbol)) (line-count (if (

Re: [Lilypond-auto] Issue 2607 in lilypond: Patch: Allow immediate Scheme expressions to take multiple values

2012-06-22 Thread Werner LEMBERG
> If I break down the example I listed before, here are a few > useful ways of applying it: This is much easier to understand, thanks. However: > ; this $@ produces elements for a sequential music list via map!. Each > ; element is constructed from p, a list of pitches making up a chord, > ; a

Re: [Lilypond-auto] Issue 2607 in lilypond: Patch: Allow immediate Scheme expressions to take multiple values

2012-06-22 Thread David Kastrup
Werner LEMBERG writes: > I find the above much too dense. It introduces three different pseudo > operators in one rush. While tightly related, it should be done step > by step. So this is a criticism of the R6RS docs (being a standard to > be read by Scheme experts), not LilyPond. However, a