Re: Allows minimum-length to work for end-of-line spanners. (issue 7453046)

2013-03-08 Thread m...@mikesolomon.org
On 8 mars 2013, at 14:10, d...@gnu.org wrote: > > https://codereview.appspot.com/7453046/diff/1/input/regression/minimum-length-end-line.ly > File input/regression/minimum-length-end-line.ly (right): > > https://codereview.appspot.com/7453046/diff/1/input/regression/minimum-length-end-line.ly#ne

Re: Standardizes use of empty extents in pure heights and skylines. (issue 7310075)

2013-03-08 Thread mtsolo
Thanks for the review! https://codereview.appspot.com/7310075/diff/53001/input/regression/skyline-point-extent.ly File input/regression/skyline-point-extent.ly (right): https://codereview.appspot.com/7310075/diff/53001/input/regression/skyline-point-extent.ly#newcode5 input/regression/skyline-p

Re: Adds Ferneyhough hairpins to LilyPond. (issue 7615043)

2013-03-08 Thread mtsolo
https://codereview.appspot.com/7615043/diff/1/scm/output-lib.scm File scm/output-lib.scm (right): https://codereview.appspot.com/7615043/diff/1/scm/output-lib.scm#newcode929 scm/output-lib.scm:929: form. @code{x} is the portion of the width consumed for a given line On 2013/03/08 06:26:29, lemzw

Re: Adds Ferneyhough hairpins to LilyPond. (issue 7615043)

2013-03-08 Thread m...@mikesolomon.org
On 9 mars 2013, at 00:15, thomasmorle...@googlemail.com wrote: > Hi Mike, > > one thought. > > The image Trevor Bača posted > http://lists.gnu.org/archive/html/lilypond-user/2013-03/pngIGBdggySyh.png > shows that the left ends of a decrecsendo-hairpin are vertical aligned > even if the hairpin

PATCHES: Countdown to 11 March 2013 - 19:00 GMT

2013-03-08 Thread James
Hello, *Countdown – March 8th 2013 – 19:00 GMT* * * * * * * * * 3212 Enhancement David Kastrup Push Patch: Make test-

Re: Adds Ferneyhough hairpins to LilyPond. (issue 7615043)

2013-03-08 Thread thomasmorley65
Hi Mike, one thought. The image Trevor Bača posted http://lists.gnu.org/archive/html/lilypond-user/2013-03/pngIGBdggySyh.png shows that the left ends of a decrecsendo-hairpin are vertical aligned even if the hairpin isn't extended horizontal but ascending. Currently the vertical alignment is gon

GUB usage

2013-03-08 Thread Jordi Gutiérrez Hermoso
For Octave, I'm trying to update GUB to use a newer gcc, and I'm running across a few problems. I haven't done much, but here is my clone of the repo: http://hg.octave.org/gub So now I need to patch the gcc sources because they have a small bug that prevents building, and here I am puzzled a

Re: Standardizes use of empty extents in pure heights and skylines. (issue 7310075)

2013-03-08 Thread dak
https://codereview.appspot.com/7310075/diff/53001/input/regression/skyline-point-extent.ly File input/regression/skyline-point-extent.ly (right): https://codereview.appspot.com/7310075/diff/53001/input/regression/skyline-point-extent.ly#newcode5 input/regression/skyline-point-extent.ly:5: even t

Re: Allows minimum-length to work for end-of-line spanners. (issue 7453046)

2013-03-08 Thread dak
https://codereview.appspot.com/7453046/diff/1/input/regression/minimum-length-end-line.ly File input/regression/minimum-length-end-line.ly (right): https://codereview.appspot.com/7453046/diff/1/input/regression/minimum-length-end-line.ly#newcode10 input/regression/minimum-length-end-line.ly:10:

Re: Allows inheritence for slur engravers (issue 7437048)

2013-03-08 Thread dak
LGTM https://codereview.appspot.com/7437048/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Allows slurs to break at barlines. (issue 7424049)

2013-03-08 Thread dak
https://codereview.appspot.com/7424049/diff/19022/ly/spanners-init.ly File ly/spanners-init.ly (right): https://codereview.appspot.com/7424049/diff/19022/ly/spanners-init.ly#newcode114 ly/spanners-init.ly:114: breakSlur = #(make-music 'BreakSlurEvent) I am not happy with a new event type here.