On 2013/07/23 20:16:24, dak wrote:
On 2013/07/23 20:05:40, david.nalesnik wrote:
>
> I hesitate to do something like the following!
>
> #(add-grob-definition
> 'SchemeTextSpanner
> (list
> (cons
> 'bound-details
> (list
[...]
No, that's nonsensical. Instead, complete-grob-
On 2013/07/23 20:05:40, david.nalesnik wrote:
Hmmm, so if I understand correctly:
The problem in the regtest is that add-grob-definition should not be
applied to
the quasiquoted list. In doing so, however, nothing is being done that
doesn't
have precedent in define-grobs.scm.
Pretty much
On 2013/07/23 15:06:51, dak wrote:
On 2013/07/23 13:52:13, david.nalesnik wrote:
> Sorry, replied a bit hastily!
[...]
> I've thought some more about the issue of trying to change constants
elsewhere
> in the file.
>
> Specifically, regarding the addition of the new grob description to
Except one nitpick, LGTM
https://codereview.appspot.com/11455046/diff/1/Documentation/learning/tweaks.itely
File Documentation/learning/tweaks.itely (right):
https://codereview.appspot.com/11455046/diff/1/Documentation/learning/tweaks.itely#newcode2387
Documentation/learning/tweaks.itely:2387:
On 2013/07/23 13:52:13, david.nalesnik wrote:
Sorry, replied a bit hastily!
[...]
I've thought some more about the issue of trying to change constants
elsewhere
in the file.
Specifically, regarding the addition of the new grob description to
all-grob-descriptions, would the following be
We have http://code.google.com/p/lilypond/issues/detail?id=2809. I'd like
to make a start on this, but don't want to waste my time if I create what I
think is a decent stab but no-one else agrees. My suggestion is that my
final code will be:
\new Score {
<<
\new ChoirStaff \with {
\
On 2013/07/23 13:27:49, dak wrote:
On 2013/07/23 13:05:47, david.nalesnik wrote:
> On 2013/07/23 12:31:25, dak wrote:
> > Frankly, just throw out the crap event-drul and current-event, and
instead
use
> > event-start and event-stop instead of (car event-drul) and (cdr
event-drul).
> OK, wil
Thank you, David.
https://codereview.appspot.com/11614044/diff/1/input/regression/scheme-text-spanner.ly
File input/regression/scheme-text-spanner.ly (right):
https://codereview.appspot.com/11614044/diff/1/input/regression/scheme-text-spanner.ly#newcode28
input/regression/scheme-text-spanner.ly
On 2013/07/23 13:05:47, david.nalesnik wrote:
On 2013/07/23 12:31:25, dak wrote:
> Frankly, just throw out the crap event-drul and current-event, and
instead use
> event-start and event-stop instead of (car event-drul) and (cdr
event-drul).
OK, will do.
https://codereview.appspot.com/1161
https://codereview.appspot.com/11614044/diff/1/input/regression/scheme-text-spanner.ly
File input/regression/scheme-text-spanner.ly (right):
https://codereview.appspot.com/11614044/diff/1/input/regression/scheme-text-spanner.ly#newcode28
input/regression/scheme-text-spanner.ly:28: (set! meta-ent
Reviewers: ,
Message:
Please review.
Thanks,
David
Description:
input/regression/scheme-text-spanner.ly: fix problem with constants
The file `input/regression/scheme-text-spanner.ly' assigns a constant
pair to the variable `event-drul' and subsequently attempts to modify
the pair. This can le
Apart from a minor nitpick LGTM
https://codereview.appspot.com/11455046/diff/1/Documentation/learning/tweaks.itely
File Documentation/learning/tweaks.itely (right):
https://codereview.appspot.com/11455046/diff/1/Documentation/learning/tweaks.itely#newcode2801
Documentation/learning/tweaks.itely
Reviewers: Graham Percival, Trevor Daniels,
Message:
Please review.
Description:
A minor change to try to make the dynamics spacing section at least
accurate - ditto a small change on fingering placement.
Please review this at https://codereview.appspot.com/11455046/
Affected files:
M Docume
https://codereview.appspot.com/11427044/diff/9001/scm/define-markup-commands.scm
File scm/define-markup-commands.scm (right):
https://codereview.appspot.com/11427044/diff/9001/scm/define-markup-commands.scm#newcode416
scm/define-markup-commands.scm:416: (x-padding 0.75)
I am not enthused about t
14 matches
Mail list logo
